diff --git a/src/main/java/net/shadowfacts/simplemultipart/client/MissingMultipartBakedModel.java b/src/main/java/net/shadowfacts/simplemultipart/client/MissingMultipartBakedModel.java index 3ace4ec..a024dda 100644 --- a/src/main/java/net/shadowfacts/simplemultipart/client/MissingMultipartBakedModel.java +++ b/src/main/java/net/shadowfacts/simplemultipart/client/MissingMultipartBakedModel.java @@ -14,6 +14,8 @@ import java.util.Random; */ public class MissingMultipartBakedModel implements MultipartBakedModel { + // TODO: actual missing model + @Override public List getQuads(MultipartState state, MultipartSlot slot, Direction side, Random random) { return ImmutableList.of(); diff --git a/src/main/java/net/shadowfacts/simplemultipart/client/MultipartContainerBakedModel.java b/src/main/java/net/shadowfacts/simplemultipart/client/MultipartContainerBakedModel.java index 2a5a9e7..1ec6d93 100644 --- a/src/main/java/net/shadowfacts/simplemultipart/client/MultipartContainerBakedModel.java +++ b/src/main/java/net/shadowfacts/simplemultipart/client/MultipartContainerBakedModel.java @@ -30,6 +30,7 @@ public class MultipartContainerBakedModel implements BakedModel { MultipartContainerBlockState containerState = (MultipartContainerBlockState)state; Map parts = containerState.getParts(); MultipartModels models = SimpleMultipartClient.getMultipartModels(); + // TODO: would manually building the list be more efficient? return parts.entrySet().stream() .flatMap(entry -> { MultipartBakedModel partModel = models.getModel(entry.getValue()); diff --git a/src/main/java/net/shadowfacts/simplemultipart/client/MultipartModels.java b/src/main/java/net/shadowfacts/simplemultipart/client/MultipartModels.java index be9a8e8..ac17374 100644 --- a/src/main/java/net/shadowfacts/simplemultipart/client/MultipartModels.java +++ b/src/main/java/net/shadowfacts/simplemultipart/client/MultipartModels.java @@ -11,13 +11,8 @@ import java.util.Map; public class MultipartModels { private final Map models = new IdentityHashMap<>(); -// private final BakedModelManager modelManager; private final MultipartBakedModel missingModel = new MissingMultipartBakedModel(); - public MultipartModels() { -// this.modelManager = modelManager; - } - public MultipartBakedModel getMissingModel() { return missingModel; } diff --git a/src/main/java/net/shadowfacts/simplemultipart/client/SimpleMultipartClient.java b/src/main/java/net/shadowfacts/simplemultipart/client/SimpleMultipartClient.java index bd5af62..d6c2fc3 100644 --- a/src/main/java/net/shadowfacts/simplemultipart/client/SimpleMultipartClient.java +++ b/src/main/java/net/shadowfacts/simplemultipart/client/SimpleMultipartClient.java @@ -12,7 +12,6 @@ public class SimpleMultipartClient implements ClientModInitializer { @Override public void onInitializeClient() { -// multipartModels = new MultipartModels(MinecraftClient.getInstance().getBlockRenderManager().getModels().getModelManager()); } public static MultipartModels getMultipartModels() { diff --git a/src/main/java/net/shadowfacts/simplemultipart/client/RenderStateProvider.java b/src/main/java/net/shadowfacts/simplemultipart/client/util/RenderStateProvider.java similarity index 84% rename from src/main/java/net/shadowfacts/simplemultipart/client/RenderStateProvider.java rename to src/main/java/net/shadowfacts/simplemultipart/client/util/RenderStateProvider.java index b963270..e715497 100644 --- a/src/main/java/net/shadowfacts/simplemultipart/client/RenderStateProvider.java +++ b/src/main/java/net/shadowfacts/simplemultipart/client/util/RenderStateProvider.java @@ -1,4 +1,4 @@ -package net.shadowfacts.simplemultipart.client; +package net.shadowfacts.simplemultipart.client.util; import net.minecraft.block.BlockState; import net.minecraft.util.math.BlockPos; diff --git a/src/main/java/net/shadowfacts/simplemultipart/container/MultipartContainerBlock.java b/src/main/java/net/shadowfacts/simplemultipart/container/MultipartContainerBlock.java index 4a7784e..d8d0276 100644 --- a/src/main/java/net/shadowfacts/simplemultipart/container/MultipartContainerBlock.java +++ b/src/main/java/net/shadowfacts/simplemultipart/container/MultipartContainerBlock.java @@ -11,7 +11,7 @@ import net.minecraft.util.shape.VoxelShapes; import net.minecraft.world.BlockView; import net.minecraft.world.ExtendedBlockView; import net.minecraft.world.World; -import net.shadowfacts.simplemultipart.client.RenderStateProvider; +import net.shadowfacts.simplemultipart.client.util.RenderStateProvider; import net.shadowfacts.simplemultipart.multipart.MultipartSlot; import net.shadowfacts.simplemultipart.multipart.MultipartState; @@ -59,11 +59,6 @@ public class MultipartContainerBlock extends Block implements BlockEntityProvide return shape == null ? VoxelShapes.empty() : shape; } - @Override - public VoxelShape getRayTraceShape(BlockState var1, BlockView var2, BlockPos var3) { - return super.getRayTraceShape(var1, var2, var3); - } - @Override public MultipartContainerBlockEntity createBlockEntity(BlockView world) { return new MultipartContainerBlockEntity(); diff --git a/src/main/java/net/shadowfacts/simplemultipart/item/ItemMultipart.java b/src/main/java/net/shadowfacts/simplemultipart/item/ItemMultipart.java index 404656f..2978df5 100644 --- a/src/main/java/net/shadowfacts/simplemultipart/item/ItemMultipart.java +++ b/src/main/java/net/shadowfacts/simplemultipart/item/ItemMultipart.java @@ -41,7 +41,7 @@ public class ItemMultipart extends Item { return ActionResult.FAILURE; } - MultipartState partState = part.getStateForPlacement(slot, container); + MultipartState partState = part.getPlacementState(slot, container); if (!container.canInsert(partState, slot)) { return ActionResult.FAILURE; } diff --git a/src/main/java/net/shadowfacts/simplemultipart/mixin/client/MixinBlockRenderManager.java b/src/main/java/net/shadowfacts/simplemultipart/mixin/client/MixinBlockRenderManager.java index 233c8e7..83e8a45 100644 --- a/src/main/java/net/shadowfacts/simplemultipart/mixin/client/MixinBlockRenderManager.java +++ b/src/main/java/net/shadowfacts/simplemultipart/mixin/client/MixinBlockRenderManager.java @@ -9,7 +9,7 @@ import net.minecraft.client.render.block.BlockRenderer; import net.minecraft.client.render.model.BakedModel; import net.minecraft.util.math.BlockPos; import net.minecraft.world.ExtendedBlockView; -import net.shadowfacts.simplemultipart.client.RenderStateProvider; +import net.shadowfacts.simplemultipart.client.util.RenderStateProvider; import org.spongepowered.asm.mixin.Mixin; import org.spongepowered.asm.mixin.Shadow; import org.spongepowered.asm.mixin.injection.At; diff --git a/src/main/java/net/shadowfacts/simplemultipart/mixin/client/MixinFuckYouBiomeColors.java b/src/main/java/net/shadowfacts/simplemultipart/mixin/client/MixinFuckYouBiomeColors.java deleted file mode 100644 index 1338427..0000000 --- a/src/main/java/net/shadowfacts/simplemultipart/mixin/client/MixinFuckYouBiomeColors.java +++ /dev/null @@ -1,21 +0,0 @@ -package net.shadowfacts.simplemultipart.mixin.client; - -import net.minecraft.client.render.block.BiomeColors; -import net.minecraft.client.render.block.GrassColorHandler; -import net.minecraft.util.math.BlockPos; -import net.minecraft.world.ExtendedBlockView; -import org.spongepowered.asm.mixin.Mixin; -import org.spongepowered.asm.mixin.Overwrite; - -/** - * @author shadowfacts - */ -@Mixin(BiomeColors.class) -public class MixinFuckYouBiomeColors { - - @Overwrite - public static int grassColorAt(ExtendedBlockView world, BlockPos pos) { - return GrassColorHandler.getColor(0.5D, 1.0D); - } - -} diff --git a/src/main/java/net/shadowfacts/simplemultipart/multipart/Multipart.java b/src/main/java/net/shadowfacts/simplemultipart/multipart/Multipart.java index 68c70c8..69ed681 100644 --- a/src/main/java/net/shadowfacts/simplemultipart/multipart/Multipart.java +++ b/src/main/java/net/shadowfacts/simplemultipart/multipart/Multipart.java @@ -49,7 +49,7 @@ public abstract class Multipart { return true; } - public MultipartState getStateForPlacement(MultipartSlot slot, MultipartContainerBlockEntity container) { + public MultipartState getPlacementState(MultipartSlot slot, MultipartContainerBlockEntity container) { return getDefaultState(); } diff --git a/src/main/resources/simplemultipart.client.json b/src/main/resources/simplemultipart.client.json index ff87340..a7a9f6c 100644 --- a/src/main/resources/simplemultipart.client.json +++ b/src/main/resources/simplemultipart.client.json @@ -3,7 +3,6 @@ "package": "net.shadowfacts.simplemultipart.mixin.client", "compatibilityLevel": "JAVA_8", "mixins": [ - "MixinFuckYouBiomeColors", "MixinBakedModelManager", "MixinBlockRenderManager" ], diff --git a/src/test/java/net/shadowfacts/simplemultipart/test/GreenMultipart.java b/src/test/java/net/shadowfacts/simplemultipart/test/GreenMultipart.java index 8e8a9fc..ffaa19b 100644 --- a/src/test/java/net/shadowfacts/simplemultipart/test/GreenMultipart.java +++ b/src/test/java/net/shadowfacts/simplemultipart/test/GreenMultipart.java @@ -18,6 +18,7 @@ public class GreenMultipart extends Multipart { } @Override + @Deprecated public VoxelShape getBoundingShape(MultipartState state, MultipartSlot slot, MultipartContainerBlockEntity container) { return VoxelShapes.cube(0, 0, 0, 1, 1, 1/16f); } diff --git a/src/test/java/net/shadowfacts/simplemultipart/test/RedMultipart.java b/src/test/java/net/shadowfacts/simplemultipart/test/RedMultipart.java index 0aea56c..a351eb8 100644 --- a/src/test/java/net/shadowfacts/simplemultipart/test/RedMultipart.java +++ b/src/test/java/net/shadowfacts/simplemultipart/test/RedMultipart.java @@ -18,6 +18,7 @@ public class RedMultipart extends Multipart { } @Override + @Deprecated public VoxelShape getBoundingShape(MultipartState state, MultipartSlot slot, MultipartContainerBlockEntity container) { return VoxelShapes.cube(0, 0, 0, 1, 1/16f, 1); }