From 02ba45fa344587e5210e66810978a5dd43dc9868 Mon Sep 17 00:00:00 2001 From: Shadowfacts Date: Sat, 6 Feb 2021 15:29:35 -0500 Subject: [PATCH] Fix crash when opening & closing Preferences after changing account The old ProfileHeaderView was being leaked, and it was still listening to the preferencesDidChange notification, but crashing because its delegate (and therefore MastodonController) had been dealloc'd. --- Tusker/Screens/Utilities/Previewing.swift | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Tusker/Screens/Utilities/Previewing.swift b/Tusker/Screens/Utilities/Previewing.swift index 4017f17c..d1995c61 100644 --- a/Tusker/Screens/Utilities/Previewing.swift +++ b/Tusker/Screens/Utilities/Previewing.swift @@ -223,8 +223,8 @@ extension MenuPreviewProvider { } private func openInSafariAction(url: URL) -> UIAction { - return createAction(identifier: "openinsafari", title: "Open in Safari", systemImageName: "safari", handler: { (_) in - self.navigationDelegate?.selected(url: url, allowUniversalLinks: false) + return createAction(identifier: "openinsafari", title: "Open in Safari", systemImageName: "safari", handler: { [weak self] (_) in + self?.navigationDelegate?.selected(url: url, allowUniversalLinks: false) }) }