shadowfacts/Tusker
2
10
Fork 2
Code Issues 72 Pull Requests Releases Wiki Activity

Fix gallery buttons changing position during dismiss animation

Browse Source 
Closes #554
This commit is contained in:
Shadowfacts 2024-12-26 17:25:31 -05:00
parent 5ce9892a9b
commit 4ea61542a0
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Packages/GalleryVC/Sources/GalleryVC/GalleryItemViewController.swift
View File

@ -11,6 +11,7 @@ import AVFoundation
@MainActor @MainActor
protocol GalleryItemViewControllerDelegate: AnyObject { protocol GalleryItemViewControllerDelegate: AnyObject {
func isGalleryBeingPresented() -> Bool func isGalleryBeingPresented() -> Bool
func isGalleryBeingDismissed() -> Bool
func addPresentationAnimationCompletion(_ block: @escaping () -> Void) func addPresentationAnimationCompletion(_ block: @escaping () -> Void)
func galleryItemClose(_ item: GalleryItemViewController) func galleryItemClose(_ item: GalleryItemViewController)
func galleryItemApplicationActivities(_ item: GalleryItemViewController) -> [UIActivity]? func galleryItemApplicationActivities(_ item: GalleryItemViewController) -> [UIActivity]?
@ -376,6 +377,9 @@ class GalleryItemViewController: UIViewController {
} }
private func updateTopControlsInsets() { private func updateTopControlsInsets() {
guard delegate?.isGalleryBeingDismissed() != true else {
return
}
let notchedDeviceTopInsets: [CGFloat] = [ let notchedDeviceTopInsets: [CGFloat] = [
44, // iPhone X, Xs, Xs Max, 11 Pro, 11 Pro Max 44, // iPhone X, Xs, Xs Max, 11 Pro, 11 Pro Max
48, // iPhone XR, 11 48, // iPhone XR, 11

4
Packages/GalleryVC/Sources/GalleryVC/GalleryViewController.swift
View File

@ -139,6 +139,10 @@ extension GalleryViewController: GalleryItemViewControllerDelegate {
isBeingPresented isBeingPresented
} }
func isGalleryBeingDismissed() -> Bool {
isBeingDismissed
}
func addPresentationAnimationCompletion(_ block: @escaping () -> Void) { func addPresentationAnimationCompletion(_ block: @escaping () -> Void) {
presentationAnimationCompletionHandlers.append(block) presentationAnimationCompletionHandlers.append(block)
} }