shadowfacts
/
Tusker
2
10
Fork 2
Code Issues 71 Pull Requests Releases Wiki Activity

Fix crash if autocomplete controller dealloc'd before search task starts

This commit is contained in:
Shadowfacts 2023-09-09 12:28:53 -04:00
parent 4b52cafb9a
commit 519446c5a8
3 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
Packages/ComposeUI/Sources/ComposeUI/Controllers/AutocompleteEmojisController.swift
View File

@ -36,8 +36,8 @@ class AutocompleteEmojisController: ViewController {
.removeDuplicates() .removeDuplicates()
.sink { [unowned self] query in .sink { [unowned self] query in
self.searchTask?.cancel() self.searchTask?.cancel()
self.searchTask = Task { self.searchTask = Task { [weak self] in
await self.queryChanged(query) await self?.queryChanged(query)
} }
} }
} }

4
Packages/ComposeUI/Sources/ComposeUI/Controllers/AutocompleteHashtagsController.swift
View File

@ -34,8 +34,8 @@ class AutocompleteHashtagsController: ViewController {
.debounce(for: .milliseconds(250), scheduler: DispatchQueue.main) .debounce(for: .milliseconds(250), scheduler: DispatchQueue.main)
.sink { [unowned self] query in .sink { [unowned self] query in
self.searchTask?.cancel() self.searchTask?.cancel()
self.searchTask = Task { self.searchTask = Task { [weak self] in
await self.queryChanged(query) await self?.queryChanged(query)
} }
} }
} }

5
Packages/ComposeUI/Sources/ComposeUI/Controllers/AutocompleteMentionsController.swift
View File

@ -36,8 +36,9 @@ class AutocompleteMentionsController: ViewController {
.debounce(for: .milliseconds(250), scheduler: DispatchQueue.main) .debounce(for: .milliseconds(250), scheduler: DispatchQueue.main)
.sink { [unowned self] query in .sink { [unowned self] query in
self.searchTask?.cancel() self.searchTask?.cancel()
self.searchTask = Task { // weak in case the autocomplete controller is dealloc'd racing with the task starting
await self.queryChanged(query) self.searchTask = Task { [weak self] in
await self?.queryChanged(query)
} }
} }
} }