shadowfacts
/
Tusker
2
10
Fork 2
Code Issues 78 Pull Requests Releases Wiki Activity

Fix crash when TimelineStatusTableViewCell outlives its containing VC

This commit is contained in:
Shadowfacts 2022-10-31 16:27:13 -04:00
parent 508eef8c07
commit b755607895
17 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Tusker/Screens/Account List/AccountListTableViewController.swift
View File

@ -65,7 +65,7 @@ class AccountListTableViewController: EnhancedTableViewController {
} }
extension AccountListTableViewController: TuskerNavigationDelegate { extension AccountListTableViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension AccountListTableViewController: ToastableViewController { extension AccountListTableViewController: ToastableViewController {

3
Tusker/Screens/Bookmarks/BookmarksTableViewController.swift
View File

@ -154,6 +154,7 @@ class BookmarksTableViewController: EnhancedTableViewController {
} }
extension BookmarksTableViewController: TuskerNavigationDelegate { extension BookmarksTableViewController: TuskerNavigationDelegate {
var apiController: MastodonController! { mastodonController }
} }
extension BookmarksTableViewController: ToastableViewController { extension BookmarksTableViewController: ToastableViewController {
@ -163,8 +164,6 @@ extension BookmarksTableViewController: MenuActionProvider {
} }
extension BookmarksTableViewController: StatusTableViewCellDelegate { extension BookmarksTableViewController: StatusTableViewCellDelegate {
var apiController: MastodonController { mastodonController }
func statusCellCollapsedStateChanged(_ cell: BaseStatusTableViewCell) { func statusCellCollapsedStateChanged(_ cell: BaseStatusTableViewCell) {
tableView.beginUpdates() tableView.beginUpdates()
tableView.endUpdates() tableView.endUpdates()

3
Tusker/Screens/Conversation/ConversationTableViewController.swift
View File

@ -441,6 +441,8 @@ extension ConversationTableViewController {
} }
extension ConversationTableViewController: TuskerNavigationDelegate { extension ConversationTableViewController: TuskerNavigationDelegate {
var apiController: MastodonController! { mastodonController }
func conversation(mainStatusID: String, state: StatusState) -> ConversationTableViewController { func conversation(mainStatusID: String, state: StatusState) -> ConversationTableViewController {
let vc = ConversationTableViewController(for: mainStatusID, state: state, mastodonController: mastodonController) let vc = ConversationTableViewController(for: mainStatusID, state: state, mastodonController: mastodonController)
// transfer show statuses automatically state when showing new conversation // transfer show statuses automatically state when showing new conversation
@ -453,7 +455,6 @@ extension ConversationTableViewController: MenuActionProvider {
} }
extension ConversationTableViewController: StatusTableViewCellDelegate { extension ConversationTableViewController: StatusTableViewCellDelegate {
var apiController: MastodonController { mastodonController }
func statusCellCollapsedStateChanged(_ cell: BaseStatusTableViewCell) { func statusCellCollapsedStateChanged(_ cell: BaseStatusTableViewCell) {
// causes the table view to recalculate the cell heights // causes the table view to recalculate the cell heights
tableView.beginUpdates() tableView.beginUpdates()

2
Tusker/Screens/Explore/ProfileDirectoryViewController.swift
View File

@ -147,7 +147,7 @@ extension ProfileDirectoryViewController {
} }
extension ProfileDirectoryViewController: TuskerNavigationDelegate { extension ProfileDirectoryViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension ProfileDirectoryViewController: ToastableViewController { extension ProfileDirectoryViewController: ToastableViewController {

2
Tusker/Screens/Explore/TrendingHashtagsViewController.swift
View File

@ -120,7 +120,7 @@ extension TrendingHashtagsViewController: UICollectionViewDragDelegate {
} }
extension TrendingHashtagsViewController: TuskerNavigationDelegate { extension TrendingHashtagsViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension TrendingHashtagsViewController: ToastableViewController { extension TrendingHashtagsViewController: ToastableViewController {

2
Tusker/Screens/Explore/TrendingLinksViewController.swift
View File

@ -101,7 +101,7 @@ extension TrendingLinksViewController {
} }
extension TrendingLinksViewController: TuskerNavigationDelegate { extension TrendingLinksViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension TrendingLinksViewController: ToastableViewController { extension TrendingLinksViewController: ToastableViewController {

2
Tusker/Screens/Explore/TrendingStatusesViewController.swift
View File

@ -82,7 +82,7 @@ extension TrendingStatusesViewController {
} }
extension TrendingStatusesViewController: TuskerNavigationDelegate { extension TrendingStatusesViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension TrendingStatusesViewController: ToastableViewController { extension TrendingStatusesViewController: ToastableViewController {

2
Tusker/Screens/Lists/EditListAccountsViewController.swift
View File

@ -174,7 +174,7 @@ extension EditListAccountsViewController: SearchResultsViewControllerDelegate {
} }
extension EditListAccountsViewController: TuskerNavigationDelegate { extension EditListAccountsViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension EditListAccountsViewController: ToastableViewController { extension EditListAccountsViewController: ToastableViewController {

2
Tusker/Screens/Notifications/NotificationsTableViewController.swift
View File

@ -269,7 +269,7 @@ extension NotificationsTableViewController {
} }
extension NotificationsTableViewController: TuskerNavigationDelegate { extension NotificationsTableViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension NotificationsTableViewController: MenuActionProvider { extension NotificationsTableViewController: MenuActionProvider {

2
Tusker/Screens/Profile/ProfileStatusesViewController.swift
View File

@ -455,7 +455,7 @@ extension ProfileStatusesViewController: UICollectionViewDragDelegate {
} }
extension ProfileStatusesViewController: TuskerNavigationDelegate { extension ProfileStatusesViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension ProfileStatusesViewController: MenuActionProvider { extension ProfileStatusesViewController: MenuActionProvider {

2
Tusker/Screens/Profile/ProfileViewController.swift
View File

@ -279,7 +279,7 @@ extension ProfileViewController {
} }
extension ProfileViewController: TuskerNavigationDelegate { extension ProfileViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension ProfileViewController: ToastableViewController { extension ProfileViewController: ToastableViewController {

2
Tusker/Screens/Search/SearchResultsViewController.swift
View File

@ -289,6 +289,7 @@ extension SearchResultsViewController: UISearchBarDelegate {
} }
extension SearchResultsViewController: TuskerNavigationDelegate { extension SearchResultsViewController: TuskerNavigationDelegate {
var apiController: MastodonController! { mastodonController }
} }
extension SearchResultsViewController: ToastableViewController { extension SearchResultsViewController: ToastableViewController {
@ -298,7 +299,6 @@ extension SearchResultsViewController: MenuActionProvider {
} }
extension SearchResultsViewController: StatusTableViewCellDelegate { extension SearchResultsViewController: StatusTableViewCellDelegate {
var apiController: MastodonController { mastodonController }
func statusCellCollapsedStateChanged(_ cell: BaseStatusTableViewCell) { func statusCellCollapsedStateChanged(_ cell: BaseStatusTableViewCell) {
tableView.beginUpdates() tableView.beginUpdates()
tableView.endUpdates() tableView.endUpdates()

2
Tusker/Screens/Search/SearchViewController.swift
View File

@ -319,7 +319,7 @@ extension SearchViewController: UICollectionViewDragDelegate {
} }
extension SearchViewController: TuskerNavigationDelegate { extension SearchViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension SearchViewController: ToastableViewController { extension SearchViewController: ToastableViewController {

2
Tusker/Screens/Status Action Account List/StatusActionAccountListTableViewController.swift
View File

@ -145,6 +145,7 @@ class StatusActionAccountListTableViewController: EnhancedTableViewController {
} }
extension StatusActionAccountListTableViewController: TuskerNavigationDelegate { extension StatusActionAccountListTableViewController: TuskerNavigationDelegate {
var apiController: MastodonController! { mastodonController }
} }
extension StatusActionAccountListTableViewController: ToastableViewController { extension StatusActionAccountListTableViewController: ToastableViewController {
@ -154,7 +155,6 @@ extension StatusActionAccountListTableViewController: MenuActionProvider {
} }
extension StatusActionAccountListTableViewController: StatusTableViewCellDelegate { extension StatusActionAccountListTableViewController: StatusTableViewCellDelegate {
var apiController: MastodonController { mastodonController }
func statusCellCollapsedStateChanged(_ cell: BaseStatusTableViewCell) { func statusCellCollapsedStateChanged(_ cell: BaseStatusTableViewCell) {
// causes the table view to recalculate the cell heights // causes the table view to recalculate the cell heights
tableView.beginUpdates() tableView.beginUpdates()

2
Tusker/Screens/Timeline/TimelineTableViewController.swift
View File

@ -294,7 +294,7 @@ extension TimelineTableViewController {
} }
extension TimelineTableViewController: TuskerNavigationDelegate { extension TimelineTableViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension TimelineTableViewController: StatusTableViewCellDelegate { extension TimelineTableViewController: StatusTableViewCellDelegate {

2
Tusker/Screens/Timeline/TimelineViewController.swift
View File

@ -398,7 +398,7 @@ extension TimelineViewController: UICollectionViewDragDelegate {
} }
extension TimelineViewController: TuskerNavigationDelegate { extension TimelineViewController: TuskerNavigationDelegate {
var apiController: MastodonController { mastodonController } var apiController: MastodonController! { mastodonController }
} }
extension TimelineViewController: MenuActionProvider { extension TimelineViewController: MenuActionProvider {

2
Tusker/TuskerNavigationDelegate.swift
View File

@ -11,7 +11,7 @@ import SafariServices
import Pachyderm import Pachyderm
protocol TuskerNavigationDelegate: UIViewController, ToastableViewController { protocol TuskerNavigationDelegate: UIViewController, ToastableViewController {
var apiController: MastodonController { get } var apiController: MastodonController! { get }
func conversation(mainStatusID: String, state: StatusState) -> ConversationTableViewController func conversation(mainStatusID: String, state: StatusState) -> ConversationTableViewController
} }