Pachyderm/Model/Account.swift

@@ -26,44 +26,9 @@ public class Account: Decodable {
     public let headerStatic: URL
     public private(set) var emojis: [Emoji]
     public let moved: Bool?
-    public let movedTo: Account?
     public let fields: [Field]?
     public let bot: Bool?
     
-    public required init(from decoder: Decoder) throws {
-        let container = try decoder.container(keyedBy: CodingKeys.self)
-        
-        self.id = try container.decode(String.self, forKey: .id)
-        self.username = try container.decode(String.self, forKey: .username)
-        self.acct = try container.decode(String.self, forKey: .acct)
-        self.displayName = try container.decode(String.self, forKey: .displayName)
-        self.locked = try container.decode(Bool.self, forKey: .locked)
-        self.createdAt = try container.decode(Date.self, forKey: .createdAt)
-        self.followersCount = try container.decode(Int.self, forKey: .followersCount)
-        self.followingCount = try container.decode(Int.self, forKey: .followingCount)
-        self.statusesCount = try container.decode(Int.self, forKey: .statusesCount)
-        self.note = try container.decode(String.self, forKey: .note)
-        self.url = try container.decode(URL.self, forKey: .url)
-        self.avatar = try container.decode(URL.self, forKey: .avatar)
-        self.avatarStatic = try container.decode(URL.self, forKey: .avatarStatic)
-        self.header = try container.decode(URL.self, forKey: .header)
-        self.headerStatic = try container.decode(URL.self, forKey: .url)
-        self.emojis = try container.decode([Emoji].self, forKey: .emojis)
-        self.fields = try? container.decode([Field].self, forKey: .fields)
-        self.bot = try? container.decode(Bool.self, forKey: .bot)
-        
-        if let moved = try? container.decode(Bool.self, forKey: .moved) {
-            self.moved = moved
-            self.movedTo = nil
-        } else if let account = try? container.decode(Account.self, forKey: .moved) {
-            self.moved = true
-            self.movedTo = account
-        } else {
-            self.moved = false
-            self.movedTo = nil
-        }
-    }
-    
     public static func authorizeFollowRequest(_ account: Account) -> Request<Relationship> {
         return Request<Relationship>(method: .post, path: "/api/v1/follow_requests/\(account.id)/authorize")
     }

Pachyderm/Model/Hashtag.swift

@@ -32,39 +32,6 @@ extension Hashtag {
         public let uses: Int
         public let accounts: Int
         
-        public required init(from decoder: Decoder) throws {
-            let container = try decoder.container(keyedBy: CodingKeys.self)
-            
-            if let day = try? container.decode(Date.self, forKey: .day) {
-                self.day = day
-            } else if let unixTimestamp = try? container.decode(Double.self, forKey: .day) {
-                self.day = Date(timeIntervalSince1970: unixTimestamp)
-            } else if let str = try? container.decode(String.self, forKey: .day),
-                let unixTimestamp = Double(str) {
-                self.day = Date(timeIntervalSince1970: unixTimestamp)
-            } else {
-                throw DecodingError.dataCorruptedError(forKey: .day, in: container, debugDescription: "day must be either date or UNIX timestamp")
-            }
-            
-            if let uses = try? container.decode(Int.self, forKey: .uses) {
-                self.uses = uses
-            } else if let str = try? container.decode(String.self, forKey: .uses),
-                let uses = Int(str) {
-                self.uses = uses
-            } else {
-                throw DecodingError.dataCorruptedError(forKey: .uses, in: container, debugDescription: "uses must either be int or string containing int")
-            }
-            
-            if let accounts = try? container.decode(Int.self, forKey: .accounts) {
-                self.accounts = accounts
-            } else if let str = try? container.decode(String.self, forKey: .accounts),
-                let accounts = Int(str) {
-                self.accounts = accounts
-            } else {
-                throw DecodingError.dataCorruptedError(forKey: .accounts, in: container, debugDescription: "accounts must either be int or string containing int")
-            }
-        }
-
         private enum CodingKeys: String, CodingKey {
             case day
             case uses

Tusker/Preferences/Preferences.swift

@@ -44,9 +44,8 @@ class Preferences: Codable, ObservableObject {
         
         self.defaultPostVisibility = try container.decode(Status.Visibility.self, forKey: .defaultPostVisibility)
         self.automaticallySaveDrafts = try container.decode(Bool.self, forKey: .automaticallySaveDrafts)
-        self.requireAttachmentDescriptions = try container.decode(Bool.self, forKey: .requireAttachmentDescriptions)
         self.contentWarningCopyMode = try container.decode(ContentWarningCopyMode.self, forKey: .contentWarningCopyMode)
-        self.mentionReblogger = try container.decode(Bool.self, forKey: .mentionReblogger)
+        self.requireAttachmentDescriptions = try container.decode(Bool.self, forKey: .requireAttachmentDescriptions)
         self.blurAllMedia = try container.decode(Bool.self, forKey: .blurAllMedia)
         self.openLinksInApps = try container.decode(Bool.self, forKey: .openLinksInApps)
         self.useInAppSafari = try container.decode(Bool.self, forKey: .useInAppSafari)
@@ -69,9 +68,8 @@ class Preferences: Codable, ObservableObject {
         
         try container.encode(defaultPostVisibility, forKey: .defaultPostVisibility)
         try container.encode(automaticallySaveDrafts, forKey: .automaticallySaveDrafts)
-        try container.encode(requireAttachmentDescriptions, forKey: .requireAttachmentDescriptions)
         try container.encode(contentWarningCopyMode, forKey: .contentWarningCopyMode)
-        try container.encode(mentionReblogger, forKey: .mentionReblogger)
+        try container.encode(requireAttachmentDescriptions, forKey: .requireAttachmentDescriptions)
         try container.encode(blurAllMedia, forKey: .blurAllMedia)
         try container.encode(openLinksInApps, forKey: .openLinksInApps)
         try container.encode(useInAppSafari, forKey: .useInAppSafari)
@@ -93,9 +91,8 @@ class Preferences: Codable, ObservableObject {
     // MARK: - Behavior
     @Published var defaultPostVisibility = Status.Visibility.public
     @Published var automaticallySaveDrafts = true
-    @Published var requireAttachmentDescriptions = false
     @Published var contentWarningCopyMode = ContentWarningCopyMode.asIs
-    @Published var mentionReblogger = false
+    @Published var requireAttachmentDescriptions = false
     @Published var blurAllMedia = false
     @Published var openLinksInApps = true
     @Published var useInAppSafari = true
@@ -117,9 +114,8 @@ class Preferences: Codable, ObservableObject {
         
         case defaultPostVisibility
         case automaticallySaveDrafts
-        case requireAttachmentDescriptions
         case contentWarningCopyMode
-        case mentionReblogger
+        case requireAttachmentDescriptions
         case blurAllMedia
         case openLinksInApps
         case useInAppSafari

Tusker/Screens/Compose/ComposeViewController.swift

@@ -15,7 +15,7 @@ class ComposeViewController: UIViewController {
     let mastodonController: MastodonController
     
     var inReplyToID: String?
-    var accountsToMention = [String]()
+    var accountsToMention: [String]
     var initialText: String?
     var contentWarningEnabled = false {
         didSet {
@@ -78,12 +78,11 @@ class ComposeViewController: UIViewController {
         self.inReplyToID = inReplyToID
         if let inReplyToID = inReplyToID, let inReplyTo = mastodonController.cache.status(for: inReplyToID) {
             accountsToMention = [inReplyTo.account.acct] + inReplyTo.mentions.map { $0.acct }
+        } else if let mentioningAcct = mentioningAcct {
+            accountsToMention = [mentioningAcct]
         } else {
             accountsToMention = []
         }
-        if let mentioningAcct = mentioningAcct {
-            accountsToMention.append(mentioningAcct)
-        }
         if let ownAccount = mastodonController.account {
             accountsToMention.removeAll(where: { acct in ownAccount.acct == acct })
         }

Tusker/Screens/Preferences/BehaviorPrefsView.swift

@@ -13,15 +13,14 @@ struct BehaviorPrefsView: View {
 
     var body: some View {
         List {
-            composingSection
+            section1
-            replyingSection
+            section2
-            readingSection
+            section3
-            linksSection
         }.listStyle(GroupedListStyle())
             .navigationBarTitle(Text("Behavior"))
     }
     
-    var composingSection: some View {
+    var section1: some View {
         Section(header: Text("COMPOSING")) {
             Picker(selection: $preferences.defaultPostVisibility, label: Text("Default Post Visibility")) {
                 ForEach(Status.Visibility.allCases, id: \.self) { visibility in
@@ -36,26 +35,18 @@ struct BehaviorPrefsView: View {
             Toggle(isOn: $preferences.automaticallySaveDrafts) {
                 Text("Automatically Save Drafts")
             }
+            Picker(selection: $preferences.contentWarningCopyMode, label: Text("Content Warning Copy Style")) {
+                Text("As-is").tag(ContentWarningCopyMode.asIs)
+                Text("Prepend 're: '").tag(ContentWarningCopyMode.prependRe)
+                Text("Don't copy").tag(ContentWarningCopyMode.doNotCopy)
+            }
             Toggle(isOn: $preferences.requireAttachmentDescriptions) {
                 Text("Require Attachment Descriptions")
             }
         }
     }
     
-    var replyingSection: some View {
+    var section2: some View {
-        Section(header: Text("REPLYING")) {
-            Picker(selection: $preferences.contentWarningCopyMode, label: Text("Content Warning Copy Style")) {
-                Text("As-is").tag(ContentWarningCopyMode.asIs)
-                Text("Prepend 're: '").tag(ContentWarningCopyMode.prependRe)
-                Text("Don't copy").tag(ContentWarningCopyMode.doNotCopy)
-            }
-            Toggle(isOn: $preferences.mentionReblogger) {
-                Text("Mention Reblogger")
-            }
-        }
-    }
-    
-    var readingSection: some View {
         Section(header: Text("READING")) {
             Toggle(isOn: $preferences.blurAllMedia) {
                 Text("Blur All Media")
@@ -63,7 +54,7 @@ struct BehaviorPrefsView: View {
         }
     }
     
-    var linksSection: some View {
+    var section3: some View {
         Section(header: Text("LINKS")) {
             Toggle(isOn: $preferences.openLinksInApps) {
                 Text("Open Links in Apps")

Tusker/TuskerNavigationDelegate.swift

@@ -34,8 +34,6 @@ protocol TuskerNavigationDelegate: class {
     
     func reply(to statusID: String)
     
-    func reply(to statusID: String, mentioningAcct: String?)
-    
     func largeImage(_ image: UIImage, description: String?, sourceView: UIImageView) -> LargeImageViewController
     
     func largeImage(gifData: Data, description: String?, sourceView: UIImageView) -> LargeImageViewController
@@ -129,7 +127,7 @@ extension TuskerNavigationDelegate where Self: UIViewController {
         compose(mentioning: nil)
     }
     
-    func compose(mentioning: String?) {
+    func compose(mentioning: String? = nil) {
         let compose = ComposeViewController(mentioningAcct: mentioning, mastodonController: apiController)
         let vc = UINavigationController(rootViewController: compose)
         vc.presentationController?.delegate = compose
@@ -137,11 +135,7 @@ extension TuskerNavigationDelegate where Self: UIViewController {
     }
     
     func reply(to statusID: String) {
-        reply(to: statusID, mentioningAcct: nil)
+        let compose = ComposeViewController(inReplyTo: statusID, mastodonController: apiController)
-    }
-    
-    func reply(to statusID: String, mentioningAcct: String?) {
-        let compose = ComposeViewController(inReplyTo: statusID, mentioningAcct: mentioningAcct, mastodonController: apiController)
         let vc = UINavigationController(rootViewController: compose)
         vc.presentationController?.delegate = compose
         present(vc, animated: true)

Tusker/Views/Status/TimelineStatusTableViewCell.swift

@@ -120,16 +120,6 @@ class TimelineStatusTableViewCell: BaseStatusTableViewCell {
         }
     }
     
-    func reply() {
-        if Preferences.shared.mentionReblogger,
-            let rebloggerID = rebloggerID,
-            let rebloggerAccount = mastodonController.cache.account(for: rebloggerID) {
-            delegate?.reply(to: statusID, mentioningAcct: rebloggerAccount.acct)
-        } else {
-            delegate?.reply(to: statusID)
-        }
-    }
-    
     override func prepareForReuse() {
         super.prepareForReuse()
         updateTimestampWorkItem?.cancel()
@@ -142,10 +132,6 @@ class TimelineStatusTableViewCell: BaseStatusTableViewCell {
         delegate?.selected(account: rebloggerID)
     }
     
-    override func replyPressed() {
-        reply()
-    }
-
     override func getStatusCellPreviewProviders(for location: CGPoint, sourceViewController: UIViewController) -> BaseStatusTableViewCell.PreviewProviders? {
         guard let mastodonController = mastodonController else { return nil }
         return (
@@ -229,7 +215,7 @@ extension TimelineStatusTableViewCell: TableViewSwipeActionProvider {
     func trailingSwipeActionsConfiguration() -> UISwipeActionsConfiguration? {
         let reply = UIContextualAction(style: .normal, title: "Reply") { (action, view, completion) in
             completion(true)
-            self.reply()
+            self.delegate?.reply(to: self.statusID)
         }
         reply.image = UIImage(systemName: "arrowshape.turn.up.left.fill")
         reply.backgroundColor = tintColor