Workaround for status collapse button overlapping other views in the cell

Closes #402

Tusker/Views/ContentTextView.swift

@@ -75,6 +75,10 @@ class ContentTextView: LinkTextView, BaseEmojiLabel {
         textContainerInset = .zero
         textContainer.lineFragmentPadding = 0
         
+        linkTextAttributes = [
+            .foregroundColor: UIColor.tintColor
+        ]
+        
         // the text view's builtin link interaction code is tied to isSelectable, so we need to use our own tap recognizer
         let recognizer = UITapGestureRecognizer(target: self, action: #selector(textTapped(_:)))
         addGestureRecognizer(recognizer)
@@ -94,12 +98,6 @@ class ContentTextView: LinkTextView, BaseEmojiLabel {
 
     // MARK: - HTML Parsing
     func setTextFromHtml(_ html: String) {
-        // this shouldn't be necessary, but sometimes when the text view is updated before
-        // being added to the view hierarchy, it doesn't get tintColorDidChange calld
-        // when it's actually added, so links have the wrong color
-        // see #402
-        self.tintColor = Preferences.shared.accentColor.color
-        
         self.attributedText = htmlConverter.convert(html)
     }
     

Tusker/Views/Status/StatusCollectionViewCell.swift

@@ -125,7 +125,19 @@ extension StatusCollectionViewCell {
                 statusState.collapsed = false
             }
         }
-        collapseButton.isHidden = !statusState.collapsible!
+        let expected = !statusState.collapsible!
+        // Very very rarely, setting isHidden to false only seems to partially take effect:
+        // the button will be rendered, but isHidden will still return true, and the
+        // containing stack view won't have updated constraints for it and so the cell
+        // layout will be wrong and the button will overlap other views in the stack.
+        // So, as a truly cursed workaround, just try a few times in a row until reading
+        // back isHidden returns the correct value.
+        for _ in 0..<5 {
+            collapseButton.isHidden = expected
+            if collapseButton.isHidden == expected {
+                break
+            }
+        }
         contentContainer.setCollapsed(statusState.collapsed!)
         if statusState.collapsed! {
             contentContainer.alpha = 0