Pachyderm/Model/Notification.swift

@@ -15,24 +15,6 @@ public class Notification: Decodable {
     public let account: Account
     public let status: Status?
     
-    public required init(from decoder: Decoder) throws {
-        let container = try decoder.container(keyedBy: CodingKeys.self)
-        
-        self.id = try container.decode(String.self, forKey: .id)
-        if let kind = try? container.decode(Kind.self, forKey: .kind) {
-            self.kind = kind
-        } else {
-            self.kind = .unknown
-        }
-        self.createdAt = try container.decode(Date.self, forKey: .createdAt)
-        self.account = try container.decode(Account.self, forKey: .account)
-        if container.contains(.status) {
-            self.status = try container.decode(Status.self, forKey: .status)
-        } else {
-            self.status = nil
-        }
-    }
-
     public static func dismiss(id notificationID: String) -> Request<Empty> {
         return Request<Empty>(method: .post, path: "/api/v1/notifications/dismiss", body: .parameters([
                 "id" => notificationID
@@ -55,7 +37,6 @@ extension Notification {
         case favourite
         case follow
         case followRequest = "follow_request"
-        case unknown
     }
 }
 

Tusker.xcodeproj/project.pbxproj

@@ -165,7 +165,6 @@
 		D6945C3A23AC75E2005C403C /* FindInstanceViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6945C3923AC75E2005C403C /* FindInstanceViewController.swift */; };
 		D6969E9E240C81B9002843CE /* NSTextAttachment+Emoji.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6969E9D240C81B9002843CE /* NSTextAttachment+Emoji.swift */; };
 		D6969EA0240C8384002843CE /* EmojiLabel.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6969E9F240C8384002843CE /* EmojiLabel.swift */; };
-		D6969EA4240DD28D002843CE /* UnknownNotificationTableViewCell.xib in Resources */ = {isa = PBXBuildFile; fileRef = D6969EA2240DD28D002843CE /* UnknownNotificationTableViewCell.xib */; };
 		D6A3BC7723218E1300FD64D5 /* TimelineSegment.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6A3BC7323218C6E00FD64D5 /* TimelineSegment.swift */; };
 		D6A3BC7923218E9200FD64D5 /* NotificationGroup.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6A3BC7823218E9200FD64D5 /* NotificationGroup.swift */; };
 		D6A3BC7C232195C600FD64D5 /* ActionNotificationGroupTableViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6A3BC7A232195C600FD64D5 /* ActionNotificationGroupTableViewCell.swift */; };
@@ -448,7 +447,6 @@
 		D6945C3923AC75E2005C403C /* FindInstanceViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; name = FindInstanceViewController.swift; path = Tusker/Screens/FindInstanceViewController.swift; sourceTree = SOURCE_ROOT; };
 		D6969E9D240C81B9002843CE /* NSTextAttachment+Emoji.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "NSTextAttachment+Emoji.swift"; sourceTree = "<group>"; };
 		D6969E9F240C8384002843CE /* EmojiLabel.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EmojiLabel.swift; sourceTree = "<group>"; };
-		D6969EA2240DD28D002843CE /* UnknownNotificationTableViewCell.xib */ = {isa = PBXFileReference; lastKnownFileType = file.xib; path = UnknownNotificationTableViewCell.xib; sourceTree = "<group>"; };
 		D6A3BC7323218C6E00FD64D5 /* TimelineSegment.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TimelineSegment.swift; sourceTree = "<group>"; };
 		D6A3BC7823218E9200FD64D5 /* NotificationGroup.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = NotificationGroup.swift; sourceTree = "<group>"; };
 		D6A3BC7A232195C600FD64D5 /* ActionNotificationGroupTableViewCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ActionNotificationGroupTableViewCell.swift; sourceTree = "<group>"; };
@@ -928,7 +926,6 @@
 				D6A3BC7F2321B7E600FD64D5 /* FollowNotificationGroupTableViewCell.xib */,
 				D64BC18D23C18B9D000D0238 /* FollowRequestNotificationTableViewCell.swift */,
 				D64BC18E23C18B9D000D0238 /* FollowRequestNotificationTableViewCell.xib */,
-				D6969EA2240DD28D002843CE /* UnknownNotificationTableViewCell.xib */,
 			);
 			path = Notifications;
 			sourceTree = "<group>";
@@ -1471,7 +1468,6 @@
 				D6D4DDD7212518A200E1C4BB /* Assets.xcassets in Resources */,
 				D663625D2135C74800C9CBA2 /* ConversationMainStatusTableViewCell.xib in Resources */,
 				D640D76922BAF5E6004FBE69 /* DomainBlocks.plist in Resources */,
-				D6969EA4240DD28D002843CE /* UnknownNotificationTableViewCell.xib in Resources */,
 				D6289E84217B795D0003D1D7 /* LargeImageViewController.xib in Resources */,
 				D627FF79217E950100CC0648 /* DraftsTableViewController.xib in Resources */,
 				D626493323BD751600612E6E /* ShowCameraCollectionViewCell.xib in Resources */,

Tusker/Screens/Notifications/NotificationsTableViewController.swift

@@ -15,7 +15,6 @@ class NotificationsTableViewController: EnhancedTableViewController {
     private let actionGroupCell = "actionGroupCell"
     private let followGroupCell = "followGroupCell"
     private let followRequestCell = "followRequestCell"
-    private let unknownCell = "unknownCell"
     
     let mastodonController: MastodonController
     
@@ -51,7 +50,6 @@ class NotificationsTableViewController: EnhancedTableViewController {
         tableView.register(UINib(nibName: "ActionNotificationGroupTableViewCell", bundle: .main), forCellReuseIdentifier: actionGroupCell)
         tableView.register(UINib(nibName: "FollowNotificationGroupTableViewCell", bundle: .main), forCellReuseIdentifier: followGroupCell)
         tableView.register(UINib(nibName: "FollowRequestNotificationTableViewCell", bundle: .main), forCellReuseIdentifier: followRequestCell)
-        tableView.register(UINib(nibName: "UnknownNotificationTableViewCell", bundle: .main), forCellReuseIdentifier: unknownCell)
         
         tableView.prefetchDataSource = self
         
@@ -118,9 +116,6 @@ class NotificationsTableViewController: EnhancedTableViewController {
             cell.delegate = self
             cell.updateUI(notification: notification)
             return cell
-            
-        case .unknown:
-            return tableView.dequeueReusableCell(withIdentifier: unknownCell, for: indexPath)
         }
     }
  

Tusker/Screens/Preferences/SilentActionPrefs.swift

@@ -31,7 +31,7 @@ struct SilentActionPrefs : View {
 //    })
 //    var silentActionPermissions: [SilentActionPermission]
 //    @Preference(\.silentActions) var silentActions: [String: Preferences.Permission]
-    @ObservedObject var preferences = Preferences.shared
+    @EnvironmentObject var preferences: Preferences
     
     var body: some View {
         List(Array(preferences.silentActions.keys), id: \.self) { source in

Tusker/Screens/Profile/ProfileTableViewController.swift

@@ -129,7 +129,7 @@ class ProfileTableViewController: EnhancedTableViewController {
     
     @objc func updateUIForPreferences() {
         guard let accountID = accountID, let account = mastodonController.cache.account(for: accountID) else { return }
-        navigationItem.title = account.displayNameWithoutCustomEmoji
+        navigationItem.title = account.displayOrUserName
     }
     
     func getStatuses(for range: RequestRange = .default, onlyPinned: Bool = false, completion: @escaping Client.Callback<[Status]>) {

Tusker/Views/EmojiLabel.swift

@@ -17,7 +17,7 @@ class EmojiLabel: UILabel {
     private var emojiRequests: [ImageCache.Request] = []
     
     func setEmojis(_ emojis: [Emoji], identifier: String) {
-        guard emojis.count > 0, let attributedText = attributedText else { return }
+        guard emojis.count > 0, self.emojiIdentifier != identifier, let attributedText = attributedText else { return }
         
         self.emojiIdentifier = identifier
         emojiRequests.forEach { $0.cancel() }

Tusker/Views/Notifications/UnknownNotificationTableViewCell.xib

@@ -1,35 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<document type="com.apple.InterfaceBuilder3.CocoaTouch.XIB" version="3.0" toolsVersion="16092.1" targetRuntime="iOS.CocoaTouch" propertyAccessControl="none" useAutolayout="YES" useTraitCollections="YES" useSafeAreas="YES" colorMatched="YES">
-    <device id="retina6_1" orientation="portrait" appearance="light"/>
-    <dependencies>
-        <plugIn identifier="com.apple.InterfaceBuilder.IBCocoaTouchPlugin" version="16082.1"/>
-        <capability name="Safe area layout guides" minToolsVersion="9.0"/>
-        <capability name="documents saved in the Xcode 8 format" minToolsVersion="8.0"/>
-    </dependencies>
-    <objects>
-        <placeholder placeholderIdentifier="IBFilesOwner" id="-1" userLabel="File's Owner"/>
-        <placeholder placeholderIdentifier="IBFirstResponder" id="-2" customClass="UIResponder"/>
-        <tableViewCell contentMode="scaleToFill" selectionStyle="default" indentationWidth="10" id="KGk-i7-Jjw">
-            <rect key="frame" x="0.0" y="0.0" width="320" height="44"/>
-            <autoresizingMask key="autoresizingMask" flexibleMaxX="YES" flexibleMaxY="YES"/>
-            <tableViewCellContentView key="contentView" opaque="NO" clipsSubviews="YES" multipleTouchEnabled="YES" contentMode="center" tableViewCell="KGk-i7-Jjw" id="H2p-sc-9uM">
-                <rect key="frame" x="0.0" y="0.0" width="320" height="44"/>
-                <autoresizingMask key="autoresizingMask"/>
-                <subviews>
-                    <label opaque="NO" userInteractionEnabled="NO" contentMode="left" horizontalHuggingPriority="251" verticalHuggingPriority="251" text="Unknown Notification" textAlignment="natural" lineBreakMode="tailTruncation" baselineAdjustment="alignBaselines" adjustsFontSizeToFit="NO" translatesAutoresizingMaskIntoConstraints="NO" id="BC8-kp-x12">
-                        <rect key="frame" x="16" y="11.5" width="164" height="21"/>
-                        <fontDescription key="fontDescription" type="system" pointSize="17"/>
-                        <nil key="textColor"/>
-                        <nil key="highlightedColor"/>
-                    </label>
-                </subviews>
-                <constraints>
-                    <constraint firstItem="BC8-kp-x12" firstAttribute="leading" secondItem="H2p-sc-9uM" secondAttribute="leadingMargin" id="MQf-82-GMw"/>
-                    <constraint firstItem="BC8-kp-x12" firstAttribute="centerY" secondItem="H2p-sc-9uM" secondAttribute="centerY" id="gHv-BQ-CXd"/>
-                </constraints>
-            </tableViewCellContentView>
-            <viewLayoutGuide key="safeArea" id="njF-e1-oar"/>
-            <point key="canvasLocation" x="132" y="154"/>
-        </tableViewCell>
-    </objects>
-</document>