Fix potential race between adding notification to NSManagedObjectContext and displaying VC

Closes #549

CHANGELOG.md

@@ -1,5 +1,16 @@
 # Changelog
 
+## 2024.5 (137)
+Features/Improvements:
+- Improve gallery presentation/dismissal transitions
+
+Bugfixes:
+- Account for bidirectional text in display names
+- Fix crash when playing back gifv
+- Fix gallery controls not hiding if video loading fails
+- iPadOS: Fix incorrect gallery dismiss animation on non-fullscreen windows
+- iPadOS: Fix hang when switching accounts
+
 ## 2024.4 (136)
 Features/Improvements:
 - Import image description when adding attachments from Photos if possible

Packages/GalleryVC/Package.swift

@@ -14,11 +14,15 @@ let package = Package(
             name: "GalleryVC",
             targets: ["GalleryVC"]),
     ],
+    dependencies: [
+        .package(path: "../TuskerComponents"),
+    ],
     targets: [
         // Targets are the basic building blocks of a package, defining a module or a test suite.
         // Targets can depend on other targets in this package and products from dependencies.
         .target(
             name: "GalleryVC",
+            dependencies: ["TuskerComponents"],
             swiftSettings: [
                 .swiftLanguageMode(.v5)
             ]),

Packages/GalleryVC/Sources/GalleryVC/Content/FallbackGalleryContentViewController.swift

@@ -1,15 +1,13 @@
 //
 //  FallbackGalleryContentViewController.swift
-//  Tusker
+//  GalleryVC
 //
 //  Created by Shadowfacts on 3/18/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
 //
 
 import UIKit
-import GalleryVC
 import QuickLook
-import Pachyderm
 
 private class FallbackGalleryContentViewController: QLPreviewController {
     private let previewItem = GalleryPreviewItem()
@@ -52,40 +50,40 @@ extension FallbackGalleryContentViewController: QLPreviewControllerDataSource {
     }
 }
 
-class FallbackGalleryNavigationController: UINavigationController, GalleryContentViewController {
-    init(url: URL) {
+public class FallbackGalleryNavigationController: UINavigationController, GalleryContentViewController {
+    public init(url: URL) {
         super.init(nibName: nil, bundle: nil)
         self.viewControllers = [FallbackGalleryContentViewController(url: url)]
     }
     
-    override func viewDidLoad() {
+    public override func viewDidLoad() {
         super.viewDidLoad()
         
         container?.disableGalleryScrollAndZoom()
     }
     
-    required init?(coder aDecoder: NSCoder) {
+    public required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
     
     // MARK: GalleryContentViewController
     
-    weak var container: (any GalleryVC.GalleryContentViewControllerContainer)?
+    public weak var container: (any GalleryContentViewControllerContainer)?
     
-    var contentSize: CGSize {
+    public var contentSize: CGSize {
         .zero
     }
     
-    var activityItemsForSharing: [Any] {
+    public var activityItemsForSharing: [Any] {
         []
     }
     
-    var caption: String? {
+    public var caption: String? {
         nil
     }
     
-    var canAnimateFromSourceView: Bool {
-        false
+    public var presentationAnimation: GalleryContentPresentationAnimation {
+        .fade
     }
 }
 

Packages/GalleryVC/Sources/GalleryVC/Content/ImageGalleryContentViewController.swift

@@ -1,22 +1,22 @@
 //
 //  ImageGalleryContentViewController.swift
-//  Tusker
+//  GalleryVC
 //
 //  Created by Shadowfacts on 3/17/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
 //
 
 import UIKit
-import GalleryVC
-import Pachyderm
 import TuskerComponents
 @preconcurrency import VisionKit
 
-class ImageGalleryContentViewController: UIViewController, GalleryContentViewController {
-    let url: URL
-    let caption: String?
-    let originalData: Data?
-    let image: UIImage
+open class ImageGalleryContentViewController: UIViewController, GalleryContentViewController {
+    public let caption: String?
+    public var image: UIImage {
+        didSet {
+            imageView?.image = image
+        }
+    }
     let gifController: GIFController?
     
     private var imageView: GIFImageView!
@@ -27,12 +27,8 @@ class ImageGalleryContentViewController: UIViewController, GalleryContentViewCon
     @available(iOS 16.0, macCatalyst 17.0, *)
     private var analysisInteraction: ImageAnalysisInteraction? { _analysisInteraction as? ImageAnalysisInteraction }
     
-    private var isGrayscale = false
-    
-    init(url: URL, caption: String?, originalData: Data?, image: UIImage, gifController: GIFController?) {
-        self.url = url
+    public init(image: UIImage, caption: String?, gifController: GIFController?) {
         self.caption = caption
-        self.originalData = originalData
         self.image = image
         self.gifController = gifController
         
@@ -41,21 +37,14 @@ class ImageGalleryContentViewController: UIViewController, GalleryContentViewCon
         preferredContentSize = image.size
     }
     
-    required init?(coder: NSCoder) {
+    public required init?(coder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
     
-    override func viewDidLoad() {
+    public override func viewDidLoad() {
         super.viewDidLoad()
         
-        isGrayscale = Preferences.shared.grayscaleImages
-        let maybeGrayscaleImage = if isGrayscale {
-            ImageGrayscalifier.convert(url: url, image: image) ?? image
-        } else {
-            image
-        }
-        
-        imageView = GIFImageView(image: maybeGrayscaleImage)
+        imageView = GIFImageView(image: image)
         imageView.translatesAutoresizingMaskIntoConstraints = false
         imageView.contentMode = .scaleAspectFill
         imageView.isUserInteractionEnabled = true
@@ -86,11 +75,9 @@ class ImageGalleryContentViewController: UIViewController, GalleryContentViewCon
                 }
             }
         }
-        
-        NotificationCenter.default.addObserver(self, selector: #selector(preferencesChanged), name: .preferencesChanged, object: nil)
     }
     
-    override func viewWillAppear(_ animated: Bool) {
+    public override func viewWillAppear(_ animated: Bool) {
         super.viewWillAppear(animated)
         
         if let gifController {
@@ -98,37 +85,23 @@ class ImageGalleryContentViewController: UIViewController, GalleryContentViewCon
         }
     }
     
-    @objc private func preferencesChanged() {
-        if isGrayscale != Preferences.shared.grayscaleImages {
-            isGrayscale = Preferences.shared.grayscaleImages
-            let image = if isGrayscale {
-                ImageGrayscalifier.convert(url: url, image: image)
-            } else {
-                image
-            }
-            if let image {
-                imageView.image = image
-            }
-        }
-    }
-    
     // MARK: GalleryContentViewController
     
-    weak var container: (any GalleryVC.GalleryContentViewControllerContainer)?
+    public weak var container: (any GalleryContentViewControllerContainer)?
     
-    var contentSize: CGSize {
+    public var contentSize: CGSize {
         image.size
     }
     
-    var activityItemsForSharing: [Any] {
-        if let data = originalData ?? image.pngData() {
-            return [ImageActivityItemSource(data: data, url: url, image: image)]
-        } else {
-            return []
-        }
+    open var activityItemsForSharing: [Any] {
+        return [image]
     }
     
-    func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
+    public var presentationAnimation: GalleryContentPresentationAnimation {
+        gifController != nil ? .fromSourceViewWithoutSnapshot : .fromSourceView
+    }
+    
+    public func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
         if #available(iOS 16.0, macCatalyst 17.0, *),
            let analysisInteraction {
             analysisInteraction.setSupplementaryInterfaceHidden(!visible, animated: animated)
@@ -138,7 +111,7 @@ class ImageGalleryContentViewController: UIViewController, GalleryContentViewCon
 
 @available(iOS 16.0, macCatalyst 17.0, *)
 extension ImageGalleryContentViewController: ImageAnalysisInteractionDelegate {
-    func interaction(_ interaction: ImageAnalysisInteraction, shouldBeginAt point: CGPoint, for interactionType: ImageAnalysisInteraction.InteractionTypes) -> Bool {
+    public func interaction(_ interaction: ImageAnalysisInteraction, shouldBeginAt point: CGPoint, for interactionType: ImageAnalysisInteraction.InteractionTypes) -> Bool {
         return container?.galleryControlsVisible ?? true
     }
 }

Packages/GalleryVC/Sources/GalleryVC/Content/LoadingGalleryContentViewController.swift

@@ -7,43 +7,42 @@
 //
 
 import UIKit
-import GalleryVC
 
-class LoadingGalleryContentViewController: UIViewController, GalleryContentViewController {
+public class LoadingGalleryContentViewController: UIViewController, GalleryContentViewController {
     private let fallbackCaption: String?
     private let provider: () async -> (any GalleryContentViewController)?
     private var wrapped: (any GalleryContentViewController)!
     
-    weak var container: GalleryContentViewControllerContainer?
+    public weak var container: GalleryContentViewControllerContainer?
     
-    var contentSize: CGSize {
+    public var contentSize: CGSize {
         wrapped?.contentSize ?? .zero
     }
     
-    var activityItemsForSharing: [Any] {
+    public var activityItemsForSharing: [Any] {
         wrapped?.activityItemsForSharing ?? []
     }
     
-    var caption: String? {
+    public var caption: String? {
         wrapped?.caption ?? fallbackCaption
     }
     
-    var canAnimateFromSourceView: Bool {
-        wrapped?.canAnimateFromSourceView ?? true
+    public var presentationAnimation: GalleryContentPresentationAnimation {
+        wrapped?.presentationAnimation ?? .fade
     }
     
-    init(caption: String?, provider: @escaping () async -> (any GalleryContentViewController)?) {
+    public init(caption: String?, provider: @escaping () async -> (any GalleryContentViewController)?) {
         self.fallbackCaption = caption
         self.provider = provider
         
         super.init(nibName: nil, bundle: nil)
     }
     
-    required init?(coder: NSCoder) {
+    public required init?(coder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
     
-    override func viewDidLoad() {
+    public override func viewDidLoad() {
         super.viewDidLoad()
         
         container?.setGalleryContentLoading(true)
@@ -81,7 +80,7 @@ class LoadingGalleryContentViewController: UIViewController, GalleryContentViewC
         
         let label = UILabel()
         label.text = "Error Loading"
-        label.font = .preferredFont(forTextStyle: .title1).withTraits(.traitBold)!
+        label.font = UIFont(descriptor: .preferredFontDescriptor(withTextStyle: .title1).withSymbolicTraits(.traitBold)!, size: 0)
         label.textColor = .secondaryLabel
         label.adjustsFontForContentSizeCategory = true
         
@@ -102,15 +101,15 @@ class LoadingGalleryContentViewController: UIViewController, GalleryContentViewC
         ])
     }
     
-    func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
+    public func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
         wrapped?.setControlsVisible(visible, animated: animated, dueToUserInteraction: dueToUserInteraction)
     }
     
-    func galleryContentDidAppear() {
+    public func galleryContentDidAppear() {
         wrapped?.galleryContentDidAppear()
     }
     
-    func galleryContentWillDisappear() {
+    public func galleryContentWillDisappear() {
         wrapped?.galleryContentWillDisappear()
     }
     

Packages/GalleryVC/Sources/GalleryVC/Content/VideoControlsViewController.swift

@@ -1,6 +1,6 @@
 //
 //  VideoControlsViewController.swift
-//  Tusker
+//  GalleryVC
 //
 //  Created by Shadowfacts on 3/21/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
@@ -19,27 +19,35 @@ class VideoControlsViewController: UIViewController {
 
     private let player: AVPlayer
     
-    private lazy var muteButton = MuteButton().configure {
-        $0.addTarget(self, action: #selector(muteButtonPressed), for: .touchUpInside)
-        $0.setMuted(false, animated: false)
-    }
+    private lazy var muteButton: MuteButton = {
+        let button = MuteButton()
+        button.addTarget(self, action: #selector(muteButtonPressed), for: .touchUpInside)
+        button.setMuted(false, animated: false)
+        return button
+    }()
     
-    private let timestampLabel = UILabel().configure {
-        $0.text = "0:00"
-        $0.font = UIFontMetrics(forTextStyle: .caption1).scaledFont(for: .monospacedDigitSystemFont(ofSize: 13, weight: .regular))
-    }
+    private let timestampLabel: UILabel = {
+        let label = UILabel()
+        label.text = "0:00"
+        label.font = UIFontMetrics(forTextStyle: .caption1).scaledFont(for: .monospacedDigitSystemFont(ofSize: 13, weight: .regular))
+        return label
+    }()
     
-    private lazy var scrubbingControl = VideoScrubbingControl().configure {
-        $0.heightAnchor.constraint(equalToConstant: 44).isActive = true
-        $0.addTarget(self, action: #selector(scrubbingStarted), for: .editingDidBegin)
-        $0.addTarget(self, action: #selector(scrubbingChanged), for: .editingChanged)
-        $0.addTarget(self, action: #selector(scrubbingEnded), for: .editingDidEnd)
-    }
+    private lazy var scrubbingControl: VideoScrubbingControl = {
+        let control = VideoScrubbingControl()
+        control.heightAnchor.constraint(equalToConstant: 44).isActive = true
+        control.addTarget(self, action: #selector(scrubbingStarted), for: .editingDidBegin)
+        control.addTarget(self, action: #selector(scrubbingChanged), for: .editingChanged)
+        control.addTarget(self, action: #selector(scrubbingEnded), for: .editingDidEnd)
+        return control
+    }()
     
-    private let timeRemainingLabel = UILabel().configure {
-        $0.text = "-0:00"
-        $0.font = UIFontMetrics(forTextStyle: .caption1).scaledFont(for: .monospacedDigitSystemFont(ofSize: 13, weight: .regular))
-    }
+    private let timeRemainingLabel: UILabel = {
+        let label = UILabel()
+        label.text = "-0:00"
+        label.font = UIFontMetrics(forTextStyle: .caption1).scaledFont(for: .monospacedDigitSystemFont(ofSize: 13, weight: .regular))
+        return label
+    }()
     
     private lazy var optionsButton = MenuButton { [unowned self] in
         let imageName: String
@@ -70,17 +78,19 @@ class VideoControlsViewController: UIViewController {
         return UIMenu(children: [speedMenu])
     }
     
-    private lazy var hStack = UIStackView(arrangedSubviews: [
-        muteButton,
-        timestampLabel,
-        scrubbingControl,
-        timeRemainingLabel,
-        optionsButton,
-    ]).configure {
-        $0.axis = .horizontal
-        $0.spacing = 8
-        $0.alignment = .center
-    }
+    private lazy var hStack: UIStackView = {
+        let stack = UIStackView(arrangedSubviews: [
+            muteButton,
+            timestampLabel,
+            scrubbingControl,
+            timeRemainingLabel,
+            optionsButton,
+        ])
+        stack.axis = .horizontal
+        stack.spacing = 8
+        stack.alignment = .center
+        return stack
+    }()
 
     private var timestampObserverToken: Any?
     private var scrubberObserverToken: Any?

Packages/GalleryVC/Sources/GalleryVC/Content/VideoGalleryContentViewController.swift

@@ -1,68 +1,53 @@
 //
 //  VideoGalleryContentViewController.swift
-//  Tusker
+//  GalleryVC
 //
 //  Created by Shadowfacts on 3/19/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
 //
 
 import UIKit
-import GalleryVC
 import AVFoundation
 import CoreImage
 
-class VideoGalleryContentViewController: UIViewController, GalleryContentViewController {
-    private let url: URL
-    let caption: String?
-    private var item: AVPlayerItem
-    let player: AVPlayer
-    
-    private var isGrayscale: Bool
+open class VideoGalleryContentViewController: UIViewController, GalleryContentViewController {
+    public let url: URL
+    public let caption: String?
+    public private(set) var item: AVPlayerItem
+    public let player: AVPlayer
     
     private var presentationSizeObservation: NSKeyValueObservation?
     private var statusObservation: NSKeyValueObservation?
     private var rateObservation: NSKeyValueObservation?
-    private var isFirstAppearance = true
     private var hideControlsWorkItem: DispatchWorkItem?
-    private var audioSessionToken: AudioSessionCoordinator.Token?
+    private var isShowingError = false
     
-    init(url: URL, caption: String?) {
+    public init(url: URL, caption: String?) {
         self.url = url
         self.caption = caption
         
-        self.isGrayscale = Preferences.shared.grayscaleImages
-        
         let asset = AVAsset(url: url)
-        self.item = VideoGalleryContentViewController.createItem(asset: asset)
+        self.item = Self.createItem(asset: asset)
         self.player = AVPlayer(playerItem: item)
         
         super.init(nibName: nil, bundle: nil)
     }
     
-    required init?(coder: NSCoder) {
+    public required init?(coder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
     
-    private static func createItem(asset: AVAsset) -> AVPlayerItem {
-        let item = AVPlayerItem(asset: asset)
-        if Preferences.shared.grayscaleImages {
-            #if os(visionOS)
-            #warning("Use async AVVideoComposition CIFilter initializer")
-            #else
-            let filter = CIFilter(name: "CIColorMonochrome")!
-            filter.setValue(CIColor(red: 0.85, green: 0.85, blue: 0.85), forKey: "inputColor")
-            filter.setValue(1.0, forKey: "inputIntensity")
-
-            item.videoComposition = AVVideoComposition(asset: asset, applyingCIFiltersWithHandler: { request in
-                filter.setValue(request.sourceImage, forKey: "inputImage")
-                request.finish(with: filter.outputImage!, context: nil)
-            })
-            #endif
-        }
-        return item
+    open class func createItem(asset: AVAsset) -> AVPlayerItem {
+        return AVPlayerItem(asset: asset)
     }
     
-    override func viewDidLoad() {
+    public func replaceCurrentItem(with item: AVPlayerItem) {
+        self.item = item
+        player.replaceCurrentItem(with: item)
+        updateItemObservations()
+    }
+    
+    public override func viewDidLoad() {
         super.viewDidLoad()
         
         container?.setGalleryContentLoading(true)
@@ -87,19 +72,17 @@ class VideoGalleryContentViewController: UIViewController, GalleryContentViewCon
                 scheduleControlsHide()
             }
         })
-        
-        NotificationCenter.default.addObserver(self, selector: #selector(preferencesChanged), name: .preferencesChanged, object: nil)
     }
     
     private func updateItemObservations() {
         presentationSizeObservation = item.observe(\.presentationSize, changeHandler: { [unowned self] item, _ in
-            MainActor.runUnsafely {
+            MainActor.assumeIsolated {
                 self.preferredContentSize = item.presentationSize
                 self.container?.galleryContentChanged()
             }
         })
         statusObservation = item.observe(\.status, changeHandler: { [unowned self] item, _ in
-            MainActor.runUnsafely {
+            MainActor.assumeIsolated {
                 if item.status == .readyToPlay {
                     self.container?.setGalleryContentLoading(false)
                     self.statusObservation = nil
@@ -108,19 +91,22 @@ class VideoGalleryContentViewController: UIViewController, GalleryContentViewCon
                     self.container?.setGalleryContentLoading(false)
                     self.showErrorView(error)
                     self.statusObservation = nil
+                    self.overlayVC.setVisible(false)
                 }
             }
         })
     }
     
     private func showErrorView(_ error: any Error) {
+        isShowingError = true
+        
         let image = UIImageView(image: UIImage(systemName: "exclamationmark.triangle.fill")!)
         image.tintColor = .secondaryLabel
         image.contentMode = .scaleAspectFit
         
         let label = UILabel()
         label.text = "Error Loading"
-        label.font = .preferredFont(forTextStyle: .title1).withTraits(.traitBold)!
+        label.font = UIFont(descriptor: .preferredFontDescriptor(withTextStyle: .title1).withSymbolicTraits(.traitBold)!, size: 0)
         label.textColor = .secondaryLabel
         label.adjustsFontForContentSizeCategory = true
         
@@ -148,22 +134,9 @@ class VideoGalleryContentViewController: UIViewController, GalleryContentViewCon
         ])
     }
     
-    @objc private func preferencesChanged() {
-        if isGrayscale != Preferences.shared.grayscaleImages {
-            let isPlaying = player.rate > 0
-            isGrayscale = Preferences.shared.grayscaleImages
-            item = VideoGalleryContentViewController.createItem(asset: item.asset)
-            player.replaceCurrentItem(with: item)
-            updateItemObservations()
-            if isPlaying {
-                player.play()
-            }
-        }
-    }
-    
     private func scheduleControlsHide() {
         hideControlsWorkItem = DispatchWorkItem { [weak self] in
-            MainActor.runUnsafely {
+            MainActor.assumeIsolated {
                 guard let self,
                       let container = self.container,
                       container.galleryControlsVisible else {
@@ -177,25 +150,32 @@ class VideoGalleryContentViewController: UIViewController, GalleryContentViewCon
     
     // MARK: GalleryContentViewController
     
-    weak var container: (any GalleryVC.GalleryContentViewControllerContainer)?
+    public weak var container: (any GalleryVC.GalleryContentViewControllerContainer)?
     
-    var contentSize: CGSize {
+    public var contentSize: CGSize {
         item.presentationSize
     }
     
-    var activityItemsForSharing: [Any] {
-        [VideoActivityItemSource(asset: item.asset, url: url)]
+    open var activityItemsForSharing: [Any] {
+//        [VideoActivityItemSource(asset: item.asset, url: url)]
+        []
+    }
+    
+    public var presentationAnimation: GalleryContentPresentationAnimation {
+        isShowingError ? .fade : .fromSourceViewWithoutSnapshot
     }
     
     private lazy var overlayVC = VideoOverlayViewController(player: player)
-    var contentOverlayAccessoryViewController: UIViewController? {
+    public var contentOverlayAccessoryViewController: UIViewController? {
         overlayVC
     }
     
-    private(set) lazy var bottomControlsAccessoryViewController: UIViewController? = VideoControlsViewController(player: player)
+    public private(set) lazy var bottomControlsAccessoryViewController: UIViewController? = VideoControlsViewController(player: player)
     
-    func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
-        overlayVC.setVisible(visible)
+    public func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
+        if !isShowingError {
+            overlayVC.setVisible(visible)
+        }
         
         if !visible {
             hideControlsWorkItem?.cancel()
@@ -205,25 +185,11 @@ class VideoGalleryContentViewController: UIViewController, GalleryContentViewCon
         }
     }
     
-    func galleryContentDidAppear() {
-        let wasFirstAppearance = isFirstAppearance
-        isFirstAppearance = false
-        
-        audioSessionToken = AudioSessionCoordinator.shared.beginPlayback(mode: .video) {
-            if wasFirstAppearance {
-                DispatchQueue.main.async {
-                    self.player.play()
-                }
-            }
-        }
+    open func galleryContentDidAppear() {
     }
     
-    func galleryContentWillDisappear() {
+    open func galleryContentWillDisappear() {
         player.pause()
-        
-        if let audioSessionToken {
-            AudioSessionCoordinator.shared.endPlayback(token: audioSessionToken)
-        }
     }
     
 }
@@ -252,9 +218,9 @@ private class PlayerView: UIView {
         playerLayer.player = player
         playerLayer.videoGravity = .resizeAspect
         
-        presentationSizeObservation = item.observe(\.presentationSize, changeHandler: { [unowned self] _, _ in
-            MainActor.runUnsafely {
-                self.invalidateIntrinsicContentSize()
+        presentationSizeObservation = item.observe(\.presentationSize, changeHandler: { [weak self] _, _ in
+            MainActor.assumeIsolated {
+                self?.invalidateIntrinsicContentSize()
             }
         })
     }

Packages/GalleryVC/Sources/GalleryVC/Content/VideoOverlayViewController.swift

@@ -1,6 +1,6 @@
 //
 //  VideoOverlayViewController.swift
-//  Tusker
+//  GalleryVC
 //
 //  Created by Shadowfacts on 3/26/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
@@ -79,7 +79,7 @@ class VideoOverlayViewController: UIViewController {
         ])
         
         rateObservation = player.observe(\.rate, changeHandler: { player, _ in
-            MainActor.runUnsafely {
+            MainActor.assumeIsolated {
                 playPauseButton.image = player.rate > 0 ? VideoOverlayViewController.pauseImage : VideoOverlayViewController.playImage
             }
         })

Packages/GalleryVC/Sources/GalleryVC/GalleryContentViewController.swift

@@ -15,7 +15,7 @@ public protocol GalleryContentViewController: UIViewController {
     var caption: String? { get }
     var contentOverlayAccessoryViewController: UIViewController? { get }
     var bottomControlsAccessoryViewController: UIViewController? { get }
-    var canAnimateFromSourceView: Bool { get }
+    var presentationAnimation: GalleryContentPresentationAnimation { get }
     
     func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool)
     func galleryContentDidAppear()
@@ -31,8 +31,8 @@ public extension GalleryContentViewController {
         nil
     }
     
-    var canAnimateFromSourceView: Bool {
-        true
+    var presentationAnimation: GalleryContentPresentationAnimation {
+        .fromSourceView
     }
     
     func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
@@ -44,3 +44,9 @@ public extension GalleryContentViewController {
     func galleryContentWillDisappear() {
     }
 }
+
+public enum GalleryContentPresentationAnimation {
+    case fade
+    case fromSourceView
+    case fromSourceViewWithoutSnapshot
+}

Packages/GalleryVC/Sources/GalleryVC/GalleryDismissAnimationController.swift

@@ -30,12 +30,37 @@ class GalleryDismissAnimationController: NSObject, UIViewControllerAnimatedTrans
         
         let itemViewController = from.currentItemViewController
         
-        if !itemViewController.content.canAnimateFromSourceView || (UIAccessibility.prefersCrossFadeTransitions && interactiveVelocity == nil) {
+        if itemViewController.content.presentationAnimation == .fade || (UIAccessibility.prefersCrossFadeTransitions && interactiveVelocity == nil) {
             animateCrossFadeTransition(using: transitionContext)
             return
         }
         
         let container = transitionContext.containerView
+
+        // Moving `to.view` to the container is necessary when the presenting VC (i.e., `to`)
+        // is in the window's root presentation.
+        // But it breaks when the gallery is presented from a sheet-presented VC--in which case
+        // `to.view` is already in the view hierarchy at this point; and adding it to the
+        // container causees it to be removed when the transition completes.
+        if to.view.superview == nil {
+            to.view.frame = container.bounds
+            container.addSubview(to.view)
+        }
+        
+        let sourceSnapshot: UIView? = if itemViewController.content.presentationAnimation == .fromSourceViewWithoutSnapshot {
+            nil
+        } else {
+            sourceView.snapshotView(afterScreenUpdates: false)
+        }
+        if let sourceSnapshot {
+            let snapshotContainer = sourceView.ancestorForInsertingSnapshot
+            snapshotContainer.addSubview(sourceSnapshot)
+            let sourceFrameInShapshotContainer = snapshotContainer.convert(sourceView.bounds, from: sourceView)
+            sourceSnapshot.frame = sourceFrameInShapshotContainer
+            sourceSnapshot.layer.opacity = 1
+            self.sourceView.layer.opacity = 0
+        }
+
         let sourceFrameInContainer = container.convert(sourceView.bounds, from: sourceView)
         let destFrameInContainer = container.convert(itemViewController.content.view.bounds, from: itemViewController.content.view)
         
@@ -48,38 +73,39 @@ class GalleryDismissAnimationController: NSObject, UIViewControllerAnimatedTrans
                 .translatedBy(x: destFrameInContainer.midX - sourceFrameInContainer.midX, y: destFrameInContainer.midY - sourceFrameInContainer.midY)
                 .scaledBy(x: scale, y: scale)
             sourceView.transform = sourceToDestTransform
+            sourceSnapshot?.transform = sourceToDestTransform
         } else {
             appliedSourceToDestTransform = false
         }
         
-        // Moving `to.view` to the container is necessary when the presenting VC (i.e., `to`)
-        // is in the window's root presentation.
-        // But it breaks when the gallery is presented from a sheet-presented VC--in which case
-        // `to.view` is already in the view hierarchy at this point; and adding it to the
-        // container causees it to be removed when the transition completes.
-        if to.view.superview == nil {
-            to.view.frame = container.bounds
-            container.addSubview(to.view)
-        }
-        
         from.view.frame = container.bounds
         container.addSubview(from.view)
-
+        
+        let contentContainer = UIView()
+        contentContainer.layer.masksToBounds = true
+        contentContainer.frame = destFrameInContainer
+        container.addSubview(contentContainer)
+        
         let content = itemViewController.takeContent()
         content.view.translatesAutoresizingMaskIntoConstraints = true
-        content.view.layer.masksToBounds = true
-        container.addSubview(content.view)
-        
-        content.view.frame = destFrameInContainer
+        content.view.transform = .identity
         content.view.layer.opacity = 1
-        
+        content.view.frame = contentContainer.bounds
+        contentContainer.addSubview(content.view)
+
         container.layoutIfNeeded()
         
+        // Hide overlaid controls immediately, to prevent the Live Text button's position
+        // getting caught up in the rest of the animation.
+        UIView.animate(withDuration: 0.1) {
+            content.setControlsVisible(false, animated: false, dueToUserInteraction: false)
+        }
+        
         let duration = self.transitionDuration(using: transitionContext)
         var initialVelocity: CGVector
         if let interactiveVelocity,
            let interactiveTranslation,
-           // very short/fast flicks don't transfer their velocity, since it makes size change animation look wacky due to the springs initial undershoot
+           // very short/fast flicks don't transfer their velocity, since it makes size change animation look wacky due to the spring's initial undershoot
            sqrt(pow(interactiveTranslation.x, 2) + pow(interactiveTranslation.y, 2)) > 100,
            sqrt(pow(interactiveVelocity.x, 2) + pow(interactiveVelocity.y, 2)) < 2000 {
             let xDistance = sourceFrameInContainer.midX - destFrameInContainer.midX
@@ -102,14 +128,34 @@ class GalleryDismissAnimationController: NSObject, UIViewControllerAnimatedTrans
             
             if appliedSourceToDestTransform {
                 self.sourceView.transform = origSourceTransform
+                sourceSnapshot?.transform = origSourceTransform
             }
-            content.view.frame = sourceFrameInContainer
-            content.view.layer.opacity = 0
+            
+            contentContainer.frame = sourceFrameInContainer
+            // Using sourceSizeWithDestAspectRatioCenteredInContentContainer does not seem to be necessary here.
+            // I guess autoresizing takes care of it?
             
             itemViewController.setControlsVisible(false, animated: false, dueToUserInteraction: false)
         }
         
+        // Delay fading out the content because if it's still big while it's semi-transparent,
+        // seeing the stuff behind it looks odd.
+        animator.addAnimations({
+            content.view.layer.opacity = 0
+        }, delayFactor: 0.35)
+        
+        if let sourceSnapshot {
+            animator.addAnimations({
+                self.sourceView.layer.opacity = 1
+                sourceSnapshot.layer.opacity = 0
+            }, delayFactor: 0.5)
+        }
+        
         animator.addCompletion { _ in
+            sourceSnapshot?.removeFromSuperview()
+            
+            // Having dismissed, we don't need to undo any of the changes to the content VC.
+            
             transitionContext.completeTransition(true)
         }
         

Packages/GalleryVC/Sources/GalleryVC/GalleryDismissInteraction.swift

@@ -20,6 +20,8 @@ class GalleryDismissInteraction: NSObject {
     private(set) var dismissVelocity: CGPoint?
     private(set) var dismissTranslation: CGPoint?
     
+    private var cancelAnimator: UIViewPropertyAnimator?
+    
     init(viewController: GalleryViewController) {
         self.viewController = viewController
         super.init()
@@ -38,6 +40,8 @@ class GalleryDismissInteraction: NSObject {
             content = viewController.currentItemViewController.takeContent()
             content!.view.translatesAutoresizingMaskIntoConstraints = true
             content!.view.frame = origContentFrameInGallery!
+            // Make sure the context remains behind the controls
+            content!.view.layer.zPosition = -1000
             viewController.view.addSubview(content!.view)
             
             origControlsVisible = viewController.currentItemViewController.controlsVisible
@@ -53,12 +57,42 @@ class GalleryDismissInteraction: NSObject {
             let translation = recognizer.translation(in: viewController.view)
             let velocity = recognizer.velocity(in: viewController.view)
             
-            dismissVelocity = velocity
-            dismissTranslation = translation
-            viewController.dismiss(animated: true)
+            let translationMagnitude = sqrt(translation.x.magnitudeSquared + translation.y.magnitudeSquared)
+            let velocityMagnitude = sqrt(velocity.x.magnitudeSquared + velocity.y.magnitudeSquared)
+            
+            if translationMagnitude < 150 && velocityMagnitude < 500 {
+                isActive = false
+                
+                cancelAnimator?.stopAnimation(true)
+                
+                let spring = UISpringTimingParameters(mass: 1, stiffness: 439, damping: 42, initialVelocity: .zero)
+                cancelAnimator = UIViewPropertyAnimator(duration: 0.2, timingParameters: spring)
+                cancelAnimator!.addAnimations {
+                    self.content!.view.frame = self.origContentFrameInGallery!
+                    self.viewController.currentItemViewController.setControlsVisible(self.origControlsVisible!, animated: false, dueToUserInteraction: false)
+                }
+                cancelAnimator!.addCompletion { _ in
+                    guard !self.isActive else {
+                        // bail in case the animation finishing raced with the user's interaction
+                        return
+                    }
+                    self.content!.view.layer.zPosition = 0
+                    self.content!.view.removeFromSuperview()
+                    self.viewController.currentItemViewController.addContent()
+                    self.content = nil
+                    self.origContentFrameInGallery = nil
+                    self.origControlsVisible = nil
+                }
+                cancelAnimator!.startAnimation()
 
-            // don't unset this until after dismiss is called, so that the dismiss animation controller can read it
-            isActive = false
+            } else {
+                dismissVelocity = velocity
+                dismissTranslation = translation
+                viewController.dismiss(animated: true)
+                
+                // don't unset this until after dismiss is called, so that the dismiss animation controller can read it
+                isActive = false
+            }
             
         default:
             break

Packages/GalleryVC/Sources/GalleryVC/GalleryItemViewController.swift

@@ -69,6 +69,10 @@ class GalleryItemViewController: UIViewController {
         scrollView = UIScrollView()
         scrollView.translatesAutoresizingMaskIntoConstraints = false
         scrollView.delegate = self
+        // We calculate zoom/position ignoring the safe area, so content insets need to not incorporate it either.
+        // Otherwise, content that fills the screen (extending into the safe area) may still end up scrollable
+        // (this is readily observable with tall images on a landscape iPad).
+        scrollView.contentInsetAdjustmentBehavior = .never
         
         view.addSubview(scrollView)
         

Packages/GalleryVC/Sources/GalleryVC/GalleryPresentationAnimationController.swift

@@ -25,11 +25,31 @@ class GalleryPresentationAnimationController: NSObject, UIViewControllerAnimated
         
         let itemViewController = to.currentItemViewController
 
-        if !itemViewController.content.canAnimateFromSourceView || UIAccessibility.prefersCrossFadeTransitions {
+        if itemViewController.content.presentationAnimation == .fade || UIAccessibility.prefersCrossFadeTransitions {
             animateCrossFadeTransition(using: transitionContext)
             return
         }
         
+        // Try to effectively "fade out" anything that's on top of the source view.
+        // The 0.1 duration makes this happen faster than the rest of the animation,
+        // and so less noticeable.
+        let sourceSnapshot: UIView? = if itemViewController.content.presentationAnimation == .fromSourceViewWithoutSnapshot {
+            nil
+        } else {
+            sourceView.snapshotView(afterScreenUpdates: false)
+        }
+        if let sourceSnapshot {
+            let snapshotContainer = sourceView.ancestorForInsertingSnapshot
+            snapshotContainer.addSubview(sourceSnapshot)
+            let sourceFrameInShapshotContainer = snapshotContainer.convert(sourceView.bounds, from: sourceView)
+            sourceSnapshot.frame = sourceFrameInShapshotContainer
+            sourceSnapshot.transform = sourceView.transform
+            sourceSnapshot.layer.opacity = 0
+            UIView.animate(withDuration: 0.1) {
+                sourceSnapshot.layer.opacity = 1
+            }
+        }
+        
         let container = transitionContext.containerView
         to.view.frame = container.bounds
         container.addSubview(to.view)
@@ -56,21 +76,70 @@ class GalleryPresentationAnimationController: NSObject, UIViewControllerAnimated
             sourceToDestTransform = nil
         }
         
+        // Grab these before taking the content out and changing the transform.
+        let origContentTransform = itemViewController.content.view.transform
+        let origContentFrame = itemViewController.content.view.frame
+        
+        // The content container provides the clipping for the content view,
+        // which, in case the source/dest aspect ratios don't match, makes
+        // it look like the content is expanding out from the source rect.
+        let contentContainer = UIView()
+        contentContainer.layer.masksToBounds = true
+        container.insertSubview(contentContainer, belowSubview: to.view)
         let content = itemViewController.takeContent()
         content.view.translatesAutoresizingMaskIntoConstraints = true
-        container.insertSubview(content.view, belowSubview: to.view)
+        content.view.transform = .identity
+        // The fade-in makes the aspect ratio handling look a little bit worse,
+        // but papers over the z-index change and potential corner radius change.
+        content.view.layer.opacity = 0
+        contentContainer.addSubview(content.view)
 
         // Use a separate dimming view from to.view, so that the gallery controls can be in front of the moving content.
         let dimmingView = UIView()
         dimmingView.backgroundColor = .black
         dimmingView.frame = container.bounds
         dimmingView.layer.opacity = 0
-        container.insertSubview(dimmingView, belowSubview: content.view)
+        container.insertSubview(dimmingView, belowSubview: contentContainer)
 
         to.view.backgroundColor = nil
         to.view.layer.opacity = 0
-        content.view.frame = sourceFrameInContainer
-        content.view.layer.opacity = 0
+        
+        contentContainer.frame = sourceFrameInContainer
+        
+        let sourceAspectRatio: CGFloat = if sourceFrameInContainer.height > 0 {
+            sourceFrameInContainer.width / sourceFrameInContainer.height
+        } else {
+            0
+        }
+        let destAspectRatio: CGFloat = if destFrameInContainer.height > 0 {
+            destFrameInContainer.width / destFrameInContainer.height
+        } else {
+            0
+        }
+        let sourceSizeWithDestAspectRatioCenteredInContentContainer: CGRect
+        if 0.001 < abs(sourceAspectRatio - destAspectRatio) {
+            // asepct ratios are effectively equal
+            sourceSizeWithDestAspectRatioCenteredInContentContainer = CGRect(origin: .zero, size: sourceFrameInContainer.size)
+        } else if sourceAspectRatio < destAspectRatio {
+            // source aspect ratio is narrow/taller than dest
+            let width = sourceFrameInContainer.height * destAspectRatio
+            sourceSizeWithDestAspectRatioCenteredInContentContainer = CGRect(
+                x: -(width - sourceFrameInContainer.width) / 2,
+                y: 0,
+                width: width,
+                height: sourceFrameInContainer.height
+            )
+        } else {
+            // source aspect ratio is wider/shorter than dest
+            let height = sourceFrameInContainer.width / destAspectRatio
+            sourceSizeWithDestAspectRatioCenteredInContentContainer = CGRect(
+                x: 0,
+                y: -(height - sourceFrameInContainer.height) / 2,
+                width: sourceFrameInContainer.width,
+                height: height
+            )
+        }
+        content.view.frame = sourceSizeWithDestAspectRatioCenteredInContentContainer
         
         container.layoutIfNeeded()
         
@@ -78,8 +147,14 @@ class GalleryPresentationAnimationController: NSObject, UIViewControllerAnimated
         itemViewController.setControlsVisible(false, animated: false, dueToUserInteraction: false)
 
         let duration = self.transitionDuration(using: transitionContext)
-        // rougly equivalent to duration: 0.35, bounce: 0.3
-        let spring = UISpringTimingParameters(mass: 1, stiffness: 322, damping: 25, initialVelocity: .zero)
+        // less bounce on bigger screens
+        let spring = if UIDevice.current.userInterfaceIdiom == .pad {
+            // roughly equivalent to duration: 0.35, bounce: 0.2
+            UISpringTimingParameters(mass: 1, stiffness: 322, damping: 28, initialVelocity: .zero)
+        } else {
+            // roughly equivalent to duration: 0.35, bounce: 0.3
+            UISpringTimingParameters(mass: 1, stiffness: 322, damping: 25, initialVelocity: .zero)
+        }
         let animator = UIViewPropertyAnimator(duration: duration, timingParameters: spring)
         
         animator.addAnimations {
@@ -87,25 +162,35 @@ class GalleryPresentationAnimationController: NSObject, UIViewControllerAnimated
             
             to.view.layer.opacity = 1
             
-            content.view.frame = destFrameInContainer
+            contentContainer.frame = destFrameInContainer
+            content.view.frame = contentContainer.bounds
             content.view.layer.opacity = 1
-            
+
             itemViewController.setControlsVisible(true, animated: false, dueToUserInteraction: false)
 
             if let sourceToDestTransform {
+                sourceSnapshot?.transform = sourceToDestTransform
                 self.sourceView.transform = sourceToDestTransform
             }
         }
         
         animator.addCompletion { _ in
+            sourceSnapshot?.removeFromSuperview()
+            self.sourceView.layer.opacity = 1
+            if sourceToDestTransform != nil {
+                self.sourceView.transform = origSourceTransform
+            }
+
+            contentContainer.removeFromSuperview()
             dimmingView.removeFromSuperview()
             
             to.view.backgroundColor = .black
             
-            if sourceToDestTransform != nil {
-                self.sourceView.transform = origSourceTransform
-            }
-            
+            // Reset the properties we changed before re-adding the content to the scroll view.
+            // (I would expect UIScrollView to effectively do this itself, but w/e.)
+            content.view.transform = origContentTransform
+            content.view.frame = origContentFrame
+
             itemViewController.addContent()
             
             transitionContext.completeTransition(true)

Packages/GalleryVC/Sources/GalleryVC/UIView+Utilities.swift

@@ -0,0 +1,26 @@
+//
+//  UIView+Utilities.swift
+//  GalleryVC
+//
+//  Created by Shadowfacts on 11/24/24.
+//
+
+import UIKit
+
+extension UIView {
+    
+    var ancestorForInsertingSnapshot: UIView {
+        var view = self
+        while let superview = view.superview {
+            if superview.layer.masksToBounds {
+                return superview
+            } else if superview is UIScrollView {
+                return self
+            } else {
+                view = superview
+            }
+        }
+        return view
+    }
+    
+}

Packages/Pachyderm/Sources/Pachyderm/Model/Emoji.swift

@@ -22,7 +22,12 @@ public struct Emoji: Codable, Sendable {
         let container = try decoder.container(keyedBy: CodingKeys.self)
         
         self.shortcode = try container.decode(String.self, forKey: .shortcode)
-        self.url = try container.decode(WebURL.self, forKey: .url)
+        do {
+            self.url = try container.decode(WebURL.self, forKey: .url)
+        } catch {
+            let s = try? container.decode(String.self, forKey: .url)
+            throw DecodingError.dataCorrupted(.init(codingPath: container.codingPath + [CodingKeys.url], debugDescription: "Could not decode URL '\(s ?? "<failed to decode string>")'", underlyingError: error))
+        }
         self.staticURL = try container.decode(WebURL.self, forKey: .staticURL)
         self.visibleInPicker = try container.decode(Bool.self, forKey: .visibleInPicker)
         self.category = try container.decodeIfPresent(String.self, forKey: .category)

Tusker.xcodeproj/project.pbxproj

@@ -203,20 +203,16 @@
 		D691771729A710520054D7EF /* ProfileNoContentCollectionViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = D691771629A710520054D7EF /* ProfileNoContentCollectionViewCell.swift */; };
 		D691771929A7B8820054D7EF /* ProfileHeaderMovedOverlayView.swift in Sources */ = {isa = PBXBuildFile; fileRef = D691771829A7B8820054D7EF /* ProfileHeaderMovedOverlayView.swift */; };
 		D691772E29AA5D420054D7EF /* UserActivityHandlingContext.swift in Sources */ = {isa = PBXBuildFile; fileRef = D691772D29AA5D420054D7EF /* UserActivityHandlingContext.swift */; };
-		D69261232BB3AEFB0023152C /* VideoOverlayViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D69261222BB3AEFB0023152C /* VideoOverlayViewController.swift */; };
 		D69261272BB3BA610023152C /* Box.swift in Sources */ = {isa = PBXBuildFile; fileRef = D69261262BB3BA610023152C /* Box.swift */; };
 		D6934F2C2BA7AD32002B1C8D /* GalleryVC in Frameworks */ = {isa = PBXBuildFile; productRef = D6934F2B2BA7AD32002B1C8D /* GalleryVC */; };
 		D6934F2E2BA7AEF9002B1C8D /* StatusAttachmentsGalleryDataSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F2D2BA7AEF9002B1C8D /* StatusAttachmentsGalleryDataSource.swift */; };
-		D6934F302BA7AF91002B1C8D /* ImageGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F2F2BA7AF91002B1C8D /* ImageGalleryContentViewController.swift */; };
-		D6934F322BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F312BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift */; };
+		D6934F302BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F2F2BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift */; };
 		D6934F342BA8D65A002B1C8D /* ImageGalleryDataSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F332BA8D65A002B1C8D /* ImageGalleryDataSource.swift */; };
 		D6934F362BA8E020002B1C8D /* GifvGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F352BA8E020002B1C8D /* GifvGalleryContentViewController.swift */; };
 		D6934F382BA8E2B7002B1C8D /* GifvController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F372BA8E2B7002B1C8D /* GifvController.swift */; };
-		D6934F3A2BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F392BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift */; };
-		D6934F3C2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F3B2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift */; };
+		D6934F3C2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F3B2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift */; };
 		D6934F3E2BAA19D5002B1C8D /* ImageActivityItemSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F3D2BAA19D5002B1C8D /* ImageActivityItemSource.swift */; };
 		D6934F402BAA19EC002B1C8D /* VideoActivityItemSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F3F2BAA19EC002B1C8D /* VideoActivityItemSource.swift */; };
-		D6934F422BAC7D6E002B1C8D /* VideoControlsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F412BAC7D6E002B1C8D /* VideoControlsViewController.swift */; };
 		D693A72825CF282E003A14E2 /* TrendingHashtagsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D693A72725CF282E003A14E2 /* TrendingHashtagsViewController.swift */; };
 		D693DE5723FE1A6A0061E07D /* EnhancedNavigationViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D693DE5623FE1A6A0061E07D /* EnhancedNavigationViewController.swift */; };
 		D693DE5923FE24310061E07D /* InteractivePushTransition.swift in Sources */ = {isa = PBXBuildFile; fileRef = D693DE5823FE24300061E07D /* InteractivePushTransition.swift */; };
@@ -637,19 +633,15 @@
 		D691771629A710520054D7EF /* ProfileNoContentCollectionViewCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ProfileNoContentCollectionViewCell.swift; sourceTree = "<group>"; };
 		D691771829A7B8820054D7EF /* ProfileHeaderMovedOverlayView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ProfileHeaderMovedOverlayView.swift; sourceTree = "<group>"; };
 		D691772D29AA5D420054D7EF /* UserActivityHandlingContext.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UserActivityHandlingContext.swift; sourceTree = "<group>"; };
-		D69261222BB3AEFB0023152C /* VideoOverlayViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VideoOverlayViewController.swift; sourceTree = "<group>"; };
 		D69261262BB3BA610023152C /* Box.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Box.swift; sourceTree = "<group>"; };
 		D6934F2D2BA7AEF9002B1C8D /* StatusAttachmentsGalleryDataSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StatusAttachmentsGalleryDataSource.swift; sourceTree = "<group>"; };
-		D6934F2F2BA7AF91002B1C8D /* ImageGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageGalleryContentViewController.swift; sourceTree = "<group>"; };
-		D6934F312BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LoadingGalleryContentViewController.swift; sourceTree = "<group>"; };
+		D6934F2F2BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GrayscalableImageGalleryContentViewController.swift; sourceTree = "<group>"; };
 		D6934F332BA8D65A002B1C8D /* ImageGalleryDataSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageGalleryDataSource.swift; sourceTree = "<group>"; };
 		D6934F352BA8E020002B1C8D /* GifvGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GifvGalleryContentViewController.swift; sourceTree = "<group>"; };
 		D6934F372BA8E2B7002B1C8D /* GifvController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GifvController.swift; sourceTree = "<group>"; };
-		D6934F392BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FallbackGalleryContentViewController.swift; sourceTree = "<group>"; };
-		D6934F3B2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VideoGalleryContentViewController.swift; sourceTree = "<group>"; };
+		D6934F3B2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GrayscalableVideoGalleryContentViewController.swift; sourceTree = "<group>"; };
 		D6934F3D2BAA19D5002B1C8D /* ImageActivityItemSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageActivityItemSource.swift; sourceTree = "<group>"; };
 		D6934F3F2BAA19EC002B1C8D /* VideoActivityItemSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VideoActivityItemSource.swift; sourceTree = "<group>"; };
-		D6934F412BAC7D6E002B1C8D /* VideoControlsViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VideoControlsViewController.swift; sourceTree = "<group>"; };
 		D693A72725CF282E003A14E2 /* TrendingHashtagsViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TrendingHashtagsViewController.swift; sourceTree = "<group>"; };
 		D693DE5623FE1A6A0061E07D /* EnhancedNavigationViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EnhancedNavigationViewController.swift; sourceTree = "<group>"; };
 		D693DE5823FE24300061E07D /* InteractivePushTransition.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = InteractivePushTransition.swift; sourceTree = "<group>"; };
@@ -899,13 +891,9 @@
 			children = (
 				D6934F2D2BA7AEF9002B1C8D /* StatusAttachmentsGalleryDataSource.swift */,
 				D6934F332BA8D65A002B1C8D /* ImageGalleryDataSource.swift */,
-				D6934F312BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift */,
-				D6934F2F2BA7AF91002B1C8D /* ImageGalleryContentViewController.swift */,
+				D6934F2F2BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift */,
 				D6934F352BA8E020002B1C8D /* GifvGalleryContentViewController.swift */,
-				D6934F3B2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift */,
-				D69261222BB3AEFB0023152C /* VideoOverlayViewController.swift */,
-				D6934F412BAC7D6E002B1C8D /* VideoControlsViewController.swift */,
-				D6934F392BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift */,
+				D6934F3B2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift */,
 			);
 			path = Gallery;
 			sourceTree = "<group>";
@@ -2122,7 +2110,6 @@
 			isa = PBXSourcesBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
-				D6934F422BAC7D6E002B1C8D /* VideoControlsViewController.swift in Sources */,
 				0427033A22B31269000D31B6 /* AdvancedPrefsView.swift in Sources */,
 				D6C3F4F5298ED0890009FCFF /* LocalPredicateStatusesViewController.swift in Sources */,
 				D691771729A710520054D7EF /* ProfileNoContentCollectionViewCell.swift in Sources */,
@@ -2169,8 +2156,7 @@
 				D6A4DCCC2553667800D9DE31 /* FastAccountSwitcherViewController.swift in Sources */,
 				D627944F23A9C99800D38C68 /* EditListAccountsViewController.swift in Sources */,
 				D6945C3423AC6431005C403C /* AddSavedHashtagViewController.swift in Sources */,
-				D69261232BB3AEFB0023152C /* VideoOverlayViewController.swift in Sources */,
-				D6934F3C2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift in Sources */,
+				D6934F3C2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift in Sources */,
 				D6F6A552291F098700F496A8 /* RenameListService.swift in Sources */,
 				D62D2426217ABF63005076CC /* UserActivityType.swift in Sources */,
 				D698F46B2BD079F00054DB14 /* AnnouncementListRow.swift in Sources */,
@@ -2190,7 +2176,6 @@
 				D6D94955298963A900C59229 /* Colors.swift in Sources */,
 				D6945C3823AC739F005C403C /* InstanceTimelineViewController.swift in Sources */,
 				D625E4822588262A0074BB2B /* DraggableTableViewCell.swift in Sources */,
-				D6934F322BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift in Sources */,
 				D68E525B24A3D77E0054355A /* TuskerRootViewController.swift in Sources */,
 				D62D2422217AA7E1005076CC /* UserActivityManager.swift in Sources */,
 				D64A50482C739DEA009D7193 /* BaseMainTabBarViewController.swift in Sources */,
@@ -2218,7 +2203,6 @@
 				D630C3CC2BC5FD4600208903 /* GetAuthorizationTokenService.swift in Sources */,
 				D61DC84B28F4FD2000B82C6E /* ProfileHeaderCollectionViewCell.swift in Sources */,
 				D61A45E828DF477D002BE511 /* LoadingCollectionViewCell.swift in Sources */,
-				D6934F3A2BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift in Sources */,
 				D67B506D250B291200FAECFB /* BlurHashDecode.swift in Sources */,
 				D68A76EC295369A8001DA1B3 /* AboutView.swift in Sources */,
 				04DACE8E212CC7CC009840C4 /* ImageCache.swift in Sources */,
@@ -2341,7 +2325,7 @@
 				D61A45EA28DF51EE002BE511 /* TimelineLikeCollectionViewController.swift in Sources */,
 				D64D0AB12128D9AE005A6F37 /* OnboardingViewController.swift in Sources */,
 				D64A50BE2C752247009D7193 /* AdaptableNavigationController.swift in Sources */,
-				D6934F302BA7AF91002B1C8D /* ImageGalleryContentViewController.swift in Sources */,
+				D6934F302BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift in Sources */,
 				D6934F3E2BAA19D5002B1C8D /* ImageActivityItemSource.swift in Sources */,
 				D67C1795266D57D10070F250 /* FastAccountSwitcherIndicatorView.swift in Sources */,
 				D61F75962937037800C0B37F /* ToggleFollowHashtagService.swift in Sources */,

Tusker/CoreData/MastodonCachePersistentStore.swift

@@ -375,13 +375,14 @@ class MastodonCachePersistentStore: NSPersistentCloudKitContainer, @unchecked Se
         }
     }
 
-    func addAll(notifications: [Pachyderm.Notification], completion: (() -> Void)? = nil) {
-        backgroundContext.perform {
+    func addAll(notifications: [Pachyderm.Notification], in context: NSManagedObjectContext? = nil, completion: (() -> Void)? = nil) {
+        let context = context ?? backgroundContext
+        context.perform {
             let statuses = notifications.compactMap { $0.status }
             let accounts = notifications.map { $0.account }
-            statuses.forEach { self.upsert(status: $0, context: self.backgroundContext) }
-            accounts.forEach { self.upsert(account: $0, in: self.backgroundContext) }
-            self.save(context: self.backgroundContext)
+            statuses.forEach { self.upsert(status: $0, context: context) }
+            accounts.forEach { self.upsert(account: $0, in: context) }
+            self.save(context: context)
             completion?()
             statuses.forEach { self.statusSubject.send($0.id) }
             accounts.forEach { self.accountSubject.send($0.id) }

Tusker/Screens/Gallery/GifvGalleryContentViewController.swift

@@ -69,4 +69,8 @@ class GifvGalleryContentViewController: UIViewController, GalleryContentViewCont
         [VideoActivityItemSource(asset: controller.item.asset, url: url)]
     }
     
+    var presentationAnimation: GalleryContentPresentationAnimation {
+        .fromSourceViewWithoutSnapshot
+    }
+    
 }

Tusker/Screens/Gallery/GrayscalableImageGalleryContentViewController.swift

@@ -0,0 +1,60 @@
+//
+//  GrayscalableImageGalleryContentViewController.swift
+//  Tusker
+//
+//  Created by Shadowfacts on 11/21/24.
+//  Copyright © 2024 Shadowfacts. All rights reserved.
+//
+
+import UIKit
+import TuskerComponents
+import GalleryVC
+
+class GrayscalableImageGalleryContentViewController: GalleryVC.ImageGalleryContentViewController {
+    private let url: URL
+    private let originalImage: UIImage
+    private let originalData: Data?
+    private var isGrayscale = false
+    
+    init(url: URL, caption: String?, originalData: Data?, image: UIImage, gifController: GIFController?) {
+        self.url = url
+        self.originalImage = image
+        self.originalData = originalData
+        
+        super.init(image: image, caption: caption, gifController: gifController)
+        
+        isGrayscale = Preferences.shared.grayscaleImages
+        if isGrayscale {
+            self.image = ImageGrayscalifier.convert(url: url, image: image) ?? image
+        }
+        
+        NotificationCenter.default.addObserver(self, selector: #selector(preferencesChanged), name: .preferencesChanged, object: nil)
+    }
+    
+    @MainActor required init?(coder: NSCoder) {
+        fatalError("init(coder:) has not been implemented")
+    }
+    
+    @objc private func preferencesChanged() {
+        if isGrayscale != Preferences.shared.grayscaleImages {
+            isGrayscale = Preferences.shared.grayscaleImages
+            let image = if isGrayscale {
+                ImageGrayscalifier.convert(url: url, image: originalImage)
+            } else {
+                originalImage
+            }
+            if let image {
+                self.image = image
+            }
+        }
+    }
+    
+    override var activityItemsForSharing: [Any] {
+        if let data = originalData ?? image.pngData() {
+            return [ImageActivityItemSource(data: data, url: url, image: image)]
+        } else {
+            return []
+        }
+    }
+    
+}

Tusker/Screens/Gallery/GrayscalableVideoGalleryContentViewController.swift

@@ -0,0 +1,83 @@
+//
+//  GrayscalableVideoGalleryContentViewController.swift
+//  Tusker
+//
+//  Created by Shadowfacts on 11/21/24.
+//  Copyright © 2024 Shadowfacts. All rights reserved.
+//
+
+import UIKit
+import GalleryVC
+import AVFoundation
+
+class GrayscalableVideoGalleryContentViewController: GalleryVC.VideoGalleryContentViewController {
+    private var audioSessionToken: AudioSessionCoordinator.Token?
+    private var isGrayscale: Bool
+    private var isFirstAppearance = true
+
+    override init(url: URL, caption: String?) {
+        self.isGrayscale = Preferences.shared.grayscaleImages
+        
+        super.init(url: url, caption: caption)
+        
+        NotificationCenter.default.addObserver(self, selector: #selector(preferencesChanged), name: .preferencesChanged, object: nil)
+    }
+    
+    @MainActor required init?(coder: NSCoder) {
+        fatalError("init(coder:) has not been implemented")
+    }
+    
+    override class func createItem(asset: AVAsset) -> AVPlayerItem {
+        let item = AVPlayerItem(asset: asset)
+        if Preferences.shared.grayscaleImages {
+            #if os(visionOS)
+            #warning("Use async AVVideoComposition CIFilter initializer")
+            #else
+            let filter = CIFilter(name: "CIColorMonochrome")!
+            filter.setValue(CIColor(red: 0.85, green: 0.85, blue: 0.85), forKey: "inputColor")
+            filter.setValue(1.0, forKey: "inputIntensity")
+            
+            item.videoComposition = AVVideoComposition(asset: asset, applyingCIFiltersWithHandler: { request in
+                filter.setValue(request.sourceImage, forKey: "inputImage")
+                request.finish(with: filter.outputImage!, context: nil)
+            })
+            #endif
+        }
+        return item
+    }
+    
+    @objc private func preferencesChanged() {
+        if isGrayscale != Preferences.shared.grayscaleImages {
+            let isPlaying = player.rate > 0
+            isGrayscale = Preferences.shared.grayscaleImages
+            replaceCurrentItem(with: Self.createItem(asset: item.asset))
+            if isPlaying {
+                player.play()
+            }
+        }
+    }
+    
+    override func galleryContentDidAppear() {
+        super.galleryContentDidAppear()
+        
+        let wasFirstAppearance = isFirstAppearance
+        isFirstAppearance = false
+        
+        audioSessionToken = AudioSessionCoordinator.shared.beginPlayback(mode: .video) {
+            if wasFirstAppearance {
+                DispatchQueue.main.async {
+                    self.player.play()
+                }
+            }
+        }
+    }
+    
+    override func galleryContentWillDisappear() {
+        super.galleryContentWillDisappear()
+        
+        if let audioSessionToken {
+            AudioSessionCoordinator.shared.endPlayback(token: audioSessionToken)
+        }
+    }
+    
+}

Tusker/Screens/Gallery/ImageGalleryDataSource.swift

@@ -34,7 +34,7 @@ class ImageGalleryDataSource: GalleryDataSource {
                 } else {
                     nil
                 }
-            return ImageGalleryContentViewController(
+            return GrayscalableImageGalleryContentViewController(
                 url: url,
                 caption: nil,
                 originalData: entry.data,
@@ -52,7 +52,7 @@ class ImageGalleryDataSource: GalleryDataSource {
                         } else {
                             nil
                         }
-                    return ImageGalleryContentViewController(
+                    return GrayscalableImageGalleryContentViewController(
                         url: self.url,
                         caption: nil,
                         originalData: data,

Tusker/Screens/Gallery/StatusAttachmentsGalleryDataSource.swift

@@ -33,7 +33,7 @@ class StatusAttachmentsGalleryDataSource: GalleryDataSource {
         case .image:
             if let view = attachmentView(for: attachment),
                let image = view.attachmentImage {
-                return ImageGalleryContentViewController(
+                return GrayscalableImageGalleryContentViewController(
                     url: attachment.url,
                     caption: attachment.description,
                     originalData: view.originalData,
@@ -49,7 +49,7 @@ class StatusAttachmentsGalleryDataSource: GalleryDataSource {
                     } else {
                         nil
                     }
-                return ImageGalleryContentViewController(
+                return GrayscalableImageGalleryContentViewController(
                     url: attachment.url,
                     caption: attachment.description,
                     originalData: entry.data,
@@ -68,7 +68,7 @@ class StatusAttachmentsGalleryDataSource: GalleryDataSource {
                             } else {
                                 nil
                             }
-                        return ImageGalleryContentViewController(
+                        return GrayscalableImageGalleryContentViewController(
                             url: attachment.url,
                             caption: attachment.description,
                             originalData: data,
@@ -91,10 +91,10 @@ class StatusAttachmentsGalleryDataSource: GalleryDataSource {
                 }
             return GifvGalleryContentViewController(controller: controller, url: attachment.url, caption: attachment.description)
         case .video:
-            return VideoGalleryContentViewController(url: attachment.url, caption: attachment.description)
+            return GrayscalableVideoGalleryContentViewController(url: attachment.url, caption: attachment.description)
         case .audio:
             // TODO: use separate content VC with audio visualization?
-            return VideoGalleryContentViewController(url: attachment.url, caption: attachment.description)
+            return GrayscalableVideoGalleryContentViewController(url: attachment.url, caption: attachment.description)
         case .unknown:
             return LoadingGalleryContentViewController(caption: nil) {
                 do {

Tusker/Screens/Main/NewMainTabBarViewController.swift

@@ -33,6 +33,13 @@ final class NewMainTabBarViewController: BaseMainTabBarViewController {
     private var isCompact: Bool?
     @Box fileprivate var myProfileCell: UIView?
     private var sidebarTapRecognizer: UITapGestureRecognizer?
+    
+    private lazy var fastAccountSwitcherIndicator: UIView = {
+        let indicator = FastAccountSwitcherIndicatorView()
+        // need to explicitly set the frame to get it vertically centered
+        indicator.frame = CGRect(origin: .zero, size: indicator.intrinsicContentSize)
+        return indicator
+    }()
 
     override func viewDidLoad() {
         super.viewDidLoad()
@@ -513,13 +520,6 @@ extension NewMainTabBarViewController: UITabBarControllerDelegate {
     }
 }
 
-private var fastAccountSwitcherIndicator: UIView = {
-    let indicator = FastAccountSwitcherIndicatorView()
-    // need to explicitly set the frame to get it vertically centered
-    indicator.frame = CGRect(origin: .zero, size: indicator.intrinsicContentSize)
-    return indicator
-}()
-
 @available(iOS 18.0, *)
 extension NewMainTabBarViewController: UITabBarController.Sidebar.Delegate {
     func tabBarController(_ tabBarController: UITabBarController, sidebarVisibilityWillChange sidebar: UITabBarController.Sidebar, animator: any UITabBarController.Sidebar.Animating) {

Tusker/Screens/Notifications/NotificationLoadingViewController.swift

@@ -48,7 +48,9 @@ class NotificationLoadingViewController: UIViewController {
             do {
                 let (notification, _) = try await mastodonController.run(request)
                 await withCheckedContinuation { continuation in
-                    mastodonController.persistentContainer.addAll(notifications: [notification]) {
+                    let container = mastodonController.persistentContainer
+                    let context = container.viewContext
+                    container.addAll(notifications: [notification], in: context) {
                         continuation.resume()
                     }
                 }

Tusker/Screens/Timeline/InstanceTimelineViewController.swift

@@ -77,11 +77,25 @@ class InstanceTimelineViewController: TimelineViewController {
         cell.updateUI(statusID: id, state: state, filterResult: filterResult, precomputedContent: precomputedContent)
     }
     
+    override func collectionView(_ collectionView: UICollectionView, shouldSelectItemAt indexPath: IndexPath) -> Bool {
+        guard browsingEnabled else {
+            return false
+        }
+        return super.collectionView(collectionView, shouldSelectItemAt: indexPath)
+    }
+    
     override func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
         guard browsingEnabled else { return }
         super.collectionView(collectionView, didSelectItemAt: indexPath)
     }
     
+    override func collectionView(_ collectionView: UICollectionView, contextMenuConfigurationForItemAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration? {
+        guard browsingEnabled else {
+            return nil
+        }
+        return super.collectionView(collectionView, contextMenuConfigurationForItemAt: indexPath, point: point)
+    }
+    
     // MARK: Timeline
     
     override func handleLoadAllError(_ error: Swift.Error) async {

Tusker/Views/AccountDisplayAndUserNameLabel.swift

@@ -30,7 +30,9 @@ class AccountDisplayAndUserNameLabel: EmojiLabel {
     
     private func makeAttributedText(state: State) -> NSAttributedString {
         let s = NSMutableAttributedString()
-        s.append(NSAttributedString(string: state.displayName, attributes: [
+        // U+2068 FIRST-STRONG ISOLATE and U+2069 POP DIRECTIONAL ISOLATE
+        // to prevent bidi text in the display name influencing the username
+        s.append(NSAttributedString(string: "\u{2068}\(state.displayName)\u{2069}", attributes: [
             .font: UIFont(descriptor: baseFont.addingAttributes([
                 .traits: [
                     UIFontDescriptor.TraitKey.weight: UIFont.Weight.semibold.rawValue,

Tusker/Views/Attachments/AttachmentView.swift

@@ -467,12 +467,12 @@ extension AttachmentView: UIContextMenuInteractionDelegate {
         return UIContextMenuConfiguration { [unowned self] () -> UIViewController? in
             if self.attachment.kind == .image,
                let image {
-                return ImageGalleryContentViewController(url: self.attachment.url, caption: nil, originalData: nil, image: image, gifController: self.gifController)
+                return GrayscalableImageGalleryContentViewController(url: self.attachment.url, caption: nil, originalData: nil, image: image, gifController: self.gifController)
             } else if self.attachment.kind == .gifv,
                       let gifvView {
                 return GifvGalleryContentViewController(controller: gifvView.controller, url: self.attachment.url, caption: nil)
             } else if self.attachment.kind == .video || self.attachment.kind == .audio {
-                let vc = VideoGalleryContentViewController(url: self.attachment.url, caption: nil)
+                let vc = GrayscalableVideoGalleryContentViewController(url: self.attachment.url, caption: nil)
                 vc.player.isMuted = true
                 return vc
             } else {

Tusker/Views/Attachments/AttachmentsContainerView.swift

@@ -295,7 +295,11 @@ class AttachmentsContainerView: UIView {
                 accessibilityElements.append(moreView)
             }
             
-            self.aspectRatio = aspectRatio
+            self.aspectRatio = if aspectRatio.isNaN || aspectRatio.isInfinite {
+                16/9
+            } else {
+                aspectRatio
+            }
         } else {
             self.isHidden = true
         }

Tusker/Views/Attachments/GifvController.swift

@@ -60,9 +60,9 @@ class GifvController {
     }
     
     private func updatePresentationSizeObservation() {
-        presentationSizeObservation = item.observe(\.presentationSize, changeHandler: { [unowned self] item, _ in
+        presentationSizeObservation = item.observe(\.presentationSize, changeHandler: { [weak self] item, _ in
             DispatchQueue.main.async {
-                self.presentationSizeSubject.send(item.presentationSize)
+                self?.presentationSizeSubject.send(item.presentationSize)
             }
         })
     }

Version.xcconfig

@@ -9,8 +9,8 @@
 // Configuration settings file format documentation can be found at:
 // https://help.apple.com/xcode/#/dev745c5c974
 
-MARKETING_VERSION = 2024.4
-CURRENT_PROJECT_VERSION = 136
+MARKETING_VERSION = 2024.5
+CURRENT_PROJECT_VERSION = 137
 CURRENT_PROJECT_VERSION = $(inherited)$(CURRENT_PROJECT_VERSION_BUILD_SUFFIX_$(CONFIGURATION))
 
 CURRENT_PROJECT_VERSION_BUILD_SUFFIX_Debug=-dev