NotificationExtension/PrivacyInfo.xcprivacy

@@ -1,17 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
-<plist version="1.0">
-<dict>
-	<key>NSPrivacyAccessedAPITypes</key>
-	<array>
-		<dict>
-			<key>NSPrivacyAccessedAPITypeReasons</key>
-			<array>
-				<string>1C8F.1</string>
-			</array>
-			<key>NSPrivacyAccessedAPIType</key>
-			<string>NSPrivacyAccessedAPICategoryUserDefaults</string>
-		</dict>
-	</array>
-</dict>
-</plist>

Packages/InstanceFeatures/Sources/InstanceFeatures/InstanceFeatures.swift

@@ -184,31 +184,6 @@ public final class InstanceFeatures: ObservableObject {
         hasMastodonVersion(4, 2, 0) || instanceType.isMastodon(.hometown(nil))
     }
     
-    public var pushNotificationTypeStatus: Bool {
-        hasMastodonVersion(3, 3, 0)
-    }
-    
-    public var pushNotificationTypeFollowRequest: Bool {
-        hasMastodonVersion(3, 1, 0)
-    }
-    
-    public var pushNotificationTypeUpdate: Bool {
-        hasMastodonVersion(3, 5, 0)
-    }
-    
-    public var pushNotificationPolicy: Bool {
-        hasMastodonVersion(3, 5, 0)
-    }
-    
-    public var pushNotificationPolicyMissingFromResponse: Bool {
-        switch instanceType {
-        case .mastodon(_, let version):
-            return version >= Version(3, 5, 0) && version < Version(4, 1, 0)
-        default:
-            return false
-        }
-    }
-    
     public init() {
     }
     

Packages/Pachyderm/Sources/Pachyderm/Model/PushSubscription.swift

@@ -9,11 +9,11 @@
 import Foundation
 
 public struct PushSubscription: Decodable, Sendable {
-    public var id: String
-    public var endpoint: URL
-    public var serverKey: String
-    public var alerts: Alerts
-    public var policy: Policy
+    public let id: String
+    public let endpoint: URL
+    public let serverKey: String
+    public let alerts: Alerts
+    public let policy: Policy
     
     public init(from decoder: any Decoder) throws {
         let container = try decoder.container(keyedBy: CodingKeys.self)
@@ -27,8 +27,7 @@ public struct PushSubscription: Decodable, Sendable {
         self.endpoint = try container.decode(URL.self, forKey: .endpoint)
         self.serverKey = try container.decode(String.self, forKey: .serverKey)
         self.alerts = try container.decode(PushSubscription.Alerts.self, forKey: .alerts)
-        // added in mastodon 4.1.0
-        self.policy = try container.decodeIfPresent(PushSubscription.Policy.self, forKey: .policy) ?? .all
+        self.policy = try container.decode(PushSubscription.Policy.self, forKey: .policy)
     }
     
     public static func create(endpoint: URL, publicKey: Data, authSecret: Data, alerts: Alerts, policy: Policy) -> Request<PushSubscription> {
@@ -97,21 +96,6 @@ extension PushSubscription {
             self.update = update
         }
         
-        public init(from decoder: any Decoder) throws {
-            let container: KeyedDecodingContainer<PushSubscription.Alerts.CodingKeys> = try decoder.container(keyedBy: PushSubscription.Alerts.CodingKeys.self)
-            self.mention = try container.decode(Bool.self, forKey: PushSubscription.Alerts.CodingKeys.mention)
-            // status added in mastodon 3.3.0
-            self.status = try container.decodeIfPresent(Bool.self, forKey: PushSubscription.Alerts.CodingKeys.status) ?? false
-            self.reblog = try container.decode(Bool.self, forKey: PushSubscription.Alerts.CodingKeys.reblog)
-            self.follow = try container.decode(Bool.self, forKey: PushSubscription.Alerts.CodingKeys.follow)
-            // follow_request added in 3.1.0
-            self.followRequest = try container.decodeIfPresent(Bool.self, forKey: PushSubscription.Alerts.CodingKeys.followRequest) ?? false
-            self.favourite = try container.decode(Bool.self, forKey: PushSubscription.Alerts.CodingKeys.favourite)
-            self.poll = try container.decode(Bool.self, forKey: PushSubscription.Alerts.CodingKeys.poll)
-            // update added in mastodon 3.5.0
-            self.update = try container.decodeIfPresent(Bool.self, forKey: PushSubscription.Alerts.CodingKeys.update) ?? false
-        }
-        
         private enum CodingKeys: String, CodingKey {
             case mention
             case status

Packages/PushNotifications/Sources/PushNotifications/PushSubscription.swift

@@ -53,7 +53,7 @@ public struct PushSubscription {
         self.policy = policy
     }
 
-    public enum Policy: String, CaseIterable, Identifiable, Sendable {
+    public enum Policy: String, CaseIterable, Identifiable {
         case all, followed, followers
         
         public var id: some Hashable {
@@ -61,7 +61,7 @@ public struct PushSubscription {
         }
     }
     
-    public struct Alerts: OptionSet, Hashable, Sendable {
+    public struct Alerts: OptionSet, Hashable {
         public static let mention = Alerts(rawValue: 1 << 0)
         public static let status = Alerts(rawValue: 1 << 1)
         public static let reblog = Alerts(rawValue: 1 << 2)

Packages/TuskerPreferences/Package.resolved

@@ -1,23 +0,0 @@
-{
-  "pins" : [
-    {
-      "identity" : "swift-system",
-      "kind" : "remoteSourceControl",
-      "location" : "https://github.com/apple/swift-system.git",
-      "state" : {
-        "revision" : "025bcb1165deab2e20d4eaba79967ce73013f496",
-        "version" : "1.2.1"
-      }
-    },
-    {
-      "identity" : "swift-url",
-      "kind" : "remoteSourceControl",
-      "location" : "https://github.com/karwa/swift-url.git",
-      "state" : {
-        "branch" : "main",
-        "revision" : "01ad5a103d14839a68c55ee556513e5939008e9e"
-      }
-    }
-  ],
-  "version" : 2
-}

Packages/TuskerPreferences/Package.swift

@@ -24,9 +24,5 @@ let package = Package(
             name: "TuskerPreferences",
             dependencies: ["Pachyderm"]
         ),
-        .testTarget(
-            name: "TuskerPreferencesTests",
-            dependencies: ["TuskerPreferences"]
-        )
     ]
 )

Packages/TuskerPreferences/Sources/TuskerPreferences/Coding.swift

@@ -1,282 +0,0 @@
-//
-//  Coding.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-private protocol PreferenceProtocol {
-    associatedtype Key: PreferenceKey
-    var storedValue: Key.Value? { get }
-    init()
-}
-
-extension Preference: PreferenceProtocol {
-}
-
-struct PreferenceCoding<Wrapped: Codable>: Codable {
-    let wrapped: Wrapped
-    
-    init(wrapped: Wrapped) {
-        self.wrapped = wrapped
-    }
-    
-    init(from decoder: any Decoder) throws {
-        self.wrapped = try Wrapped(from: PreferenceDecoder(wrapped: decoder))
-    }
-    
-    func encode(to encoder: any Encoder) throws {
-        try wrapped.encode(to: PreferenceEncoder(wrapped: encoder))
-    }
-}
-
-private struct PreferenceDecoder: Decoder {
-    let wrapped: any Decoder
-    
-    var codingPath: [any CodingKey] {
-        wrapped.codingPath
-    }
-    
-    var userInfo: [CodingUserInfoKey : Any] {
-        wrapped.userInfo
-    }
-    
-    func container<Key>(keyedBy type: Key.Type) throws -> KeyedDecodingContainer<Key> where Key : CodingKey {
-        KeyedDecodingContainer(PreferenceDecodingContainer(wrapped: try wrapped.container(keyedBy: type)))
-    }
-    
-    func unkeyedContainer() throws -> any UnkeyedDecodingContainer {
-        throw Error.onlyKeyedContainerSupported
-    }
-    
-    func singleValueContainer() throws -> any SingleValueDecodingContainer {
-        throw Error.onlyKeyedContainerSupported
-    }
-    
-    enum Error: Swift.Error {
-        case onlyKeyedContainerSupported
-    }
-}
-
-private struct PreferenceDecodingContainer<Key: CodingKey>: KeyedDecodingContainerProtocol {
-    let wrapped: KeyedDecodingContainer<Key>
-    
-    var codingPath: [any CodingKey] {
-        wrapped.codingPath
-    }
-    
-    var allKeys: [Key] {
-        wrapped.allKeys
-    }
-    
-    func contains(_ key: Key) -> Bool {
-        wrapped.contains(key)
-    }
-    
-    func decodeNil(forKey key: Key) throws -> Bool {
-        try wrapped.decodeNil(forKey: key)
-    }
-    
-    func decode(_ type: Bool.Type, forKey key: Key) throws -> Bool {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: String.Type, forKey key: Key) throws -> String {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: Double.Type, forKey key: Key) throws -> Double {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: Float.Type, forKey key: Key) throws -> Float {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: Int.Type, forKey key: Key) throws -> Int {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: Int8.Type, forKey key: Key) throws -> Int8 {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: Int16.Type, forKey key: Key) throws -> Int16 {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: Int32.Type, forKey key: Key) throws -> Int32 {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: Int64.Type, forKey key: Key) throws -> Int64 {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: UInt.Type, forKey key: Key) throws -> UInt {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: UInt8.Type, forKey key: Key) throws -> UInt8 {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: UInt16.Type, forKey key: Key) throws -> UInt16 {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: UInt32.Type, forKey key: Key) throws -> UInt32 {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode(_ type: UInt64.Type, forKey key: Key) throws -> UInt64 {
-        try wrapped.decode(type, forKey: key)
-    }
-    
-    func decode<T>(_ type: T.Type, forKey key: Key) throws -> T where T : Decodable {
-        if let type = type as? any PreferenceProtocol.Type,
-           !contains(key) {
-            func makePreference<P: PreferenceProtocol>(_: P.Type) -> T {
-                P() as! T
-            }
-            return _openExistential(type, do: makePreference)
-        }
-        return try wrapped.decode(type, forKey: key)
-    }
-    
-    func nestedContainer<NestedKey>(keyedBy type: NestedKey.Type, forKey key: Key) throws -> KeyedDecodingContainer<NestedKey> where NestedKey : CodingKey {
-        try wrapped.nestedContainer(keyedBy: type, forKey: key)
-    }
-    
-    func nestedUnkeyedContainer(forKey key: Key) throws -> any UnkeyedDecodingContainer {
-        try wrapped.nestedUnkeyedContainer(forKey: key)
-    }
-    
-    func superDecoder() throws -> any Decoder {
-        try wrapped.superDecoder()
-    }
-    
-    func superDecoder(forKey key: Key) throws -> any Decoder {
-        try wrapped.superDecoder(forKey: key)
-    }
-}
-
-private struct PreferenceEncoder: Encoder {
-    let wrapped: any Encoder
-    
-    var codingPath: [any CodingKey] {
-        wrapped.codingPath
-    }
-    
-    var userInfo: [CodingUserInfoKey : Any] {
-        wrapped.userInfo
-    }
-    
-    func container<Key>(keyedBy type: Key.Type) -> KeyedEncodingContainer<Key> where Key : CodingKey {
-        KeyedEncodingContainer(PreferenceEncodingContainer(wrapped: wrapped.container(keyedBy: type)))
-    }
-    
-    func unkeyedContainer() -> any UnkeyedEncodingContainer {
-        fatalError("Only keyed containers supported")
-    }
-    
-    func singleValueContainer() -> any SingleValueEncodingContainer {
-        fatalError("Only keyed containers supported")
-    }
-}
-
-private struct PreferenceEncodingContainer<Key: CodingKey>: KeyedEncodingContainerProtocol {
-    var wrapped: KeyedEncodingContainer<Key>
-    
-    var codingPath: [any CodingKey] {
-        wrapped.codingPath
-    }
-    
-    mutating func encodeNil(forKey key: Key) throws {
-        try wrapped.encodeNil(forKey: key)
-    }
-    
-    mutating func encode(_ value: Bool, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: String, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: Double, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: Float, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: Int, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: Int8, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: Int16, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: Int32, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: Int64, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: UInt, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: UInt8, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: UInt16, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: UInt32, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode(_ value: UInt64, forKey key: Key) throws {
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func encode<T>(_ value: T, forKey key: Key) throws where T : Encodable {
-        if let value = value as? any PreferenceProtocol,
-           value.storedValue == nil {
-            return
-        }
-        try wrapped.encode(value, forKey: key)
-    }
-    
-    mutating func nestedContainer<NestedKey>(keyedBy keyType: NestedKey.Type, forKey key: Key) -> KeyedEncodingContainer<NestedKey> where NestedKey : CodingKey {
-        wrapped.nestedContainer(keyedBy: keyType, forKey: key)
-    }
-    
-    mutating func nestedUnkeyedContainer(forKey key: Key) -> any UnkeyedEncodingContainer {
-        wrapped.nestedUnkeyedContainer(forKey: key)
-    }
-    
-    mutating func superEncoder() -> any Encoder {
-        wrapped.superEncoder()
-    }
-    
-    mutating func superEncoder(forKey key: Key) -> any Encoder {
-        wrapped.superEncoder(forKey: key)
-    }
-    
-    
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Keys/AdvancedKeys.swift

@@ -1,17 +0,0 @@
-//
-//  AdvancedKeys.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-import Pachyderm
-
-struct StatusContentTypeKey: PreferenceKey {
-    static var defaultValue: StatusContentType { .plain }
-}
-
-struct FeatureFlagsKey: PreferenceKey {
-    static var defaultValue: Set<FeatureFlag> { [] }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Keys/AppearanceKeys.swift

@@ -1,33 +0,0 @@
-//
-//  AppearanceKeys.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-import UIKit
-
-struct ThemeKey: PreferenceKey {
-    static var defaultValue: Theme { .unspecified }
-}
-
-struct AccentColorKey: PreferenceKey {
-    static var defaultValue: AccentColor { .default }
-}
-
-struct AvatarStyleKey: PreferenceKey {
-    static var defaultValue: AvatarStyle { .roundRect }
-}
-
-struct LeadingSwipeActionsKey: PreferenceKey {
-    static var defaultValue: [StatusSwipeAction] { [.favorite, .reblog] }
-}
-
-struct TrailingSwipeActionsKey: PreferenceKey {
-    static var defaultValue: [StatusSwipeAction] { [.reply, .share] }
-}
-
-struct WidescreenNavigationModeKey: PreferenceKey {
-    static var defaultValue: WidescreenNavigationMode { .splitScreen }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Keys/BehaviorKeys.swift

@@ -1,26 +0,0 @@
-//
-//  BehaviorKeys.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-struct OppositeCollapseKeywordsKey: PreferenceKey {
-    static var defaultValue: [String] { [] }
-}
-
-struct ConfirmReblogKey: PreferenceKey {
-    static var defaultValue: Bool {
-        #if os(visionOS)
-        true
-        #else
-        false
-        #endif
-    }
-}
-
-struct TimelineSyncModeKey: PreferenceKey {
-    static var defaultValue: TimelineSyncMode { .icloud }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Keys/CommonKeys.swift

@@ -1,16 +0,0 @@
-//
-//  CommonKeys.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-struct TrueKey: PreferenceKey {
-    static var defaultValue: Bool { true }
-}
-
-struct FalseKey: PreferenceKey {
-    static var defaultValue: Bool { false }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Keys/ComposingKeys.swift

@@ -1,20 +0,0 @@
-//
-//  ComposingKeys.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-struct PostVisibilityKey: PreferenceKey {
-    static var defaultValue: PostVisibility { .serverDefault }
-}
-
-struct ReplyVisibilityKey: PreferenceKey {
-    static var defaultValue: ReplyVisibility { .sameAsPost }
-}
-
-struct ContentWarningCopyModeKey: PreferenceKey {
-    static var defaultValue: ContentWarningCopyMode { .asIs }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Keys/DigitalWellnessKeys.swift

@@ -1,12 +0,0 @@
-//
-//  DigitalWellnessKeys.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-struct NotificationsModeKey: PreferenceKey {
-    static var defaultValue: NotificationsMode { .allNotifications }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Keys/MediaKeys.swift

@@ -1,20 +0,0 @@
-//
-//  MediaKeys.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-struct AttachmentBlurModeKey: PreferenceKey {
-    static var defaultValue: AttachmentBlurMode { .useStatusSetting }
-    
-    static func didSet(in store: PreferenceStore, newValue: AttachmentBlurMode) {
-        if newValue == .always {
-            store.blurMediaBehindContentWarning = true
-        } else if newValue == .never {
-            store.blurMediaBehindContentWarning = false
-        }
-    }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Legacy/LegacyPreferences.swift

@@ -1,205 +0,0 @@
-//
-//  LegacyPreferences.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 8/28/18.
-//  Copyright © 2018 Shadowfacts. All rights reserved.
-//
-
-import UIKit
-import Pachyderm
-import Combine
-
-public final class LegacyPreferences: Decodable {
-
-    init() {}
-    
-    public required init(from decoder: Decoder) throws {
-        let container = try decoder.container(keyedBy: CodingKeys.self)
-        
-        self.theme = try container.decode(UIUserInterfaceStyle.self, forKey: .theme)
-        self.pureBlackDarkMode = try container.decodeIfPresent(Bool.self, forKey: .pureBlackDarkMode) ?? true
-        self.accentColor = try container.decodeIfPresent(AccentColor.self, forKey: .accentColor) ?? .default
-        self.avatarStyle = try container.decode(AvatarStyle.self, forKey: .avatarStyle)
-        self.hideCustomEmojiInUsernames = try container.decode(Bool.self, forKey: .hideCustomEmojiInUsernames)
-        self.showIsStatusReplyIcon = try container.decode(Bool.self, forKey: .showIsStatusReplyIcon)
-        self.alwaysShowStatusVisibilityIcon = try container.decode(Bool.self, forKey: .alwaysShowStatusVisibilityIcon)
-        self.hideActionsInTimeline = try container.decodeIfPresent(Bool.self, forKey: .hideActionsInTimeline) ?? false
-        self.showLinkPreviews = try container.decodeIfPresent(Bool.self, forKey: .showLinkPreviews) ?? true
-        self.leadingStatusSwipeActions = try container.decodeIfPresent([StatusSwipeAction].self, forKey: .leadingStatusSwipeActions) ?? leadingStatusSwipeActions
-        self.trailingStatusSwipeActions = try container.decodeIfPresent([StatusSwipeAction].self, forKey: .trailingStatusSwipeActions) ?? trailingStatusSwipeActions
-        self.widescreenNavigationMode = try container.decodeIfPresent(WidescreenNavigationMode.self, forKey: .widescreenNavigationMode) ?? Self.defaultWidescreenNavigationMode
-        self.underlineTextLinks = try container.decodeIfPresent(Bool.self, forKey: .underlineTextLinks) ?? false
-        self.showAttachmentsInTimeline = try container.decodeIfPresent(Bool.self, forKey: .showAttachmentsInTimeline) ?? true
-        
-        if let existing = try? container.decode(Visibility.self, forKey: .defaultPostVisibility) {
-            self.defaultPostVisibility = .visibility(existing)
-        } else {
-            self.defaultPostVisibility = try container.decode(PostVisibility.self, forKey: .defaultPostVisibility)
-        }
-        self.defaultReplyVisibility = try container.decodeIfPresent(ReplyVisibility.self, forKey: .defaultReplyVisibility) ?? .sameAsPost
-        self.requireAttachmentDescriptions = try container.decode(Bool.self, forKey: .requireAttachmentDescriptions)
-        self.contentWarningCopyMode = try container.decode(ContentWarningCopyMode.self, forKey: .contentWarningCopyMode)
-        self.mentionReblogger = try container.decode(Bool.self, forKey: .mentionReblogger)
-        self.useTwitterKeyboard = try container.decodeIfPresent(Bool.self, forKey: .useTwitterKeyboard) ?? false
-        
-        if let blurAllMedia = try? container.decodeIfPresent(Bool.self, forKey: .blurAllMedia) {
-            self.attachmentBlurMode = blurAllMedia ? .always : .useStatusSetting
-        } else {
-            self.attachmentBlurMode = try container.decode(AttachmentBlurMode.self, forKey: .attachmentBlurMode)
-        }
-        self.blurMediaBehindContentWarning = try container.decodeIfPresent(Bool.self, forKey: .blurMediaBehindContentWarning) ?? true
-        self.automaticallyPlayGifs = try container.decode(Bool.self, forKey: .automaticallyPlayGifs)
-        self.showUncroppedMediaInline = try container.decodeIfPresent(Bool.self, forKey: .showUncroppedMediaInline) ?? true
-        self.showAttachmentBadges = try container.decodeIfPresent(Bool.self, forKey: .showAttachmentBadges) ?? true
-        self.attachmentAltBadgeInverted = try container.decodeIfPresent(Bool.self, forKey: .attachmentAltBadgeInverted) ?? false
-        
-        self.openLinksInApps = try container.decode(Bool.self, forKey: .openLinksInApps)
-        self.useInAppSafari = try container.decode(Bool.self, forKey: .useInAppSafari)
-        self.inAppSafariAutomaticReaderMode = try container.decode(Bool.self, forKey: .inAppSafariAutomaticReaderMode)
-        self.expandAllContentWarnings = try container.decodeIfPresent(Bool.self, forKey: .expandAllContentWarnings) ?? false
-        self.collapseLongPosts = try container.decodeIfPresent(Bool.self, forKey: .collapseLongPosts) ?? true
-        self.oppositeCollapseKeywords = try container.decodeIfPresent([String].self, forKey: .oppositeCollapseKeywords) ?? []
-        self.confirmBeforeReblog = try container.decodeIfPresent(Bool.self, forKey: .confirmBeforeReblog) ?? false
-        self.timelineStateRestoration = try container.decodeIfPresent(Bool.self, forKey: .timelineStateRestoration) ?? true
-        self.timelineSyncMode = try container.decodeIfPresent(TimelineSyncMode.self, forKey: .timelineSyncMode) ?? .icloud
-        self.hideReblogsInTimelines = try container.decodeIfPresent(Bool.self, forKey: .hideReblogsInTimelines) ?? false
-        self.hideRepliesInTimelines = try container.decodeIfPresent(Bool.self, forKey: .hideRepliesInTimelines) ?? false
-        
-        self.showFavoriteAndReblogCounts = try container.decode(Bool.self, forKey: .showFavoriteAndReblogCounts)
-        self.defaultNotificationsMode = try container.decode(NotificationsMode.self, forKey: .defaultNotificationsType)
-        self.grayscaleImages = try container.decodeIfPresent(Bool.self, forKey: .grayscaleImages) ?? false
-        self.disableInfiniteScrolling = try container.decodeIfPresent(Bool.self, forKey: .disableInfiniteScrolling) ?? false
-        self.hideTrends = try container.decodeIfPresent(Bool.self, forKey: .hideTrends) ?? false
-        
-        self.statusContentType = try container.decode(StatusContentType.self, forKey: .statusContentType)
-        self.reportErrorsAutomatically = try container.decodeIfPresent(Bool.self, forKey: .reportErrorsAutomatically) ?? true
-        let featureFlagNames = (try? container.decodeIfPresent([String].self, forKey: .enabledFeatureFlags)) ?? []
-        self.enabledFeatureFlags = Set(featureFlagNames.compactMap(FeatureFlag.init))
-        
-        self.hasShownLocalTimelineDescription = try container.decodeIfPresent(Bool.self, forKey: .hasShownLocalTimelineDescription) ?? false
-        self.hasShownFederatedTimelineDescription = try container.decodeIfPresent(Bool.self, forKey: .hasShownFederatedTimelineDescription) ?? false
-    }
-    
-    // MARK: Appearance
-    @Published public var theme = UIUserInterfaceStyle.unspecified
-    @Published public var pureBlackDarkMode = true
-    @Published public var accentColor = AccentColor.default
-    @Published public var avatarStyle = AvatarStyle.roundRect
-    @Published public var hideCustomEmojiInUsernames = false
-    @Published public var showIsStatusReplyIcon = false
-    @Published public var alwaysShowStatusVisibilityIcon = false
-    @Published public var hideActionsInTimeline = false
-    @Published public var showLinkPreviews = true
-    @Published public var leadingStatusSwipeActions: [StatusSwipeAction] = [.favorite, .reblog]
-    @Published public var trailingStatusSwipeActions: [StatusSwipeAction] = [.reply, .share]
-    private static var defaultWidescreenNavigationMode = WidescreenNavigationMode.splitScreen
-    @Published public var widescreenNavigationMode = LegacyPreferences.defaultWidescreenNavigationMode
-    @Published public var underlineTextLinks = false
-    @Published public var showAttachmentsInTimeline = true
-    
-    // MARK: Composing
-    @Published public var defaultPostVisibility = PostVisibility.serverDefault
-    @Published public var defaultReplyVisibility = ReplyVisibility.sameAsPost
-    @Published public var requireAttachmentDescriptions = false
-    @Published public var contentWarningCopyMode = ContentWarningCopyMode.asIs
-    @Published public var mentionReblogger = false
-    @Published public var useTwitterKeyboard = false
-    
-    // MARK: Media
-    @Published public var attachmentBlurMode = AttachmentBlurMode.useStatusSetting
-    @Published public var blurMediaBehindContentWarning = true
-    @Published public var automaticallyPlayGifs = true
-    @Published public var showUncroppedMediaInline = true
-    @Published public var showAttachmentBadges = true
-    @Published public var attachmentAltBadgeInverted = false
-    
-    // MARK: Behavior
-    @Published public var openLinksInApps = true
-    @Published public var useInAppSafari = true
-    @Published public var inAppSafariAutomaticReaderMode = false
-    @Published public var expandAllContentWarnings = false
-    @Published public var collapseLongPosts = true
-    @Published public var oppositeCollapseKeywords: [String] = []
-    @Published public var confirmBeforeReblog = false
-    @Published public var timelineStateRestoration = true
-    @Published public var timelineSyncMode = TimelineSyncMode.icloud
-    @Published public var hideReblogsInTimelines = false
-    @Published public var hideRepliesInTimelines = false
-    
-    // MARK: Digital Wellness
-    @Published public var showFavoriteAndReblogCounts = true
-    @Published public var defaultNotificationsMode = NotificationsMode.allNotifications
-    @Published public var grayscaleImages = false
-    @Published public var disableInfiniteScrolling = false
-    @Published public var hideTrends = false
-    
-    // MARK: Advanced
-    @Published public var statusContentType: StatusContentType = .plain
-    @Published public var reportErrorsAutomatically = true
-    @Published public var enabledFeatureFlags: Set<FeatureFlag> = []
-    
-    // MARK:
-    @Published public var hasShownLocalTimelineDescription = false
-    @Published public var hasShownFederatedTimelineDescription = false
-    
-    private enum CodingKeys: String, CodingKey {
-        case theme
-        case pureBlackDarkMode
-        case accentColor
-        case avatarStyle
-        case hideCustomEmojiInUsernames
-        case showIsStatusReplyIcon
-        case alwaysShowStatusVisibilityIcon
-        case hideActionsInTimeline
-        case showLinkPreviews
-        case leadingStatusSwipeActions
-        case trailingStatusSwipeActions
-        case widescreenNavigationMode
-        case underlineTextLinks
-        case showAttachmentsInTimeline
-        
-        case defaultPostVisibility
-        case defaultReplyVisibility
-        case requireAttachmentDescriptions
-        case contentWarningCopyMode
-        case mentionReblogger
-        case useTwitterKeyboard
-        
-        case blurAllMedia // only used for migration
-        case attachmentBlurMode
-        case blurMediaBehindContentWarning
-        case automaticallyPlayGifs
-        case showUncroppedMediaInline
-        case showAttachmentBadges
-        case attachmentAltBadgeInverted
-        
-        case openLinksInApps
-        case useInAppSafari
-        case inAppSafariAutomaticReaderMode
-        case expandAllContentWarnings
-        case collapseLongPosts
-        case oppositeCollapseKeywords
-        case confirmBeforeReblog
-        case timelineStateRestoration
-        case timelineSyncMode
-        case hideReblogsInTimelines
-        case hideRepliesInTimelines
-        
-        case showFavoriteAndReblogCounts
-        case defaultNotificationsType
-        case grayscaleImages
-        case disableInfiniteScrolling
-        case hideTrends = "hideDiscover"
-        
-        case statusContentType
-        case reportErrorsAutomatically
-        case enabledFeatureFlags
-        
-        case hasShownLocalTimelineDescription
-        case hasShownFederatedTimelineDescription
-    }
-    
-}
-
-extension UIUserInterfaceStyle: Codable {}

Packages/TuskerPreferences/Sources/TuskerPreferences/Legacy/PreferenceStore+Migrate.swift

@@ -1,102 +0,0 @@
-//
-//  PreferenceStore+Migrate.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-import UIKit
-
-extension PreferenceStore {
-    func migrate(from legacy: LegacyPreferences) {
-        let migrations: [any MigrationProtocol] = [
-            Migration(from: \.theme.theme, to: \.$theme),
-            Migration(from: \.pureBlackDarkMode, to: \.$pureBlackDarkMode),
-            Migration(from: \.accentColor, to: \.$accentColor),
-            Migration(from: \.avatarStyle, to: \.$avatarStyle),
-            Migration(from: \.hideCustomEmojiInUsernames, to: \.$hideCustomEmojiInUsernames),
-            Migration(from: \.showIsStatusReplyIcon, to: \.$showIsStatusReplyIcon),
-            Migration(from: \.alwaysShowStatusVisibilityIcon, to: \.$alwaysShowStatusVisibilityIcon),
-            Migration(from: \.hideActionsInTimeline, to: \.$hideActionsInTimeline),
-            Migration(from: \.showLinkPreviews, to: \.$showLinkPreviews),
-            Migration(from: \.leadingStatusSwipeActions, to: \.$leadingStatusSwipeActions),
-            Migration(from: \.trailingStatusSwipeActions, to: \.$trailingStatusSwipeActions),
-            Migration(from: \.widescreenNavigationMode, to: \.$widescreenNavigationMode),
-            Migration(from: \.underlineTextLinks, to: \.$underlineTextLinks),
-            Migration(from: \.showAttachmentsInTimeline, to: \.$showAttachmentsInTimeline),
-            
-            Migration(from: \.defaultPostVisibility, to: \.$defaultPostVisibility),
-            Migration(from: \.defaultReplyVisibility, to: \.$defaultReplyVisibility),
-            Migration(from: \.requireAttachmentDescriptions, to: \.$requireAttachmentDescriptions),
-            Migration(from: \.contentWarningCopyMode, to: \.$contentWarningCopyMode),
-            Migration(from: \.mentionReblogger, to: \.$mentionReblogger),
-            Migration(from: \.useTwitterKeyboard, to: \.$useTwitterKeyboard),
-            
-            Migration(from: \.attachmentBlurMode, to: \.$attachmentBlurMode),
-            Migration(from: \.blurMediaBehindContentWarning, to: \.$blurMediaBehindContentWarning),
-            Migration(from: \.automaticallyPlayGifs, to: \.$automaticallyPlayGifs),
-            Migration(from: \.showUncroppedMediaInline, to: \.$showUncroppedMediaInline),
-            Migration(from: \.showAttachmentBadges, to: \.$showAttachmentBadges),
-            Migration(from: \.attachmentAltBadgeInverted, to: \.$attachmentAltBadgeInverted),
-            
-            Migration(from: \.openLinksInApps, to: \.$openLinksInApps),
-            Migration(from: \.useInAppSafari, to: \.$useInAppSafari),
-            Migration(from: \.inAppSafariAutomaticReaderMode, to: \.$inAppSafariAutomaticReaderMode),
-            Migration(from: \.expandAllContentWarnings, to: \.$expandAllContentWarnings),
-            Migration(from: \.collapseLongPosts, to: \.$collapseLongPosts),
-            Migration(from: \.oppositeCollapseKeywords, to: \.$oppositeCollapseKeywords),
-            Migration(from: \.confirmBeforeReblog, to: \.$confirmBeforeReblog),
-            Migration(from: \.timelineStateRestoration, to: \.$timelineStateRestoration),
-            Migration(from: \.timelineSyncMode, to: \.$timelineSyncMode),
-            Migration(from: \.hideReblogsInTimelines, to: \.$hideReblogsInTimelines),
-            Migration(from: \.hideRepliesInTimelines, to: \.$hideRepliesInTimelines),
-            
-            Migration(from: \.showFavoriteAndReblogCounts, to: \.$showFavoriteAndReblogCounts),
-            Migration(from: \.defaultNotificationsMode, to: \.$defaultNotificationsMode),
-            Migration(from: \.grayscaleImages, to: \.$grayscaleImages),
-            Migration(from: \.disableInfiniteScrolling, to: \.$disableInfiniteScrolling),
-            Migration(from: \.hideTrends, to: \.$hideTrends),
-            
-            Migration(from: \.statusContentType, to: \.$statusContentType),
-            Migration(from: \.reportErrorsAutomatically, to: \.$reportErrorsAutomatically),
-            Migration(from: \.enabledFeatureFlags, to: \.$enabledFeatureFlags),
-            
-            Migration(from: \.hasShownLocalTimelineDescription, to: \.$hasShownLocalTimelineDescription),
-            Migration(from: \.hasShownFederatedTimelineDescription, to: \.$hasShownFederatedTimelineDescription),
-        ]
-        
-        for migration in migrations {
-            migration.migrate(from: legacy, to: self)
-        }
-    }
-}
-
-private protocol MigrationProtocol {
-    func migrate(from legacy: LegacyPreferences, to store: PreferenceStore)
-}
-
-private struct Migration<Key: PreferenceKey>: MigrationProtocol where Key.Value: Equatable {
-    let from: KeyPath<LegacyPreferences, Key.Value>
-    let to: KeyPath<PreferenceStore, PreferencePublisher<Key>>
-    
-    func migrate(from legacy: LegacyPreferences, to store: PreferenceStore) {
-        let value = legacy[keyPath: from]
-        if value != Key.defaultValue {
-            Preference.set(enclosingInstance: store, storage: to.appending(path: \.preference), newValue: value)
-        }
-    }
-}
-
-private extension UIUserInterfaceStyle {
-    var theme: Theme {
-        switch self {
-        case .light:
-            .light
-        case .dark:
-            .dark
-        default:
-            .unspecified
-        }
-    }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/PostVisibility.swift

@@ -12,7 +12,7 @@ public enum PostVisibility: Codable, Hashable, CaseIterable, Sendable {
     case serverDefault
     case visibility(Visibility)
     
-    public private(set) static var allCases: [PostVisibility] = [.serverDefault] + Visibility.allCases.map { .visibility($0) }
+    public static var allCases: [PostVisibility] = [.serverDefault] + Visibility.allCases.map { .visibility($0) }
     
     public func resolved(withServerDefault serverDefault: Visibility?) -> Visibility {
         switch self {
@@ -57,7 +57,7 @@ public enum ReplyVisibility: Codable, Hashable, CaseIterable {
     case sameAsPost
     case visibility(Visibility)
     
-    public private(set) static var allCases: [ReplyVisibility] = [.sameAsPost] + Visibility.allCases.map { .visibility($0) }
+    public static var allCases: [ReplyVisibility] = [.sameAsPost] + Visibility.allCases.map { .visibility($0) }
     
     @MainActor
     public func resolved(withServerDefault serverDefault: Visibility?) -> Visibility {

Packages/TuskerPreferences/Sources/TuskerPreferences/Preference.swift

@@ -1,92 +0,0 @@
-//
-//  Preference.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-import Combine
-
-// TODO: once we target iOS 17, use Observable for this
-@propertyWrapper
-final class Preference<Key: PreferenceKey>: Codable {
-    @Published private(set) var storedValue: Key.Value?
-    
-    var wrappedValue: Key.Value {
-        get {
-            storedValue ?? Key.defaultValue
-        }
-        set {
-            fatalError("unreachable")
-        }
-    }
-    
-    init() {
-        self.storedValue = nil
-    }
-    
-    init(from decoder: any Decoder) throws {
-        if let container = try? decoder.singleValueContainer() {
-            self.storedValue = try? container.decode(Key.Value.self)
-        }
-    }
-    
-    func encode(to encoder: any Encoder) throws {
-        if let storedValue {
-            var container = encoder.singleValueContainer()
-            try container.encode(storedValue)
-        }
-    }
-    
-    static subscript(
-        _enclosingInstance instance: PreferenceStore,
-        wrapped wrappedKeyPath: ReferenceWritableKeyPath<PreferenceStore, Key.Value>,
-        storage storageKeyPath: ReferenceWritableKeyPath<PreferenceStore, Preference>
-    ) -> Key.Value {
-        get {
-            get(enclosingInstance: instance, storage: storageKeyPath)
-        }
-        set {
-            set(enclosingInstance: instance, storage: storageKeyPath, newValue: newValue)
-            Key.didSet(in: instance, newValue: newValue)
-        }
-    }
-    
-    // for testing only
-    @inline(__always)
-    static func get<Enclosing>(
-        enclosingInstance: Enclosing,
-        storage: KeyPath<Enclosing, Preference>
-    ) -> Key.Value where Enclosing: ObservableObject, Enclosing.ObjectWillChangePublisher == ObservableObjectPublisher {
-        let pref = enclosingInstance[keyPath: storage]
-        return pref.storedValue ?? Key.defaultValue
-    }
-    
-    // for testing only
-    @inline(__always)
-    static func set<Enclosing>(
-        enclosingInstance: Enclosing,
-        storage: KeyPath<Enclosing, Preference>,
-        newValue: Key.Value
-    ) where Enclosing: ObservableObject, Enclosing.ObjectWillChangePublisher == ObservableObjectPublisher {
-        enclosingInstance.objectWillChange.send()
-        let pref = enclosingInstance[keyPath: storage]
-        pref.storedValue = newValue
-    }
-    
-    var projectedValue: PreferencePublisher<Key> {
-        .init(preference: self)
-    }
-}
-
-struct PreferencePublisher<Key: PreferenceKey>: Publisher {
-    typealias Output = Key.Value
-    typealias Failure = Never
-    
-    let preference: Preference<Key>
-    
-    func receive<S>(subscriber: S) where S : Subscriber, Never == S.Failure, Key.Value == S.Input {
-        preference.$storedValue.map { $0 ?? Key.defaultValue }.receive(subscriber: subscriber)
-    }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/PreferenceKey.swift

@@ -1,20 +0,0 @@
-//
-//  PreferenceKey.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/12/24.
-//
-
-import Foundation
-
-public protocol PreferenceKey {
-    associatedtype Value: Codable
-    
-    static var defaultValue: Value { get }
-    
-    static func didSet(in store: PreferenceStore, newValue: Value)
-}
-
-extension PreferenceKey {
-    static func didSet(in store: PreferenceStore, newValue: Value) {}
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/PreferenceStore.swift

@@ -1,79 +0,0 @@
-//
-//  PreferenceStore.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/12/24.
-//
-
-import Foundation
-import UIKit
-import Pachyderm
-
-public final class PreferenceStore: ObservableObject, Codable {
-    // MARK: Appearance
-    @Preference<ThemeKey> public var theme
-    @Preference<TrueKey> public var pureBlackDarkMode
-    @Preference<AccentColorKey> public var accentColor
-    @Preference<AvatarStyleKey> public var avatarStyle
-    @Preference<FalseKey> public var hideCustomEmojiInUsernames
-    @Preference<FalseKey> public var showIsStatusReplyIcon
-    @Preference<FalseKey> public var alwaysShowStatusVisibilityIcon
-    @Preference<FalseKey> public var hideActionsInTimeline
-    @Preference<TrueKey> public var showLinkPreviews
-    @Preference<LeadingSwipeActionsKey> public var leadingStatusSwipeActions
-    @Preference<TrailingSwipeActionsKey> public var trailingStatusSwipeActions
-    @Preference<WidescreenNavigationModeKey> public var widescreenNavigationMode
-    @Preference<FalseKey> public var underlineTextLinks
-    @Preference<TrueKey> public var showAttachmentsInTimeline
-    
-    // MARK: Composing
-    @Preference<PostVisibilityKey> public var defaultPostVisibility
-    @Preference<ReplyVisibilityKey> public var defaultReplyVisibility
-    @Preference<FalseKey> public var requireAttachmentDescriptions
-    @Preference<ContentWarningCopyModeKey> public var contentWarningCopyMode
-    @Preference<FalseKey> public var mentionReblogger
-    @Preference<FalseKey> public var useTwitterKeyboard
-    
-    // MARK: Media
-    @Preference<AttachmentBlurModeKey> public var attachmentBlurMode
-    @Preference<TrueKey> public var blurMediaBehindContentWarning
-    @Preference<TrueKey> public var automaticallyPlayGifs
-    @Preference<TrueKey> public var showUncroppedMediaInline
-    @Preference<TrueKey> public var showAttachmentBadges
-    @Preference<FalseKey> public var attachmentAltBadgeInverted
-
-    // MARK: Behavior
-    @Preference<TrueKey> public var openLinksInApps
-    @Preference<TrueKey> public var useInAppSafari
-    @Preference<FalseKey> public var inAppSafariAutomaticReaderMode
-    @Preference<FalseKey> public var expandAllContentWarnings
-    @Preference<TrueKey> public var collapseLongPosts
-    @Preference<OppositeCollapseKeywordsKey> public var oppositeCollapseKeywords
-    @Preference<ConfirmReblogKey> public var confirmBeforeReblog
-    @Preference<TrueKey> public var timelineStateRestoration
-    @Preference<TimelineSyncModeKey> public var timelineSyncMode
-    @Preference<FalseKey> public var hideReblogsInTimelines
-    @Preference<FalseKey> public var hideRepliesInTimelines
-    
-    // MARK: Digital Wellness
-    @Preference<TrueKey> public var showFavoriteAndReblogCounts
-    @Preference<NotificationsModeKey> public var defaultNotificationsMode
-    @Preference<FalseKey> public var grayscaleImages
-    @Preference<FalseKey> public var disableInfiniteScrolling
-    @Preference<FalseKey> public var hideTrends
-    
-    // MARK: Advanced
-    @Preference<StatusContentTypeKey> public var statusContentType
-    @Preference<TrueKey> public var reportErrorsAutomatically
-    @Preference<FeatureFlagsKey> public var enabledFeatureFlags
-    
-    // MARK: Internal
-    @Preference<FalseKey> public var hasShownLocalTimelineDescription
-    @Preference<FalseKey> public var hasShownFederatedTimelineDescription
-}
-
-extension PreferenceStore {
-    public func hasFeatureFlag(_ flag: FeatureFlag) -> Bool {
-        enabledFeatureFlags.contains(flag)
-    }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Preferences.swift

@@ -2,42 +2,430 @@
 //  Preferences.swift
 //  TuskerPreferences
 //
-//  Created by Shadowfacts on 4/12/24.
+//  Created by Shadowfacts on 8/28/18.
+//  Copyright © 2018 Shadowfacts. All rights reserved.
 //
 
-import Foundation
+import UIKit
+import Pachyderm
+import Combine
+
+public final class Preferences: Codable, ObservableObject {
 
-public struct Preferences {
     @MainActor
-    public static let shared: PreferenceStore = load()
+    public static var shared: Preferences = load()
     
     private static var documentsDirectory = FileManager.default.urls(for: .documentDirectory, in: .userDomainMask).first!
     private static var appGroupDirectory = FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: "group.space.vaccor.Tusker")!
-    private static var legacyURL = appGroupDirectory.appendingPathComponent("preferences").appendingPathExtension("plist")
-    private static var preferencesURL = appGroupDirectory.appendingPathComponent("preferences.v2").appendingPathExtension("plist")
-    private static var nonAppGroupURL = documentsDirectory.appendingPathComponent("preferences").appendingPathExtension("plist")
-
-    private init() {}
+    private static var archiveURL = appGroupDirectory.appendingPathComponent("preferences").appendingPathExtension("plist")
     
     @MainActor
     public static func save() {
         let encoder = PropertyListEncoder()
-        let data = try? encoder.encode(PreferenceCoding(wrapped: shared))
-        try? data?.write(to: preferencesURL, options: .noFileProtection)
+        let data = try? encoder.encode(shared)
+        try? data?.write(to: archiveURL, options: .noFileProtection)
     }
     
-    private static func load() -> PreferenceStore {
+    public static func load() -> Preferences {
         let decoder = PropertyListDecoder()
-        if let data = try? Data(contentsOf: preferencesURL),
-           let store = try? decoder.decode(PreferenceCoding<PreferenceStore>.self, from: data) {
-            return store.wrapped
-        } else if let legacyData = (try? Data(contentsOf: legacyURL)) ?? (try? Data(contentsOf: nonAppGroupURL)),
-           let legacy = try? decoder.decode(LegacyPreferences.self, from: legacyData) {
-            let store = PreferenceStore()
-            store.migrate(from: legacy)
-            return store
+        if let data = try? Data(contentsOf: archiveURL),
+            let preferences = try? decoder.decode(Preferences.self, from: data) {
+            return preferences
+        }
+        return Preferences()
+    }
+    
+    @MainActor
+    public static func migrate(from url: URL) -> Result<Void, any Error> {
+        do {
+            try? FileManager.default.removeItem(at: archiveURL)
+            try FileManager.default.moveItem(at: url, to: archiveURL)
+        } catch {
+            return .failure(error)
+        }
+        shared = load()
+        return .success(())
+    }
+
+    private init() {}
+    
+    public required init(from decoder: Decoder) throws {
+        let container = try decoder.container(keyedBy: CodingKeys.self)
+        
+        self.theme = try container.decode(UIUserInterfaceStyle.self, forKey: .theme)
+        self.pureBlackDarkMode = try container.decodeIfPresent(Bool.self, forKey: .pureBlackDarkMode) ?? true
+        self.accentColor = try container.decodeIfPresent(AccentColor.self, forKey: .accentColor) ?? .default
+        self.avatarStyle = try container.decode(AvatarStyle.self, forKey: .avatarStyle)
+        self.hideCustomEmojiInUsernames = try container.decode(Bool.self, forKey: .hideCustomEmojiInUsernames)
+        self.showIsStatusReplyIcon = try container.decode(Bool.self, forKey: .showIsStatusReplyIcon)
+        self.alwaysShowStatusVisibilityIcon = try container.decode(Bool.self, forKey: .alwaysShowStatusVisibilityIcon)
+        self.hideActionsInTimeline = try container.decodeIfPresent(Bool.self, forKey: .hideActionsInTimeline) ?? false
+        self.showLinkPreviews = try container.decodeIfPresent(Bool.self, forKey: .showLinkPreviews) ?? true
+        self.leadingStatusSwipeActions = try container.decodeIfPresent([StatusSwipeAction].self, forKey: .leadingStatusSwipeActions) ?? leadingStatusSwipeActions
+        self.trailingStatusSwipeActions = try container.decodeIfPresent([StatusSwipeAction].self, forKey: .trailingStatusSwipeActions) ?? trailingStatusSwipeActions
+        self.widescreenNavigationMode = try container.decodeIfPresent(WidescreenNavigationMode.self, forKey: .widescreenNavigationMode) ?? Self.defaultWidescreenNavigationMode
+        self.underlineTextLinks = try container.decodeIfPresent(Bool.self, forKey: .underlineTextLinks) ?? false
+        self.showAttachmentsInTimeline = try container.decodeIfPresent(Bool.self, forKey: .showAttachmentsInTimeline) ?? true
+        
+        if let existing = try? container.decode(Visibility.self, forKey: .defaultPostVisibility) {
+            self.defaultPostVisibility = .visibility(existing)
         } else {
-            return PreferenceStore()
+            self.defaultPostVisibility = try container.decode(PostVisibility.self, forKey: .defaultPostVisibility)
+        }
+        self.defaultReplyVisibility = try container.decodeIfPresent(ReplyVisibility.self, forKey: .defaultReplyVisibility) ?? .sameAsPost
+        self.requireAttachmentDescriptions = try container.decode(Bool.self, forKey: .requireAttachmentDescriptions)
+        self.contentWarningCopyMode = try container.decode(ContentWarningCopyMode.self, forKey: .contentWarningCopyMode)
+        self.mentionReblogger = try container.decode(Bool.self, forKey: .mentionReblogger)
+        self.useTwitterKeyboard = try container.decodeIfPresent(Bool.self, forKey: .useTwitterKeyboard) ?? false
+        
+        if let blurAllMedia = try? container.decodeIfPresent(Bool.self, forKey: .blurAllMedia) {
+            self.attachmentBlurMode = blurAllMedia ? .always : .useStatusSetting
+        } else {
+            self.attachmentBlurMode = try container.decode(AttachmentBlurMode.self, forKey: .attachmentBlurMode)
+        }
+        self.blurMediaBehindContentWarning = try container.decodeIfPresent(Bool.self, forKey: .blurMediaBehindContentWarning) ?? true
+        self.automaticallyPlayGifs = try container.decode(Bool.self, forKey: .automaticallyPlayGifs)
+        self.showUncroppedMediaInline = try container.decodeIfPresent(Bool.self, forKey: .showUncroppedMediaInline) ?? true
+        self.showAttachmentBadges = try container.decodeIfPresent(Bool.self, forKey: .showAttachmentBadges) ?? true
+        self.attachmentAltBadgeInverted = try container.decodeIfPresent(Bool.self, forKey: .attachmentAltBadgeInverted) ?? false
+        
+        self.openLinksInApps = try container.decode(Bool.self, forKey: .openLinksInApps)
+        self.useInAppSafari = try container.decode(Bool.self, forKey: .useInAppSafari)
+        self.inAppSafariAutomaticReaderMode = try container.decode(Bool.self, forKey: .inAppSafariAutomaticReaderMode)
+        self.expandAllContentWarnings = try container.decodeIfPresent(Bool.self, forKey: .expandAllContentWarnings) ?? false
+        self.collapseLongPosts = try container.decodeIfPresent(Bool.self, forKey: .collapseLongPosts) ?? true
+        self.oppositeCollapseKeywords = try container.decodeIfPresent([String].self, forKey: .oppositeCollapseKeywords) ?? []
+        self.confirmBeforeReblog = try container.decodeIfPresent(Bool.self, forKey: .confirmBeforeReblog) ?? false
+        self.timelineStateRestoration = try container.decodeIfPresent(Bool.self, forKey: .timelineStateRestoration) ?? true
+        self.timelineSyncMode = try container.decodeIfPresent(TimelineSyncMode.self, forKey: .timelineSyncMode) ?? .icloud
+        self.hideReblogsInTimelines = try container.decodeIfPresent(Bool.self, forKey: .hideReblogsInTimelines) ?? false
+        self.hideRepliesInTimelines = try container.decodeIfPresent(Bool.self, forKey: .hideRepliesInTimelines) ?? false
+        
+        self.showFavoriteAndReblogCounts = try container.decode(Bool.self, forKey: .showFavoriteAndReblogCounts)
+        self.defaultNotificationsMode = try container.decode(NotificationsMode.self, forKey: .defaultNotificationsType)
+        self.grayscaleImages = try container.decodeIfPresent(Bool.self, forKey: .grayscaleImages) ?? false
+        self.disableInfiniteScrolling = try container.decodeIfPresent(Bool.self, forKey: .disableInfiniteScrolling) ?? false
+        self.hideTrends = try container.decodeIfPresent(Bool.self, forKey: .hideTrends) ?? false
+        
+        self.statusContentType = try container.decode(StatusContentType.self, forKey: .statusContentType)
+        self.reportErrorsAutomatically = try container.decodeIfPresent(Bool.self, forKey: .reportErrorsAutomatically) ?? true
+        let featureFlagNames = (try? container.decodeIfPresent([String].self, forKey: .enabledFeatureFlags)) ?? []
+        self.enabledFeatureFlags = Set(featureFlagNames.compactMap(FeatureFlag.init))
+        
+        self.hasShownLocalTimelineDescription = try container.decodeIfPresent(Bool.self, forKey: .hasShownLocalTimelineDescription) ?? false
+        self.hasShownFederatedTimelineDescription = try container.decodeIfPresent(Bool.self, forKey: .hasShownFederatedTimelineDescription) ?? false
+    }
+    
+    public func encode(to encoder: Encoder) throws {
+        var container = encoder.container(keyedBy: CodingKeys.self)
+        
+        try container.encode(theme, forKey: .theme)
+        try container.encode(pureBlackDarkMode, forKey: .pureBlackDarkMode)
+        try container.encode(accentColor, forKey: .accentColor)
+        try container.encode(avatarStyle, forKey: .avatarStyle)
+        try container.encode(hideCustomEmojiInUsernames, forKey: .hideCustomEmojiInUsernames)
+        try container.encode(showIsStatusReplyIcon, forKey: .showIsStatusReplyIcon)
+        try container.encode(alwaysShowStatusVisibilityIcon, forKey: .alwaysShowStatusVisibilityIcon)
+        try container.encode(hideActionsInTimeline, forKey: .hideActionsInTimeline)
+        try container.encode(showLinkPreviews, forKey: .showLinkPreviews)
+        try container.encode(leadingStatusSwipeActions, forKey: .leadingStatusSwipeActions)
+        try container.encode(trailingStatusSwipeActions, forKey: .trailingStatusSwipeActions)
+        try container.encode(widescreenNavigationMode, forKey: .widescreenNavigationMode)
+        try container.encode(underlineTextLinks, forKey: .underlineTextLinks)
+        try container.encode(showAttachmentsInTimeline, forKey: .showAttachmentsInTimeline)
+        
+        try container.encode(defaultPostVisibility, forKey: .defaultPostVisibility)
+        try container.encode(defaultReplyVisibility, forKey: .defaultReplyVisibility)
+        try container.encode(requireAttachmentDescriptions, forKey: .requireAttachmentDescriptions)
+        try container.encode(contentWarningCopyMode, forKey: .contentWarningCopyMode)
+        try container.encode(mentionReblogger, forKey: .mentionReblogger)
+        try container.encode(useTwitterKeyboard, forKey: .useTwitterKeyboard)
+        
+        try container.encode(attachmentBlurMode, forKey: .attachmentBlurMode)
+        try container.encode(blurMediaBehindContentWarning, forKey: .blurMediaBehindContentWarning)
+        try container.encode(automaticallyPlayGifs, forKey: .automaticallyPlayGifs)
+        try container.encode(showUncroppedMediaInline, forKey: .showUncroppedMediaInline)
+        try container.encode(showAttachmentBadges, forKey: .showAttachmentBadges)
+        try container.encode(attachmentAltBadgeInverted, forKey: .attachmentAltBadgeInverted)
+        
+        try container.encode(openLinksInApps, forKey: .openLinksInApps)
+        try container.encode(useInAppSafari, forKey: .useInAppSafari)
+        try container.encode(inAppSafariAutomaticReaderMode, forKey: .inAppSafariAutomaticReaderMode)
+        try container.encode(expandAllContentWarnings, forKey: .expandAllContentWarnings)
+        try container.encode(collapseLongPosts, forKey: .collapseLongPosts)
+        try container.encode(oppositeCollapseKeywords, forKey: .oppositeCollapseKeywords)
+        try container.encode(confirmBeforeReblog, forKey: .confirmBeforeReblog)
+        try container.encode(timelineStateRestoration, forKey: .timelineStateRestoration)
+        try container.encode(timelineSyncMode, forKey: .timelineSyncMode)
+        try container.encode(hideReblogsInTimelines, forKey: .hideReblogsInTimelines)
+        try container.encode(hideRepliesInTimelines, forKey: .hideRepliesInTimelines)
+        
+        try container.encode(showFavoriteAndReblogCounts, forKey: .showFavoriteAndReblogCounts)
+        try container.encode(defaultNotificationsMode, forKey: .defaultNotificationsType)
+        try container.encode(grayscaleImages, forKey: .grayscaleImages)
+        try container.encode(disableInfiniteScrolling, forKey: .disableInfiniteScrolling)
+        try container.encode(hideTrends, forKey: .hideTrends)
+        
+        try container.encode(statusContentType, forKey: .statusContentType)
+        try container.encode(reportErrorsAutomatically, forKey: .reportErrorsAutomatically)
+        try container.encode(enabledFeatureFlags, forKey: .enabledFeatureFlags)
+        
+        try container.encode(hasShownLocalTimelineDescription, forKey: .hasShownLocalTimelineDescription)
+        try container.encode(hasShownFederatedTimelineDescription, forKey: .hasShownFederatedTimelineDescription)
+    }
+    
+    // MARK: Appearance
+    @Published public var theme = UIUserInterfaceStyle.unspecified
+    @Published public var pureBlackDarkMode = true
+    @Published public var accentColor = AccentColor.default
+    @Published public var avatarStyle = AvatarStyle.roundRect
+    @Published public var hideCustomEmojiInUsernames = false
+    @Published public var showIsStatusReplyIcon = false
+    @Published public var alwaysShowStatusVisibilityIcon = false
+    @Published public var hideActionsInTimeline = false
+    @Published public var showLinkPreviews = true
+    @Published public var leadingStatusSwipeActions: [StatusSwipeAction] = [.favorite, .reblog]
+    @Published public var trailingStatusSwipeActions: [StatusSwipeAction] = [.reply, .share]
+    private static var defaultWidescreenNavigationMode = WidescreenNavigationMode.splitScreen
+    @Published public var widescreenNavigationMode  = Preferences.defaultWidescreenNavigationMode
+    @Published public var underlineTextLinks = false
+    @Published public var showAttachmentsInTimeline = true
+    
+    // MARK: Composing
+    @Published public var defaultPostVisibility = PostVisibility.serverDefault
+    @Published public var defaultReplyVisibility = ReplyVisibility.sameAsPost
+    @Published public var requireAttachmentDescriptions = false
+    @Published public var contentWarningCopyMode = ContentWarningCopyMode.asIs
+    @Published public var mentionReblogger = false
+    @Published public var useTwitterKeyboard = false
+    
+    // MARK: Media
+    @Published public var attachmentBlurMode = AttachmentBlurMode.useStatusSetting {
+        didSet {
+            if attachmentBlurMode == .always {
+                blurMediaBehindContentWarning = true
+            } else if attachmentBlurMode == .never {
+                blurMediaBehindContentWarning = false
             }
         }
     }
+    @Published public var blurMediaBehindContentWarning = true
+    @Published public var automaticallyPlayGifs = true
+    @Published public var showUncroppedMediaInline = true
+    @Published public var showAttachmentBadges = true
+    @Published public var attachmentAltBadgeInverted = false
+    
+    // MARK: Behavior
+    @Published public var openLinksInApps = true
+    @Published public var useInAppSafari = true
+    @Published public var inAppSafariAutomaticReaderMode = false
+    @Published public var expandAllContentWarnings = false
+    @Published public var collapseLongPosts = true
+    @Published public var oppositeCollapseKeywords: [String] = []
+    @Published public var confirmBeforeReblog = false
+    @Published public var timelineStateRestoration = true
+    @Published public var timelineSyncMode = TimelineSyncMode.icloud
+    @Published public var hideReblogsInTimelines = false
+    @Published public var hideRepliesInTimelines = false
+    
+    // MARK: Digital Wellness
+    @Published public var showFavoriteAndReblogCounts = true
+    @Published public var defaultNotificationsMode = NotificationsMode.allNotifications
+    @Published public var grayscaleImages = false
+    @Published public var disableInfiniteScrolling = false
+    @Published public var hideTrends = false
+    
+    // MARK: Advanced
+    @Published public var statusContentType: StatusContentType = .plain
+    @Published public var reportErrorsAutomatically = true
+    @Published public var enabledFeatureFlags: Set<FeatureFlag> = []
+    
+    // MARK:
+    @Published public var hasShownLocalTimelineDescription = false
+    @Published public var hasShownFederatedTimelineDescription = false
+    
+    public func hasFeatureFlag(_ flag: FeatureFlag) -> Bool {
+        enabledFeatureFlags.contains(flag)
+    }
+    
+    private enum CodingKeys: String, CodingKey {
+        case theme
+        case pureBlackDarkMode
+        case accentColor
+        case avatarStyle
+        case hideCustomEmojiInUsernames
+        case showIsStatusReplyIcon
+        case alwaysShowStatusVisibilityIcon
+        case hideActionsInTimeline
+        case showLinkPreviews
+        case leadingStatusSwipeActions
+        case trailingStatusSwipeActions
+        case widescreenNavigationMode
+        case underlineTextLinks
+        case showAttachmentsInTimeline
+        
+        case defaultPostVisibility
+        case defaultReplyVisibility
+        case requireAttachmentDescriptions
+        case contentWarningCopyMode
+        case mentionReblogger
+        case useTwitterKeyboard
+        
+        case blurAllMedia // only used for migration
+        case attachmentBlurMode
+        case blurMediaBehindContentWarning
+        case automaticallyPlayGifs
+        case showUncroppedMediaInline
+        case showAttachmentBadges
+        case attachmentAltBadgeInverted
+        
+        case openLinksInApps
+        case useInAppSafari
+        case inAppSafariAutomaticReaderMode
+        case expandAllContentWarnings
+        case collapseLongPosts
+        case oppositeCollapseKeywords
+        case confirmBeforeReblog
+        case timelineStateRestoration
+        case timelineSyncMode
+        case hideReblogsInTimelines
+        case hideRepliesInTimelines
+        
+        case showFavoriteAndReblogCounts
+        case defaultNotificationsType
+        case grayscaleImages
+        case disableInfiniteScrolling
+        case hideTrends = "hideDiscover"
+        
+        case statusContentType
+        case reportErrorsAutomatically
+        case enabledFeatureFlags
+        
+        case hasShownLocalTimelineDescription
+        case hasShownFederatedTimelineDescription
+    }
+    
+}
+
+extension Preferences {
+    public enum AttachmentBlurMode: Codable, Hashable, CaseIterable {
+        case useStatusSetting
+        case always
+        case never
+        
+        public var displayName: String {
+            switch self {
+            case .useStatusSetting:
+                return "Default"
+            case .always:
+                return "Always"
+            case .never:
+                return "Never"
+            }
+        }
+    }
+}
+
+extension UIUserInterfaceStyle: Codable {}
+
+extension Preferences {
+    public enum AccentColor: String, Codable, CaseIterable {
+        case `default`
+        case purple
+        case indigo
+        case blue
+        case cyan
+        case teal
+        case mint
+        case green
+//        case yellow
+        case orange
+        case red
+        case pink
+//        case brown
+        
+        public var color: UIColor? {
+            switch self {
+            case .default:
+                return nil
+            case .blue:
+                return .systemBlue
+//            case .brown:
+//                return .systemBrown
+            case .cyan:
+                return .systemCyan
+            case .green:
+                return .systemGreen
+            case .indigo:
+                return .systemIndigo
+            case .mint:
+                return .systemMint
+            case .orange:
+                return .systemOrange
+            case .pink:
+                return .systemPink
+            case .purple:
+                return .systemPurple
+            case .red:
+                return .systemRed
+            case .teal:
+                return .systemTeal
+//            case .yellow:
+//                return .systemYellow
+            }
+        }
+        
+        public var name: String {
+            switch self {
+            case .default:
+                return "Default"
+            case .blue:
+                return "Blue"
+//            case .brown:
+//                return "Brown"
+            case .cyan:
+                return "Cyan"
+            case .green:
+                return "Green"
+            case .indigo:
+                return "Indigo"
+            case .mint:
+                return "Mint"
+            case .orange:
+                return "Orange"
+            case .pink:
+                return "Pink"
+            case .purple:
+                return "Purple"
+            case .red:
+                return "Red"
+            case .teal:
+                return "Teal"
+//            case .yellow:
+//                return "Yellow"
+            }
+        }
+    }
+}
+
+extension Preferences {
+    public enum TimelineSyncMode: String, Codable {
+        case mastodon
+        case icloud
+    }
+}
+
+extension Preferences {
+    public enum FeatureFlag: String, Codable {
+        case iPadMultiColumn = "ipad-multi-column"
+        case iPadBrowserNavigation = "ipad-browser-navigation"
+    }
+}
+
+extension Preferences {
+    public enum WidescreenNavigationMode: String, Codable {
+        case stack
+        case splitScreen
+        case multiColumn
+    }
+}

Packages/TuskerPreferences/Sources/TuskerPreferences/Supporting Types/AccentColor.swift

@@ -1,86 +0,0 @@
-//
-//  AccentColor.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import UIKit
-
-public enum AccentColor: String, Codable, CaseIterable {
-    case `default`
-    case purple
-    case indigo
-    case blue
-    case cyan
-    case teal
-    case mint
-    case green
-//    case yellow
-    case orange
-    case red
-    case pink
-//    case brown
-    
-    public var color: UIColor? {
-        switch self {
-        case .default:
-            return nil
-        case .blue:
-            return .systemBlue
-//            case .brown:
-//                return .systemBrown
-        case .cyan:
-            return .systemCyan
-        case .green:
-            return .systemGreen
-        case .indigo:
-            return .systemIndigo
-        case .mint:
-            return .systemMint
-        case .orange:
-            return .systemOrange
-        case .pink:
-            return .systemPink
-        case .purple:
-            return .systemPurple
-        case .red:
-            return .systemRed
-        case .teal:
-            return .systemTeal
-//            case .yellow:
-//                return .systemYellow
-        }
-    }
-    
-    public var name: String {
-        switch self {
-        case .default:
-            return "Default"
-        case .blue:
-            return "Blue"
-//            case .brown:
-//                return "Brown"
-        case .cyan:
-            return "Cyan"
-        case .green:
-            return "Green"
-        case .indigo:
-            return "Indigo"
-        case .mint:
-            return "Mint"
-        case .orange:
-            return "Orange"
-        case .pink:
-            return "Pink"
-        case .purple:
-            return "Purple"
-        case .red:
-            return "Red"
-        case .teal:
-            return "Teal"
-//            case .yellow:
-//                return "Yellow"
-        }
-    }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Supporting Types/AttachmentBlurMode.swift

@@ -1,25 +0,0 @@
-//
-//  AttachmentBlurMode.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-public enum AttachmentBlurMode: Codable, Hashable, CaseIterable {
-    case useStatusSetting
-    case always
-    case never
-    
-    public var displayName: String {
-        switch self {
-        case .useStatusSetting:
-            return "Default"
-        case .always:
-            return "Always"
-        case .never:
-            return "Never"
-        }
-    }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Supporting Types/FeatureFlag.swift

@@ -1,13 +0,0 @@
-//
-//  FeatureFlag.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-public enum FeatureFlag: String, Codable {
-    case iPadMultiColumn = "ipad-multi-column"
-    case iPadBrowserNavigation = "ipad-browser-navigation"
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Supporting Types/Theme.swift

@@ -1,24 +0,0 @@
-//
-//  Theme.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-import UIKit
-
-public enum Theme: String, Codable {
-    case unspecified, light, dark
-    
-    public var userInterfaceStyle: UIUserInterfaceStyle {
-        switch self {
-        case .unspecified:
-            .unspecified
-        case .light:
-            .light
-        case .dark:
-            .dark
-        }
-    }
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Supporting Types/TimelineSyncMode.swift

@@ -1,13 +0,0 @@
-//
-//  TimelineSyncMode.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-public enum TimelineSyncMode: String, Codable {
-    case mastodon
-    case icloud
-}

Packages/TuskerPreferences/Sources/TuskerPreferences/Supporting Types/WidescreenNavigationMode.swift

@@ -1,14 +0,0 @@
-//
-//  WidescreenNavigationMode.swift
-//  TuskerPreferences
-//
-//  Created by Shadowfacts on 4/13/24.
-//
-
-import Foundation
-
-public enum WidescreenNavigationMode: String, Codable {
-    case stack
-    case splitScreen
-    case multiColumn
-}

Packages/TuskerPreferences/Tests/TuskerPreferencesTests/PreferenceStoreTests.swift

@@ -1,100 +0,0 @@
-//
-//  PreferenceStoreTests.swift
-//  TuskerPreferencesTests
-//
-//  Created by Shadowfacts on 4/12/24.
-//
-
-import XCTest
-@testable import TuskerPreferences
-import Combine
-
-final class PreferenceStoreTests: XCTestCase {
-    
-    struct TestKey: PreferenceKey {
-        static let defaultValue = false
-    }
-    
-    final class TestStore: Codable, ObservableObject {
-        private var _test = Preference<TestKey>()
-        
-        // the acutal subscript expects the enclosingInstance to be a PreferenceStore, so do it manually
-        var test: Bool {
-            get {
-                Preference.get(enclosingInstance: self, storage: \._test)
-            }
-            set {
-                Preference.set(enclosingInstance: self, storage: \._test, newValue: newValue)
-            }
-        }
-        
-        var testPublisher: some Publisher<TestKey.Value, Never> {
-            _test.projectedValue
-        }
-        
-        init() {
-        }
-        
-        init(from decoder: any Decoder) throws {
-            let container = try decoder.container(keyedBy: CodingKeys.self)
-            self._test = try container.decode(Preference<TestKey>.self, forKey: .test)
-        }
-        
-        enum CodingKeys: CodingKey {
-            case test
-        }
-        
-        func encode(to encoder: any Encoder) throws {
-            var container = encoder.container(keyedBy: CodingKeys.self)
-            try container.encode(self._test, forKey: .test)
-        }
-    }
-
-    func testDecoding() throws {
-        let decoder = JSONDecoder()
-        let present = try decoder.decode(PreferenceCoding<TestStore>.self, from: Data("""
-{"test": true}
-""".utf8)).wrapped
-        XCTAssertEqual(present.test, true)
-        let absent = try decoder.decode(PreferenceCoding<TestStore>.self, from: Data("""
-{}
-""".utf8)).wrapped
-        XCTAssertEqual(absent.test, false)
-    }
-    
-    func testEncoding() throws {
-        let store = TestStore()
-        let encoder = JSONEncoder()
-        XCTAssertEqual(String(data: try encoder.encode(PreferenceCoding(wrapped: store)), encoding: .utf8)!, """
-{}
-""")
-        store.test = true
-        XCTAssertEqual(String(data: try encoder.encode(PreferenceCoding(wrapped: store)), encoding: .utf8)!, """
-{"test":true}
-""")
-        store.test = false
-        XCTAssertEqual(String(data: try encoder.encode(PreferenceCoding(wrapped: store)), encoding: .utf8)!, """
-{"test":false}
-""")
-    }
-    
-    func testPublisher() {
-        let topLevel = expectation(description: "top level publisher")
-        let specificPref = expectation(description: "preference publisher")
-        // initial and on change
-        specificPref.expectedFulfillmentCount = 2
-        let store = TestStore()
-        var cancellables = Set<AnyCancellable>()
-        store.objectWillChange.sink {
-            topLevel.fulfill()
-            // fires on will change
-            XCTAssertEqual(store.test, false)
-        }.store(in: &cancellables)
-        store.testPublisher.sink { _ in
-            specificPref.fulfill()
-        }.store(in: &cancellables)
-        store.test = true
-        wait(for: [topLevel, specificPref])
-    }
-
-}

Packages/UserAccounts/Sources/UserAccounts/UserAccountsManager.swift

@@ -8,8 +8,7 @@
 import Foundation
 import Combine
 
-// Sendability: UserDefaults is not marked Sendable, but is documented as being thread safe
-public final class UserAccountsManager: ObservableObject, @unchecked Sendable {
+public class UserAccountsManager: ObservableObject {
     
     public static let shared = UserAccountsManager()
     

Tusker.xcodeproj/project.pbxproj

@@ -713,7 +713,6 @@
 		D6C3F4FA299035650009FCFF /* TrendsViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TrendsViewController.swift; sourceTree = "<group>"; };
 		D6C3F5162991C1A00009FCFF /* View+AppListStyle.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "View+AppListStyle.swift"; sourceTree = "<group>"; };
 		D6C3F5182991F5D60009FCFF /* TimelineJumpButton.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TimelineJumpButton.swift; sourceTree = "<group>"; };
-		D6C4532A2BCAD7F900E26A0E /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
 		D6C693EE216192C2007D6A6D /* TuskerNavigationDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TuskerNavigationDelegate.swift; sourceTree = "<group>"; };
 		D6C693FB2162FE6F007D6A6D /* LoadingViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LoadingViewController.swift; sourceTree = "<group>"; };
 		D6C693FD2162FEEA007D6A6D /* UIViewController+Children.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = "UIViewController+Children.swift"; sourceTree = "<group>"; };
@@ -1010,7 +1009,6 @@
 				D630C3D92BC61B6100208903 /* NotificationExtension.entitlements */,
 				D630C3D32BC61B6100208903 /* NotificationService.swift */,
 				D630C3D52BC61B6100208903 /* Info.plist */,
-				D6C4532A2BCAD7F900E26A0E /* PrivacyInfo.xcprivacy */,
 			);
 			path = NotificationExtension;
 			sourceTree = "<group>";

Tusker/API/LogoutService.swift

@@ -23,10 +23,10 @@ class LogoutService {
     
     func run() {
         let accountInfo = self.accountInfo
-        Task.detached { @MainActor in
-            if PushManager.shared.pushSubscription(account: accountInfo) != nil {
+        Task.detached {
+            if await PushManager.shared.pushSubscription(account: accountInfo) != nil {
                 _ = try? await self.mastodonController.run(Pachyderm.PushSubscription.delete())
-                PushManager.shared.removeSubscription(account: accountInfo)
+                await PushManager.shared.removeSubscription(account: accountInfo)
             }
             try? await self.mastodonController.client.revokeAccessToken()
         }

Tusker/API/MastodonController+Push.swift

@@ -33,13 +33,7 @@ extension MastodonController {
 
     func updatePushSubscription(alerts: PushNotifications.PushSubscription.Alerts, policy: PushNotifications.PushSubscription.Policy) async throws -> Pachyderm.PushSubscription {
         let req = Pachyderm.PushSubscription.update(alerts: .init(alerts), policy: .init(policy))
-        var result = try await run(req).0
-        if instanceFeatures.pushNotificationPolicyMissingFromResponse {
-            // see https://github.com/mastodon/mastodon/issues/23145
-            // so just assume if the request was successful that it worked
-            result.policy = .init(policy)
-        }
-        return result
+        return try await run(req).0
     }
     
     func deletePushSubscription() async throws {

Tusker/AppDelegate.swift

@@ -54,12 +54,21 @@ class AppDelegate: UIResponder, UIApplicationDelegate {
             }
         }
         
+        let documentsDirectory = FileManager.default.urls(for: .documentDirectory, in: .userDomainMask).first!
+        let oldPreferencesFile = documentsDirectory.appendingPathComponent("preferences").appendingPathExtension("plist")
+        if FileManager.default.fileExists(atPath: oldPreferencesFile.path) {
+            if case .failure(let error) = Preferences.migrate(from: oldPreferencesFile) {
+                #if canImport(Sentry)
+                SentrySDK.capture(error: error)
+                #endif
+            }
+        }
+        
         // make sure the persistent container is initialized on the main thread
         // otherwise initializing it on the background thread can deadlock with accessing it on the main thread elsewhere
         _ = DraftsPersistentContainer.shared
         
         DispatchQueue.global(qos: .userInitiated).async {
-            let documentsDirectory = FileManager.default.urls(for: .documentDirectory, in: .userDomainMask).first!
             let oldDraftsFile = documentsDirectory.appendingPathComponent("drafts").appendingPathExtension("plist")
             let appGroupDraftsFile = FileManager.default.containerURL(forSecurityApplicationGroupIdentifier: "group.space.vaccor.Tusker")!.appendingPathComponent("drafts").appendingPathExtension("plist")
             for url in [oldDraftsFile, appGroupDraftsFile] where FileManager.default.fileExists(atPath: url.path) {

Tusker/Scenes/TuskerSceneDelegate.swift

@@ -33,7 +33,7 @@ extension TuskerSceneDelegate {
     
     func applyAppearancePreferences() {
         guard let window else { return }
-        window.overrideUserInterfaceStyle = Preferences.shared.theme.userInterfaceStyle
+        window.overrideUserInterfaceStyle = Preferences.shared.theme
         window.tintColor = Preferences.shared.accentColor.color
         #if os(visionOS)
         window.traitOverrides.pureBlackDarkMode = Preferences.shared.pureBlackDarkMode

Tusker/Screens/Main/MainSplitViewController.swift

@@ -8,7 +8,6 @@
 
 import UIKit
 import Combine
-import TuskerPreferences
 
 class MainSplitViewController: UISplitViewController {
 
@@ -22,7 +21,7 @@ class MainSplitViewController: UISplitViewController {
     
     private var tabBarViewController: MainTabBarViewController!
     
-    private var navigationMode: WidescreenNavigationMode!
+    private var navigationMode: Preferences.WidescreenNavigationMode!
     private var secondaryNavController: NavigationControllerProtocol! {
         viewController(for: .secondary) as? NavigationControllerProtocol
     }
@@ -114,7 +113,7 @@ class MainSplitViewController: UISplitViewController {
             .store(in: &cancellables)
     }
     
-    private func updateNavigationMode(_ mode: WidescreenNavigationMode) {
+    private func updateNavigationMode(_ mode: Preferences.WidescreenNavigationMode) {
         guard mode != navigationMode else {
             return
         }

Tusker/Screens/Preferences/About/AboutView.swift

@@ -59,12 +59,7 @@ struct AboutView: View {
                     }
                 } label: {
                     HStack {
-                        Label {
-                            Text("Get Support")
-                        } icon: {
-                            Image(systemName: "envelope")
-                                .foregroundStyle(.tint)
-                        }
+                        Label("Get Support", systemImage: "envelope")
                         Spacer()
                         if isGettingLogData {
                             ProgressView()
@@ -80,6 +75,7 @@ struct AboutView: View {
                     Label("Issue Tracker", systemImage: "checklist")
                 }
             }
+            .labelStyle(AboutLinksLabelStyle())
             .appGroupedListRowBackground()
         }
         .listStyle(.insetGrouped)
@@ -178,6 +174,15 @@ private struct MailSheet: UIViewControllerRepresentable {
     }
 }
 
+private struct AboutLinksLabelStyle: LabelStyle {
+    func makeBody(configuration: Configuration) -> some View {
+        HStack(alignment: .lastTextBaseline, spacing: 8) {
+            configuration.icon
+            configuration.title
+        }
+    }
+}
+
 struct AboutView_Previews: PreviewProvider {
     static var previews: some View {
         AboutView()

Tusker/Screens/Preferences/About/FlipView.swift

@@ -107,7 +107,7 @@ struct FlipEffect: GeometryEffect {
 }
 
 private struct WidthPrefKey: PreferenceKey {
-    static let defaultValue: CGFloat = 0
+    static var defaultValue: CGFloat = 0
     
     static func reduce(value: inout CGFloat, nextValue: () -> CGFloat) {
         value = nextValue()

Tusker/Screens/Preferences/AcknowledgementsView.swift

@@ -292,7 +292,7 @@ private extension AttributeScopes {
 private enum HeadingLevelAttributes: CodableAttributedStringKey, MarkdownDecodableAttributedStringKey {
     public typealias Value = Int
 
-    public static let name = "headingLevel"
+    public static var name = "headingLevel"
 }
 
 private extension AttributeDynamicLookup {

Tusker/Screens/Preferences/AdvancedPrefsView.swift

@@ -10,7 +10,6 @@ import Pachyderm
 import CoreData
 import CloudKit
 import UserAccounts
-import TuskerPreferences
 
 struct AdvancedPrefsView : View {
     @ObservedObject var preferences = Preferences.shared
@@ -42,7 +41,7 @@ struct AdvancedPrefsView : View {
             
             Button("Cancel", role: .cancel) {}
             Button("Enable") {
-                if let flag = FeatureFlag(rawValue: featureFlagName) {
+                if let flag = Preferences.FeatureFlag(rawValue: featureFlagName) {
                     preferences.enabledFeatureFlags.insert(flag)
                 }
             }

Tusker/Screens/Preferences/AppearancePrefsView.swift

@@ -7,7 +7,6 @@
 
 import SwiftUI
 import Combine
-import TuskerPreferences
 
 struct AppearancePrefsView : View {
     @ObservedObject var preferences = Preferences.shared
@@ -28,7 +27,7 @@ struct AppearancePrefsView : View {
         Preferences.shared.avatarStyle = $0 ? .circle : .roundRect
     }
     
-    private let accentColorsAndImages: [(AccentColor, UIImage?)] = AccentColor.allCases.map { color in
+    private let accentColorsAndImages: [(Preferences.AccentColor, UIImage?)] = Preferences.AccentColor.allCases.map { color in
         var image: UIImage?
         if let color = color.color {
             if #available(iOS 16.0, *) {

Tusker/Screens/Preferences/BehaviorPrefsView.swift

@@ -7,7 +7,6 @@
 
 import SwiftUI
 import Pachyderm
-import TuskerPreferences
 
 struct BehaviorPrefsView: View {
     @ObservedObject var preferences = Preferences.shared
@@ -40,8 +39,8 @@ struct BehaviorPrefsView: View {
             }
             
             Picker(selection: $preferences.timelineSyncMode) {
-                Text("iCloud").tag(TimelineSyncMode.icloud)
-                Text("Mastodon").tag(TimelineSyncMode.mastodon)
+                Text("iCloud").tag(Preferences.TimelineSyncMode.icloud)
+                Text("Mastodon").tag(Preferences.TimelineSyncMode.mastodon)
             } label: {
                 Text("Sync Timeline Position via")
             }

Tusker/Screens/Preferences/MediaPrefsView.swift

@@ -7,7 +7,6 @@
 //
 
 import SwiftUI
-import TuskerPreferences
 
 struct MediaPrefsView: View {
     @ObservedObject var preferences = Preferences.shared
@@ -24,7 +23,7 @@ struct MediaPrefsView: View {
     var viewingSection: some View {
         Section(header: Text("Viewing")) {
             Picker(selection: $preferences.attachmentBlurMode) {
-                ForEach(AttachmentBlurMode.allCases, id: \.self) { mode in
+                ForEach(Preferences.AttachmentBlurMode.allCases, id: \.self) { mode in
                     Text(mode.displayName).tag(mode)
                 }
             } label: {

Tusker/Screens/Preferences/Notifications/NotificationsPrefsView.swift

@@ -13,6 +13,7 @@ import PushNotifications
 import TuskerComponents
 
 struct NotificationsPrefsView: View {
+    @State private var error: NotificationsSetupError?
     @ObservedObject private var userAccounts = UserAccountsManager.shared
     
     var body: some View {
@@ -47,3 +48,14 @@ struct NotificationsPrefsView: View {
         .navigationTitle("Notifications")
     }
 }
+
+private enum NotificationsSetupError: LocalizedError {
+    case requestingAuthorization(any Error)
+    
+    var errorDescription: String? {
+        switch self {
+        case .requestingAuthorization(let error):
+            "Notifications authorization request failed: \(error.localizedDescription)"
+        }
+    }
+}

Tusker/Screens/Preferences/Notifications/PushInstanceSettingsView.swift

@@ -14,7 +14,6 @@ import TuskerComponents
 
 struct PushInstanceSettingsView: View {
     let account: UserAccountInfo
-    let mastodonController: MastodonController
     @State private var mode: AsyncToggle.Mode
     @State private var error: Error?
     @State private var subscription: PushNotifications.PushSubscription?
@@ -23,7 +22,6 @@ struct PushInstanceSettingsView: View {
     @MainActor
     init(account: UserAccountInfo) {
         self.account = account
-        self.mastodonController = .getForAccount(account)
         let subscription = PushManager.shared.pushSubscription(account: account)
         self.subscription = subscription
         self.mode = subscription == nil ? .off : .on
@@ -37,7 +35,7 @@ struct PushInstanceSettingsView: View {
                 AsyncToggle("\(account.instanceURL.host!) notifications enabled", labelHidden: true, mode: $mode, onChange: updateNotificationsEnabled(enabled:))
                     .labelsHidden()
             }
-            PushSubscriptionView(account: account, mastodonController: mastodonController, subscription: subscription, updateSubscription: updateSubscription)
+            PushSubscriptionView(account: account, subscription: subscription, updateSubscription: updateSubscription)
         }
         .alertWithData("An Error Occurred", data: $error) { data in
             Button("OK") {}

Tusker/Screens/Preferences/Notifications/PushSubscriptionView.swift

@@ -13,13 +13,12 @@ import TuskerComponents
 
 struct PushSubscriptionView: View {
     let account: UserAccountInfo
-    let mastodonController: MastodonController
     let subscription: PushSubscription?
     let updateSubscription: (PushSubscription.Alerts, PushSubscription.Policy) async -> Bool
 
     var body: some View {
         if let subscription {
-            PushSubscriptionSettingsView(account: account, mastodonController: mastodonController, subscription: subscription, updateSubscription: updateSubscription)
+            PushSubscriptionSettingsView(account: account, subscription: subscription, updateSubscription: updateSubscription)
         } else {
             Text("No notifications")
                 .font(.callout)
@@ -30,16 +29,20 @@ struct PushSubscriptionView: View {
 
 private struct PushSubscriptionSettingsView: View {
     let account: UserAccountInfo
-    let mastodonController: MastodonController
     let subscription: PushSubscription
     let updateSubscription: (PushSubscription.Alerts, PushSubscription.Policy) async -> Bool
     @State private var isLoading: [PushSubscription.Alerts: Bool] = [:]
     
+    init(account: UserAccountInfo, subscription: PushSubscription, updateSubscription: @escaping (PushSubscription.Alerts, PushSubscription.Policy) async -> Bool) {
+        self.account = account
+        self.subscription = subscription
+        self.updateSubscription = updateSubscription
+    }
+    
     var body: some View {
         VStack {
             alertsToggles
             
-            if mastodonController.instanceFeatures.pushNotificationPolicy {
             AsyncPicker("From", alignment: .trailing, value: .constant(subscription.policy)) { newPolicy in
                 await updateSubscription(subscription.alerts, newPolicy)
             } content: {
@@ -49,7 +52,6 @@ private struct PushSubscriptionSettingsView: View {
             }
             .pickerStyle(.menu)
         }
-        }
         // this is the default value of the alignment guide, but this modifier is loading bearing
         .alignmentGuide(.prefsAvatar, computeValue: { dimension in
             dimension[.leading]
@@ -61,35 +63,18 @@ private struct PushSubscriptionSettingsView: View {
     private var alertsToggles: some View {
         GroupBox("Get notifications for") {
             VStack {
-                toggle("All", alert: allSupportedAlertTypes)
+                toggle("All", alert: [.mention, .favorite, .reblog, .follow, .followRequest, .poll, .update])
                 toggle("Mentions", alert: .mention)
                 toggle("Favorites", alert: .favorite)
                 toggle("Reblogs", alert: .reblog)
-                if mastodonController.instanceFeatures.pushNotificationTypeFollowRequest {
                 toggle("Follows", alert: [.follow, .followRequest])
-                } else {
-                    toggle("Follows", alert: .follow)
-                }
                 toggle("Polls finishing", alert: .poll)
-                if mastodonController.instanceFeatures.pushNotificationTypeUpdate {
                 toggle("Edits", alert: .update)
-                }
                 // status notifications not supported until we can enable/disable them in the app
             }
         }
     }
     
-    private var allSupportedAlertTypes: PushSubscription.Alerts {
-        var alerts: PushSubscription.Alerts = [.mention, .favorite, .reblog, .follow, .poll]
-        if mastodonController.instanceFeatures.pushNotificationTypeFollowRequest {
-            alerts.insert(.followRequest)
-        }
-        if mastodonController.instanceFeatures.pushNotificationTypeUpdate {
-            alerts.insert(.update)
-        }
-        return alerts
-    }
-    
     private func toggle(_ titleKey: LocalizedStringKey, alert: PushSubscription.Alerts) -> some View {
         let binding: Binding<AsyncToggle.Mode> = Binding {
             isLoading[alert] == true ? .loading : subscription.alerts.contains(alert) ? .on : .off

Tusker/Screens/Preferences/Tip Jar/ConfettiView.swift

@@ -59,7 +59,7 @@ struct ConfettiView: View {
 }
 
 private struct SizeKey: PreferenceKey {
-    static let defaultValue: CGSize = .zero
+    static var defaultValue: CGSize = .zero
     static func reduce(value: inout CGSize, nextValue: () -> CGSize) {
         value = nextValue()
     }

Tusker/Screens/Preferences/Tip Jar/TipJarView.swift

@@ -44,7 +44,7 @@ struct TipJarView: View {
             Text(error.localizedDescription)
         })
         .task {
-            updatesObserver = Task.detached { @MainActor in
+            updatesObserver = Task.detached {
                 await observeTransactionUpdates()
             }
             do {
@@ -95,7 +95,6 @@ struct TipJarView: View {
         }
     }
     
-    @MainActor
     private func observeTransactionUpdates() async {
         for await verificationResult in StoreKit.Transaction.updates {
             guard let index = products.firstIndex(where: { $0.0.id == verificationResult.unsafePayloadValue.productID }) else {
@@ -176,7 +175,6 @@ private struct TipRow: View {
         }
     }
     
-    @MainActor
     private func purchase() async {
         isPurchasing = true
         let result: Product.PurchaseResult
@@ -231,7 +229,7 @@ extension HorizontalAlignment {
 }
 
 private struct ButtonWidthKey: PreferenceKey {
-    static let defaultValue: CGFloat = 0
+    static var defaultValue: CGFloat = 0
     static func reduce(value: inout CGFloat, nextValue: () -> CGFloat) {
         value = max(value, nextValue())
     }

Tusker/Screens/Preferences/WidescreenNavigationPrefsView.swift

@@ -8,7 +8,6 @@
 
 import SwiftUI
 import Combine
-import TuskerPreferences
 
 struct WidescreenNavigationPrefsView: View {
     @ObservedObject private var preferences = Preferences.shared
@@ -60,8 +59,8 @@ struct WidescreenNavigationPrefsView: View {
 }
 
 private struct OptionView<Content: NavigationModePreview>: View {
-    let value: WidescreenNavigationMode
-    @Binding var selection: WidescreenNavigationMode
+    let value: Preferences.WidescreenNavigationMode
+    @Binding var selection: Preferences.WidescreenNavigationMode
     let startAnimation: PassthroughSubject<Void, Never>
     @ViewBuilder let label: Text
     @Environment(\.colorScheme) private var colorScheme