Enable libdispatch cooperative pool strict mode in debug

Pachyderm/Client.swift

@@ -101,6 +101,19 @@ public class Client {
         return task
     }
     
+    public func run<Result>(_ request: Request<Result>) async throws -> (Result, Pagination?) {
+        return try await withCheckedThrowingContinuation { continuation in
+            run(request) { response in
+                switch response {
+                case let .failure(error):
+                    continuation.resume(throwing: error)
+                case let .success(result, pagination):
+                    continuation.resume(returning: (result, pagination))
+                }
+            }
+        }
+    }
+    
     func createURLRequest<Result>(request: Request<Result>) -> URLRequest? {
         guard var components = URLComponents(url: baseURL, resolvingAgainstBaseURL: true) else { return nil }
         components.path = request.path
@@ -117,24 +130,21 @@ public class Client {
     }
     
     // MARK: - Authorization
-    public func registerApp(name: String, redirectURI: String, scopes: [Scope], website: URL? = nil, completion: @escaping Callback<RegisteredApplication>) {
+    public func registerApp(name: String, redirectURI: String, scopes: [Scope], website: URL? = nil) async throws -> RegisteredApplication {
         let request = Request<RegisteredApplication>(method: .post, path: "/api/v1/apps", body: ParametersBody([
                 "client_name" => name,
                 "redirect_uris" => redirectURI,
                 "scopes" => scopes.scopeString,
                 "website" => website?.absoluteString
             ]))
-        run(request) { result in
-            defer { completion(result) }
-            guard case let .success(application, _) = result else { return }
-            
+        let (application, _) = try await run(request)
         self.appID = application.id
         self.clientID = application.clientID
         self.clientSecret = application.clientSecret
-        }
+        return application
     }
     
-    public func getAccessToken(authorizationCode: String, redirectURI: String, completion: @escaping Callback<LoginSettings>) {
+    public func getAccessToken(authorizationCode: String, redirectURI: String) async throws -> LoginSettings {
         let request = Request<LoginSettings>(method: .post, path: "/oauth/token", body: ParametersBody([
                 "client_id" => clientID,
                 "client_secret" => clientSecret,
@@ -142,12 +152,9 @@ public class Client {
                 "code" => authorizationCode,
                 "redirect_uri" => redirectURI
             ]))
-        run(request) { result in
-            defer { completion(result) }
-            guard case let .success(loginSettings, _) = result else { return }
-            
-            self.accessToken = loginSettings.accessToken
-        }
+        let (settings, _) = try await run(request)
+        self.accessToken = settings.accessToken
+        return settings
     }
     
     // MARK: - Self

Tusker.xcodeproj/project.pbxproj

@@ -2342,6 +2342,7 @@
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				INFOPLIST_FILE = Pachyderm/Info.plist;
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
+				IPHONEOS_DEPLOYMENT_TARGET = 15.0;
 				"IPHONEOS_DEPLOYMENT_TARGET[sdk=macosx*]" = 14.3;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",
@@ -2373,6 +2374,7 @@
 				DYLIB_INSTALL_NAME_BASE = "@rpath";
 				INFOPLIST_FILE = Pachyderm/Info.plist;
 				INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
+				IPHONEOS_DEPLOYMENT_TARGET = 15.0;
 				"IPHONEOS_DEPLOYMENT_TARGET[sdk=macosx*]" = 14.3;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",
@@ -2560,7 +2562,7 @@
 				CURRENT_PROJECT_VERSION = 19;
 				DEVELOPMENT_TEAM = V4WK9KR9U2;
 				INFOPLIST_FILE = Tusker/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 14.1;
+				IPHONEOS_DEPLOYMENT_TARGET = 15.0;
 				"IPHONEOS_DEPLOYMENT_TARGET[sdk=macosx*]" = 14.3;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",
@@ -2593,7 +2595,7 @@
 				CURRENT_PROJECT_VERSION = 19;
 				DEVELOPMENT_TEAM = V4WK9KR9U2;
 				INFOPLIST_FILE = Tusker/Info.plist;
-				IPHONEOS_DEPLOYMENT_TARGET = 14.1;
+				IPHONEOS_DEPLOYMENT_TARGET = 15.0;
 				"IPHONEOS_DEPLOYMENT_TARGET[sdk=macosx*]" = 14.3;
 				LD_RUNPATH_SEARCH_PATHS = (
 					"$(inherited)",

Tusker.xcodeproj/xcshareddata/xcschemes/Tusker.xcscheme

@@ -99,6 +99,11 @@
             value = "1"
             isEnabled = "NO">
          </EnvironmentVariable>
+         <EnvironmentVariable
+            key = "LIBDISPATCH_COOPERATIVE_POOL_STRICT"
+            value = "1"
+            isEnabled = "YES">
+         </EnvironmentVariable>
       </EnvironmentVariables>
    </LaunchAction>
    <ProfileAction

Tusker.xcworkspace/xcshareddata/swiftpm/Package.resolved

@@ -2,7 +2,7 @@
   "object": {
     "pins": [
       {
-        "package": "PLCrashReporter",
+        "package": "plcrashreporter",
         "repositoryURL": "https://github.com/microsoft/plcrashreporter",
         "state": {
           "branch": null,

Tusker/Controllers/MastodonController.swift

@@ -46,8 +46,8 @@ class MastodonController: ObservableObject {
     @Published private(set) var instance: Instance!
     private(set) var customEmojis: [Emoji]?
     
-    private var pendingOwnInstanceRequestCallbacks = [(Instance) -> Void]()
-    private var ownInstanceRequest: URLSessionTask?
+    @MainActor private var pendingOwnInstanceRequestCallbacks = [(Instance) -> Void]()
+    @MainActor private var ownInstanceRequest: URLSessionTask?
     
     var loggedIn: Bool {
         accountInfo != nil
@@ -65,28 +65,22 @@ class MastodonController: ObservableObject {
         return client.run(request, completion: completion)
     }
     
-    func registerApp(completion: @escaping (_ clientID: String, _ clientSecret: String) -> Void) {
+    @discardableResult
+    func run<Result>(_ request: Request<Result>) async throws -> (Result, Pagination?) {
+        return try await client.run(request)
+    }
+    
+    func registerApp() async -> (String, String) {
         guard client.clientID == nil,
               client.clientSecret == nil else {
-                
-                completion(client.clientID!, client.clientSecret!)
-                return
+                  return (client.clientID!, client.clientSecret!)
+              }
+        let app = try! await client.registerApp(name: "Tusker", redirectURI: "tusker://oauth", scopes: [.read, .write, .follow])
+        return (app.clientID, app.clientSecret)
     }
     
-        client.registerApp(name: "Tusker", redirectURI: "tusker://oauth", scopes: [.read, .write, .follow]) { response in
-            guard case let .success(app, _) = response else { fatalError() }
-            self.client.clientID = app.clientID
-            self.client.clientSecret = app.clientSecret
-            completion(app.clientID, app.clientSecret)
-        }
-    }
-    
-    func authorize(authorizationCode: String, completion: @escaping (_ accessToken: String) -> Void) {
-        client.getAccessToken(authorizationCode: authorizationCode, redirectURI: "tusker://oauth") { response in
-            guard case let .success(settings, _) = response else { fatalError() }
-            self.client.accessToken = settings.accessToken
-            completion(settings.accessToken)
-        }
+    func authorize(authorizationCode: String) async -> String {
+        return try! await client.getAccessToken(authorizationCode: authorizationCode, redirectURI: "tusker://oauth").accessToken
     }
     
     func getOwnAccount(completion: ((Result<Account, Client.Error>) -> Void)? = nil) {
@@ -118,14 +112,19 @@ class MastodonController: ObservableObject {
         }
     }
     
+    func getOwnAccount() async throws -> Account {
+        return try await withCheckedThrowingContinuation { continuation in
+            getOwnAccount(completion: continuation.resume)
+        }
+    }
+    
+    @MainActor
     func getOwnInstance(completion: ((Instance) -> Void)? = nil) {
         getOwnInstanceInternal(retryAttempt: 0, completion: completion)
     }
     
+    @MainActor
     private func getOwnInstanceInternal(retryAttempt: Int, completion: ((Instance) -> Void)?) {
-        // this is main thread only to prevent concurrent access to ownInstanceRequest and pendingOwnInstanceRequestCallbacks
-        assert(Thread.isMainThread)
-        
         if let instance = self.instance {
             completion?(instance)
         } else {

Tusker/Models/CompositionAttachmentData.swift

@@ -104,6 +104,14 @@ enum CompositionAttachmentData {
         }
     }
     
+    func getData() async -> (Data, String) {
+        return await withCheckedContinuation { continuation in
+            getData { data, mimeType in
+                continuation.resume(returning: (data, mimeType))
+            }
+        }
+    }
+    
     private static func exportVideoData(session: AVAssetExportSession, completion: @escaping (Data, String) -> Void) {
         session.outputFileType = .mp4
         session.outputURL = FileManager.default.temporaryDirectory.appendingPathComponent("exported_video_\(UUID())").appendingPathExtension("mp4")

Tusker/Screens/Compose/ComposeView.swift

@@ -19,7 +19,7 @@ struct ComposeView: View {
     @State private var postProgress: Double = 0
     @State private var postTotalProgress: Double = 0
     @State private var isShowingPostErrorAlert = false
-    @State private var postError: PostError?
+    @State private var postError: Error?
     
     private let stackPadding: CGFloat = 8
     
@@ -148,7 +148,11 @@ struct ComposeView: View {
     }
     
     private var postButton: some View {
-        Button(action: self.postStatus) {
+        Button {
+            async {
+                await self.postStatus()
+            }
+        } label: {
             Text("Post")
         }
         .disabled(!postButtonEnabled)
@@ -190,7 +194,7 @@ struct ComposeView: View {
         ])
     }
     
-    private func postStatus() {
+    private func postStatus() async {
         guard draft.hasContent else { return }
         
         isPosting = true
@@ -205,16 +209,18 @@ struct ComposeView: View {
         postTotalProgress = Double(2 + (draft.attachments.count * 2))
         postProgress = 1
         
-        uploadAttachments { (result) in
-            switch result {
-            case let .failure(error):
+        let uploadedAttachments: [Attachment]
+        do {
+            uploadedAttachments = try await uploadAttachments()
+        } catch {
             self.isShowingPostErrorAlert = true
             self.postError = error
             self.postProgress = 0
             self.postTotalProgress = 0
             self.isPosting = false
+            return
+        }
         
-            case let .success(uploadedAttachments):
         let request = Client.createStatus(text: draft.textForPosting,
                                           contentType: Preferences.shared.statusContentType,
                                           inReplyTo: draft.inReplyToID,
@@ -226,13 +232,8 @@ struct ComposeView: View {
                                           pollOptions: draft.poll?.options.map(\.text),
                                           pollExpiresIn: draft.poll == nil ? nil : Int(draft.poll!.duration),
                                           pollMultiple: draft.poll?.multiple)
-                self.mastodonController.run(request) { (response) in
-                    switch response {
-                    case let .failure(error):
-                        self.isShowingPostErrorAlert = true
-                        self.postError = error
-
-                    case .success(_, _):
+        do {
+            try await mastodonController.run(request)
             self.postProgress += 1
             
             DraftsManager.shared.remove(self.draft)
@@ -241,35 +242,25 @@ struct ComposeView: View {
             DispatchQueue.main.asyncAfter(deadline: .now() + .milliseconds(250)) {
                 self.uiState.delegate?.dismissCompose(mode: .post)
             }
-                    }
-                }
-            }
+        } catch {
+            self.isShowingPostErrorAlert = true
+            self.postError = error
         }
     }
     
-    private func uploadAttachments(_ completion: @escaping (Result<[Attachment], AttachmentUploadError>) -> Void) {
-        let group = DispatchGroup()
+    private func uploadAttachments() async throws -> [Attachment] {
+        guard !draft.attachments.isEmpty else {
+            return []
+        }
         
-        var attachmentDatas = [(Data, String)?]()
-        
-        for (index, compAttachment) in draft.attachments.enumerated() {
-            group.enter()
-            
-            attachmentDatas.append(nil)
-            
-            compAttachment.data.getData { (data, mimeType) in
+        return try await withThrowingTaskGroup(of: (CompositionAttachment, (Data, String)).self) { taskGroup in
+            for compAttachment in draft.attachments {
                 postProgress += 1
-                
-                attachmentDatas[index] = (data, mimeType)
-                group.leave()
+                taskGroup.async {
+                    return (compAttachment, await compAttachment.data.getData())
                 }
             }
 
-        group.notify(queue: .global(qos: .userInitiated)) {
-            
-            var anyFailed = false
-            var uploadedAttachments = [Result<Attachment, Error>?]()
-        
             // Mastodon does not respect the order of the `media_ids` parameter in the create post request,
             // it determines attachment order by which was uploaded first. Since the upload attachment request
             // does not include any timestamp data, and requests may arrive at the server out-of-order,
@@ -277,67 +268,40 @@ struct ComposeView: View {
             // posted status reflects order the user set.
             // Pleroma does respect the order of the `media_ids` parameter.
             
-            for (index, (data, mimeType)) in attachmentDatas.map(\.unsafelyUnwrapped).enumerated() {
-                group.enter()
+            var anyFailed = false
+            var uploaded = [Result<Attachment, Error>]()
             
-                let compAttachment = draft.attachments[index]
+            for try await (compAttachment, (data, mimeType)) in taskGroup {
                 let formAttachment = FormAttachment(mimeType: mimeType, data: data, fileName: "file")
                 let request = Client.upload(attachment: formAttachment, description: compAttachment.attachmentDescription)
-                self.mastodonController.run(request) { (response) in
-                    switch response {
-                    case let .failure(error):
-                        uploadedAttachments.append(.failure(error))
+
+                do {
+                    let (uploadedAttachment, _) = try await mastodonController.run(request)
+                    uploaded.append(.success(uploadedAttachment))
+                    postProgress += 1
+                } catch {
+                    uploaded.append(.failure(error))
                     anyFailed = true
-                        
-                    case let .success(attachment, _):
-                        self.postProgress += 1
-                        uploadedAttachments.append(.success(attachment))
                 }
-                    
-                    group.leave()
             }
 
-                group.wait()
-            }
-            
-            
             if anyFailed {
-                let errors = uploadedAttachments.map { (result) -> Error? in
+                let errors = uploaded.map { result -> Error? in
                     if case let .failure(error) = result {
                         return error
                     } else {
                         return nil
                     }
                 }
-                completion(.failure(AttachmentUploadError(errors: errors)))
+                throw AttachmentUploadError(errors: errors)
             } else {
-                let uploadedAttachments = uploadedAttachments.map {
-                    try! $0!.get()
+                return uploaded.map { try! $0.get() }
             }
-                completion(.success(uploadedAttachments))
-            }
-
         }
     }
 }
 
-fileprivate protocol PostError: LocalizedError {}
-
-extension PostError {
-    var localizedDescription: String {
-        if let self = self as? Client.Error {
-            return self.localizedDescription
-        } else if let self = self as? AttachmentUploadError {
-            return self.localizedDescription
-        } else {
-            return "Unknown Error"
-        }
-    }
-}
-
-extension Client.Error: PostError {}
-
-fileprivate struct AttachmentUploadError: PostError {
+fileprivate struct AttachmentUploadError: LocalizedError {
     let errors: [Error?]
     
     var localizedDescription: String {

Tusker/Screens/Onboarding/OnboardingViewController.swift

@@ -8,6 +8,7 @@
 
 import UIKit
 import AuthenticationServices
+import Pachyderm
 
 protocol OnboardingViewControllerDelegate {
     func didFinishOnboarding(account: LocalData.UserAccountInfo)
@@ -41,52 +42,18 @@ class OnboardingViewController: UINavigationController {
         instanceSelector.delegate = self
     }
     
-}
-
-extension OnboardingViewController: InstanceSelectorTableViewControllerDelegate {
-    func didSelectInstance(url instanceURL: URL) {
-        let mastodonController = MastodonController(instanceURL: instanceURL)
-        mastodonController.registerApp { (clientID, clientSecret) in
-
-            var components = URLComponents(url: instanceURL, resolvingAgainstBaseURL: false)!
-            components.path = "/oauth/authorize"
-            components.queryItems = [
-                URLQueryItem(name: "client_id", value: clientID),
-                URLQueryItem(name: "response_type", value: "code"),
-                URLQueryItem(name: "scope", value: "read write follow"),
-                URLQueryItem(name: "redirect_uri", value: "tusker://oauth")
-            ]
-            let authorizeURL = components.url!
-            
-            self.authenticationSession = ASWebAuthenticationSession(url: authorizeURL, callbackURLScheme: "tusker") { url, error in
-                guard error == nil,
-                    let url = url,
-                    let components = URLComponents(url: url, resolvingAgainstBaseURL: true),
-                    let item = components.queryItems?.first(where: { $0.name == "code" }),
-                    let authCode = item.value else { return }
-                
-                mastodonController.authorize(authorizationCode: authCode) { (accessToken) in
-                    // construct a temporary UserAccountInfo instance for the MastodonController to use to fetch it's own account
-                    let tempAccountInfo = LocalData.UserAccountInfo(id: "temp", instanceURL: instanceURL, clientID: clientID, clientSecret: clientSecret, username: nil, accessToken: accessToken)
-                    mastodonController.accountInfo = tempAccountInfo
-                    
-                    mastodonController.getOwnAccount { (result) in
+    private func doAuthenticationSession(url: URL) async throws -> URL {
+        return try await withCheckedThrowingContinuation { continuation in
+            self.authenticationSession = ASWebAuthenticationSession(url: url, callbackURLScheme: "tusker") { url, error in
+                defer {
                     DispatchQueue.main.async {
-                            switch result {
-                            case let .failure(error):
-                                let alert = UIAlertController(title: "Unable to Verify Credentials", message: "Your account could not be fetched at this time: \(error.localizedDescription)", preferredStyle: .alert)
-                                alert.addAction(UIAlertAction(title: "Ok", style: .default, handler: nil))
-                                self.present(alert, animated: true)
-                                
-                            case let .success(account):
-                                // this needs to happen on the main thread because it publishes a new value for the ObservableObject
-                                let accountInfo = LocalData.shared.addAccount(instanceURL: instanceURL, clientID: clientID, clientSecret: clientSecret, username: account.username, accessToken: accessToken)
-                                mastodonController.accountInfo = accountInfo
-                                
-                                self.onboardingDelegate?.didFinishOnboarding(account: accountInfo)
-                            }
+                        self.authenticationSession = nil
                     }
                 }
+                if let url = url {
+                    continuation.resume(returning: url)
+                } else {
+                    continuation.resume(throwing: error!)
                 }
             }
             DispatchQueue.main.async {
@@ -97,6 +64,53 @@ extension OnboardingViewController: InstanceSelectorTableViewControllerDelegate
             }
         }
     }
+
+}
+
+extension OnboardingViewController: InstanceSelectorTableViewControllerDelegate {
+    func didSelectInstance(url instanceURL: URL) {
+        async {
+            let mastodonController = MastodonController(instanceURL: instanceURL)
+            let (clientID, clientSecret) = await mastodonController.registerApp()
+            
+            var components = URLComponents(url: instanceURL, resolvingAgainstBaseURL: false)!
+            components.path = "/oauth/authorize"
+            components.queryItems = [
+                URLQueryItem(name: "client_id", value: clientID),
+                URLQueryItem(name: "response_type", value: "code"),
+                URLQueryItem(name: "scope", value: "read write follow"),
+                URLQueryItem(name: "redirect_uri", value: "tusker://oauth")
+            ]
+            
+            guard let url = try? await self.doAuthenticationSession(url: components.url!),
+                  let components = URLComponents(url: url, resolvingAgainstBaseURL: true),
+                  let item = components.queryItems?.first(where: { $0.name == "code" }),
+                  let authCode = item.value else {
+                return
+            }
+            
+            let accessToken = await mastodonController.authorize(authorizationCode: authCode)
+            
+            // construct a temporary UserAccountInfo instance for the MastodonController to use to fetch its own account
+            let tempAccountInfo = LocalData.UserAccountInfo(id: "temp", instanceURL: instanceURL, clientID: clientID, clientSecret: clientSecret, username: nil, accessToken: accessToken)
+            mastodonController.accountInfo = tempAccountInfo
+            
+            let account: Account
+            do {
+                account = try await mastodonController.getOwnAccount()
+            } catch {
+                let alert = UIAlertController(title: "Unable to Verify Credentials", message: "Your account fcould not be fetcheda this time: \(error.localizedDescription)", preferredStyle: .alert)
+                alert.addAction(UIAlertAction(title: "Ok", style: .default, handler: nil))
+                self.present(alert, animated: true)
+                return
+            }
+            
+            let accountInfo = LocalData.shared.addAccount(instanceURL: instanceURL, clientID: clientID, clientSecret: clientSecret, username: account.username, accessToken: accessToken)
+            mastodonController.accountInfo = accountInfo
+            
+            self.onboardingDelegate?.didFinishOnboarding(account: accountInfo)
+        }
+    }
 }
 
 extension OnboardingViewController: ASWebAuthenticationPresentationContextProviding {