Fix attachments collection view sizing

This reverts commit f4b51c06c1107cd8149a8e07a0f652ac6816ee3a.

CHANGELOG-release.md

@@ -1,13 +1,3 @@
-## 2024.5
-Features/Improvements:
-- Improve gallery animations
-
-Bugfixes:
-- Handle right-to-left text in display names
-- Fix crash during gifv playback
-- iPadOS: Fix app becoming unresponsive when switching accounts
-- iPadOS/macOS: Fix Cmd+R shortcuts not working
-
 ## 2024.4
 This release introduces support for iOS 18, including a new sidebar/tab bar on iPad, as well as bugfixes and improvements.
 

CHANGELOG.md

@@ -1,22 +1,5 @@
 # Changelog
 
-## 2024.5 (141)
-Bugfixes:
-- Fix gallery controls being positioned incorrectly during dismiss animation on certain devices
-- Fix gallery controls being positioned incorrectly in landscape orientations
-
-## 2024.5 (139)
-Bugfixes:
-- Fix error decoding certain posts
-
-## 2024.5 (138)
-Bugfixes:
-- Fix potential crash when displaying certain attachments
-- Fix potential crash due to race condition when opening push notification in app
-- Fix misaligned text between profile field values/labels
-- Fix rate limited error message not including reset timestamp
-- iPadOS/macOS: Fix Cmd+R shortcut not working
-
 ## 2024.5 (137)
 Features/Improvements:
 - Improve gallery presentation/dismissal transitions

Packages/ComposeUI/Package.swift

@@ -20,13 +20,24 @@ let package = Package(
         .package(path: "../InstanceFeatures"),
         .package(path: "../TuskerComponents"),
         .package(path: "../MatchedGeometryPresentation"),
+        .package(path: "../TuskerPreferences"),
+        .package(path: "../UserAccounts"),
+        .package(path: "../GalleryVC"),
     ],
     targets: [
         // Targets are the basic building blocks of a package. A target can define a module or a test suite.
         // Targets can depend on other targets in this package, and on products in packages this package depends on.
         .target(
             name: "ComposeUI",
-            dependencies: ["Pachyderm", "InstanceFeatures", "TuskerComponents", "MatchedGeometryPresentation"],
+            dependencies: [
+                "Pachyderm",
+                "InstanceFeatures",
+                "TuskerComponents",
+                "MatchedGeometryPresentation",
+                "TuskerPreferences",
+                "UserAccounts",
+                "GalleryVC",
+            ],
             swiftSettings: [
                 .swiftLanguageMode(.v5)
             ]),

Packages/ComposeUI/Sources/ComposeUI/API/PostService.swift

@@ -11,7 +11,7 @@ import Pachyderm
 import UniformTypeIdentifiers
 
 @MainActor
-class PostService: ObservableObject {
+final class PostService: ObservableObject {
     private let mastodonController: ComposeMastodonContext
     private let config: ComposeUIConfig
     private let draft: Draft

Packages/ComposeUI/Sources/ComposeUI/CharacterCounter.swift

@@ -12,7 +12,7 @@ import InstanceFeatures
 public struct CharacterCounter {
     
     private static let linkDetector = try! NSDataDetector(types: NSTextCheckingResult.CheckingType.link.rawValue)
-    private static let mention = try! NSRegularExpression(pattern: "(@[a-z0-9_]+)(?:@[a-z0-9\\-\\.]+[a-z0-9]+)?", options: .caseInsensitive)
+    static let mention = try! NSRegularExpression(pattern: "(@[a-z0-9_]+)(?:@[a-z0-9\\-\\.]+[a-z0-9]+)?", options: .caseInsensitive)
     
     public static func count(text: String, for instanceFeatures: InstanceFeatures) -> Int {
         let mentionsRemoved = removeMentions(in: text)

Packages/ComposeUI/Sources/ComposeUI/ComposeInput.swift

@@ -8,6 +8,7 @@
 import Foundation
 import Combine
 import UIKit
+import SwiftUI
 
 protocol ComposeInput: AnyObject, ObservableObject {
     var toolbarElements: [ToolbarElement] { get }
@@ -27,3 +28,45 @@ enum ToolbarElement {
     case emojiPicker
     case formattingButtons
 }
+
+private struct FocusedComposeInput: FocusedValueKey {
+    typealias Value = (any ComposeInput)?
+}
+
+extension FocusedValues {
+    // double optional is necessary pre-iOS 16
+    var composeInput: (any ComposeInput)?? {
+        get { self[FocusedComposeInput.self] }
+        set { self[FocusedComposeInput.self] = newValue }
+    }
+}
+
+@propertyWrapper
+final class MutableObservableBox<Value>: ObservableObject {
+    @Published var wrappedValue: Value
+    
+    init(wrappedValue: Value) {
+        self.wrappedValue = wrappedValue
+    }
+}
+
+private struct FocusedComposeInputBox: EnvironmentKey {
+    static let defaultValue: MutableObservableBox<(any ComposeInput)?> = .init(wrappedValue: nil)
+}
+
+extension EnvironmentValues {
+    var composeInputBox: MutableObservableBox<(any ComposeInput)?> {
+        get { self[FocusedComposeInputBox.self] }
+        set { self[FocusedComposeInputBox.self] = newValue }
+    }
+}
+
+struct FocusedInputModifier: ViewModifier {
+    @StateObject var box: MutableObservableBox<(any ComposeInput)?> = .init(wrappedValue: nil)
+    
+    func body(content: Content) -> some View {
+        content
+            .environment(\.composeInputBox, box)
+            .focusedValue(\.composeInput, box.wrappedValue)
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/ComposeMastodonContext.swift

@@ -9,6 +9,7 @@ import Foundation
 import Pachyderm
 import InstanceFeatures
 import UserAccounts
+import SwiftUI
 
 public protocol ComposeMastodonContext {
     var accountInfo: UserAccountInfo? { get }
@@ -26,4 +27,6 @@ public protocol ComposeMastodonContext {
     func searchCachedHashtags(query: String) -> [Hashtag]
     
     func storeCreatedStatus(_ status: Status)
+    
+    func fetchStatus(id: String) -> (any StatusProtocol)?
 }

Packages/ComposeUI/Sources/ComposeUI/Controllers/AttachmentRowController.swift

@@ -221,16 +221,3 @@ extension AttachmentRowController {
         case allowEntry, recognizingText
     }
 }
-
-private extension View {
-    @available(iOS, obsoleted: 16.0)
-    @available(visionOS 1.0, *)
-    @ViewBuilder
-    func contextMenu<M: View, P: View>(@ViewBuilder menuItems: () -> M, @ViewBuilder previewIfAvailable preview: () -> P) -> some View {
-        if #available(iOS 16.0, *) {
-            self.contextMenu(menuItems: menuItems, preview: preview)
-        } else {
-            self.contextMenu(menuItems: menuItems)
-        }
-    }
-}

Packages/ComposeUI/Sources/ComposeUI/Controllers/AttachmentThumbnailController.swift

@@ -181,7 +181,7 @@ extension EnvironmentValues {
     }
 }
 
-private struct GIFViewWrapper: UIViewRepresentable {
+struct GIFViewWrapper: UIViewRepresentable {
     typealias UIViewType = GIFImageView
 
     @State var controller: GIFController

Packages/ComposeUI/Sources/ComposeUI/Controllers/AttachmentsListController.swift

@@ -131,7 +131,6 @@ class AttachmentsListController: ViewController {
         @EnvironmentObject private var controller: AttachmentsListController
         @EnvironmentObject private var draft: Draft
         @Environment(\.colorScheme) private var colorScheme
-        @Environment(\.horizontalSizeClass) private var horizontalSizeClass
         
         var body: some View {
             attachmentsList
@@ -255,7 +254,7 @@ fileprivate struct SheetOrPopover<V: View>: ViewModifier {
 }
 
 @available(visionOS 1.0, *)
-fileprivate struct AttachmentButtonLabelStyle: LabelStyle {
+struct AttachmentButtonLabelStyle: LabelStyle {
     func makeBody(configuration: Configuration) -> some View {
         DefaultLabelStyle().makeBody(configuration: configuration)
             .foregroundStyle(.white)

Packages/ComposeUI/Sources/ComposeUI/Controllers/ComposeController.swift

@@ -132,11 +132,17 @@ public final class ComposeController: ViewController {
     }
     
     public var view: some View {
-        ComposeView(poster: poster)
+        if Preferences.shared.hasFeatureFlag(.composeRewrite) {
-            .environment(\.managedObjectContext, DraftsPersistentContainer.shared.viewContext)
+            ComposeUI.ComposeView(draft: draft, mastodonController: mastodonController)
-            .environmentObject(draft)
+                .environment(\.currentAccount, currentAccount)
-            .environmentObject(mastodonController.instanceFeatures)
+                .environment(\.composeUIConfig, config)
-            .environment(\.composeUIConfig, config)
+        } else {
+            ComposeView(poster: poster)
+                .environment(\.managedObjectContext, DraftsPersistentContainer.shared.viewContext)
+                .environmentObject(draft)
+                .environmentObject(mastodonController.instanceFeatures)
+                .environment(\.composeUIConfig, config)
+        }
     }
     
     @MainActor
@@ -503,18 +509,6 @@ public final class ComposeController: ViewController {
     }
 }
 
-private extension View {
-    @available(iOS, obsoleted: 16.0)
-    @ViewBuilder
-    func scrollDismissesKeyboardInteractivelyIfAvailable() -> some View {
-        if #available(iOS 16.0, *) {
-            self.scrollDismissesKeyboard(.interactively)
-        } else {
-            self
-        }
-    }
-}
-
 private struct GlobalFrameOutsideListPrefKey: PreferenceKey {
     static var defaultValue: CGRect = .zero
     static func reduce(value: inout CGRect, nextValue: () -> CGRect) {

Packages/ComposeUI/Sources/ComposeUI/Controllers/PlaceholderController.swift

@@ -17,7 +17,7 @@ final class PlaceholderController: ViewController, PlaceholderViewProvider {
            Date().formatted(date: .numeric, time: .omitted).starts(with: "3") {
             Text("Happy π day!")
         } else if components.month == 4 && components.day == 1 {
-            Text("April Fool's!").rotationEffect(.radians(.pi), anchor: .center)
+            Text("April Fool’s!").rotationEffect(.radians(.pi), anchor: .center)
         } else if components.month == 9 && components.day == 5 {
             // https://weirder.earth/@noracodes/109276419847254552
             // https://retrocomputing.stackexchange.com/questions/14763/what-warning-was-given-on-attempting-to-post-to-usenet-circa-1990
@@ -31,7 +31,7 @@ final class PlaceholderController: ViewController, PlaceholderViewProvider {
                 Text("Any questions?")
             }
         } else {
-            Text("What's on your mind?")
+            Text("What’s on your mind?")
         }
     }
     
@@ -41,7 +41,7 @@ final class PlaceholderController: ViewController, PlaceholderViewProvider {
 }
 
 // exists to provide access to the type alias since the @State property needs it to be explicit
-private protocol PlaceholderViewProvider {
+protocol PlaceholderViewProvider {
     associatedtype PlaceholderView: View
     @ViewBuilder
     static func makePlaceholderView() -> PlaceholderView

Packages/ComposeUI/Sources/ComposeUI/CoreData/DraftsPersistentContainer.swift

@@ -170,17 +170,26 @@ public class DraftsPersistentContainer: NSPersistentContainer {
             return
         }
         performBackgroundTask { context in
+            let orphanedAttachmentsReq: NSFetchRequest<any NSFetchRequestResult> = DraftAttachment.fetchRequest()
+            orphanedAttachmentsReq.predicate = NSPredicate(format: "draft == nil")
+            let deleteReq = NSBatchDeleteRequest(fetchRequest: orphanedAttachmentsReq)
+            do {
+                try context.execute(deleteReq)
+            } catch {
+                logger.error("Failed to remove orphaned attachments: \(String(describing: error), privacy: .public)")
+            }
+            
             let allAttachmentsReq = DraftAttachment.fetchRequest()
             allAttachmentsReq.predicate = NSPredicate(format: "fileURL != nil")
             guard let allAttachments = try? context.fetch(allAttachmentsReq) else {
                 return
             }
-            let orphaned = Set(files).subtracting(allAttachments.lazy.compactMap(\.fileURL))
+            let orphanedFiles = Set(files).subtracting(allAttachments.lazy.compactMap(\.fileURL))
-            for url in orphaned {
+            for url in orphanedFiles {
                 do {
                     try FileManager.default.removeItem(at: url)
                 } catch {
-                    logger.error("Failed to remove orphaned attachment: \(String(describing: error), privacy: .public)")
+                    logger.error("Failed to remove orphaned attachment files: \(String(describing: error), privacy: .public)")
                 }
             }
             completion()

Packages/ComposeUI/Sources/ComposeUI/Environment.swift

@@ -0,0 +1,49 @@
+//
+//  Environment.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+import Pachyderm
+
+//@propertyWrapper
+//struct RequiredEnvironment<Value>: DynamicProperty {
+//    private let keyPath: KeyPath<EnvironmentValues, Value?>
+//    @Environment private var value: Value?
+//    
+//    init(_ keyPath: KeyPath<EnvironmentValues, Value?>) {
+//        self.keyPath = keyPath
+//        self._value = Environment(keyPath)
+//    }
+//    
+//    var wrappedValue: Value {
+//        guard let value else {
+//            preconditionFailure("Missing required environment value for \(keyPath)")
+//        }
+//        return value
+//    }
+//}
+
+private struct ComposeMastodonContextKey: EnvironmentKey {
+    static let defaultValue: (any ComposeMastodonContext)? = nil
+}
+
+extension EnvironmentValues {
+    var mastodonController: (any ComposeMastodonContext)? {
+        get { self[ComposeMastodonContextKey.self] }
+        set { self[ComposeMastodonContextKey.self] = newValue }
+    }
+}
+
+private struct CurrentAccountKey: EnvironmentKey {
+    static let defaultValue: (any AccountProtocol)? = nil
+}
+
+extension EnvironmentValues {
+    var currentAccount: (any AccountProtocol)? {
+        get { self[CurrentAccountKey.self] }
+        set { self[CurrentAccountKey.self] = newValue }
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/KeyboardReader.swift

@@ -12,7 +12,6 @@ import Combine
 
 @available(iOS, obsoleted: 16.0)
 class KeyboardReader: ObservableObject {
-//    @Published var isVisible = false
     @Published var keyboardHeight: CGFloat = 0
     
     var isVisible: Bool {
@@ -27,14 +26,12 @@ class KeyboardReader: ObservableObject {
     
     @objc func willShow(_ notification: Foundation.Notification) {
         let endFrame = notification.userInfo![UIResponder.keyboardFrameEndUserInfoKey] as! CGRect
-//        isVisible = endFrame.height > 72
         keyboardHeight = endFrame.height
     }
     
     @objc func willHide() {
         // sometimes willHide is called during a SwiftUI view update
         DispatchQueue.main.async {
-//            self.isVisible = false
             self.keyboardHeight = 0
         }
     }

Packages/ComposeUI/Sources/ComposeUI/Model/StatusFormat.swift

@@ -9,9 +9,13 @@
 import UIKit
 import Pachyderm
 
-enum StatusFormat: Int, CaseIterable {
+enum StatusFormat: Int, CaseIterable, Identifiable {
     case bold, italics, strikethrough, code
     
+    var id: some Hashable {
+        rawValue
+    }
+    
     func insertionResult(for contentType: StatusContentType) -> FormatInsertionResult? {
         switch contentType {
         case .plain:

Packages/ComposeUI/Sources/ComposeUI/Preferences.swift

@@ -0,0 +1,11 @@
+//
+//  Preferences.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import Foundation
+import TuskerPreferences
+
+typealias Preferences = TuskerPreferences.Preferences

Packages/ComposeUI/Sources/ComposeUI/View+ForwardsCompat.swift

@@ -23,4 +23,33 @@ extension View {
         }
     }
     #endif
+    
+    @available(iOS, obsoleted: 16.0)
+    @ViewBuilder
+    func scrollDismissesKeyboardInteractivelyIfAvailable() -> some View {
+        #if os(visionOS)
+        self.scrollDismissesKeyboard(.interactively)
+        #else
+        if #available(iOS 16.0, *) {
+            self.scrollDismissesKeyboard(.interactively)
+        } else {
+            self
+        }
+        #endif
+    }
+    
+    @available(iOS, obsoleted: 16.0)
+    @available(visionOS 1.0, *)
+    @ViewBuilder
+    func contextMenu<M: View, P: View>(@ViewBuilder menuItems: () -> M, @ViewBuilder previewIfAvailable preview: () -> P) -> some View {
+        #if os(visionOS)
+        self.contextMenu(menuItems: menuItems, preview: preview)
+        #else
+        if #available(iOS 16.0, *) {
+            self.contextMenu(menuItems: menuItems, preview: preview)
+        } else {
+            self.contextMenu(menuItems: menuItems)
+        }
+        #endif
+    }
 }

Packages/ComposeUI/Sources/ComposeUI/ViewController.swift

@@ -11,6 +11,7 @@ import Combine
 public protocol ViewController: ObservableObject {
     associatedtype ContentView: View
     
+    @MainActor
     @ViewBuilder
     var view: ContentView { get }
 }

Packages/ComposeUI/Sources/ComposeUI/Views/AttachmentThumbnailView.swift

@@ -0,0 +1,139 @@
+//
+//  AttachmentThumbnailView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 10/14/24.
+//
+
+import SwiftUI
+import TuskerComponents
+import AVFoundation
+import Photos
+
+struct AttachmentThumbnailView: View {
+    let attachment: DraftAttachment
+    var contentMode: ContentMode = .fit
+    
+    var body: some View {
+        AttachmentThumbnailViewContent(attachment: attachment, contentMode: contentMode)
+            .id(attachment.id)
+    }
+    
+}
+
+private struct AttachmentThumbnailViewContent: View {
+    var attachment: DraftAttachment
+    var contentMode: ContentMode = .fit
+    @State private var mode: Mode = .empty
+    @EnvironmentObject private var composeController: ComposeController
+
+    var body: some View {
+        switch mode {
+        case .empty:
+            Image(systemName: "photo")
+                .imageScale(.large)
+                .foregroundStyle(.gray)
+                .task {
+                    await loadThumbnail()
+                }
+        case .image(let image):
+            Image(uiImage: image)
+                .resizable()
+                .aspectRatio(contentMode: contentMode)
+        case .gifController(let controller):
+            GIFViewWrapper(controller: controller)
+        }
+    }
+    
+    private func loadThumbnail() async {
+        switch attachment.data {
+        case .editing(_, let kind, let url):
+            switch kind {
+            case .image:
+                if let image = await composeController.fetchAttachment(url) {
+                    self.mode = .image(image)
+                }
+                
+            case .video, .gifv:
+                await loadVideoThumbnail(url: url)
+                
+            case .audio, .unknown:
+                break
+            }
+            
+        case .asset(let id):
+            guard let asset = PHAsset.fetchAssets(withLocalIdentifiers: [id], options: nil).firstObject else {
+                return
+            }
+            let isGIF = PHAssetResource.assetResources(for: asset).contains {
+                $0.uniformTypeIdentifier == UTType.gif.identifier
+            }
+            if isGIF {
+                PHImageManager.default().requestImageDataAndOrientation(for: asset, options: nil) { data, typeIdentifier, orientation, info in
+                    guard let data else { return }
+                    if typeIdentifier == UTType.gif.identifier {
+                        self.mode = .gifController(GIFController(gifData: data))
+                    } else if let image = UIImage(data: data) {
+                        self.mode = .image(image)
+                    }
+                }
+            } else {
+                let size = CGSize(width: 80, height: 80)
+                PHImageManager.default().requestImage(for: asset, targetSize: size, contentMode: .aspectFill, options: nil) { image, _ in
+                    if let image {
+                        self.mode = .image(image)
+                    }
+                }
+            }
+            
+        case .drawing(let drawing):
+            self.mode = .image(drawing.imageInLightMode(from: drawing.bounds))
+            
+        case .file(let url, let type):
+            if type.conforms(to: .movie) {
+                await loadVideoThumbnail(url: url)
+            } else if let data = try? Data(contentsOf: url) {
+                if type == .gif {
+                    self.mode = .gifController(GIFController(gifData: data))
+                } else if type.conforms(to: .image) {
+                    if let image = UIImage(data: data),
+                       // using prepareThumbnail on images from PHPicker results in extremely high memory usage,
+                       // crashing share extension. see FB12186346
+                       let prepared = await image.byPreparingForDisplay() {
+                        self.mode = .image(prepared)
+                    }
+                }
+            }
+            
+        case .none:
+            break
+        }
+    }
+    
+    private func loadVideoThumbnail(url: URL) async {
+        let asset = AVURLAsset(url: url)
+        let imageGenerator = AVAssetImageGenerator(asset: asset)
+        imageGenerator.appliesPreferredTrackTransform = true
+        #if os(visionOS)
+        if let (cgImage, _) = try? await imageGenerator.image(at: .zero) {
+            self.mode = .image(UIImage(cgImage: cgImage))
+        }
+        #else
+        if #available(iOS 16.0, *) {
+            if let (cgImage, _) = try? await imageGenerator.image(at: .zero) {
+                self.mode = .image(UIImage(cgImage: cgImage))
+            }
+        } else {
+            if let cgImage = try? imageGenerator.copyCGImage(at: .zero, actualTime: nil) {
+                self.mode = .image(UIImage(cgImage: cgImage))
+            }
+        }
+        #endif
+    }
+    
+    enum Mode {
+        case empty
+        case image(UIImage)
+        case gifController(GIFController)
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/Attachments/AttachmentCollectionViewCell.swift

@@ -0,0 +1,158 @@
+//
+//  AttachmentCollectionViewCell.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 11/20/24.
+//
+
+import UIKit
+import SwiftUI
+
+struct AttachmentCollectionViewCellView: View {
+    let attachment: DraftAttachment?
+    
+    var body: some View {
+        if let attachment {
+            AttachmentThumbnailView(attachment: attachment, contentMode: .fill)
+                .squareFrame()
+                .background {
+                    RoundedSquare(cornerRadius: 5)
+                        .fill(.quaternary)
+                }
+                .overlay(alignment: .bottom) {
+                    AttachmentDescriptionLabel(attachment: attachment)
+                }
+                .overlay(alignment: .topTrailing) {
+                    AttachmentRemoveButton(attachment: attachment)
+                }
+                .clipShape(RoundedSquare(cornerRadius: 5))
+        }
+    }
+    
+}
+
+private struct AttachmentRemoveButton: View {
+    let attachment: DraftAttachment
+    
+    var body: some View {
+        Button("Remove", systemImage: "xmark.circle.fill") {
+            let draft = attachment.draft
+            let attachments = draft.attachments.mutableCopy() as! NSMutableOrderedSet
+            attachments.remove(attachment)
+            draft.attachments = attachments
+            DraftsPersistentContainer.shared.viewContext.delete(attachment)
+        }
+        .labelStyle(.iconOnly)
+        .imageScale(.large)
+        .foregroundStyle(.white)
+        .shadow(radius: 2)
+        .padding([.top, .trailing], 2)
+    }
+}
+
+private struct AttachmentDescriptionLabel: View {
+    @ObservedObject var attachment: DraftAttachment
+    
+    var body: some View {
+        ZStack(alignment: .bottomLeading) {
+            LinearGradient(
+                stops: [.init(color: .clear, location: 0), .init(color: .clear, location: 0.6), .init(color: .black.opacity(0.5), location: 1)],
+                startPoint: .top,
+                endPoint: .bottom
+            )
+            
+            label
+                .foregroundStyle(.white)
+                .shadow(color: .black.opacity(0.5), radius: 1)
+                .padding([.horizontal, .bottom], 4)
+        }
+    }
+    
+    @ViewBuilder
+    private var label: some View {
+        if attachment.attachmentDescription.isEmpty {
+            Label("Add alt", systemImage: "pencil")
+                .labelStyle(NarrowSpacingLabelStyle())
+                .font(.callout)
+                .lineLimit(1)
+        } else {
+            Text(attachment.attachmentDescription)
+                .font(.caption)
+                .lineLimit(2)
+        }
+    }
+}
+
+private struct NarrowSpacingLabelStyle: LabelStyle {
+    func makeBody(configuration: Configuration) -> some View {
+        HStack(spacing: 4) {
+            configuration.icon
+            configuration.title
+        }
+    }
+}
+
+private struct RoundedSquare: Shape {
+    let cornerRadius: CGFloat
+    
+    nonisolated func path(in rect: CGRect) -> Path {
+        let minDimension = min(rect.width, rect.height)
+        let square = CGRect(x: rect.minX - (rect.width - minDimension) / 2, y: rect.minY - (rect.height - minDimension), width: minDimension, height: minDimension)
+        return RoundedRectangle(cornerRadius: cornerRadius).path(in: square)
+    }
+}
+
+@available(iOS 16.0, *)
+private struct SquareFrame: Layout {
+    func sizeThatFits(proposal: ProposedViewSize, subviews: Subviews, cache: inout ()) -> CGSize {
+        precondition(subviews.count == 1)
+        let size = proposal.replacingUnspecifiedDimensions(by: subviews[0].sizeThatFits(proposal))
+        let minDimension = min(size.width, size.height)
+        return CGSize(width: minDimension, height: minDimension)
+    }
+    
+    func placeSubviews(in bounds: CGRect, proposal: ProposedViewSize, subviews: Subviews, cache: inout ()) {
+        precondition(subviews.count == 1)
+        let subviewSize = subviews[0].sizeThatFits(proposal)
+        let minDimension = min(bounds.width, bounds.height)
+        let origin = CGPoint(x: bounds.minX - (subviewSize.width - minDimension) / 2, y: bounds.minY - (subviewSize.height - minDimension) / 2)
+        subviews[0].place(at: origin, proposal: ProposedViewSize(subviewSize))
+    }
+}
+
+#if !os(visionOS)
+@available(iOS, obsoleted: 16.0)
+private struct LegacySquareFrame<Content: View>: View {
+    @ViewBuilder let content: Content
+    
+    var body: some View {
+        GeometryReader { proxy in
+            let minDimension = min(proxy.size.width, proxy.size.height)
+            content
+                .frame(width: minDimension, height: minDimension, alignment: .center)
+        }
+    }
+}
+#endif
+
+private extension View {
+    @ViewBuilder
+    func squareFrame() -> some View {
+        #if os(visionOS)
+        SquareFrame {
+            self
+        }
+        #else
+        if #available(iOS 16.0, *) {
+            SquareFrame {
+                self
+            }
+        } else {
+            LegacySquareFrame {
+                self
+            }
+        }
+        #endif
+    }
+}
+

Packages/ComposeUI/Sources/ComposeUI/Views/Attachments/AttachmentsGalleryDataSource.swift

@@ -0,0 +1,90 @@
+//
+//  AttachmentGalleryDataSource.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 11/21/24.
+//
+
+import UIKit
+import GalleryVC
+import TuskerComponents
+import Photos
+
+struct AttachmentsGalleryDataSource: GalleryDataSource {
+    let collectionView: UICollectionView
+    let attachmentAtIndex: (Int) -> DraftAttachment?
+    
+    func galleryItemsCount() -> Int {
+        collectionView.numberOfItems(inSection: 0) - 1
+    }
+    
+    func galleryContentViewController(forItemAt index: Int) -> any GalleryVC.GalleryContentViewController {
+        let attachment = attachmentAtIndex(index)!
+        
+        let content: any GalleryContentViewController
+        switch attachment.data {
+        case .editing(_, _, _):
+            fatalError("TODO")
+            
+        case .asset(let id):
+            content = LoadingGalleryContentViewController(caption: nil) {
+                if let (image, gifData) = await fetchImageAndGIFData(assetID: id) {
+                    let gifController = gifData.map(GIFController.init)
+                    return ImageGalleryContentViewController(image: image, caption: nil, gifController: gifController)
+                } else {
+                    return nil
+                }
+            }
+            
+        case .drawing(let drawing):
+            let image = drawing.imageInLightMode(from: drawing.bounds)
+            content = ImageGalleryContentViewController(image: image, caption: nil, gifController: nil)
+            
+        case .file(let url, let type):
+            if type.conforms(to: .movie) {
+                content = VideoGalleryContentViewController(url: url, caption: nil)
+            } else if type.conforms(to: .image),
+                      let data = try? Data(contentsOf: url),
+                      let image = UIImage(data: data) {
+                let gifController = type == .gif ? GIFController(gifData: data) : nil
+                content = ImageGalleryContentViewController(image: image, caption: nil, gifController: gifController)
+            } else {
+                return LoadingGalleryContentViewController(caption: nil) {
+                    nil
+                }
+            }
+            
+        case .none:
+            return LoadingGalleryContentViewController(caption: nil) {
+                nil
+            }
+        }
+        
+        return EditAttachmentWrapperGalleryContentViewController(draftAttachment: attachment, wrapped: content)
+    }
+    
+    func galleryContentTransitionSourceView(forItemAt index: Int) -> UIView? {
+        collectionView.cellForItem(at: IndexPath(item: index, section: 0))
+    }
+    
+    private func fetchImageAndGIFData(assetID id: String) async -> (UIImage, Data?)? {
+        guard let asset = PHAsset.fetchAssets(withLocalIdentifiers: [id], options: nil).firstObject else {
+            return nil
+        }
+        let (type, data) = await withCheckedContinuation { continuation in
+            PHImageManager.default().requestImageDataAndOrientation(for: asset, options: nil) { data, typeIdentifier, orientation, info in
+                continuation.resume(returning: (typeIdentifier, data))
+            }
+        }
+        guard let data,
+              let image = UIImage(data: data) else {
+            return nil
+        }
+        if type == UTType.gif.identifier {
+            return (image, data)
+        } else {
+            return (image, nil)
+        }
+    }
+    
+}

Packages/ComposeUI/Sources/ComposeUI/Views/Attachments/AttachmentsSection.swift

@@ -0,0 +1,529 @@
+//
+//  AttachmentsSection.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 11/17/24.
+//
+
+import SwiftUI
+import PhotosUI
+import PencilKit
+import GalleryVC
+import InstanceFeatures
+
+struct AttachmentsSection: View {
+    @ObservedObject var draft: Draft
+    private let spacing: CGFloat = 8
+    private let minItemSize: CGFloat = 100
+    
+    var body: some View {
+        #if os(visionOS)
+        collectionView
+        #else
+        if #available(iOS 16.0, *) {
+            collectionView
+        } else {
+            LegacyCollectionViewSizingView {
+                collectionView
+            } computeHeight: { width in
+                WrappedCollectionView.totalHeight(width: width, minItemSize: minItemSize, spacing: spacing, items: draft.attachments.count + 1)
+            }
+        }
+        #endif
+    }
+    
+    private var collectionView: some View {
+        WrappedCollectionView(
+            draft: draft,
+            spacing: spacing,
+            minItemSize: minItemSize
+        )
+        // Impose a minimum height, because otherwise it defaults to zero which prevents the collection
+        // view from laying out, and leaving the intrinsic content size at zero too.
+        // Add 4 to the minItemSize because otherwise drag-and-drop while reordering can alter the contentOffset by that much.
+        .frame(minHeight: minItemSize + 4)
+    }
+    
+    static func insertAttachments(in draft: Draft, at index: Int, itemProviders: [NSItemProvider]) {
+        for provider in itemProviders where provider.canLoadObject(ofClass: DraftAttachment.self) {
+            provider.loadObject(ofClass: DraftAttachment.self) { object, error in
+                guard let attachment = object as? DraftAttachment else { return }
+                DispatchQueue.main.async {
+                    DraftsPersistentContainer.shared.viewContext.insert(attachment)
+                    attachment.draft = draft
+                    draft.attachments.add(attachment)
+                }
+            }
+        }
+    }
+}
+
+#if !os(visionOS)
+@available(iOS, obsoleted: 16.0)
+private struct LegacyCollectionViewSizingView<Content: View>: View {
+    @ViewBuilder let content: Content
+    let computeHeight: (CGFloat) -> CGFloat
+    @State private var width: CGFloat = 0
+
+    var body: some View {
+        let height = computeHeight(width)
+        
+        content
+            .frame(height: max(height, 10))
+            .overlay {
+                GeometryReader { proxy in
+                    Color.clear
+                        .preference(key: WidthPrefKey.self, value: proxy.size.width)
+                        .onPreferenceChange(WidthPrefKey.self) {
+                            width = $0
+                        }
+                }
+            }
+    }
+}
+
+private struct WidthPrefKey: PreferenceKey {
+    static var defaultValue: CGFloat { 0 }
+    static func reduce(value: inout CGFloat, nextValue: () -> CGFloat) {
+        let next = nextValue()
+        if next != 0 {
+            value = next
+        }
+    }
+}
+#endif
+
+// Use a UIViewControllerRepresentable so we have something from which to present the gallery VC.
+private struct WrappedCollectionView: UIViewControllerRepresentable {
+    @ObservedObject var draft: Draft
+    let spacing: CGFloat
+    let minItemSize: CGFloat
+    
+    func makeUIViewController(context: Context) -> WrappedCollectionViewController {
+        WrappedCollectionViewController(spacing: spacing, minItemSize: minItemSize)
+    }
+    
+    func updateUIViewController(_ uiViewController: UIViewControllerType, context: Context) {
+        uiViewController.draft = draft
+        uiViewController.addAttachment = {
+            DraftsPersistentContainer.shared.viewContext.insert($0)
+            $0.draft = draft
+            draft.attachments.add($0)
+        }
+        uiViewController.updateAttachments()
+    }
+    
+    @available(iOS 16.0, *)
+    func sizeThatFits(_ proposal: ProposedViewSize, uiViewController: WrappedCollectionViewController, context: Context) -> CGSize? {
+        guard let width = proposal.width,
+              width.isFinite else {
+            return nil
+        }
+        let count = draft.attachments.count + 1
+        return CGSize(
+            width: width,
+            height: Self.totalHeight(width: width, minItemSize: minItemSize, spacing: spacing, items: count)
+        )
+    }
+
+    fileprivate static func itemSize(width: CGFloat, minItemSize: CGFloat, spacing: CGFloat) -> (CGFloat, Int) {
+        // The maximum item size is 2*minItemSize + spacing - 1,
+        // in the case where one item fits in the row but we are one pt short of
+        // adding a second item.
+        var itemSize = minItemSize
+        var fittingCount = floor((width + spacing) / (itemSize + spacing))
+        var usedSpaceForFittingCount = fittingCount * itemSize + (fittingCount - 1) * spacing
+        var remainingSpace = width - usedSpaceForFittingCount
+        if fittingCount == 0 {
+            return (0, 0)
+        } else if fittingCount == 1 && remainingSpace > minItemSize / 2 {
+            // If there's only one item that would fit at min size, and giving
+            // it the rest of the space would increase it by at least 50%,
+            // add a second item anywyas.
+            itemSize = (width - spacing) / 2
+            fittingCount = 2
+            usedSpaceForFittingCount = fittingCount * itemSize + (fittingCount - 1) * spacing
+            remainingSpace = width - usedSpaceForFittingCount
+        }
+        itemSize = itemSize + remainingSpace / fittingCount
+        return (itemSize, Int(fittingCount))
+    }
+    
+    fileprivate static func totalHeight(width: CGFloat, minItemSize: CGFloat, spacing: CGFloat, items: Int) -> CGFloat {
+        let (size, itemsPerRow) = itemSize(width: width, minItemSize: minItemSize, spacing: spacing)
+        guard itemsPerRow != 0 else {
+            return 0
+        }
+        let rows = ceil(Double(items) / Double(itemsPerRow))
+        return size * rows + spacing * (rows - 1)
+    }
+}
+
+private class WrappedCollectionViewController: UIViewController {
+    let spacing: CGFloat
+    let minItemSize: CGFloat
+    var draft: Draft!
+    private var dataSource: UICollectionViewDiffableDataSource<Section, Item>!
+    fileprivate var currentInteractiveMoveStartOffsetInCell: CGPoint?
+    fileprivate var currentInteractiveMoveCell: HostingCollectionViewCell?
+    fileprivate var addAttachment: ((DraftAttachment) -> Void)? = nil
+    
+    var collectionView: UICollectionView {
+        view as! UICollectionView
+    }
+    
+    init(spacing: CGFloat, minItemSize: CGFloat) {
+        self.spacing = spacing
+        self.minItemSize = minItemSize
+        super.init(nibName: nil, bundle: nil)
+    }
+    
+    required init?(coder: NSCoder) {
+        fatalError("init(coder:) has not been implemented")
+    }
+    
+    override func loadView() {
+        let layout = UICollectionViewCompositionalLayout { [unowned self] section, environment in
+            let (itemSize, itemsPerRow) = WrappedCollectionView.itemSize(width: environment.container.contentSize.width, minItemSize: minItemSize, spacing: spacing)
+            
+            let items = Array(repeating: NSCollectionLayoutItem(layoutSize: .init(widthDimension: .absolute(itemSize), heightDimension: .absolute(itemSize))), count: itemsPerRow)
+            let group = NSCollectionLayoutGroup.horizontal(layoutSize: .init(widthDimension: .fractionalWidth(1), heightDimension: .absolute(itemSize)), subitems: items)
+            group.interItemSpacing = .fixed(spacing)
+            let section = NSCollectionLayoutSection(group: group)
+            section.interGroupSpacing = spacing
+            return section
+        }
+        let attachmentCell = UICollectionView.CellRegistration<HostingCollectionViewCell, DraftAttachment> { [unowned self] cell, indexPath, attachment in
+            cell.containingViewController = self
+            cell.setView(AttachmentCollectionViewCellView(attachment: attachment))
+        }
+        let addButtonCell = UICollectionView.CellRegistration<HostingCollectionViewCell, Bool> { [unowned self] cell, indexPath, item in
+            cell.containingViewController = self
+            cell.setView(AddAttachmentButton(viewController: self, enabled: item))
+        }
+        let collectionView = IntrinsicContentSizeCollectionView(frame: .zero, collectionViewLayout: layout)
+        self.view = collectionView
+        dataSource = UICollectionViewDiffableDataSource<Section, Item>(collectionView: collectionView) { collectionView, indexPath, itemIdentifier in
+            switch itemIdentifier {
+            case .attachment(let attachment):
+                return collectionView.dequeueConfiguredReusableCell(using: attachmentCell, for: indexPath, item: attachment)
+            case .addButton:
+                return collectionView.dequeueConfiguredReusableCell(using: addButtonCell, for: indexPath, item: true)
+            }
+        }
+        dataSource.reorderingHandlers.canReorderItem = { item in
+            switch item {
+            case .attachment(_):
+                true
+            case .addButton:
+                false
+            }
+        }
+        dataSource.reorderingHandlers.didReorder = { [unowned self] transaction in
+            let attachmentChanges = transaction.difference.map {
+                switch $0 {
+                case .insert(let offset, let element, let associatedWith):
+                    guard case .attachment(let attachment) = element else { fatalError() }
+                    return CollectionDifference<DraftAttachment>.Change.insert(offset: offset, element: attachment, associatedWith: associatedWith)
+                case .remove(let offset, let element, let associatedWith):
+                    guard case .attachment(let attachment) = element else { fatalError() }
+                    return CollectionDifference<DraftAttachment>.Change.remove(offset: offset, element: attachment, associatedWith: associatedWith)
+                }
+            }
+            let attachmentsDiff = CollectionDifference(attachmentChanges)!
+            let array = draft.draftAttachments.applying(attachmentsDiff)!
+            draft.attachments = NSMutableOrderedSet(array: array)
+        }
+        
+        collectionView.isScrollEnabled = false
+        collectionView.clipsToBounds = false
+        collectionView.delegate = self
+        
+        let longPressRecognizer = UILongPressGestureRecognizer(target: self, action: #selector(reorderingLongPressRecognized))
+        longPressRecognizer.delegate = self
+        collectionView.addGestureRecognizer(longPressRecognizer)
+    }
+    
+    func updateAttachments() {
+        var snapshot = NSDiffableDataSourceSnapshot<Section, Item>()
+        snapshot.appendSections([.all])
+        snapshot.appendItems(draft.draftAttachments.map { .attachment($0) })
+        snapshot.appendItems([.addButton])
+        dataSource.apply(snapshot)
+    }
+    
+    @objc func reorderingLongPressRecognized(_ recognizer: UILongPressGestureRecognizer) {
+        let collectionView = recognizer.view as! UICollectionView
+        switch recognizer.state {
+        case .began:
+            break
+        case .changed:
+            var pos = recognizer.location(in: collectionView)
+            if let currentInteractiveMoveStartOffsetInCell {
+                pos.x -= currentInteractiveMoveStartOffsetInCell.x
+                pos.y -= currentInteractiveMoveStartOffsetInCell.y
+            }
+            collectionView.updateInteractiveMovementTargetPosition(pos)
+        case .ended:
+            collectionView.endInteractiveMovement()
+            UIView.animate(withDuration: 0.2) {
+                self.currentInteractiveMoveCell?.hostView?.transform = .identity
+            }
+            currentInteractiveMoveCell = nil
+            currentInteractiveMoveStartOffsetInCell = nil
+        case .cancelled:
+            collectionView.cancelInteractiveMovement()
+            UIView.animate(withDuration: 0.2) {
+                self.currentInteractiveMoveCell?.hostView?.transform = .identity
+            }
+            currentInteractiveMoveCell = nil
+            currentInteractiveMoveStartOffsetInCell = nil
+        default:
+            break
+        }
+    }
+    
+    enum Section {
+        case all
+    }
+    
+    enum Item: Hashable {
+        case attachment(DraftAttachment)
+        case addButton
+    }
+}
+
+extension WrappedCollectionViewController: UIGestureRecognizerDelegate {
+    func gestureRecognizerShouldBegin(_ gestureRecognizer: UIGestureRecognizer) -> Bool {
+        let collectionView = gestureRecognizer.view as! UICollectionView
+        let location = gestureRecognizer.location(in: collectionView)
+        guard let indexPath = collectionView.indexPathForItem(at: location),
+              let cell = collectionView.cellForItem(at: indexPath) as? HostingCollectionViewCell else {
+            return false
+        }
+        guard collectionView.beginInteractiveMovementForItem(at: indexPath) else {
+            return false
+        }
+        UIView.animate(withDuration: 0.2) {
+            cell.hostView?.transform = CGAffineTransform(scaleX: 1.2, y: 1.2)
+        }
+        currentInteractiveMoveCell = cell
+        currentInteractiveMoveStartOffsetInCell = gestureRecognizer.location(in: cell)
+        currentInteractiveMoveStartOffsetInCell!.x -= cell.bounds.midX
+        currentInteractiveMoveStartOffsetInCell!.y -= cell.bounds.midY
+        return true
+    }
+}
+
+extension WrappedCollectionViewController: UICollectionViewDelegate {
+    func collectionView(_ collectionView: UICollectionView, targetIndexPathForMoveOfItemFromOriginalIndexPath originalIndexPath: IndexPath, atCurrentIndexPath currentIndexPath: IndexPath, toProposedIndexPath proposedIndexPath: IndexPath) -> IndexPath {
+        let snapshot = dataSource.snapshot()
+        let items = snapshot.itemIdentifiers(inSection: .all).count
+        if proposedIndexPath.row == items - 1 {
+            return IndexPath(item: items - 2, section: proposedIndexPath.section)
+        } else {
+            return proposedIndexPath
+        }
+    }
+    
+    func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
+        guard case .attachment(_) = dataSource.itemIdentifier(for: indexPath) else {
+            return
+        }
+        let dataSource = AttachmentsGalleryDataSource(collectionView: collectionView) { [dataSource] in
+            let item = dataSource?.itemIdentifier(for: IndexPath(item: $0, section: 0))
+            switch item {
+            case .attachment(let attachment):
+                return attachment
+            default:
+                return nil
+            }
+        }
+        let galleryVC = GalleryViewController(dataSource: dataSource, initialItemIndex: indexPath.item)
+        galleryVC.showShareButton = false
+        present(galleryVC, animated: true)
+    }
+}
+
+private final class IntrinsicContentSizeCollectionView: UICollectionView {
+    private var _intrinsicContentSize = CGSize.zero
+    
+    override var intrinsicContentSize: CGSize {
+        _intrinsicContentSize
+    }
+    
+    override func layoutSubviews() {
+        super.layoutSubviews()
+        
+        if contentSize != _intrinsicContentSize {
+            _intrinsicContentSize = contentSize
+            invalidateIntrinsicContentSize()
+        }
+    }
+}
+
+#if os(visionOS)
+private class HostingCollectionViewCell: UICollectionViewCell {
+    private(set) var hostView: UIView?
+    
+    func setView<V: View>(_ view: V) {
+        let config = UIHostingConfiguration(content: {
+            view
+        }).margins(.all, 0)
+        
+        if let hostView = hostView as? UIContentView {
+            hostView.configuration = config
+        } else {
+            hostView = config.makeContentView()
+            hostView!.frame = contentView.bounds
+            contentView.addSubview(hostView!)
+        }
+    }
+}
+#else
+@available(iOS, obsoleted: 16.0)
+private class HostingCollectionViewCell: UICollectionViewCell {
+    weak var containingViewController: UIViewController?
+    
+    @available(iOS, obsoleted: 16.0)
+    private var hostController: UIHostingController<AnyView>?
+    private(set) var hostView: UIView?
+    
+    func setView<V: View>(_ view: V) {
+        if #available(iOS 16.0, *) {
+            let config = UIHostingConfiguration(content: {
+                view
+            }).margins(.all, 0)
+            
+            // We don't just use the cell's contentConfiguration property because we need to animate
+            // the size of the host view, and when the host view is the contentView, that doesn't work.
+            if let hostView = hostView as? UIContentView {
+                hostView.configuration = config
+            } else {
+                hostView = config.makeContentView()
+                hostView!.frame = contentView.bounds
+                contentView.addSubview(hostView!)
+            }
+        } else {
+            if let hostController {
+                hostController.rootView = AnyView(view)
+            } else {
+                let host = UIHostingController(rootView: AnyView(view))
+                containingViewController!.addChild(host)
+                host.view.frame = contentView.bounds
+                contentView.addSubview(host.view)
+                host.didMove(toParent: containingViewController!)
+                hostController = host
+                hostView = host.view
+            }
+        }
+    }
+}
+#endif
+
+private struct AddAttachmentButton: View {
+    unowned let viewController: WrappedCollectionViewController
+    let enabled: Bool
+    @Environment(\.composeUIConfig.presentAssetPicker) private var presentAssetPicker
+    @Environment(\.composeUIConfig.presentDrawing) private var presentDrawing
+
+    var body: some View {
+        Menu {
+            if let presentAssetPicker {
+                Button("Add photo or video", systemImage: "photo") {
+                    presentAssetPicker {
+                        let draft = viewController.draft!
+                        AttachmentsSection.insertAttachments(in: draft, at: draft.attachments.count, itemProviders: $0.map(\.itemProvider))
+                    }
+                }
+            }
+            if let presentDrawing {
+                Button("Draw something", systemImage: "hand.draw") {
+                    presentDrawing(PKDrawing()) { drawing in
+                        let draft = viewController.draft!
+                        let attachment = DraftAttachment(context: DraftsPersistentContainer.shared.viewContext)
+                        attachment.id = UUID()
+                        attachment.drawing = drawing
+                        attachment.draft = draft
+                        draft.attachments.add(attachment)
+                    }
+                }
+            }
+        } label: {
+            Image(systemName: iconName)
+                .imageScale(.large)
+                .frame(maxWidth: .infinity, maxHeight: .infinity)
+                .background {
+                    RoundedRectangle(cornerRadius: 5)
+                        .foregroundStyle(.tint.opacity(0.1))
+                    
+                    RoundedRectangle(cornerRadius: 5)
+                        .stroke(.tint, style: StrokeStyle(lineWidth: 2, dash: [5]))
+                }
+        }
+        .disabled(!enabled)
+    }
+    
+    private var iconName: String {
+        if #available(iOS 17.0, *) {
+            "photo.badge.plus"
+        } else {
+            "photo"
+        }
+    }
+}
+
+struct AddAttachmentConditionsModifier: ViewModifier {
+    @ObservedObject var draft: Draft
+    @EnvironmentObject private var instanceFeatures: InstanceFeatures
+    
+    private var canAddAttachment: Bool {
+        if instanceFeatures.mastodonAttachmentRestrictions {
+            return draft.attachments.count < 4
+                && draft.draftAttachments.allSatisfy { $0.type == .image }
+                && draft.poll == nil
+        } else {
+            return true
+        }
+    }
+
+    func body(content: Content) -> some View {
+        content
+            .environment(\.canAddAttachment, canAddAttachment)
+    }
+}
+
+private struct CanAddAttachmentKey: EnvironmentKey {
+    static let defaultValue = false
+}
+
+extension EnvironmentValues {
+    var canAddAttachment: Bool {
+        get { self[CanAddAttachmentKey.self] }
+        set { self[CanAddAttachmentKey.self] = newValue }
+    }
+}
+
+struct DropAttachmentModifier: ViewModifier {
+    let draft: Draft
+    @Environment(\.canAddAttachment) private var canAddAttachment
+    
+    func body(content: Content) -> some View {
+        content
+            .onDrop(of: DraftAttachment.readableTypeIdentifiersForItemProvider, delegate: AttachmentDropDelegate(draft: draft, canAddAttachment: canAddAttachment))
+    }
+}
+
+private struct AttachmentDropDelegate: DropDelegate {
+    let draft: Draft
+    let canAddAttachment: Bool
+    
+    func validateDrop(info: DropInfo) -> Bool {
+        canAddAttachment
+    }
+    
+    func performDrop(info: DropInfo) -> Bool {
+        AttachmentsSection.insertAttachments(in: draft, at: draft.attachments.count, itemProviders: info.itemProviders(for: DraftAttachment.readableTypeIdentifiersForItemProvider))
+        return true
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/Attachments/EditAttachmentWrapperGalleryContentViewController.swift

@@ -0,0 +1,198 @@
+//
+//  EditAttachmentWrapperGalleryContentViewController.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 11/22/24.
+//
+
+import UIKit
+import GalleryVC
+
+class EditAttachmentWrapperGalleryContentViewController: UIViewController, GalleryContentViewController {
+    let draftAttachment: DraftAttachment
+    let wrapped: any GalleryContentViewController
+    
+    var container: (any GalleryContentViewControllerContainer)?
+    
+    var contentSize: CGSize {
+        wrapped.contentSize
+    }
+    
+    var activityItemsForSharing: [Any] {
+        wrapped.activityItemsForSharing
+    }
+    
+    var caption: String? {
+        wrapped.caption
+    }
+    
+    private lazy var editDescriptionViewController: EditAttachmentDescriptionViewController = EditAttachmentDescriptionViewController(draftAttachment: draftAttachment, wrapped: wrapped.bottomControlsAccessoryViewController)
+    
+    var bottomControlsAccessoryViewController: UIViewController? {
+        editDescriptionViewController
+    }
+    
+    var insetBottomControlsAccessoryViewControllerToSafeArea: Bool {
+        false
+    }
+    
+    var presentationAnimation: GalleryContentPresentationAnimation {
+        wrapped.presentationAnimation
+    }
+    
+    var hideControlsOnZoom: Bool {
+        false
+    }
+    
+    init(draftAttachment: DraftAttachment, wrapped: any GalleryContentViewController) {
+        self.draftAttachment = draftAttachment
+        self.wrapped = wrapped
+        
+        super.init(nibName: nil, bundle: nil)
+    }
+    
+    required init?(coder: NSCoder) {
+        fatalError("init(coder:) has not been implemented")
+    }
+    
+    override func viewDidLoad() {
+        super.viewDidLoad()
+        
+        wrapped.container = container
+        addChild(wrapped)
+        wrapped.view.translatesAutoresizingMaskIntoConstraints = false
+        view.addSubview(wrapped.view)
+        NSLayoutConstraint.activate([
+            wrapped.view.leadingAnchor.constraint(equalTo: view.leadingAnchor),
+            wrapped.view.trailingAnchor.constraint(equalTo: view.trailingAnchor),
+            wrapped.view.topAnchor.constraint(equalTo: view.topAnchor),
+            wrapped.view.bottomAnchor.constraint(equalTo: view.bottomAnchor),
+        ])
+        wrapped.didMove(toParent: self)
+    }
+    
+    func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
+        wrapped.setControlsVisible(visible, animated: animated, dueToUserInteraction: dueToUserInteraction)
+        if !visible {
+            editDescriptionViewController.textView?.resignFirstResponder()
+        }
+    }
+    
+    func galleryContentDidAppear() {
+        wrapped.galleryContentDidAppear()
+    }
+    
+    func galleryContentWillDisappear() {
+        wrapped.galleryContentWillDisappear()
+    }
+    
+    func shouldHideControls() -> Bool {
+        if editDescriptionViewController.textView.isFirstResponder {
+            editDescriptionViewController.textView.resignFirstResponder()
+            return false
+        } else {
+            return true
+        }
+    }
+}
+
+private class EditAttachmentDescriptionViewController: UIViewController {
+    private let draftAttachment: DraftAttachment
+    private let wrapped: UIViewController?
+    
+    private(set) var textView: UITextView!
+    private var isShowingPlaceholder = false
+    
+    private var descriptionObservation: NSKeyValueObservation?
+    
+    init(draftAttachment: DraftAttachment, wrapped: UIViewController?) {
+        self.draftAttachment = draftAttachment
+        self.wrapped = wrapped
+        
+        super.init(nibName: nil, bundle: nil)
+    }
+    
+    required init?(coder: NSCoder) {
+        fatalError("init(coder:) has not been implemented")
+    }
+    
+    override func viewDidLoad() {
+        super.viewDidLoad()
+        
+        view.overrideUserInterfaceStyle = .dark
+        view.backgroundColor = .secondarySystemFill
+        
+        let stack = UIStackView()
+        stack.axis = .vertical
+        stack.distribution = .fill
+        stack.spacing = 0
+        stack.translatesAutoresizingMaskIntoConstraints = false
+        view.addSubview(stack)
+        NSLayoutConstraint.activate([
+            stack.leadingAnchor.constraint(equalTo: view.leadingAnchor),
+            stack.trailingAnchor.constraint(equalTo: view.trailingAnchor),
+            stack.topAnchor.constraint(equalTo: view.topAnchor),
+            stack.bottomAnchor.constraint(equalTo: view.keyboardLayoutGuide.topAnchor),
+        ])
+
+        if let wrapped {
+            stack.addArrangedSubview(wrapped.view)
+        }
+        
+        textView = UITextView()
+        textView.backgroundColor = nil
+        textView.font = .preferredFont(forTextStyle: .body)
+        textView.adjustsFontForContentSizeCategory = true
+        if draftAttachment.attachmentDescription.isEmpty {
+            showPlaceholder()
+        } else {
+            removePlaceholder()
+            textView.text = draftAttachment.attachmentDescription
+        }
+        textView.delegate = self
+        stack.addArrangedSubview(textView)
+        textView.heightAnchor.constraint(equalToConstant: 150).isActive = true
+        
+        descriptionObservation = draftAttachment.observe(\.attachmentDescription) { [unowned self] _, _ in
+            let desc = self.draftAttachment.attachmentDescription
+            if desc.isEmpty {
+                if !isShowingPlaceholder {
+                    showPlaceholder()
+                }
+            } else {
+                if isShowingPlaceholder {
+                    removePlaceholder()
+                }
+                self.textView.text = desc
+            }
+        }
+    }
+    
+    fileprivate func showPlaceholder() {
+        isShowingPlaceholder = true
+        textView.text = "Describe for the visually impaired"
+        textView.textColor = .secondaryLabel
+    }
+    
+    fileprivate func removePlaceholder() {
+        isShowingPlaceholder = false
+        textView.text = ""
+        textView.textColor = .label
+    }
+}
+
+extension EditAttachmentDescriptionViewController: UITextViewDelegate {
+    func textViewDidBeginEditing(_ textView: UITextView) {
+        if isShowingPlaceholder {
+            removePlaceholder()
+        }
+    }
+    
+    func textViewDidEndEditing(_ textView: UITextView) {
+        draftAttachment.attachmentDescription = textView.text
+        
+        if textView.text.isEmpty {
+            showPlaceholder()
+        }
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/ComposeDraftView.swift

@@ -0,0 +1,59 @@
+//
+//  ComposeDraftView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 11/16/24.
+//
+
+import SwiftUI
+import Pachyderm
+import TuskerComponents
+
+struct ComposeDraftView: View {
+    @ObservedObject var draft: Draft
+    @FocusState.Binding var focusedField: FocusableField?
+    @Environment(\.currentAccount) private var currentAccount
+    @EnvironmentObject private var controller: ComposeController
+
+    var body: some View {
+        HStack(alignment: .top, spacing: 8) {
+            // TODO: scroll effect?
+            AvatarImageView(
+                url: currentAccount?.avatar,
+                size: 50,
+                style: controller.config.avatarStyle,
+                fetchAvatar: controller.fetchAvatar
+            )
+            .accessibilityHidden(true)
+            
+            VStack(alignment: .leading, spacing: 4) {
+                if let currentAccount {
+                    AccountNameView(account: currentAccount)
+                }
+                
+                ContentWarningTextField(draft: draft, focusedField: $focusedField)
+                
+                DraftContentEditor(draft: draft, focusedField: $focusedField)
+                
+                AttachmentsSection(draft: draft)
+            }
+        }
+    }
+}
+
+private struct AccountNameView: View {
+    let account: any AccountProtocol
+    @EnvironmentObject private var controller: ComposeController
+
+    var body: some View {
+        HStack(spacing: 4) {
+            controller.displayNameLabel(account, .body, 16)
+                .lineLimit(1)
+            
+            Text(verbatim: "@\(account.acct)")
+                .font(.body.weight(.light))
+                .foregroundColor(.secondary)
+                .lineLimit(1)
+        }
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/ComposeToolbarView.swift

@@ -0,0 +1,242 @@
+//
+//  ComposeToolbarView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+import TuskerComponents
+import InstanceFeatures
+import Pachyderm
+import TuskerPreferences
+
+struct ComposeToolbarView: View {
+    static let height: CGFloat = 44
+    
+    @ObservedObject var draft: Draft
+    let mastodonController: any ComposeMastodonContext
+    @FocusState.Binding var focusedField: FocusableField?
+    
+    var body: some View {
+        #if os(visionOS)
+        buttons
+        #else
+        ToolbarScrollView {
+            buttons
+                .padding(.horizontal, 16)
+        }
+        .frame(height: Self.height)
+        .background(.regularMaterial, ignoresSafeAreaEdges: [.bottom, .leading, .trailing])
+        .overlay(alignment: .top) {
+            Divider()
+                .ignoresSafeArea(edges: [.leading, .trailing])
+        }
+        #endif
+    }
+    
+    private var buttons: some View {
+        HStack(spacing: 0) {
+            ContentWarningButton(enabled: $draft.contentWarningEnabled, focusedField: $focusedField)
+            
+            VisibilityButton(draft: draft, instanceFeatures: mastodonController.instanceFeatures)
+            
+            LocalOnlyButton(enabled: $draft.localOnly, mastodonController: mastodonController)
+            
+            InsertEmojiButton()
+            
+            FormatButtons()
+            
+            Spacer()
+        }
+    }
+}
+
+#if !os(visionOS)
+private struct ToolbarScrollView<Content: View>: View {
+    @ViewBuilder let content: Content
+    @State private var minWidth: CGFloat?
+    @State private var realWidth: CGFloat?
+    
+    var body: some View {
+        ScrollView(.horizontal, showsIndicators: false) {
+            content
+                .frame(minWidth: minWidth)
+                .background {
+                    GeometryReader { proxy in
+                        Color.clear
+                            .preference(key: ToolbarWidthPrefKey.self, value: proxy.size.width)
+                            .onPreferenceChange(ToolbarWidthPrefKey.self) {
+                                realWidth = $0
+                            }
+                    }
+                }
+        }
+        .scrollDisabledIfAvailable(realWidth ?? 0 <= minWidth ?? 0)
+        .frame(maxWidth: .infinity)
+        .background {
+            GeometryReader { proxy in
+                Color.clear
+                    .preference(key: ToolbarWidthPrefKey.self, value: proxy.size.width)
+                    .onPreferenceChange(ToolbarWidthPrefKey.self) {
+                        minWidth = $0
+                    }
+            }
+        }
+    }
+}
+#endif
+
+private struct ToolbarWidthPrefKey: SwiftUI.PreferenceKey {
+    static var defaultValue: CGFloat? = nil
+    static func reduce(value: inout CGFloat?, nextValue: () -> CGFloat?) {
+        value = value ?? nextValue()
+    }
+}
+
+private struct ContentWarningButton: View {
+    @Binding var enabled: Bool
+    @FocusState.Binding var focusedField: FocusableField?
+    
+    var body: some View {
+        Button("CW", action: toggleContentWarning)
+            .accessibilityLabel(enabled ? "Remove content warning" : "Add content warning")
+            .padding(5)
+            .hoverEffect()
+    }
+    
+    private func toggleContentWarning() {
+        enabled.toggle()
+        if enabled {
+            focusedField = .contentWarning
+        }
+    }
+}
+
+private struct VisibilityButton: View {
+    @ObservedObject var draft: Draft
+    @ObservedObject var instanceFeatures: InstanceFeatures
+    
+    private var visibilityBinding: Binding<Pachyderm.Visibility> {
+        // On instances that conflate visibliity and local only, we still show two separate controls but don't allow
+        // changing the visibility when local-only.
+        if draft.localOnly,
+           instanceFeatures.localOnlyPostsVisibility {
+            return .constant(.public)
+        } else {
+            return $draft.visibility
+        }
+    }
+    
+    private var visibilityOptions: [MenuPicker<Pachyderm.Visibility>.Option] {
+        let visibilities: [Pachyderm.Visibility]
+        if !instanceFeatures.composeDirectStatuses {
+            visibilities = [.public, .unlisted, .private]
+        } else {
+            visibilities = Pachyderm.Visibility.allCases
+        }
+        return visibilities.map { vis in
+            .init(value: vis, title: vis.displayName, subtitle: vis.subtitle, image: UIImage(systemName: vis.unfilledImageName), accessibilityLabel: "Visibility: \(vis.displayName)")
+        }
+    }
+    
+    var body: some View {
+        MenuPicker(selection: visibilityBinding, options: visibilityOptions, buttonStyle: .iconOnly)
+            #if !targetEnvironment(macCatalyst) && !os(visionOS)
+            // the button has a bunch of extra space by default, but combined with what we add it's too much
+            .padding(.horizontal, -8)
+            #endif
+            .disabled(draft.editedStatusID != nil)
+            .disabled(instanceFeatures.localOnlyPostsVisibility && draft.localOnly)
+    }
+}
+
+private struct LocalOnlyButton: View {
+    @Binding var enabled: Bool
+    var mastodonController: any ComposeMastodonContext
+    @ObservedObject private var instanceFeatures: InstanceFeatures
+    
+    init(enabled: Binding<Bool>, mastodonController: any ComposeMastodonContext) {
+        self._enabled = enabled
+        self.mastodonController = mastodonController
+        self.instanceFeatures = mastodonController.instanceFeatures
+    }
+    
+    private var options: [MenuPicker<Bool>.Option] {
+        let domain = mastodonController.accountInfo!.instanceURL.host!
+        return [
+            .init(value: true, title: "Local-only", subtitle: "Only \(domain)", image: UIImage(named: "link.broken")),
+            .init(value: false, title: "Federated", image: UIImage(systemName: "link")),
+        ]
+    }
+    
+    var body: some View {
+        if mastodonController.instanceFeatures.localOnlyPosts {
+            MenuPicker(selection: $enabled, options: options, buttonStyle: .iconOnly)
+        }
+    }
+}
+
+private struct InsertEmojiButton: View {
+    @FocusedValue(\.composeInput) private var input
+    @ScaledMetric(relativeTo: .body) private var imageSize: CGFloat = 22
+    
+    var body: some View {
+        if input??.toolbarElements.contains(.emojiPicker) == true {
+            Button(action: beginAutocompletingEmoji) {
+                Label("Insert custom emoji", systemImage: "face.smiling")
+            }
+            .labelStyle(.iconOnly)
+            .font(.system(size: imageSize))
+            .padding(5)
+            .hoverEffect()
+            .transition(.opacity.animation(.linear(duration: 0.2)))
+        }
+    }
+    
+    private func beginAutocompletingEmoji() {
+        input??.beginAutocompletingEmoji()
+    }
+}
+
+private struct FormatButtons: View {
+    @FocusedValue(\.composeInput) private var input
+    @PreferenceObserving(\.$statusContentType) private var contentType
+    
+    var body: some View {
+        if let input = input.flatMap(\.self),
+           input.toolbarElements.contains(.formattingButtons),
+           contentType != .plain {
+            
+            Spacer()
+            ForEach(StatusFormat.allCases) { format in
+                FormatButton(format: format, input: input)
+            }
+        }
+    }
+}
+
+private struct FormatButton: View {
+    let format: StatusFormat
+    let input: any ComposeInput
+    @ScaledMetric(relativeTo: .body) private var imageSize: CGFloat = 22
+    
+    var body: some View {
+        Button(action: applyFormat) {
+            Image(systemName: format.imageName)
+                .font(.system(size: imageSize))
+        }
+        .accessibilityLabel(format.accessibilityLabel)
+        .padding(5)
+        .hoverEffect()
+        .transition(.opacity.animation(.linear(duration: 0.2)))
+    }
+    
+    private func applyFormat() {
+        input.applyFormat(format)
+    }
+}
+
+//#Preview {
+//    ComposeToolbarView()
+//}

Packages/ComposeUI/Sources/ComposeUI/Views/ComposeView.swift

@@ -0,0 +1,242 @@
+//
+//  ComposeView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+
+struct ComposeView: View {
+    @ObservedObject var draft: Draft
+    let mastodonController: any ComposeMastodonContext
+    @State private var poster: PostService? = nil
+    @FocusState private var focusedField: FocusableField?
+    @EnvironmentObject private var controller: ComposeController
+    
+    var body: some View {
+        navigation
+            .environmentObject(mastodonController.instanceFeatures)
+    }
+    
+    @ViewBuilder
+    private var navigation: some View {
+        #if os(visionOS)
+        NavigationStack {
+            navigationRoot
+        }
+        #else
+        if #available(iOS 16.0, *) {
+            NavigationStack {
+                navigationRoot
+            }
+        } else {
+            NavigationView {
+                navigationRoot
+            }
+            .navigationViewStyle(.stack)
+        }
+        #endif
+    }
+    
+    private var navigationRoot: some View {
+        ZStack {
+            ScrollView {
+                scrollContent
+            }
+            .scrollDismissesKeyboardInteractivelyIfAvailable()
+            #if !os(visionOS) && !targetEnvironment(macCatalyst)
+            .modifier(ToolbarSafeAreaInsetModifier())
+            #endif
+        }
+        .overlay(alignment: .top) {
+            if let poster {
+                PostProgressView(poster: poster)
+                    .frame(alignment: .top)
+            }
+        }
+        #if !os(visionOS)
+        .overlay(alignment: .bottom, content: {
+            // TODO: during ducking animation, toolbar should move off the botto edge
+            // This needs to be in an overlay, ignoring the keyboard safe area
+            // doesn't work with the safeAreaInset modifier.
+            toolbarView
+                .frame(maxHeight: .infinity, alignment: .bottom)
+                .ignoresSafeArea(.keyboard)
+        })
+        #endif
+        // Have these after the overlays so they barely work instead of not working at all. FB11790805
+        .modifier(DropAttachmentModifier(draft: draft))
+        .modifier(AddAttachmentConditionsModifier(draft: draft))
+        .modifier(NavigationTitleModifier(draft: draft, mastodonController: mastodonController))
+        .navigationBarTitleDisplayMode(.inline)
+        .toolbar {
+            ToolbarActions(draft: draft, controller: controller)
+            #if os(visionOS)
+            ToolbarItem(placement: .bottomOrnament) {
+                toolbarView
+            }
+            #endif
+        }
+    }
+    
+    private var toolbarView: some View {
+        ComposeToolbarView(draft: draft, mastodonController: mastodonController, focusedField: $focusedField)
+    }
+    
+    @ViewBuilder
+    private var scrollContent: some View {
+        VStack(spacing: 8) {
+            NewReplyStatusView(draft: draft, mastodonController: mastodonController)
+            
+            ComposeDraftView(draft: draft, focusedField: $focusedField)
+        }
+        .padding(8)
+    }
+    
+    private func addAttachments(_ itemProviders: [NSItemProvider]) {
+        AttachmentsSection.insertAttachments(in: draft, at: draft.attachments.count, itemProviders: itemProviders)
+    }
+}
+
+private struct NavigationTitleModifier: ViewModifier {
+    let draft: Draft
+    let mastodonController: any ComposeMastodonContext
+    
+    private var navigationTitle: String {
+        if let id = draft.inReplyToID,
+           let status = mastodonController.fetchStatus(id: id) {
+            return "Reply to @\(status.account.acct)"
+        } else if draft.editedStatusID != nil {
+            return "Edit Post"
+        } else {
+            return "New Post"
+        }
+    }
+
+    func body(content: Content) -> some View {
+        content
+            .navigationTitle(navigationTitle)
+            .preference(key: NavigationTitlePreferenceKey.self, value: navigationTitle)
+    }
+}
+
+// Public preference so that the host can read the title.
+public struct NavigationTitlePreferenceKey: PreferenceKey {
+    public static var defaultValue: String? { nil }
+    public static func reduce(value: inout String?, nextValue: () -> String?) {
+        value = value ?? nextValue()
+    }
+}
+
+private struct ToolbarActions: ToolbarContent {
+    @ObservedObject var draft: Draft
+    // Prior to iOS 16, the toolbar content doesn't seem to have access
+    // to the environment form the containing view.
+    let controller: ComposeController
+    
+    var body: some ToolbarContent {
+        ToolbarItem(placement: .cancellationAction) { ToolbarCancelButton(draft: draft) }
+        
+        #if targetEnvironment(macCatalyst)
+        ToolbarItem(placement: .topBarTrailing) { draftsButton }
+        ToolbarItem(placement: .confirmationAction) { postButton }
+        #else
+        ToolbarItem(placement: .confirmationAction) { postOrDraftsButton }
+        #endif
+    }
+    
+    private var draftsButton: some View {
+        Button(action: controller.showDrafts) {
+            Text("Drafts")
+        }
+    }
+    
+    private var postButton: some View {
+        // TODO: don't use the controller for this
+        Button(action: controller.postStatus) {
+            Text(draft.editedStatusID == nil ? "Post" : "Edit")
+        }
+        .keyboardShortcut(.return, modifiers: .command)
+        .disabled(!controller.postButtonEnabled)
+    }
+    
+    #if !targetEnvironment(macCatalyst)
+    @ViewBuilder
+    private var postOrDraftsButton: some View {
+        if draft.hasContent || draft.editedStatusID != nil || !controller.config.allowSwitchingDrafts {
+            postButton
+        } else {
+            draftsButton
+        }
+    }
+    #endif
+}
+
+private struct ToolbarCancelButton: View {
+    let draft: Draft
+    @EnvironmentObject private var controller: ComposeController
+    
+    var body: some View {
+        Button(action: controller.cancel) {
+            Text("Cancel")
+                // otherwise all Buttons in the nav bar are made semibold
+                .font(.system(size: 17, weight: .regular))
+        }
+        .disabled(controller.isPosting)
+        .confirmationDialog("Are you sure?", isPresented: $controller.isShowingSaveDraftSheet) {
+            // edit drafts can't be saved
+            if draft.editedStatusID == nil {
+                Button(action: { controller.cancel(deleteDraft: false) }) {
+                    Text("Save Draft")
+                }
+                Button(role: .destructive, action: { controller.cancel(deleteDraft: true) }) {
+                    Text("Delete Draft")
+                }
+            } else {
+                Button(role: .destructive, action: { controller.cancel(deleteDraft: true) }) {
+                    Text("Cancel Edit")
+                }
+            }
+        }
+    }
+}
+
+enum FocusableField: Hashable {
+    case contentWarning
+    case body
+    case attachmentDescription(UUID)
+    
+    var nextField: FocusableField? {
+        switch self {
+        case .contentWarning:
+            return .body
+        default:
+            return nil
+        }
+    }
+}
+
+#if !os(visionOS) && !targetEnvironment(macCatalyst)
+private struct ToolbarSafeAreaInsetModifier: ViewModifier {
+    @StateObject private var keyboardReader = KeyboardReader()
+    
+    func body(content: Content) -> some View {
+        if #available(iOS 17.0, *) {
+            content
+                .safeAreaPadding(.bottom, keyboardReader.isVisible ? 0 : ComposeToolbarView.height)
+        } else {
+            content
+                .safeAreaInset(edge: .bottom) {
+                    if !keyboardReader.isVisible {
+                        Color.clear.frame(height: ComposeToolbarView.height)
+                    }
+                }
+        }
+    }
+}
+#endif
+
+//#Preview {
+//    ComposeView()
+//}

Packages/ComposeUI/Sources/ComposeUI/Views/ContentWarningTextField.swift

@@ -0,0 +1,38 @@
+//
+//  ContentWarningTextField.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+
+struct ContentWarningTextField: View {
+    @ObservedObject var draft: Draft
+    @FocusState.Binding var focusedField: FocusableField?
+    
+    var body: some View {
+        if draft.contentWarningEnabled {
+            EmojiTextField(
+                text: $draft.contentWarning,
+                placeholder: "Write your warning here",
+                maxLength: nil,
+                // TODO: completely replace this with FocusState
+                becomeFirstResponder: .constant(false),
+                focusNextView: Binding(get: {
+                    false
+                }, set: {
+                    if $0 {
+                        focusedField = .body
+                    }
+                })
+            )
+            .focused($focusedField, equals: .contentWarning)
+            .modifier(FocusedInputModifier())
+        }
+    }
+}
+
+//#Preview {
+//    ContentWarningTextField()
+//}

Packages/ComposeUI/Sources/ComposeUI/Views/DraftContentEditor.swift

@@ -0,0 +1,98 @@
+//
+//  DraftContentEditor.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 11/16/24.
+//
+
+import SwiftUI
+import InstanceFeatures
+
+struct DraftContentEditor: View {
+    @ObservedObject var draft: Draft
+    @FocusState.Binding var focusedField: FocusableField?
+    @Environment(\.colorScheme) private var colorScheme
+    @Environment(\.composeUIConfig.fillColor) private var fillColor
+
+    var body: some View {
+        VStack(spacing: 4) {
+            NewMainTextView(value: $draft.text, focusedField: $focusedField, handleAttachmentDrop: self.addAttachments)
+            
+            HStack(alignment: .firstTextBaseline) {
+                LanguageButton(draft: draft)
+                Spacer()
+                CharactersRemaining(draft: draft)
+                    .padding(.trailing, 4)
+            }
+            .padding(.all.subtracting(.top), 2)
+        }
+        .background {
+            RoundedRectangle(cornerRadius: 5)
+                .fill(colorScheme == .dark ? fillColor : Color(uiColor: .secondarySystemBackground))
+        }
+    }
+    
+    private func addAttachments(_ providers: [NSItemProvider]) {
+        AttachmentsSection.insertAttachments(in: draft, at: draft.attachments.count, itemProviders: providers)
+    }
+}
+
+private struct CharactersRemaining: View {
+    @ObservedObject var draft: Draft
+    @EnvironmentObject var instanceFeatures: InstanceFeatures
+    
+    private var charsRemaining: Int {
+        let limit = instanceFeatures.maxStatusChars
+        let cwCount = draft.contentWarningEnabled ? draft.contentWarning.count : 0
+        return limit - (cwCount + CharacterCounter.count(text: draft.text, for: instanceFeatures))
+    }
+    
+    var body: some View {
+        Text(verbatim: charsRemaining.description)
+            .foregroundStyle(charsRemaining < 0 ? .red : .secondary)
+            .font(.callout.monospacedDigit())
+            .accessibility(label: Text(charsRemaining < 0 ? "\(-charsRemaining) characters too many" : "\(charsRemaining) characters remaining"))
+    }
+}
+
+private struct LanguageButton: View {
+    @ObservedObject var draft: Draft
+    @EnvironmentObject private var instanceFeatures: InstanceFeatures
+    @FocusedValue(\.composeInput) private var input
+    @State private var hasChanged = false
+    
+    var body: some View {
+        if #available(iOS 16.0, *),
+           instanceFeatures.createStatusWithLanguage {
+            LanguagePicker(draftLanguage: $draft.language, hasChangedSelection: $hasChanged)
+                .buttonStyle(LanguageButtonStyle())
+                .onReceive(NotificationCenter.default.publisher(for: UITextInputMode.currentInputModeDidChangeNotification), perform: currentInputModeChanged)
+                .onChange(of: draft.id) { _ in
+                    hasChanged = false
+                }
+        }
+    }
+    
+    @available(iOS 16.0, *)
+    private func currentInputModeChanged(_ notification: Foundation.Notification) {
+        guard !hasChanged,
+              !draft.hasContent,
+              let mode = input??.textInputMode,
+              let code = LanguagePicker.codeFromInputMode(mode) else {
+            return
+        }
+        draft.language = code.identifier
+    }
+}
+
+private struct LanguageButtonStyle: ButtonStyle {
+    func makeBody(configuration: Configuration) -> some View {
+        configuration.label
+            .font(.callout)
+            .foregroundStyle(.tint.opacity(configuration.isPressed ? 0.8 : 1))
+            .padding(.vertical, 2)
+            .padding(.horizontal, 4)
+            .background(.tint.opacity(configuration.isPressed ? 0.15 : 0.2), in: RoundedRectangle(cornerRadius: 3))
+            .animation(.linear(duration: 0.1), value: configuration.isPressed)
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/EmojiTextField.swift

@@ -12,6 +12,7 @@ struct EmojiTextField: UIViewRepresentable {
     
     @EnvironmentObject private var controller: ComposeController
     @Environment(\.colorScheme) private var colorScheme
+    @Environment(\.composeInputBox) private var inputBox
     
     @Binding var text: String
     let placeholder: String
@@ -75,7 +76,11 @@ struct EmojiTextField: UIViewRepresentable {
     }
     
     func makeCoordinator() -> Coordinator {
-        Coordinator(controller: controller, text: $text, focusNextView: focusNextView)
+        let coordinator = Coordinator(controller: controller, text: $text, focusNextView: focusNextView)
+        DispatchQueue.main.async {
+            inputBox.wrappedValue = coordinator
+        }
+        return coordinator
     }
     
     class Coordinator: NSObject, UITextFieldDelegate, ComposeInput {
@@ -113,12 +118,16 @@ struct EmojiTextField: UIViewRepresentable {
         }
         
         func textFieldDidBeginEditing(_ textField: UITextField) {
-            controller.currentInput = self
+            DispatchQueue.main.async {
+                self.controller.currentInput = self
+            }
             autocompleteState = textField.updateAutocompleteState(permittedModes: .emojis)
         }
         
         func textFieldDidEndEditing(_ textField: UITextField) {
-            controller.currentInput = nil
+            DispatchQueue.main.async {
+                self.controller.currentInput = nil
+            }
             autocompleteState = textField.updateAutocompleteState(permittedModes: .emojis)
         }
         

Packages/ComposeUI/Sources/ComposeUI/Views/NewMainTextView.swift

@@ -0,0 +1,286 @@
+//
+//  NewMainTextView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/11/24.
+//
+
+import SwiftUI
+
+struct NewMainTextView: View {
+    static var minHeight: CGFloat { 150 }
+    
+    @Binding var value: String
+    @FocusState.Binding var focusedField: FocusableField?
+    var handleAttachmentDrop: ([NSItemProvider]) -> Void
+    @State private var becomeFirstResponder = true
+    
+    var body: some View {
+        NewMainTextViewRepresentable(value: $value, becomeFirstResponder: $becomeFirstResponder, handleAttachmentDrop: handleAttachmentDrop)
+            .focused($focusedField, equals: .body)
+            .modifier(FocusedInputModifier())
+            .overlay(alignment: .topLeading) {
+                if value.isEmpty {
+                    PlaceholderView()
+                }
+            }
+    }
+}
+
+private struct NewMainTextViewRepresentable: UIViewRepresentable {
+    @Binding var value: String
+    @Binding var becomeFirstResponder: Bool
+    var handleAttachmentDrop: ([NSItemProvider]) -> Void
+    @Environment(\.composeInputBox) private var inputBox
+    @Environment(\.isEnabled) private var isEnabled
+    @Environment(\.colorScheme) private var colorScheme
+    @Environment(\.composeUIConfig.fillColor) private var fillColor
+    @Environment(\.composeUIConfig.useTwitterKeyboard) private var useTwitterKeyboard
+    // TODO: test textSelectionStartsAtBeginning
+    @Environment(\.composeUIConfig.textSelectionStartsAtBeginning) private var textSelectionStartsAtBeginning
+    
+    func makeUIView(context: Context) -> UITextView {
+        // TODO: if we're not doing the pill background, reevaluate whether this version fork is necessary
+        let view = if #available(iOS 16.0, *) {
+            WrappedTextView(usingTextLayoutManager: true)
+        } else {
+            WrappedTextView()
+        }
+        view.addInteraction(UIDropInteraction(delegate: context.coordinator))
+        view.delegate = context.coordinator
+        view.adjustsFontForContentSizeCategory = true
+        view.textContainer.lineBreakMode = .byWordWrapping
+        view.isScrollEnabled = false
+        view.typingAttributes = [
+            .foregroundColor: UIColor.label,
+            .font: UIFontMetrics.default.scaledFont(for: .systemFont(ofSize: 20)),
+        ]
+        view.backgroundColor = nil
+        
+//        view.layer.cornerRadius = 5
+//        view.layer.cornerCurve = .continuous
+//        view.layer.shadowColor = UIColor.black.cgColor
+//        view.layer.shadowOpacity = 0.15
+//        view.layer.shadowOffset = .zero
+//        view.layer.shadowRadius = 1
+        
+        if textSelectionStartsAtBeginning {
+            // Update the text immediately so that the selection isn't invalidated by the text changing.
+            context.coordinator.updateTextViewTextIfNecessary(value, textView: view)
+            view.selectedTextRange = view.textRange(from: view.beginningOfDocument, to: view.beginningOfDocument)
+        }
+        
+        return view
+    }
+    
+    func updateUIView(_ uiView: UIViewType, context: Context) {
+        context.coordinator.value = $value
+        context.coordinator.handleAttachmentDrop = handleAttachmentDrop
+        context.coordinator.updateTextViewTextIfNecessary(value, textView: uiView)
+        
+        uiView.isEditable = isEnabled
+        uiView.keyboardType = useTwitterKeyboard ? .twitter : .default
+//        #if !os(visionOS)
+//        uiView.backgroundColor = colorScheme == .dark ? UIColor(fillColor) : .secondarySystemBackground
+//        #endif
+        
+        // Trying to set this with the @FocusState binding in onAppear results in the
+        // keyboard not appearing until after the sheet presentation animation completes :/
+        if becomeFirstResponder {
+            uiView.becomeFirstResponder()
+            DispatchQueue.main.async {
+                becomeFirstResponder = false
+            }
+        }
+    }
+    
+    func makeCoordinator() -> WrappedTextViewCoordinator {
+        let coordinator = WrappedTextViewCoordinator(value: $value, handleAttachmentDrop: handleAttachmentDrop)
+//        DispatchQueue.main.async {
+//            inputBox.wrappedValue = coordinator
+//        }
+        return coordinator
+    }
+    
+    @available(iOS 16.0, *)
+    func sizeThatFits(_ proposal: ProposedViewSize, uiView: UIViewType, context: Context) -> CGSize? {
+        let width = proposal.width ?? 10
+        let size = uiView.sizeThatFits(CGSize(width: width, height: 0))
+        return CGSize(width: width, height: max(NewMainTextView.minHeight, size.height))
+    }
+}
+
+// laxer than the CharacterCounter regex, because we want to find mentions that are being typed but aren't yet complete (e.g., "@a@b")
+private let mentionRegex = try! NSRegularExpression(pattern: "(@[a-z0-9_]+)(?:@[a-z0-9\\-\\.]+)?", options: .caseInsensitive)
+
+private final class WrappedTextViewCoordinator: NSObject {
+    private static let attachment: NSTextAttachment = {
+        let font = UIFont.systemFont(ofSize: 20)
+        let size = /*1.4 * */font.capHeight
+        let renderer = UIGraphicsImageRenderer(size: CGSize(width: size, height: size))
+        let image = renderer.image { ctx in
+            UIColor.systemRed.setFill()
+            ctx.fill(CGRect(x: 0, y: 0, width: size, height: size))
+        }
+        let attachment = NSTextAttachment(image: image)
+        attachment.bounds = CGRect(x: 0, y: -1, width: size + 2, height: size)
+        attachment.lineLayoutPadding = 1
+        return attachment
+    }()
+    
+    var value: Binding<String>
+    var handleAttachmentDrop: ([NSItemProvider]) -> Void
+    
+    init(value: Binding<String>, handleAttachmentDrop: @escaping ([NSItemProvider]) -> Void) {
+        self.value = value
+        self.handleAttachmentDrop = handleAttachmentDrop
+    }
+    
+    private func plainTextFromAttributed(_ attributedText: NSAttributedString) -> String {
+        attributedText.string.replacingOccurrences(of: "\u{FFFC}", with: "")
+    }
+    
+    private func attributedTextFromPlain(_ text: String) -> NSAttributedString {
+        let str = NSMutableAttributedString(string: text)
+        let mentionMatches = CharacterCounter.mention.matches(in: text, range: NSRange(location: 0, length: str.length))
+        for match in mentionMatches.reversed() {
+            str.insert(NSAttributedString(attachment: Self.attachment), at: match.range.location)
+            let range = NSRange(location: match.range.location, length: match.range.length + 1)
+            str.addAttributes([
+                .mention: true,
+                .foregroundColor: UIColor.tintColor,
+            ], range: range)
+        }
+        return str
+    }
+    
+    func updateTextViewTextIfNecessary(_ text: String, textView: UITextView) {
+        if text != plainTextFromAttributed(textView.attributedText) {
+            textView.attributedText = attributedTextFromPlain(text)
+        }
+    }
+    
+    private func updateAttributes(in textView: UITextView) {
+        let str = NSMutableAttributedString(attributedString: textView.attributedText!)
+        var changed = false
+        var cursorOffset = 0
+        
+        // remove existing mentions that aren't valid
+        str.enumerateAttribute(.mention, in: NSRange(location: 0, length: str.length), options: .reverse) { value, range, stop in
+            var substr = (str.string as NSString).substring(with: range)
+            let hasTextAttachment = substr.unicodeScalars.first == UnicodeScalar(NSTextAttachment.character)
+            if hasTextAttachment {
+                substr = String(substr.dropFirst())
+            }
+            if mentionRegex.numberOfMatches(in: substr, range: NSRange(location: 0, length: substr.utf16.count)) == 0 {
+                changed = true
+                str.removeAttribute(.mention, range: range)
+                str.removeAttribute(.foregroundColor, range: range)
+                if hasTextAttachment {
+                    str.deleteCharacters(in: NSRange(location: range.location, length: 1))
+                    cursorOffset -= 1
+                }
+            }
+        }
+        
+        // add mentions for those missing
+        let mentionMatches = mentionRegex.matches(in: str.string, range: NSRange(location: 0, length: str.length))
+        for match in mentionMatches.reversed() {
+            var attributeRange = NSRange()
+            let attribute = str.attribute(.mention, at: match.range.location, effectiveRange: &attributeRange)
+            // the attribute range should always be one greater than the match range, to account for the text attachment
+            if attribute == nil || attributeRange.length <= match.range.length {
+                changed = true
+                let newAttributeRange: NSRange
+                if attribute == nil {
+                    str.insert(NSAttributedString(attachment: Self.attachment), at: match.range.location)
+                    newAttributeRange = NSRange(location: match.range.location, length: match.range.length + 1)
+                    cursorOffset += 1
+                } else {
+                    newAttributeRange = match.range
+                }
+                str.addAttributes([
+                    .mention: true,
+                    .foregroundColor: UIColor.tintColor,
+                ], range: newAttributeRange)
+            }
+        }
+        
+        if changed {
+            let selection = textView.selectedRange
+            
+            textView.attributedText = str
+            
+            textView.selectedRange = NSRange(location: selection.location + cursorOffset, length: selection.length)
+        }
+    }
+}
+
+extension WrappedTextViewCoordinator: UITextViewDelegate {
+    func textViewDidChange(_ textView: UITextView) {
+        if textView.text.isEmpty {
+            textView.typingAttributes = [
+                .foregroundColor: UIColor.label,
+                .font: UIFontMetrics.default.scaledFont(for: .systemFont(ofSize: 20)),
+            ]
+        } else {
+            updateAttributes(in: textView)
+        }
+        
+        let plain = plainTextFromAttributed(textView.attributedText)
+        if plain != value.wrappedValue {
+            value.wrappedValue = plain
+        }
+    }
+    
+    func textViewDidChangeSelection(_ textView: UITextView) {
+    }
+}
+
+//extension WrappedTextViewCoordinator: ComposeInput {
+//    
+//}
+
+// Because of FB11790805, we can't handle drops for the entire screen.
+// The onDrop modifier also doesn't work when applied to the NewMainTextView.
+// So, manually add the UIInteraction to at least handle that.
+extension WrappedTextViewCoordinator: UIDropInteractionDelegate {
+    func dropInteraction(_ interaction: UIDropInteraction, canHandle session: any UIDropSession) -> Bool {
+        session.canLoadObjects(ofClass: DraftAttachment.self)
+    }
+    func dropInteraction(_ interaction: UIDropInteraction, sessionDidUpdate session: any UIDropSession) -> UIDropProposal {
+        UIDropProposal(operation: .copy)
+    }
+    func dropInteraction(_ interaction: UIDropInteraction, performDrop session: any UIDropSession) {
+        handleAttachmentDrop(session.items.map(\.itemProvider))
+    }
+}
+
+private final class WrappedTextView: UITextView {
+}
+
+private extension NSAttributedString.Key {
+    static let mention = NSAttributedString.Key("Tusker.ComposeUI.mention")
+}
+
+private struct PlaceholderView: View {
+    @State private var placeholder: PlaceholderController.PlaceholderView = PlaceholderController.makePlaceholderView()
+    @ScaledMetric private var fontSize = 20
+    
+    private var placeholderOffset: CGSize {
+        #if os(visionOS)
+        CGSize(width: 8, height: 8)
+        #else
+        CGSize(width: 4, height: 8)
+        #endif
+    }
+
+    var body: some View {
+        placeholder
+            .font(.system(size: fontSize))
+            .foregroundStyle(.secondary)
+            .offset(placeholderOffset)
+            .accessibilityHidden(true)
+            .allowsHitTesting(false)
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/PostProgressView.swift

@@ -0,0 +1,21 @@
+//
+//  PostProgressView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+
+struct PostProgressView: View {
+    @ObservedObject var poster: PostService
+    
+    var body: some View {
+        // can't use SwiftUI.ProgressView because there's no UIProgressView.Style.bar equivalent, see FB8587149
+        WrappedProgressView(value: poster.currentStep, total: poster.totalSteps)
+    }
+}
+
+//#Preview {
+//    PostProgressView()
+//}

Packages/ComposeUI/Sources/ComposeUI/Views/ReplyStatusView.swift

@@ -132,3 +132,21 @@ private struct AvatarContainerRepresentable<Content: View>: UIViewControllerRepr
         }
     }
 }
+
+struct NewReplyStatusView: View {
+    let draft: Draft
+    let mastodonController: any ComposeMastodonContext
+    
+    var body: some View {
+        if let id = draft.inReplyToID,
+           let status = mastodonController.fetchStatus(id: id) {
+            ReplyStatusView(
+                status: status,
+                rowTopInset: 8,
+                globalFrameOutsideList: .zero
+            )
+            // i don't know why swiftui can't infer this from the status that's passed into the ReplyStatusView changing
+            .id(id)
+        }
+    }
+}

Packages/GalleryVC/Sources/GalleryVC/Content/VideoGalleryContentViewController.swift

@@ -162,7 +162,6 @@ open class VideoGalleryContentViewController: UIViewController, GalleryContentVi
     }
     
     open var activityItemsForSharing: [Any] {
-//        [VideoActivityItemSource(asset: item.asset, url: url)]
         []
     }
     

Packages/GalleryVC/Sources/GalleryVC/GalleryContentViewController.swift

@@ -15,8 +15,11 @@ public protocol GalleryContentViewController: UIViewController {
     var caption: String? { get }
     var contentOverlayAccessoryViewController: UIViewController? { get }
     var bottomControlsAccessoryViewController: UIViewController? { get }
+    var insetBottomControlsAccessoryViewControllerToSafeArea: Bool { get }
     var presentationAnimation: GalleryContentPresentationAnimation { get }
+    var hideControlsOnZoom: Bool { get }
     
+    func shouldHideControls() -> Bool
     func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool)
     func galleryContentDidAppear()
     func galleryContentWillDisappear()
@@ -31,10 +34,22 @@ public extension GalleryContentViewController {
         nil
     }
     
+    var insetBottomControlsAccessoryViewControllerToSafeArea: Bool {
+        true
+    }
+
     var presentationAnimation: GalleryContentPresentationAnimation {
         .fromSourceView
     }
     
+    var hideControlsOnZoom: Bool {
+        true
+    }
+    
+    func shouldHideControls() -> Bool {
+        true
+    }
+    
     func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
     }
     

Packages/GalleryVC/Sources/GalleryVC/GalleryItemViewController.swift

@@ -11,7 +11,6 @@ import AVFoundation
 @MainActor
 protocol GalleryItemViewControllerDelegate: AnyObject {
     func isGalleryBeingPresented() -> Bool
-    func isGalleryBeingDismissed() -> Bool
     func addPresentationAnimationCompletion(_ block: @escaping () -> Void)
     func galleryItemClose(_ item: GalleryItemViewController)
     func galleryItemApplicationActivities(_ item: GalleryItemViewController) -> [UIActivity]?
@@ -46,6 +45,12 @@ class GalleryItemViewController: UIViewController {
     
     private var scrollViewSizeForLastZoomScaleUpdate: CGSize?
     
+    var showShareButton: Bool = true {
+        didSet {
+            shareButton?.isHidden = !showShareButton
+        }
+    }
+    
     override var prefersHomeIndicatorAutoHidden: Bool {
         return !controlsVisible
     }
@@ -67,6 +72,10 @@ class GalleryItemViewController: UIViewController {
     override func viewDidLoad() {
         super.viewDidLoad()
         
+        // Need to use the keyboard layout guide in some way in this VC,
+        // otherwise the keyboardLayoutGuide inside the bottom controls accessory view doesn't animate
+        _ = view.keyboardLayoutGuide
+        
         scrollView = UIScrollView()
         scrollView.translatesAutoresizingMaskIntoConstraints = false
         scrollView.delegate = self
@@ -110,6 +119,7 @@ class GalleryItemViewController: UIViewController {
             return UIPointerStyle(effect: .highlight(effect.preview), shape: .roundedRect(button.frame))
         }
         shareButton.preferredBehavioralStyle = .pad
+        shareButton.isHidden = !showShareButton
         shareButton.translatesAutoresizingMaskIntoConstraints = false
         updateShareButton()
         topControlsView.addSubview(shareButton)
@@ -142,12 +152,14 @@ class GalleryItemViewController: UIViewController {
             bottomControlsView.addArrangedSubview(controlsAccessory.view)
             controlsAccessory.didMove(toParent: self)
             
-            // Make sure the controls accessory is within the safe area.
+            if content.insetBottomControlsAccessoryViewControllerToSafeArea {
-            let spacer = UIView()
+                // Make sure the controls accessory is within the safe area.
-            bottomControlsView.addArrangedSubview(spacer)
+                let spacer = UIView()
-            let spacerTopConstraint = spacer.topAnchor.constraint(equalTo: view.safeAreaLayoutGuide.bottomAnchor)
+                bottomControlsView.addArrangedSubview(spacer)
-            spacerTopConstraint.priority = .init(999)
+                let spacerTopConstraint = spacer.topAnchor.constraint(equalTo: view.safeAreaLayoutGuide.bottomAnchor)
-            spacerTopConstraint.isActive = true
+                spacerTopConstraint.priority = .init(999)
+                spacerTopConstraint.isActive = true
+            }
         }
         
         captionTextView = UITextView()
@@ -211,6 +223,14 @@ class GalleryItemViewController: UIViewController {
         singleTap.require(toFail: doubleTap)
         view.addGestureRecognizer(singleTap)
         view.addGestureRecognizer(doubleTap)
+        
+        NotificationCenter.default.addObserver(self, selector: #selector(keyboardWillUpdate), name: UIResponder.keyboardWillShowNotification, object: nil)
+        NotificationCenter.default.addObserver(self, selector: #selector(keyboardWillUpdate), name: UIResponder.keyboardWillHideNotification, object: nil)
+        NotificationCenter.default.addObserver(self, selector: #selector(keyboardWillUpdate), name: UIResponder.keyboardWillChangeFrameNotification, object: nil)
+    }
+    
+    @objc private func keyboardWillUpdate() {
+        updateZoomScale(resetZoom: true)
     }
     
     override func viewSafeAreaInsetsDidChange() {
@@ -333,7 +353,7 @@ class GalleryItemViewController: UIViewController {
             return
         }
         
-        let heightScale = view.bounds.height / content.contentSize.height
+        let heightScale = (view.bounds.height - view.keyboardLayoutGuide.layoutFrame.height) / content.contentSize.height
         let widthScale = view.bounds.width / content.contentSize.width
         let minScale = min(widthScale, heightScale)
         let maxScale = minScale >= 1 ? minScale + 2 : 2
@@ -356,7 +376,7 @@ class GalleryItemViewController: UIViewController {
         
         // Note: use frame for the content.view, because that's in the coordinate space of the scroll view
         // which means it's already been scaled by the zoom factor.
-        let yOffset = max(0, (view.bounds.height - content.view.frame.height) / 2)
+        let yOffset = max(0, (view.bounds.height - view.keyboardLayoutGuide.layoutFrame.height - content.view.frame.height) / 2)
         contentViewTopConstraint!.constant = yOffset
         
         let xOffset = max(0, (view.bounds.width - content.view.frame.width) / 2)
@@ -377,27 +397,13 @@ class GalleryItemViewController: UIViewController {
     }
     
     private func updateTopControlsInsets() {
-        guard delegate?.isGalleryBeingDismissed() != true else {
-            return
-        }
         let notchedDeviceTopInsets: [CGFloat] = [
             44, // iPhone X, Xs, Xs Max, 11 Pro, 11 Pro Max
             48, // iPhone XR, 11
             47, // iPhone 12, 12 Pro, 12 Pro Max, 13, 13 Pro, 13 Pro Max, 14, 14 Plus
             50, // iPhone 12 mini, 13 mini
         ]
-        let topInset: CGFloat
+        if notchedDeviceTopInsets.contains(view.safeAreaInsets.top) {
-        switch view.window?.windowScene?.interfaceOrientation {
-        case .portraitUpsideDown:
-            topInset = view.safeAreaInsets.bottom
-        case .landscapeLeft:
-            topInset = view.safeAreaInsets.right
-        case .landscapeRight:
-            topInset = view.safeAreaInsets.left
-        default:
-            topInset = view.safeAreaInsets.top
-        }
-        if notchedDeviceTopInsets.contains(topInset) {
             // the notch width is not the same for the iPhones 13,
             // but what we actually want is the same offset from the edges
             // since the corner radius didn't change
@@ -406,7 +412,7 @@ class GalleryItemViewController: UIViewController {
             let offset = (earWidth - (shareButton.imageView?.bounds.width ?? 0)) / 2
             shareButtonLeadingConstraint.constant = offset
             closeButtonTrailingConstraint.constant = offset
-        } else if topInset == 0 {
+        } else if view.safeAreaInsets.top == 0 {
             // square corner devices
             shareButtonLeadingConstraint.constant = 8
             shareButtonTopConstraint.constant = 8
@@ -447,7 +453,9 @@ class GalleryItemViewController: UIViewController {
            scrollView.zoomScale > scrollView.minimumZoomScale {
             animateZoomOut()
         } else {
-            setControlsVisible(!controlsVisible, animated: true, dueToUserInteraction: true)
+            if content.shouldHideControls() {
+                setControlsVisible(!controlsVisible, animated: true, dueToUserInteraction: true)
+            }
         }
     }
     
@@ -566,7 +574,9 @@ extension GalleryItemViewController: UIScrollViewDelegate {
         if scrollView.zoomScale <= scrollView.minimumZoomScale {
             setControlsVisible(true, animated: true, dueToUserInteraction: true)
         } else {
-            setControlsVisible(false, animated: true, dueToUserInteraction: true)
+            if content.hideControlsOnZoom {
+                setControlsVisible(false, animated: true, dueToUserInteraction: true)
+            }
         }
         
         centerContent()

Packages/GalleryVC/Sources/GalleryVC/GalleryViewController.swift

@@ -26,6 +26,14 @@ public class GalleryViewController: UIPageViewController {
     private var dismissInteraction: GalleryDismissInteraction!
     private var presentationAnimationCompletionHandlers: [() -> Void] = []
     
+    public var showShareButton: Bool = true {
+        didSet {
+            if viewControllers?.isEmpty == false {
+                currentItemViewController.showShareButton = showShareButton
+            }
+        }
+    }
+    
     override public var prefersStatusBarHidden: Bool {
         true
     }
@@ -89,7 +97,9 @@ public class GalleryViewController: UIPageViewController {
     
     private func makeItemVC(index: Int) -> GalleryItemViewController {
         let content = galleryDataSource.galleryContentViewController(forItemAt: index)
-        return GalleryItemViewController(delegate: self, itemIndex: index, content: content)
+        let itemVC = GalleryItemViewController(delegate: self, itemIndex: index, content: content)
+        itemVC.showShareButton = showShareButton
+        return itemVC
     }
     
     func presentationAnimationCompleted() {
@@ -139,10 +149,6 @@ extension GalleryViewController: GalleryItemViewControllerDelegate {
         isBeingPresented
     }
     
-    func isGalleryBeingDismissed() -> Bool {
-        isBeingDismissed
-    }
-    
     func addPresentationAnimationCompletion(_ block: @escaping () -> Void) {
         presentationAnimationCompletionHandlers.append(block)
     }

Packages/GalleryVC/Sources/GalleryVC/UIView+Utilities.swift

@@ -14,7 +14,8 @@ extension UIView {
         while let superview = view.superview {
             if superview.layer.masksToBounds {
                 return superview
-            } else if superview is UIScrollView {
+            } else if let scrollView = superview as? UIScrollView,
+                      scrollView.isScrollEnabled {
                 return self
             } else {
                 view = superview

Packages/Pachyderm/Sources/Pachyderm/Client.swift

@@ -25,30 +25,27 @@ public struct Client: Sendable {
     
     public var timeoutInterval: TimeInterval = 60
     
-    private static let dateFormatter: DateFormatter = {
+    static let decoder: JSONDecoder = {
+        let decoder = JSONDecoder()
+        
         let formatter = DateFormatter()
         formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss.SZ"
         formatter.timeZone = TimeZone(abbreviation: "UTC")
         formatter.locale = Locale(identifier: "en_US_POSIX")
-        return formatter
+        let iso8601 = ISO8601DateFormatter()
-    }()
-    private static let iso8601Formatter = ISO8601DateFormatter()
-    private static func decodeDate(string: String) -> Date? {
-        // for the next time mastodon accidentally changes date formats >.>
-        return dateFormatter.date(from: string) ?? iso8601Formatter.date(from: string)
-    }
-    
-    static let decoder: JSONDecoder = {
-        let decoder = JSONDecoder()
         decoder.dateDecodingStrategy = .custom({ (decoder) in
             let container = try decoder.singleValueContainer()
             let str = try container.decode(String.self)
-            if let date = Self.decodeDate(string: str) {
+            // for the next time mastodon accidentally changes date formats >.>
+            if let date = formatter.date(from: str) {
+                return date
+            } else if let date = iso8601.date(from: str) {
                 return date
             } else {
                 throw DecodingError.typeMismatch(Date.self, .init(codingPath: container.codingPath, debugDescription: "unexpected date format: \(str)"))
             }
         })
+        
         return decoder
     }()
     
@@ -108,15 +105,6 @@ public struct Client: Sendable {
         return task
     }
     
-    private func error(from response: HTTPURLResponse) -> ErrorType {
-        if response.statusCode == 429,
-           let date = response.value(forHTTPHeaderField: "X-RateLimit-Reset").flatMap(Self.decodeDate) {
-            return .rateLimited(date)
-        } else {
-            return .unexpectedStatus(response.statusCode)
-        }
-    }
-    
     @discardableResult
     public func run<Result: Sendable>(_ request: Request<Result>) async throws -> (Result, Pagination?) {
         return try await withCheckedThrowingContinuation { continuation in
@@ -587,8 +575,6 @@ extension Client {
                 return "Invalid Model"
             case .mastodonError(let code, let error):
                 return "Server Error (\(code)): \(error)"
-            case .rateLimited(let reset):
-                return "Rate Limited Until \(reset.formatted(date: .omitted, time: .standard))"
             }
         }
     }
@@ -599,7 +585,6 @@ extension Client {
         case invalidResponse
         case invalidModel(Swift.Error)
         case mastodonError(Int, String)
-        case rateLimited(Date)
     }
     
     enum NodeInfoError: LocalizedError {

Packages/Pachyderm/Sources/Pachyderm/Model/NodeInfo.swift

@@ -11,15 +11,9 @@ import Foundation
 public struct NodeInfo: Decodable, Sendable, Equatable {
     public let version: String
     public let software: Software
-    public let metadata: Metadata
     
     public struct Software: Decodable, Sendable, Equatable {
         public let name: String
         public let version: String
     }
-    
-    public struct Metadata: Decodable, Sendable, Equatable {
-        public let nodeName: String
-        public let nodeDescription: String
-    }
 }

Packages/Pachyderm/Tests/PachydermTests/NotificationGroupTests.swift

@@ -197,72 +197,72 @@ class NotificationGroupTests: XCTestCase {
 
     func testGroupSimple() {
         let groups = NotificationGroup.createGroups(notifications: [likeA1, likeA2], only: [.favourite])
-        XCTAssertEqual(groups, [NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!])
+        XCTAssertEqual(groups, [NotificationGroup(notifications: [likeA1, likeA2])!])
     }
     
     func testGroupWithOtherGroupableInBetween() {
         let groups = NotificationGroup.createGroups(notifications: [likeA1, likeB, likeA2], only: [.favourite])
         XCTAssertEqual(groups, [
-            NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1, likeA2])!,
-            NotificationGroup(notifications: [likeB], kind: .favourite)!,
+            NotificationGroup(notifications: [likeB])!,
         ])
     }
     
     func testDontGroupWithUngroupableInBetween() {
         let groups = NotificationGroup.createGroups(notifications: [likeA1, mentionB, likeA2], only: [.favourite])
         XCTAssertEqual(groups, [
-            NotificationGroup(notifications: [likeA1], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1])!,
-            NotificationGroup(notifications: [mentionB], kind: .mention)!,
+            NotificationGroup(notifications: [mentionB])!,
-            NotificationGroup(notifications: [likeA2], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA2])!,
         ])
     }
 
     func testMergeSimpleGroups() {
-        let group1 = NotificationGroup(notifications: [likeA1], kind: .favourite)!
+        let group1 = NotificationGroup(notifications: [likeA1])!
-        let group2 = NotificationGroup(notifications: [likeA2], kind: .favourite)!
+        let group2 = NotificationGroup(notifications: [likeA2])!
         let merged = NotificationGroup.mergeGroups(first: [group1], second: [group2], only: [.favourite])
         XCTAssertEqual(merged, [
-            NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!
+            NotificationGroup(notifications: [likeA1, likeA2])!
         ])
     }
     
     func testMergeGroupsWithOtherGroupableInBetween() {
-        let group1 = NotificationGroup(notifications: [likeA1], kind: .favourite)!
+        let group1 = NotificationGroup(notifications: [likeA1])!
-        let group2 = NotificationGroup(notifications: [likeB], kind: .favourite)!
+        let group2 = NotificationGroup(notifications: [likeB])!
-        let group3 = NotificationGroup(notifications: [likeA2], kind: .favourite)!
+        let group3 = NotificationGroup(notifications: [likeA2])!
         let merged = NotificationGroup.mergeGroups(first: [group1, group2], second: [group3], only: [.favourite])
         XCTAssertEqual(merged, [
-            NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1, likeA2])!,
-            NotificationGroup(notifications: [likeB], kind: .favourite)!,
+            NotificationGroup(notifications: [likeB])!,
         ])
         
         let merged2 = NotificationGroup.mergeGroups(first: [group1], second: [group2, group3], only: [.favourite])
         XCTAssertEqual(merged2, [
-            NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1, likeA2])!,
-            NotificationGroup(notifications: [likeB], kind: .favourite)!,
+            NotificationGroup(notifications: [likeB])!,
         ])
         
-        let group4 = NotificationGroup(notifications: [likeB2], kind: .favourite)!
+        let group4 = NotificationGroup(notifications: [likeB2])!
-        let group5 = NotificationGroup(notifications: [mentionB], kind: .mention)!
+        let group5 = NotificationGroup(notifications: [mentionB])!
         let merged3 = NotificationGroup.mergeGroups(first: [group1, group5, group2], second: [group4, group3], only: [.favourite])
         print(merged3.count)
         XCTAssertEqual(merged3, [
             group1,
             group5,
-            NotificationGroup(notifications: [likeB, likeB2], kind: .favourite),
+            NotificationGroup(notifications: [likeB, likeB2]),
             group3
         ])
     }
     
     func testDontMergeWithUngroupableInBetween() {
-        let group1 = NotificationGroup(notifications: [likeA1], kind: .favourite)!
+        let group1 = NotificationGroup(notifications: [likeA1])!
-        let group2 = NotificationGroup(notifications: [mentionB], kind: .mention)!
+        let group2 = NotificationGroup(notifications: [mentionB])!
-        let group3 = NotificationGroup(notifications: [likeA2], kind: .favourite)!
+        let group3 = NotificationGroup(notifications: [likeA2])!
         let merged = NotificationGroup.mergeGroups(first: [group1, group2], second: [group3], only: [.favourite])
         XCTAssertEqual(merged, [
-            NotificationGroup(notifications: [likeA1], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1])!,
-            NotificationGroup(notifications: [mentionB], kind: .mention)!,
+            NotificationGroup(notifications: [mentionB])!,
-            NotificationGroup(notifications: [likeA2], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA2])!,
         ])
     }
 

Packages/TuskerPreferences/Sources/TuskerPreferences/Supporting Types/FeatureFlag.swift

@@ -9,5 +9,6 @@ import Foundation
 
 public enum FeatureFlag: String, Codable {
     case iPadBrowserNavigation = "ipad-browser-navigation"
+    case composeRewrite = "compose-rewrite"
     case pushNotifCustomEmoji = "push-notif-custom-emoji"
 }

Packages/TuskerPreferences/Sources/TuskerPreferences/SwiftUI/PreferenceObserving.swift

@@ -0,0 +1,37 @@
+//
+//  PreferenceObserving.swift
+//  TuskerPreferences
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+import Combine
+
+@propertyWrapper
+public struct PreferenceObserving<Key: PreferenceKey>: DynamicProperty {
+    public typealias PrefKeyPath = KeyPath<PreferenceStore, PreferencePublisher<Key>>
+    
+    private let keyPath: PrefKeyPath
+    @StateObject private var observer: Observer
+    
+    public init(_ keyPath: PrefKeyPath) {
+        self.keyPath = keyPath
+        self._observer = StateObject(wrappedValue: Observer(keyPath: keyPath))
+    }
+    
+    public var wrappedValue: Key.Value {
+        Preferences.shared.getValue(preferenceKeyPath: keyPath)
+    }
+    
+    @MainActor
+    private class Observer: ObservableObject {
+        private var cancellable: AnyCancellable?
+        
+        init(keyPath: PrefKeyPath) {
+            cancellable = Preferences.shared[keyPath: keyPath].sink { [unowned self] _ in
+                self.objectWillChange.send()
+            }
+        }
+    }
+}

ShareExtension/ShareMastodonContext.swift

@@ -83,4 +83,8 @@ final class ShareMastodonContext: ComposeMastodonContext, ObservableObject, Send
     
     func storeCreatedStatus(_ status: Status) {
     }
+    
+    func fetchStatus(id: String) -> (any StatusProtocol)? {
+        return nil
+    }
 }

Tusker/Extensions/View+AppListStyle.swift

@@ -66,31 +66,3 @@ private struct AppGroupedListRowBackground: ViewModifier {
         }
     }
 }
-
-@propertyWrapper
-private struct PreferenceObserving<Key: TuskerPreferences.PreferenceKey>: DynamicProperty {
-    typealias PrefKeyPath = KeyPath<PreferenceStore, PreferencePublisher<Key>>
-    
-    let keyPath: PrefKeyPath
-    @StateObject private var observer: Observer
-    
-    init(_ keyPath: PrefKeyPath) {
-        self.keyPath = keyPath
-        self._observer = StateObject(wrappedValue: Observer(keyPath: keyPath))
-    }
-    
-    var wrappedValue: Key.Value {
-        Preferences.shared.getValue(preferenceKeyPath: keyPath)
-    }
-    
-    @MainActor
-    private class Observer: ObservableObject {
-        private var cancellable: AnyCancellable?
-        
-        init(keyPath: PrefKeyPath) {
-            cancellable = Preferences.shared[keyPath: keyPath].sink { [unowned self] _ in
-                self.objectWillChange.send()
-            }
-        }
-    }
-}

Tusker/Screens/Compose/ComposeHostingController.swift

@@ -50,6 +50,10 @@ class ComposeHostingController: UIHostingController<ComposeHostingController.Vie
             emojiImageView: { AnyView(CustomEmojiImageView(emoji: $0)) }
         )
         
+        if let account = mastodonController.account {
+            controller.currentAccount = account
+        }
+        
         self.mastodonController = mastodonController
         
         super.init(rootView: View(mastodonController: mastodonController, controller: controller))
@@ -129,7 +133,6 @@ class ComposeHostingController: UIHostingController<ComposeHostingController.Vie
         let picker = PHPickerViewController(configuration: config)
         picker.delegate = self
         picker.modalPresentationStyle = .pageSheet
-        picker.overrideUserInterfaceStyle = .dark
         // sheet detents don't play nice with PHPickerViewController, see
 //        let sheet = picker.sheetPresentationController!
 //        sheet.detents = [.medium(), .large()]
@@ -151,7 +154,8 @@ class ComposeHostingController: UIHostingController<ComposeHostingController.Vie
         var body: some SwiftUI.View {
             ControllerView(controller: { controller })
                 .task {
-                    if let account = try? await mastodonController.getOwnAccount() {
+                    if controller.currentAccount == nil,
+                       let account = try? await mastodonController.getOwnAccount() {
                         controller.currentAccount = account
                     }
                 }
@@ -185,6 +189,7 @@ extension ComposeHostingController: DuckableViewController {
 }
 #endif
 
+// TODO: don't conform MastodonController to this protocol, use a separate type
 extension MastodonController: ComposeMastodonContext {
     @MainActor
     func searchCachedAccounts(query: String) -> [AccountProtocol] {
@@ -227,6 +232,10 @@ extension MastodonController: ComposeMastodonContext {
     func storeCreatedStatus(_ status: Status) {
         persistentContainer.addOrUpdate(status: status)
     }
+    
+    func fetchStatus(id: String) -> (any StatusProtocol)? {
+        return persistentContainer.status(for: id)
+    }
 }
 
 extension ComposeHostingController: PHPickerViewControllerDelegate {

Tusker/Screens/Conversation/ConversationViewController.swift

@@ -484,11 +484,3 @@ extension ConversationViewController: StatusBarTappableViewController {
         }
     }
 }
-
-extension ConversationViewController: RefreshableViewController {
-    func refresh() {
-        Task {
-            await refreshContext()
-        }
-    }
-}

Tusker/Screens/Explore/TrendingLinkCardView.swift

@@ -16,11 +16,15 @@ struct TrendingLinkCardView: View {
     let card: Card
     
     private var imageURL: URL? {
-        card.image.flatMap { URL($0) }
+        if let image = card.image {
+            URL(image)
+        } else {
+            nil
+        }
     }
     
     private var descriptionText: String {
-        let converter = TextConverter(configuration: .init(insertNewlines: false))
+        var converter = TextConverter(configuration: .init(insertNewlines: false))
         return converter.convert(html: card.description)
     }
     

Tusker/Screens/Main/BaseMainTabBarViewController.swift

@@ -151,22 +151,6 @@ class BaseMainTabBarViewController: UITabBarController, FastAccountSwitcherViewC
         return false
         #endif // !os(visionOS)
     }
-    
-    // MARK: Keyboard shortcuts
-    
-    override func target(forAction action: Selector, withSender sender: Any?) -> Any? {
-        // This is a silly workaround for when the sidebar is focused (and therefore first responder), which,
-        // unfortunately, is almost always. Because the content view controller then isn't in the responder chain,
-        // we manually delegate to the top view controller if possible.
-        if action == #selector(RefreshableViewController.refresh),
-           let selected = selectedViewController as? NavigationControllerProtocol,
-           let top = selected.topViewController as? RefreshableViewController {
-            return top
-        } else {
-            return super.target(forAction: action, withSender: sender)
-        }
-    }
-
 }
 
 extension BaseMainTabBarViewController: TuskerNavigationDelegate {

Tusker/Screens/Main/MainSplitViewController.swift

@@ -219,19 +219,6 @@ class MainSplitViewController: UISplitViewController {
     @objc func handleComposeKeyCommand() {
         compose(editing: nil)
     }
-    
-    override func target(forAction action: Selector, withSender sender: Any?) -> Any? {
-        // This is a silly workaround for when the sidebar is focused (and therefore first responder), which,
-        // unfortunately, is almost always. Because the content view controller then isn't in the responder chain,
-        // we manually delegate to the top view controller if possible.
-        if action == #selector(RefreshableViewController.refresh),
-           traitCollection.horizontalSizeClass == .regular,
-           let top = secondaryNavController.topViewController as? RefreshableViewController {
-            return top
-        } else {
-            return super.target(forAction: action, withSender: sender)
-        }
-    }
 
 }
 

Tusker/Screens/Notifications/NotificationsPageViewController.swift

@@ -180,9 +180,3 @@ extension NotificationsPageViewController: StateRestorableViewController {
         return currentPage.userActivity(accountID: mastodonController.accountInfo!.id)
     }
 }
-
-extension NotificationsPageViewController: RefreshableViewController {
-    func refresh() {
-        (currentViewController as? RefreshableViewController)?.refresh()
-    }
-}

Tusker/Screens/Onboarding/InstanceSelectorTableViewController.swift

@@ -75,14 +75,13 @@ class InstanceSelectorTableViewController: UITableViewController {
         
         dataSource = UITableViewDiffableDataSource(tableView: tableView, cellProvider: { (tableView, indexPath, item) -> UITableViewCell? in
             switch item {
-            case let .selected(_, info):
+            case let .selected(_, instance):
                 let cell = tableView.dequeueReusableCell(withIdentifier: instanceCell, for: indexPath) as! InstanceTableViewCell
-                cell.updateUI(info: info)
+                cell.updateUI(instance: instance)
                 return cell
             case let .recommended(instance):
                 let cell = tableView.dequeueReusableCell(withIdentifier: instanceCell, for: indexPath) as! InstanceTableViewCell
-                let info = Info(host: instance.domain, description: instance.description, thumbnail: instance.proxiedThumbnailURL, adult: instance.category == "adult")
+                cell.updateUI(instance: instance)
-                cell.updateUI(info: info)
                 return cell
             }
         })
@@ -165,20 +164,22 @@ class InstanceSelectorTableViewController: UITableViewController {
             return
         }
 
-        checkSpecificInstance(url: url) { (info) in
+        let client = Client(baseURL: url, session: .appDefault)
+        let request = Client.getInstanceV1()
+        client.run(request) { (response) in
             var snapshot = self.dataSource.snapshot()
             if snapshot.indexOfSection(.selected) != nil {
                 snapshot.deleteSections([.selected])
             }
 
-            if let info {
+            if case let .success(instance, _) = response {
                 if snapshot.indexOfSection(.recommendedInstances) != nil {
                     snapshot.insertSections([.selected], beforeSection: .recommendedInstances)
                 } else {
                     snapshot.appendSections([.selected])
                 }
                 
-                snapshot.appendItems([.selected(url, info)], toSection: .selected)
+                snapshot.appendItems([.selected(url, instance)], toSection: .selected)
                 
                 DispatchQueue.main.async {
                     self.dataSource.apply(snapshot) {
@@ -193,29 +194,6 @@ class InstanceSelectorTableViewController: UITableViewController {
         }
     }
     
-    private func checkSpecificInstance(url: URL, completionHandler: @escaping (Info?) -> Void) {
-        let client = Client(baseURL: url, session: .appDefault)
-        let request = Client.getInstanceV1()
-        client.run(request) { response in
-            switch response {
-            case .success(let instance, _):
-                let host = url.host ?? URLComponents(string: instance.uri)?.host ?? instance.uri
-                let info = Info(host: host, description: instance.shortDescription ?? instance.description, thumbnail: instance.thumbnail, adult: false)
-                completionHandler(info)
-            case .failure(_):
-                Task {
-                    do {
-                        let nodeInfo = try await client.nodeInfo()
-                        let info = Info(host: url.host!, description: nodeInfo.metadata.nodeDescription, thumbnail: nil, adult: false)
-                        completionHandler(info)
-                    } catch {
-                        completionHandler(nil)
-                    }
-                }
-            }
-        }
-    }
-    
     private func loadRecommendedInstances() {
         InstanceSelector.getInstances(category: nil) { (response) in
             DispatchQueue.main.async {
@@ -334,13 +312,13 @@ extension InstanceSelectorTableViewController {
         case recommendedInstances
     }
     enum Item: Equatable, Hashable, Sendable {
-        case selected(URL, Info)
+        case selected(URL, InstanceV1)
         case recommended(InstanceSelector.Instance)
         
         static func ==(lhs: Item, rhs: Item) -> Bool {
             switch (lhs, rhs) {
-            case let (.selected(urlA, _), .selected(urlB, _)):
+            case let (.selected(urlA, instanceA), .selected(urlB, instanceB)):
-                return urlA == urlB
+                return urlA == urlB && instanceA.uri == instanceB.uri
             case let (.recommended(a), .recommended(b)):
                 return a.domain == b.domain
             default:
@@ -350,21 +328,16 @@ extension InstanceSelectorTableViewController {
         
         func hash(into hasher: inout Hasher) {
             switch self {
-            case let .selected(url, _):
+            case let .selected(url, instance):
                 hasher.combine(0)
                 hasher.combine(url)
+                hasher.combine(instance.uri)
             case let .recommended(instance):
                 hasher.combine(1)
                 hasher.combine(instance.domain)
             }
         }
     }
-    struct Info: Hashable {
-        let host: String
-        let description: String
-        let thumbnail: URL?
-        let adult: Bool
-    }
 }
 
 extension InstanceSelectorTableViewController: UISearchResultsUpdating {

Tusker/Screens/Preferences/AdvancedPrefsView.swift

@@ -18,7 +18,6 @@ struct AdvancedPrefsView : View {
     @State private var mastodonCacheSize: Int64 = 0
     @State private var cloudKitStatus: CKAccountStatus?
     @State private var isShowingFeatureFlagAlert = false
-    @State private var featureFlagName = ""
     
     var body: some View {
         List {
@@ -32,23 +31,9 @@ struct AdvancedPrefsView : View {
         .listStyle(.insetGrouped)
         .appGroupedListBackground(container: PreferencesNavigationController.self)
         .onTapGesture(count: 3) {
-            featureFlagName = ""
             isShowingFeatureFlagAlert = true
         }
-        .alert("Enable Feature Flag", isPresented: $isShowingFeatureFlagAlert) {
+        .modifier(FeatureFlagAlertModifier(showing: $isShowingFeatureFlagAlert))
-            TextField("Flag Name", text: $featureFlagName)
-                .textInputAutocapitalization(.never)
-                .autocorrectionDisabled()
-            
-            Button("Cancel", role: .cancel) {}
-            Button("Enable") {
-                if let flag = FeatureFlag(rawValue: featureFlagName) {
-                    preferences.enabledFeatureFlags.insert(flag)
-                }
-            }
-        } message: {
-            Text("Warning: Feature flags are intended for development and debugging use only. They are experimental and subject to change at any time.")
-        }
         .navigationBarTitle(Text("Advanced"))
     }
     
@@ -252,6 +237,74 @@ extension StatusContentType {
     }
 }
 
+private struct FeatureFlagAlertModifier: ViewModifier {
+    @Binding var showing: Bool
+    @ObservedObject private var preferences = Preferences.shared
+    @State private var featureFlagName = ""
+    
+    func body(content: Content) -> some View {
+        if #available(iOS 16.0, *) {
+            content
+                .onChange(of: showing) {
+                    if $0 {
+                        featureFlagName = ""
+                    }
+                }
+                .alert("Enable Feature Flag", isPresented: $showing) {
+                    textField
+                    Button("Cancel", role: .cancel) {}
+                    Button("Enable", action: enableFlag)
+                } message: {
+                    warning
+                }
+        } else {
+            content
+                .sheet(isPresented: $showing) {
+                    NavigationView {
+                        List {
+                            Section {
+                                textField
+                            } footer: {
+                                warning
+                            }
+                        }
+                        .navigationTitle("Enable Feature Flag")
+                        .navigationBarTitleDisplayMode(.inline)
+                        .listStyle(.insetGrouped)
+                        .toolbar {
+                            ToolbarItem(placement: .cancellationAction) {
+                                Button("Cancel") {
+                                    showing = false
+                                }
+                            }
+                            ToolbarItem(placement: .confirmationAction) {
+                                Button("Enable", action: self.enableFlag)
+                            }
+                        }
+                    }
+                    .navigationViewStyle(.stack)
+                }
+        }
+    }
+    
+    private var textField: some View {
+        TextField("Flag Name", text: $featureFlagName)
+            .textInputAutocapitalization(.never)
+            .autocorrectionDisabled()
+    }
+    
+    private var warning: Text {
+        Text("Warning: Feature flags are intended for development and debugging use only. They are experimental and subject to change at any time.")
+    }
+    
+    private func enableFlag() {
+        if let flag = FeatureFlag(rawValue: featureFlagName) {
+            preferences.enabledFeatureFlags.insert(flag)
+            showing = false
+        }
+    }
+}
+
 #if DEBUG
 struct AdvancedPrefsView_Previews : PreviewProvider {
     static var previews: some View {

Tusker/Screens/Profile/ProfileViewController.swift

@@ -393,9 +393,3 @@ extension ProfileViewController: StatusBarTappableViewController {
         return currentViewController.handleStatusBarTapped(xPosition: xPosition)
     }
 }
-
-extension ProfileViewController: RefreshableViewController {
-    func refresh() {
-        currentViewController.refresh()
-    }
-}

Tusker/Screens/Timeline/TimelinesPageViewController.swift

@@ -212,9 +212,3 @@ extension TimelinesPageViewController: StateRestorableViewController {
         return (currentViewController as? TimelineViewController)?.stateRestorationActivity()
     }
 }
-
-extension TimelinesPageViewController: RefreshableViewController {
-    func refresh() {
-        (currentViewController as? RefreshableViewController)?.refresh()
-    }
-}

Tusker/Views/Attachments/AttachmentView.swift

@@ -412,7 +412,7 @@ class AttachmentView: GIFImageView {
             makeBadgeView(text: "ALT")
         }
         if badges.contains(.noAlt) {
-            makeBadgeView(text: "NO ALT")
+            makeBadgeView(text: "No ALT")
         }
         
         let first = stack.arrangedSubviews.first!

Tusker/Views/Instance Cell/InstanceTableViewCell.swift

@@ -16,7 +16,8 @@ class InstanceTableViewCell: UITableViewCell {
     @IBOutlet weak var adultLabel: UILabel!
     @IBOutlet weak var descriptionTextView: ContentTextView!
     
-    private var instance: InstanceSelectorTableViewController.Info?
+    var instance: InstanceV1?
+    var selectorInstance: InstanceSelector.Instance?
     
     private var thumbnailTask: Task<Void, Never>?
     
@@ -43,14 +44,25 @@ class InstanceTableViewCell: UITableViewCell {
         backgroundConfiguration = .appListGroupedCell(for: state)
     }
     
-    func updateUI(info: InstanceSelectorTableViewController.Info) {
+    func updateUI(instance: InstanceSelector.Instance) {
-        self.instance = info
+        self.selectorInstance = instance
-
+        self.instance = nil
-        domainLabel.text = info.host
-        adultLabel.isHidden = !info.adult
-        descriptionTextView.setBodyTextFromHTML(info.description)
         
-        if let thumbnail = info.thumbnail {
+        domainLabel.text = instance.domain
+        adultLabel.isHidden = instance.category != "adult"
+        descriptionTextView.setBodyTextFromHTML(instance.description)
+        updateThumbnail(url: instance.proxiedThumbnailURL)
+    }
+    
+    func updateUI(instance: InstanceV1) {
+        self.instance = instance
+        self.selectorInstance = nil
+
+        domainLabel.text = URLComponents(string: instance.uri)?.host ?? instance.uri
+        adultLabel.isHidden = true
+        descriptionTextView.setBodyTextFromHTML(instance.shortDescription ?? instance.description)
+        
+        if let thumbnail = instance.thumbnail {
             updateThumbnail(url: thumbnail)
         } else {
             thumbnailImageView.image = nil
@@ -73,6 +85,7 @@ class InstanceTableViewCell: UITableViewCell {
         
         thumbnailTask?.cancel()
         instance = nil
+        selectorInstance = nil
     }
 
 }

Tusker/Views/Profile Header/ProfileFieldValueView.swift

@@ -12,7 +12,11 @@ import SwiftUI
 import SafariServices
 
 class ProfileFieldValueView: UIView {
-    weak var navigationDelegate: TuskerNavigationDelegate?
+    weak var navigationDelegate: TuskerNavigationDelegate? {
+        didSet {
+            textView.navigationDelegate = navigationDelegate
+        }
+    }
     
     private static let converter = HTMLConverter(
         font: .preferredFont(forTextStyle: .body),
@@ -24,9 +28,8 @@ class ProfileFieldValueView: UIView {
     
     private let account: AccountMO
     private let field: Account.Field
-    private var link: (String, URL)?
     
-    private let label = EmojiLabel()
+    private let textView = ContentTextView()
     private var iconView: UIView?
     
     private var currentTargetedPreview: UITargetedPreview?
@@ -39,34 +42,28 @@ class ProfileFieldValueView: UIView {
         
         let converted = NSMutableAttributedString(attributedString: ProfileFieldValueView.converter.convert(field.value))
         
-        converted.enumerateAttribute(.link, in: converted.fullRange) { value, range, stop in
+        #if os(visionOS)
-            guard value != nil else { return }
+        textView.linkTextAttributes = [
-            if self.link == nil {
+            .foregroundColor: UIColor.link
-                self.link = (converted.attributedSubstring(from: range).string, value as! URL)
+        ]
-            }
+        #else
-            #if os(visionOS)
+        textView.linkTextAttributes = [
-            converted.addAttribute(.foregroundColor, value: UIColor.link, range: range)
+            .foregroundColor: UIColor.tintColor
-            #else
+        ]
-            converted.addAttribute(.foregroundColor, value: UIColor.tintColor, range: range)
+        #endif
-            #endif
+        textView.backgroundColor = nil
-            // the .link attribute in a UILabel always makes the color blue >.>
+        textView.isScrollEnabled = false
-            converted.removeAttribute(.link, range: range)
+        textView.isSelectable = false
-        }
+        textView.isEditable = false
-            
+        textView.font = .preferredFont(forTextStyle: .body)
-        if link != nil {
+        updateTextContainerInset()
-            label.addGestureRecognizer(UITapGestureRecognizer(target: self, action: #selector(linkTapped)))
+        textView.adjustsFontForContentSizeCategory = true
-            label.addInteraction(UIContextMenuInteraction(delegate: self))
+        textView.attributedText = converted
-            label.isUserInteractionEnabled = true
+        textView.setEmojis(account.emojis, identifier: account.id)
-        }
+        textView.isUserInteractionEnabled = true
-        
+        textView.setContentCompressionResistancePriority(.required, for: .vertical)
-        label.numberOfLines = 0
+        textView.translatesAutoresizingMaskIntoConstraints = false
-        label.font = .preferredFont(forTextStyle: .body)
+        addSubview(textView)
-        label.adjustsFontForContentSizeCategory = true
-        label.attributedText = converted
-        label.setEmojis(account.emojis, identifier: account.id)
-        label.setContentCompressionResistancePriority(.required, for: .vertical)
-        label.translatesAutoresizingMaskIntoConstraints = false
-        addSubview(label)
         
         let labelTrailingConstraint: NSLayoutConstraint
         
@@ -83,20 +80,20 @@ class ProfileFieldValueView: UIView {
             icon.isPointerInteractionEnabled = true
             icon.accessibilityLabel = "Verified link"
             addSubview(icon)
-            labelTrailingConstraint = label.trailingAnchor.constraint(equalTo: icon.leadingAnchor)
+            labelTrailingConstraint = textView.trailingAnchor.constraint(equalTo: icon.leadingAnchor)
             NSLayoutConstraint.activate([
-                icon.centerYAnchor.constraint(equalTo: label.centerYAnchor),
+                icon.centerYAnchor.constraint(equalTo: textView.centerYAnchor),
                 icon.trailingAnchor.constraint(lessThanOrEqualTo: trailingAnchor),
             ])
         } else {
-            labelTrailingConstraint = label.trailingAnchor.constraint(equalTo: trailingAnchor)
+            labelTrailingConstraint = textView.trailingAnchor.constraint(equalTo: trailingAnchor)
         }
         
         NSLayoutConstraint.activate([
-            label.leadingAnchor.constraint(equalTo: leadingAnchor),
+            textView.leadingAnchor.constraint(equalTo: leadingAnchor),
             labelTrailingConstraint,
-            label.topAnchor.constraint(equalTo: topAnchor),
+            textView.topAnchor.constraint(equalTo: topAnchor),
-            label.bottomAnchor.constraint(equalTo: bottomAnchor),
+            textView.bottomAnchor.constraint(equalTo: bottomAnchor),
         ])
     }
     
@@ -105,37 +102,36 @@ class ProfileFieldValueView: UIView {
     }
     
     override func sizeThatFits(_ size: CGSize) -> CGSize {
-        var size = label.sizeThatFits(size)
+        var size = textView.sizeThatFits(size)
         if let iconView {
             size.width += iconView.sizeThatFits(UIView.layoutFittingCompressedSize).width
         }
         return size
     }
     
+    override func traitCollectionDidChange(_ previousTraitCollection: UITraitCollection?) {
+        super.traitCollectionDidChange(previousTraitCollection)
+        if traitCollection.preferredContentSizeCategory != previousTraitCollection?.preferredContentSizeCategory {
+            updateTextContainerInset()
+        }
+    }
+    
+    private func updateTextContainerInset() {
+        // blergh
+        switch traitCollection.preferredContentSizeCategory {
+        case .extraSmall:
+            textView.textContainerInset = UIEdgeInsets(top: 4, left: 0, bottom: 0, right: 0)
+        case .small:
+            textView.textContainerInset = UIEdgeInsets(top: 3, left: 0, bottom: 0, right: 0)
+        case .medium, .large:
+            textView.textContainerInset = UIEdgeInsets(top: 2, left: 0, bottom: 0, right: 0)
+        default:
+            textView.textContainerInset = .zero
+        }
+    }
+    
     func setTextAlignment(_ alignment: NSTextAlignment) {
-        label.textAlignment = alignment
+        textView.textAlignment = alignment
-    }
-    
-    func getHashtagOrURL() -> (Hashtag?, URL)? {
-        guard let (text, url) = link else {
-            return nil
-        }
-        if text.starts(with: "#") {
-            return (Hashtag(name: String(text.dropFirst()), url: url), url)
-        } else {
-            return (nil, url)
-        }
-    }
-    
-    @objc private func linkTapped() {
-        guard let (hashtag, url) = getHashtagOrURL() else {
-            return
-        }
-        if let hashtag {
-            navigationDelegate?.selected(tag: hashtag)
-        } else {
-            navigationDelegate?.selected(url: url)
-        }
     }
     
     @objc private func verifiedIconTapped() {
@@ -145,7 +141,7 @@ class ProfileFieldValueView: UIView {
         let view = ProfileFieldVerificationView(
             acct: account.acct,
             verifiedAt: field.verifiedAt!,
-            linkText: label.text ?? "",
+            linkText: textView.text ?? "",
             navigationDelegate: navigationDelegate
         )
         let host = UIHostingController(rootView: view)
@@ -169,49 +165,3 @@ class ProfileFieldValueView: UIView {
         navigationDelegate.present(toPresent, animated: true)
     }
 }
-
-extension ProfileFieldValueView: UIContextMenuInteractionDelegate, MenuActionProvider {
-    func contextMenuInteraction(_ interaction: UIContextMenuInteraction, configurationForMenuAtLocation location: CGPoint) -> UIContextMenuConfiguration? {
-        guard let (hashtag, url) = getHashtagOrURL(),
-              let navigationDelegate else {
-            return nil
-        }
-        if let hashtag {
-            return UIContextMenuConfiguration {
-                HashtagTimelineViewController(for: hashtag, mastodonController: navigationDelegate.apiController)
-            } actionProvider: { _ in
-                UIMenu(children: self.actionsForHashtag(hashtag, source: .view(self)))
-            }
-        } else {
-            return UIContextMenuConfiguration {
-                let vc = SFSafariViewController(url: url)
-                #if !os(visionOS)
-                vc.preferredControlTintColor = Preferences.shared.accentColor.color
-                #endif
-                return vc
-            } actionProvider: { _ in
-                UIMenu(children: self.actionsForURL(url, source: .view(self)))
-            }
-        }
-    }
-    
-    
-    func contextMenuInteraction(_ interaction: UIContextMenuInteraction, configuration: UIContextMenuConfiguration, highlightPreviewForItemWithIdentifier identifier: NSCopying) -> UITargetedPreview? {
-        var rect = label.textRect(forBounds: label.bounds, limitedToNumberOfLines: 0)
-        // the rect should be vertically centered, but textRect doesn't seem to take the label's vertical alignment into account
-        rect.origin.x = 0
-        rect.origin.y = (bounds.height - rect.height) / 2
-        let parameters = UIPreviewParameters(textLineRects: [rect as NSValue])
-        let preview = UITargetedPreview(view: label, parameters: parameters)
-        currentTargetedPreview = preview
-        return preview
-    }
-    
-    func contextMenuInteraction(_ interaction: UIContextMenuInteraction, configuration: UIContextMenuConfiguration, dismissalPreviewForItemWithIdentifier identifier: NSCopying) -> UITargetedPreview? {
-        return currentTargetedPreview
-    }
-    
-    func contextMenuInteraction(_ interaction: UIContextMenuInteraction, willPerformPreviewActionForMenuWith configuration: UIContextMenuConfiguration, animator: UIContextMenuInteractionCommitAnimating) {
-        MenuPreviewHelper.willPerformPreviewAction(animator: animator, presenter: navigationDelegate!)
-    }
-}

Version.xcconfig

@@ -10,7 +10,7 @@
 // https://help.apple.com/xcode/#/dev745c5c974
 
 MARKETING_VERSION = 2024.5
-CURRENT_PROJECT_VERSION = 141
+CURRENT_PROJECT_VERSION = 137
 CURRENT_PROJECT_VERSION = $(inherited)$(CURRENT_PROJECT_VERSION_BUILD_SUFFIX_$(CONFIGURATION))
 
 CURRENT_PROJECT_VERSION_BUILD_SUFFIX_Debug=-dev