Go back to using one List for everything in compose

# Conflicts:
#	Packages/ComposeUI/Package.swift
#	Packages/ComposeUI/Sources/ComposeUI/Controllers/ComposeController.swift

CHANGELOG.md

@@ -1,28 +1,5 @@
 # Changelog
 
-## 2024.5 (139)
-Bugfixes:
-- Fix error decoding certain posts
-
-## 2024.5 (138)
-Bugfixes:
-- Fix potential crash when displaying certain attachments
-- Fix potential crash due to race condition when opening push notification in app
-- Fix misaligned text between profile field values/labels
-- Fix rate limited error message not including reset timestamp
-- iPadOS/macOS: Fix Cmd+R shortcut not working
-
-## 2024.5 (137)
-Features/Improvements:
-- Improve gallery presentation/dismissal transitions
-
-Bugfixes:
-- Account for bidirectional text in display names
-- Fix crash when playing back gifv
-- Fix gallery controls not hiding if video loading fails
-- iPadOS: Fix incorrect gallery dismiss animation on non-fullscreen windows
-- iPadOS: Fix hang when switching accounts
-
 ## 2024.4 (136)
 Features/Improvements:
 - Import image description when adding attachments from Photos if possible

NotificationExtension/NotificationService.swift

@@ -14,6 +14,7 @@ import OSLog
 import Pachyderm
 import Intents
 import HTMLStreamer
+import WebURL
 import UIKit
 import TuskerPreferences
 
@@ -237,7 +238,8 @@ class NotificationService: UNNotificationServiceExtension {
             for match in emojiRegex.matches(in: content.body, range: NSRange(location: 0, length: content.body.utf16.count)).reversed() {
                 let emojiName = (content.body as NSString).substring(with: match.range(at: 1))
                 guard let emoji = notification.status?.emojis.first(where: { $0.shortcode == emojiName }),
-                      let (data, _) = try? await URLSession.shared.data(from: emoji.url),
+                      let url = URL(emoji.url),
+                      let (data, _) = try? await URLSession.shared.data(from: url),
                       let image = UIImage(data: data) else {
                     continue
                 }
@@ -366,7 +368,17 @@ private func decodeBase64URL(_ s: String) -> Data? {
 // copied from HTMLConverter.Callbacks, blergh
 private struct HTMLCallbacks: HTMLConversionCallbacks {
     static func makeURL(string: String) -> URL? {
-        try? URL.ParseStrategy().parse(string)
+        // Converting WebURL to URL is a small but non-trivial expense (since it works by
+        // serializing the WebURL as a string and then having Foundation parse it again),
+        // so, if available, use the system parser which doesn't require another round trip.
+        if let url = try? URL.ParseStrategy().parse(string) {
+            url
+        } else if let web = WebURL(string),
+                  let url = URL(web) {
+            url
+        } else {
+            nil
+        }
     }
     
     static func elementAction(name: String, attributes: [Attribute]) -> ElementAction {

Packages/ComposeUI/Package.swift

@@ -20,13 +20,14 @@ let package = Package(
         .package(path: "../InstanceFeatures"),
         .package(path: "../TuskerComponents"),
         .package(path: "../MatchedGeometryPresentation"),
+        .package(path: "../TuskerPreferences"),
     ],
     targets: [
         // Targets are the basic building blocks of a package. A target can define a module or a test suite.
         // Targets can depend on other targets in this package, and on products in packages this package depends on.
         .target(
             name: "ComposeUI",
-            dependencies: ["Pachyderm", "InstanceFeatures", "TuskerComponents", "MatchedGeometryPresentation"],
+            dependencies: ["Pachyderm", "InstanceFeatures", "TuskerComponents", "MatchedGeometryPresentation", "TuskerPreferences"],
             swiftSettings: [
                 .swiftLanguageMode(.v5)
             ]),

Packages/ComposeUI/Sources/ComposeUI/API/PostService.swift

@@ -11,7 +11,7 @@ import Pachyderm
 import UniformTypeIdentifiers
 
 @MainActor
-class PostService: ObservableObject {
+final class PostService: ObservableObject {
     private let mastodonController: ComposeMastodonContext
     private let config: ComposeUIConfig
     private let draft: Draft

Packages/ComposeUI/Sources/ComposeUI/CharacterCounter.swift

@@ -12,7 +12,7 @@ import InstanceFeatures
 public struct CharacterCounter {
     
     private static let linkDetector = try! NSDataDetector(types: NSTextCheckingResult.CheckingType.link.rawValue)
-    private static let mention = try! NSRegularExpression(pattern: "(@[a-z0-9_]+)(?:@[a-z0-9\\-\\.]+[a-z0-9]+)?", options: .caseInsensitive)
+    static let mention = try! NSRegularExpression(pattern: "(@[a-z0-9_]+)(?:@[a-z0-9\\-\\.]+[a-z0-9]+)?", options: .caseInsensitive)
     
     public static func count(text: String, for instanceFeatures: InstanceFeatures) -> Int {
         let mentionsRemoved = removeMentions(in: text)

Packages/ComposeUI/Sources/ComposeUI/ComposeInput.swift

@@ -8,6 +8,7 @@
 import Foundation
 import Combine
 import UIKit
+import SwiftUI
 
 protocol ComposeInput: AnyObject, ObservableObject {
     var toolbarElements: [ToolbarElement] { get }
@@ -27,3 +28,44 @@ enum ToolbarElement {
     case emojiPicker
     case formattingButtons
 }
+
+private struct FocusedComposeInput: FocusedValueKey {
+    typealias Value = any ComposeInput
+}
+
+extension FocusedValues {
+    var composeInput: (any ComposeInput)? {
+        get { self[FocusedComposeInput.self] }
+        set { self[FocusedComposeInput.self] = newValue }
+    }
+}
+
+@propertyWrapper
+final class MutableObservableBox<Value>: ObservableObject {
+    @Published var wrappedValue: Value
+    
+    init(wrappedValue: Value) {
+        self.wrappedValue = wrappedValue
+    }
+}
+
+private struct FocusedComposeInputBox: EnvironmentKey {
+    static let defaultValue: MutableObservableBox<(any ComposeInput)?> = .init(wrappedValue: nil)
+}
+
+extension EnvironmentValues {
+    var composeInputBox: MutableObservableBox<(any ComposeInput)?> {
+        get { self[FocusedComposeInputBox.self] }
+        set { self[FocusedComposeInputBox.self] = newValue }
+    }
+}
+
+struct FocusedInputModifier: ViewModifier {
+    @StateObject var box: MutableObservableBox<(any ComposeInput)?> = .init(wrappedValue: nil)
+    
+    func body(content: Content) -> some View {
+        content
+            .environment(\.composeInputBox, box)
+            .focusedValue(\.composeInput, box.wrappedValue)
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/ComposeMastodonContext.swift

@@ -9,6 +9,7 @@ import Foundation
 import Pachyderm
 import InstanceFeatures
 import UserAccounts
+import SwiftUI
 
 public protocol ComposeMastodonContext {
     var accountInfo: UserAccountInfo? { get }
@@ -26,4 +27,6 @@ public protocol ComposeMastodonContext {
     func searchCachedHashtags(query: String) -> [Hashtag]
     
     func storeCreatedStatus(_ status: Status)
+    
+    func fetchStatus(id: String) -> (any StatusProtocol)?
 }

Packages/ComposeUI/Sources/ComposeUI/Controllers/AttachmentThumbnailController.swift

@@ -181,7 +181,7 @@ extension EnvironmentValues {
     }
 }
 
-private struct GIFViewWrapper: UIViewRepresentable {
+struct GIFViewWrapper: UIViewRepresentable {
     typealias UIViewType = GIFImageView
 
     @State var controller: GIFController

Packages/ComposeUI/Sources/ComposeUI/Controllers/AttachmentsListController.swift

@@ -131,7 +131,6 @@ class AttachmentsListController: ViewController {
         @EnvironmentObject private var controller: AttachmentsListController
         @EnvironmentObject private var draft: Draft
         @Environment(\.colorScheme) private var colorScheme
-        @Environment(\.horizontalSizeClass) private var horizontalSizeClass
         
         var body: some View {
             attachmentsList
@@ -217,7 +216,7 @@ fileprivate extension View {
 }
 
 @available(visionOS 1.0, *)
-fileprivate struct AttachmentButtonLabelStyle: LabelStyle {
+struct AttachmentButtonLabelStyle: LabelStyle {
     func makeBody(configuration: Configuration) -> some View {
         DefaultLabelStyle().makeBody(configuration: configuration)
             .foregroundStyle(.white)

Packages/ComposeUI/Sources/ComposeUI/Controllers/ComposeController.swift

@@ -130,11 +130,17 @@ public final class ComposeController: ViewController {
     }
     
     public var view: some View {
-        ComposeView(poster: poster)
-            .environment(\.managedObjectContext, DraftsPersistentContainer.shared.viewContext)
-            .environmentObject(draft)
-            .environmentObject(mastodonController.instanceFeatures)
-            .environment(\.composeUIConfig, config)
+        if Preferences.shared.hasFeatureFlag(.composeRewrite) {
+            ComposeUI.ComposeView(draft: draft, mastodonController: mastodonController)
+                .environment(\.currentAccount, currentAccount)
+                .environment(\.composeUIConfig, config)
+        } else {
+            ComposeView(poster: poster)
+                .environment(\.managedObjectContext, DraftsPersistentContainer.shared.viewContext)
+                .environmentObject(draft)
+                .environmentObject(mastodonController.instanceFeatures)
+                .environment(\.composeUIConfig, config)
+        }
     }
     
     @MainActor

Packages/ComposeUI/Sources/ComposeUI/Controllers/PlaceholderController.swift

@@ -17,7 +17,7 @@ final class PlaceholderController: ViewController, PlaceholderViewProvider {
            Date().formatted(date: .numeric, time: .omitted).starts(with: "3") {
             Text("Happy π day!")
         } else if components.month == 4 && components.day == 1 {
-            Text("April Fool's!").rotationEffect(.radians(.pi), anchor: .center)
+            Text("April Fool’s!").rotationEffect(.radians(.pi), anchor: .center)
         } else if components.month == 9 && components.day == 5 {
             // https://weirder.earth/@noracodes/109276419847254552
             // https://retrocomputing.stackexchange.com/questions/14763/what-warning-was-given-on-attempting-to-post-to-usenet-circa-1990
@@ -31,7 +31,7 @@ final class PlaceholderController: ViewController, PlaceholderViewProvider {
                 Text("Any questions?")
             }
         } else {
-            Text("What's on your mind?")
+            Text("What’s on your mind?")
         }
     }
     
@@ -41,7 +41,7 @@ final class PlaceholderController: ViewController, PlaceholderViewProvider {
 }
 
 // exists to provide access to the type alias since the @State property needs it to be explicit
-private protocol PlaceholderViewProvider {
+protocol PlaceholderViewProvider {
     associatedtype PlaceholderView: View
     @ViewBuilder
     static func makePlaceholderView() -> PlaceholderView

Packages/ComposeUI/Sources/ComposeUI/Environment.swift

@@ -0,0 +1,49 @@
+//
+//  Environment.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+import Pachyderm
+
+//@propertyWrapper
+//struct RequiredEnvironment<Value>: DynamicProperty {
+//    private let keyPath: KeyPath<EnvironmentValues, Value?>
+//    @Environment private var value: Value?
+//    
+//    init(_ keyPath: KeyPath<EnvironmentValues, Value?>) {
+//        self.keyPath = keyPath
+//        self._value = Environment(keyPath)
+//    }
+//    
+//    var wrappedValue: Value {
+//        guard let value else {
+//            preconditionFailure("Missing required environment value for \(keyPath)")
+//        }
+//        return value
+//    }
+//}
+
+private struct ComposeMastodonContextKey: EnvironmentKey {
+    static let defaultValue: (any ComposeMastodonContext)? = nil
+}
+
+extension EnvironmentValues {
+    var mastodonController: (any ComposeMastodonContext)? {
+        get { self[ComposeMastodonContextKey.self] }
+        set { self[ComposeMastodonContextKey.self] = newValue }
+    }
+}
+
+private struct CurrentAccountKey: EnvironmentKey {
+    static let defaultValue: (any AccountProtocol)? = nil
+}
+
+extension EnvironmentValues {
+    var currentAccount: (any AccountProtocol)? {
+        get { self[CurrentAccountKey.self] }
+        set { self[CurrentAccountKey.self] = newValue }
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/KeyboardReader.swift

@@ -11,7 +11,6 @@ import UIKit
 import Combine
 
 class KeyboardReader: ObservableObject {
-//    @Published var isVisible = false
     @Published var keyboardHeight: CGFloat = 0
     
     var isVisible: Bool {
@@ -26,14 +25,12 @@ class KeyboardReader: ObservableObject {
     
     @objc func willShow(_ notification: Foundation.Notification) {
         let endFrame = notification.userInfo![UIResponder.keyboardFrameEndUserInfoKey] as! CGRect
-//        isVisible = endFrame.height > 72
         keyboardHeight = endFrame.height
     }
     
     @objc func willHide() {
         // sometimes willHide is called during a SwiftUI view update
         DispatchQueue.main.async {
-//            self.isVisible = false
             self.keyboardHeight = 0
         }
     }

Packages/ComposeUI/Sources/ComposeUI/Model/StatusFormat.swift

@@ -9,9 +9,13 @@
 import UIKit
 import Pachyderm
 
-enum StatusFormat: Int, CaseIterable {
+enum StatusFormat: Int, CaseIterable, Identifiable {
     case bold, italics, strikethrough, code
     
+    var id: some Hashable {
+        rawValue
+    }
+    
     func insertionResult(for contentType: StatusContentType) -> FormatInsertionResult? {
         switch contentType {
         case .plain:

Packages/ComposeUI/Sources/ComposeUI/Preferences.swift

@@ -0,0 +1,11 @@
+//
+//  Preferences.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import Foundation
+import TuskerPreferences
+
+typealias Preferences = TuskerPreferences.Preferences

Packages/ComposeUI/Sources/ComposeUI/ViewController.swift

@@ -11,6 +11,7 @@ import Combine
 public protocol ViewController: ObservableObject {
     associatedtype ContentView: View
     
+    @MainActor
     @ViewBuilder
     var view: ContentView { get }
 }

Packages/ComposeUI/Sources/ComposeUI/Views/AttachmentRowView.swift

@@ -0,0 +1,182 @@
+//
+//  AttachmentRowView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/18/24.
+//
+
+import SwiftUI
+import InstanceFeatures
+import Vision
+
+struct AttachmentRowView: View {
+    @ObservedObject var attachment: DraftAttachment
+    @State private var isRecognizingText = false
+    @State private var textRecognitionError: (any Error)?
+    
+    private var thumbnailSize: CGFloat {
+        #if os(visionOS)
+        120
+        #else
+        80
+        #endif
+    }
+    
+    var body: some View {
+        HStack(alignment: .center, spacing: 4) {
+            thumbnailView
+            
+            descriptionView
+        }
+        .alertWithData("Text Recognition Failed", data: $textRecognitionError) { _ in
+            Button("OK") {}
+        } message: { error in
+            Text(error.localizedDescription)
+        }
+    }
+    
+    // TODO: attachments missing descriptions feature
+    
+    private var thumbnailView: some View {
+        AttachmentThumbnailView(attachment: attachment)
+            .clipShape(RoundedRectangle(cornerRadius: 8))
+            .frame(width: thumbnailSize, height: thumbnailSize)
+            .contextMenu {
+                EditDrawingButton(attachment: attachment)
+                RecognizeTextButton(attachment: attachment, isRecognizingText: $isRecognizingText, error: $textRecognitionError)
+                DeleteButton(attachment: attachment)
+            } preview: {
+                // TODO: need to fix flash of preview changing size
+                AttachmentThumbnailView(attachment: attachment)
+            }
+    }
+    
+    @ViewBuilder
+    private var descriptionView: some View {
+        if isRecognizingText {
+            ProgressView()
+                .progressViewStyle(.circular)
+        } else {
+            InlineAttachmentDescriptionView(attachment: attachment, minHeight: thumbnailSize)
+        }
+    }
+}
+
+private struct EditDrawingButton: View {
+    @ObservedObject var attachment: DraftAttachment
+    @Environment(\.composeUIConfig.presentDrawing) private var presentDrawing
+    
+    var body: some View {
+        if attachment.drawingData != nil {
+            Button(action: editDrawing) {
+                Label("Edit Drawing", systemImage: "hand.draw")
+            }
+        }
+    }
+    
+    private func editDrawing() {
+        if case .drawing(let drawing) = attachment.data {
+            presentDrawing?(drawing) {
+                attachment.drawing = $0
+            }
+        }
+    }
+}
+
+private struct RecognizeTextButton: View {
+    @ObservedObject var attachment: DraftAttachment
+    @Binding var isRecognizingText: Bool
+    @Binding var error: (any Error)?
+    @EnvironmentObject private var instanceFeatures: InstanceFeatures
+    
+    var body: some View {
+        if attachment.type == .image {
+            Button {
+                Task {
+                    await recognizeText()
+                }
+            } label: {
+                Label("Recognize Text", systemImage: "doc.text.viewfinder")
+            }
+        }
+    }
+    
+    private func recognizeText() async {
+        isRecognizingText = true
+        defer { isRecognizingText = false }
+        
+        do {
+            let data = try await getAttachmentData()
+            let observations = try await runRecognizeTextRequest(data: data)
+            if let observations {
+                var text = ""
+                for observation in observations {
+                    let result = observation.topCandidates(1).first!
+                    text.append(result.string)
+                    text.append("\n")
+                }
+                self.attachment.attachmentDescription = text
+            }
+        } catch let error as NSError where error.domain == VNErrorDomain && error.code == 1 {
+            // The perform call throws an error with code 1 if the request is cancelled, which we don't want to show an alert for.
+            return
+        } catch {
+            self.error = error
+        }
+    }
+    
+    private func getAttachmentData() async throws -> Data {
+        return try await withCheckedThrowingContinuation { continuation in
+            attachment.getData(features: instanceFeatures) { result in
+                switch result {
+                case .success(let (data, _)):
+                    continuation.resume(returning: data)
+                case .failure(let error):
+                    continuation.resume(throwing: error)
+                }
+            }
+        }
+    }
+    
+    private func runRecognizeTextRequest(data: Data) async throws -> [VNRecognizedTextObservation]? {
+        return try await withCheckedThrowingContinuation { continuation in
+            let handler = VNImageRequestHandler(data: data)
+            let request = VNRecognizeTextRequest { request, error in
+                if let error {
+                    continuation.resume(throwing: error)
+                } else {
+                    continuation.resume(returning: request.results as? [VNRecognizedTextObservation])
+                }
+            }
+            request.recognitionLevel = .accurate
+            request.usesLanguageCorrection = true
+            DispatchQueue.global(qos: .userInitiated).async {
+                try? handler.perform([request])
+            }
+        }
+    }
+}
+
+private struct DeleteButton: View {
+    let attachment: DraftAttachment
+    
+    var body: some View {
+        Button(role: .destructive, action: removeAttachment) {
+            Label("Delete", systemImage: "trash")
+        }
+    }
+    
+    private func removeAttachment() {
+        let draft = attachment.draft
+        var array = draft.draftAttachments
+        guard let index = array.firstIndex(of: attachment) else {
+            return
+        }
+        array.remove(at: index)
+        draft.attachments = NSMutableOrderedSet(array: array)
+    }
+}
+
+//#Preview {
+//    AttachmentRowView()
+//}

Packages/ComposeUI/Sources/ComposeUI/Views/AttachmentThumbnailView.swift

@@ -0,0 +1,114 @@
+//
+//  AttachmentThumbnailView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 10/14/24.
+//
+
+import SwiftUI
+import TuskerComponents
+import AVFoundation
+import Photos
+
+struct AttachmentThumbnailView: View {
+    let attachment: DraftAttachment
+    let contentMode: ContentMode = .fit
+    @State private var mode: Mode = .empty
+    @EnvironmentObject private var composeController: ComposeController
+    
+    var body: some View {
+        switch mode {
+        case .empty:
+            Image(systemName: "photo")
+                .task {
+                    await loadThumbnail()
+                }
+        case .image(let image):
+            Image(uiImage: image)
+                .resizable()
+                .aspectRatio(contentMode: contentMode)
+        case .gifController(let controller):
+            GIFViewWrapper(controller: controller)
+        }
+    }
+    
+    private func loadThumbnail() async {
+        switch attachment.data {
+        case .editing(_, let kind, let url):
+            switch kind {
+            case .image:
+                if let image = await composeController.fetchAttachment(url) {
+                    self.mode = .image(image)
+                }
+                
+            case .video, .gifv:
+                await loadVideoThumbnail(url: url)
+                
+            case .audio, .unknown:
+                break
+            }
+            
+        case .asset(let id):
+            guard let asset = PHAsset.fetchAssets(withLocalIdentifiers: [id], options: nil).firstObject else {
+                return
+            }
+            let isGIF = PHAssetResource.assetResources(for: asset).contains {
+                $0.uniformTypeIdentifier == UTType.gif.identifier
+            }
+            if isGIF {
+                PHImageManager.default().requestImageDataAndOrientation(for: asset, options: nil) { data, typeIdentifier, orientation, info in
+                    guard let data else { return }
+                    if typeIdentifier == UTType.gif.identifier {
+                        self.mode = .gifController(GIFController(gifData: data))
+                    } else if let image = UIImage(data: data) {
+                        self.mode = .image(image)
+                    }
+                }
+            } else {
+                let size = CGSize(width: 80, height: 80)
+                PHImageManager.default().requestImage(for: asset, targetSize: size, contentMode: .aspectFill, options: nil) { image, _ in
+                    if let image {
+                        self.mode = .image(image)
+                    }
+                }
+            }
+            
+        case .drawing(let drawing):
+            self.mode = .image(drawing.imageInLightMode(from: drawing.bounds))
+            
+        case .file(let url, let type):
+            if type.conforms(to: .movie) {
+                await loadVideoThumbnail(url: url)
+            } else if let data = try? Data(contentsOf: url) {
+                if type == .gif {
+                    self.mode = .gifController(GIFController(gifData: data))
+                } else if type.conforms(to: .image) {
+                    if let image = UIImage(data: data),
+                       // using prepareThumbnail on images from PHPicker results in extremely high memory usage,
+                       // crashing share extension. see FB12186346
+                       let prepared = await image.byPreparingForDisplay() {
+                        self.mode = .image(prepared)
+                    }
+                }
+            }
+            
+        case .none:
+            break
+        }
+    }
+    
+    private func loadVideoThumbnail(url: URL) async {
+        let asset = AVURLAsset(url: url)
+        let imageGenerator = AVAssetImageGenerator(asset: asset)
+        imageGenerator.appliesPreferredTrackTransform = true
+        if let (cgImage, _) = try? await imageGenerator.image(at: .zero) {
+            self.mode = .image(UIImage(cgImage: cgImage))
+        }
+    }
+    
+    enum Mode {
+        case empty
+        case image(UIImage)
+        case gifController(GIFController)
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/AttachmentsListSection.swift

@@ -0,0 +1,182 @@
+//
+//  AttachmentsListSection.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 10/14/24.
+//
+
+import SwiftUI
+import InstanceFeatures
+import PencilKit
+
+struct AttachmentsListSection: View {
+    @ObservedObject var draft: Draft
+    @ObservedObject var instanceFeatures: InstanceFeatures
+    @Environment(\.canAddAttachment) private var canAddAttachment
+    
+    var body: some View {
+        attachmentRows
+        
+        buttons
+            .foregroundStyle(.tint)
+            #if os(visionOS)
+            .buttonStyle(.bordered)
+            .labelStyle(AttachmentButtonLabelStyle())
+            #endif
+    }
+    
+    private var attachmentRows: some View {
+        ForEach(draft.draftAttachments) { attachment in
+            AttachmentRowView(attachment: attachment)
+        }
+        .onMove(perform: moveAttachments)
+        .onDelete(perform: deleteAttachments)
+        .onInsert(of: DraftAttachment.readableTypeIdentifiersForItemProvider) { offset, providers in
+            Self.insertAttachments(in: draft, at: offset, itemProviders: providers)
+        }
+    }
+    
+    @ViewBuilder
+    private var buttons: some View {
+        AddPhotoButton(addAttachments: self.addAttachments)
+        
+        AddDrawingButton(draft: draft)
+        
+        TogglePollButton(draft: draft)
+    }
+    
+    static func insertAttachments(in draft: Draft, at index: Int, itemProviders: [NSItemProvider]) {
+        for provider in itemProviders where provider.canLoadObject(ofClass: DraftAttachment.self) {
+            provider.loadObject(ofClass: DraftAttachment.self) { object, error in
+                guard let attachment = object as? DraftAttachment else { return }
+                DispatchQueue.main.async {
+                    DraftsPersistentContainer.shared.viewContext.insert(attachment)
+                    attachment.draft = draft
+                    draft.attachments.add(attachment)
+                }
+            }
+        }
+    }
+    
+    private func addAttachments(itemProviders: [NSItemProvider]) {
+        Self.insertAttachments(in: draft, at: draft.attachments.count, itemProviders: itemProviders)
+    }
+    
+    private func moveAttachments(from source: IndexSet, to destination: Int) {
+        // just using moveObjects(at:to:) on the draft.attachments NSMutableOrderedSet
+        // results in the order switching back to the previous order and then to the correct one
+        // on the subsequent 2 view updates. creating a new set with the proper order doesn't have that problem
+        var array = draft.draftAttachments
+        array.move(fromOffsets: source, toOffset: destination)
+        draft.attachments = NSMutableOrderedSet(array: array)
+    }
+    
+    private func deleteAttachments(at indices: IndexSet) {
+        var array = draft.draftAttachments
+        array.remove(atOffsets: indices)
+        draft.attachments = NSMutableOrderedSet(array: array)
+    }
+
+}
+
+private struct AddPhotoButton: View {
+    let addAttachments: ([NSItemProvider]) -> Void
+    @Environment(\.composeUIConfig.presentAssetPicker) private var presentAssetPicker
+    
+    var body: some View {
+        if let presentAssetPicker {
+            Button("Add photo or video", systemImage: "photo") {
+                presentAssetPicker { results in
+                    addAttachments(results.map(\.itemProvider))
+                }
+            }
+        }
+    }
+}
+
+private struct AddDrawingButton: View {
+    let draft: Draft
+    @Environment(\.composeUIConfig.presentDrawing) private var presentDrawing
+    
+    var body: some View {
+        if let presentDrawing {
+            Button("Add drawing", systemImage: "hand.draw") {
+                presentDrawing(PKDrawing()) { drawing in
+                    let attachment = DraftAttachment(context: DraftsPersistentContainer.shared.viewContext)
+                    attachment.id = UUID()
+                    attachment.drawing = drawing
+                    attachment.draft = self.draft
+                    self.draft.attachments.add(attachment)
+                }
+            }
+        }
+    }
+}
+
+private struct TogglePollButton: View {
+    @ObservedObject var draft: Draft
+    
+    var body: some View {
+        Button(draft.poll == nil ? "Add a poll" : "Remove poll", systemImage: "chart.bar.doc.horizontal") {
+            withAnimation {
+                draft.poll = draft.poll == nil ? Poll(context: DraftsPersistentContainer.shared.viewContext) : nil
+            }
+        }
+        .disabled(draft.attachments.count > 0)
+    }
+}
+
+struct AddAttachmentConditionsModifier: ViewModifier {
+    @ObservedObject var draft: Draft
+    @ObservedObject var instanceFeatures: InstanceFeatures
+    
+    private var canAddAttachment: Bool {
+        if instanceFeatures.mastodonAttachmentRestrictions {
+            return draft.attachments.count < 4
+                && draft.draftAttachments.allSatisfy { $0.type == .image }
+                && draft.poll == nil
+        } else {
+            return true
+        }
+    }
+
+    func body(content: Content) -> some View {
+        content
+            .environment(\.canAddAttachment, canAddAttachment)
+    }
+}
+
+private struct CanAddAttachmentKey: EnvironmentKey {
+    static let defaultValue = false
+}
+
+extension EnvironmentValues {
+    var canAddAttachment: Bool {
+        get { self[CanAddAttachmentKey.self] }
+        set { self[CanAddAttachmentKey.self] = newValue }
+    }
+}
+
+struct DropAttachmentModifier: ViewModifier {
+    let draft: Draft
+    @Environment(\.canAddAttachment) private var canAddAttachment
+    
+    func body(content: Content) -> some View {
+        content
+            .onDrop(of: DraftAttachment.readableTypeIdentifiersForItemProvider, delegate: AttachmentDropDelegate(draft: draft, canAddAttachment: canAddAttachment))
+    }
+}
+
+private struct AttachmentDropDelegate: DropDelegate {
+    let draft: Draft
+    let canAddAttachment: Bool
+    
+    func validateDrop(info: DropInfo) -> Bool {
+        canAddAttachment
+    }
+    
+    func performDrop(info: DropInfo) -> Bool {
+        AttachmentsListSection.insertAttachments(in: draft, at: draft.attachments.count, itemProviders: info.itemProviders(for: DraftAttachment.readableTypeIdentifiersForItemProvider))
+        return true
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/ComposeToolbarView.swift

@@ -0,0 +1,272 @@
+//
+//  ComposeToolbarView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+import TuskerComponents
+import InstanceFeatures
+import Pachyderm
+import TuskerPreferences
+
+struct ComposeToolbarView: View {
+    static let height: CGFloat = 44
+    
+    @ObservedObject var draft: Draft
+    let mastodonController: any ComposeMastodonContext
+    @FocusState.Binding var focusedField: FocusableField?
+    
+    var body: some View {
+        #if os(visionOS)
+        buttons
+        #else
+        ToolbarScrollView {
+            buttons
+                .padding(.horizontal, 16)
+        }
+        .frame(height: Self.height)
+        .background(.regularMaterial, ignoresSafeAreaEdges: [.bottom, .leading, .trailing])
+        .overlay(alignment: .top) {
+            Divider()
+                .ignoresSafeArea(edges: [.leading, .trailing])
+        }
+        #endif
+    }
+    
+    private var buttons: some View {
+        HStack(spacing: 0) {
+            ContentWarningButton(enabled: $draft.contentWarningEnabled, focusedField: $focusedField)
+            
+            VisibilityButton(draft: draft, instanceFeatures: mastodonController.instanceFeatures)
+            
+            LocalOnlyButton(enabled: $draft.localOnly, mastodonController: mastodonController)
+            
+            InsertEmojiButton()
+            
+            FormatButtons()
+            
+            Spacer()
+            
+            LangaugeButton(draft: draft, instanceFeatures: mastodonController.instanceFeatures)
+        }
+    }
+}
+
+#if !os(visionOS)
+private struct ToolbarScrollView<Content: View>: View {
+    @ViewBuilder let content: Content
+    @State private var minWidth: CGFloat?
+    @State private var realWidth: CGFloat?
+    
+    var body: some View {
+        ScrollView(.horizontal, showsIndicators: false) {
+            content
+                .frame(minWidth: minWidth)
+                .background {
+                    GeometryReader { proxy in
+                        Color.clear
+                            .preference(key: ToolbarWidthPrefKey.self, value: proxy.size.width)
+                            .onPreferenceChange(ToolbarWidthPrefKey.self) {
+                                realWidth = $0
+                            }
+                    }
+                }
+        }
+        .scrollDisabled(realWidth ?? 0 <= minWidth ?? 0)
+        .frame(maxWidth: .infinity)
+        .background {
+            GeometryReader { proxy in
+                Color.clear
+                    .preference(key: ToolbarWidthPrefKey.self, value: proxy.size.width)
+                    .onPreferenceChange(ToolbarWidthPrefKey.self) {
+                        minWidth = $0
+                    }
+            }
+        }
+    }
+}
+#endif
+
+private struct ToolbarWidthPrefKey: SwiftUI.PreferenceKey {
+    static var defaultValue: CGFloat? = nil
+    static func reduce(value: inout CGFloat?, nextValue: () -> CGFloat?) {
+        value = value ?? nextValue()
+    }
+}
+
+private struct ContentWarningButton: View {
+    @Binding var enabled: Bool
+    @FocusState.Binding var focusedField: FocusableField?
+    
+    var body: some View {
+        Button("CW", action: toggleContentWarning)
+            .accessibilityLabel(enabled ? "Remove content warning" : "Add content warning")
+            .padding(5)
+            .hoverEffect()
+    }
+    
+    private func toggleContentWarning() {
+        enabled.toggle()
+        if enabled {
+            focusedField = .contentWarning
+        }
+    }
+}
+
+private struct VisibilityButton: View {
+    @ObservedObject var draft: Draft
+    @ObservedObject var instanceFeatures: InstanceFeatures
+    
+    private var visibilityBinding: Binding<Pachyderm.Visibility> {
+        // On instances that conflate visibliity and local only, we still show two separate controls but don't allow
+        // changing the visibility when local-only.
+        if draft.localOnly,
+           instanceFeatures.localOnlyPostsVisibility {
+            return .constant(.public)
+        } else {
+            return $draft.visibility
+        }
+    }
+    
+    private var visibilityOptions: [MenuPicker<Pachyderm.Visibility>.Option] {
+        let visibilities: [Pachyderm.Visibility]
+        if !instanceFeatures.composeDirectStatuses {
+            visibilities = [.public, .unlisted, .private]
+        } else {
+            visibilities = Pachyderm.Visibility.allCases
+        }
+        return visibilities.map { vis in
+            .init(value: vis, title: vis.displayName, subtitle: vis.subtitle, image: UIImage(systemName: vis.unfilledImageName), accessibilityLabel: "Visibility: \(vis.displayName)")
+        }
+    }
+    
+    var body: some View {
+        MenuPicker(selection: visibilityBinding, options: visibilityOptions, buttonStyle: .iconOnly)
+            #if !targetEnvironment(macCatalyst) && !os(visionOS)
+            // the button has a bunch of extra space by default, but combined with what we add it's too much
+            .padding(.horizontal, -8)
+            #endif
+            .disabled(draft.editedStatusID != nil)
+            .disabled(instanceFeatures.localOnlyPostsVisibility && draft.localOnly)
+    }
+}
+
+private struct LocalOnlyButton: View {
+    @Binding var enabled: Bool
+    var mastodonController: any ComposeMastodonContext
+    @ObservedObject private var instanceFeatures: InstanceFeatures
+    
+    init(enabled: Binding<Bool>, mastodonController: any ComposeMastodonContext) {
+        self._enabled = enabled
+        self.mastodonController = mastodonController
+        self.instanceFeatures = mastodonController.instanceFeatures
+    }
+    
+    private var options: [MenuPicker<Bool>.Option] {
+        let domain = mastodonController.accountInfo!.instanceURL.host!
+        return [
+            .init(value: true, title: "Local-only", subtitle: "Only \(domain)", image: UIImage(named: "link.broken")),
+            .init(value: false, title: "Federated", image: UIImage(systemName: "link")),
+        ]
+    }
+    
+    var body: some View {
+        if mastodonController.instanceFeatures.localOnlyPosts {
+            MenuPicker(selection: $enabled, options: options, buttonStyle: .iconOnly)
+        }
+    }
+}
+
+private struct InsertEmojiButton: View {
+    @FocusedValue(\.composeInput) private var input
+    @ScaledMetric(relativeTo: .body) private var imageSize: CGFloat = 22
+    
+    var body: some View {
+        if input?.toolbarElements.contains(.emojiPicker) == true {
+            Button(action: beginAutocompletingEmoji) {
+                Label("Insert custom emoji", systemImage: "face.smiling")
+            }
+            .labelStyle(.iconOnly)
+            .font(.system(size: imageSize))
+            .padding(5)
+            .hoverEffect()
+            .transition(.opacity.animation(.linear(duration: 0.2)))
+        }
+    }
+    
+    private func beginAutocompletingEmoji() {
+        input?.beginAutocompletingEmoji()
+    }
+}
+
+private struct FormatButtons: View {
+    @FocusedValue(\.composeInput) private var input
+    @PreferenceObserving(\.$statusContentType) private var contentType
+    
+    var body: some View {
+        if let input,
+           input.toolbarElements.contains(.formattingButtons),
+           contentType != .plain {
+            
+            Spacer()
+            ForEach(StatusFormat.allCases) { format in
+                FormatButton(format: format, input: input)
+            }
+        }
+    }
+}
+
+private struct FormatButton: View {
+    let format: StatusFormat
+    let input: any ComposeInput
+    @ScaledMetric(relativeTo: .body) private var imageSize: CGFloat = 22
+    
+    var body: some View {
+        Button(action: applyFormat) {
+            Image(systemName: format.imageName)
+                .font(.system(size: imageSize))
+        }
+        .accessibilityLabel(format.accessibilityLabel)
+        .padding(5)
+        .hoverEffect()
+        .transition(.opacity.animation(.linear(duration: 0.2)))
+    }
+    
+    private func applyFormat() {
+        input.applyFormat(format)
+    }
+}
+
+private struct LangaugeButton: View {
+    @ObservedObject var draft: Draft
+    @ObservedObject var instanceFeatures: InstanceFeatures
+    @FocusedValue(\.composeInput) private var input
+    @State private var hasChanged = false
+    
+    var body: some View {
+        if instanceFeatures.createStatusWithLanguage {
+            LanguagePicker(draftLanguage: $draft.language, hasChangedSelection: $hasChanged)
+                .onReceive(NotificationCenter.default.publisher(for: UITextInputMode.currentInputModeDidChangeNotification), perform: currentInputModeChanged)
+                .onChange(of: draft.id) { _ in
+                    hasChanged = false
+                }
+        }
+    }
+    
+    @available(iOS 16.0, *)
+    private func currentInputModeChanged(_ notification: Foundation.Notification) {
+        guard !hasChanged,
+              !draft.hasContent,
+              let mode = input?.textInputMode,
+              let code = LanguagePicker.codeFromInputMode(mode) else {
+            return
+        }
+        draft.language = code.identifier
+    }
+}
+
+//#Preview {
+//    ComposeToolbarView()
+//}

Packages/ComposeUI/Sources/ComposeUI/Views/ComposeView.swift

@@ -0,0 +1,235 @@
+//
+//  ComposeView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+
+struct ComposeView: View {
+    @ObservedObject var draft: Draft
+    let mastodonController: any ComposeMastodonContext
+    @State private var poster: PostService? = nil
+    @FocusState private var focusedField: FocusableField?
+    @EnvironmentObject private var controller: ComposeController
+    
+    var body: some View {
+        NavigationStack {
+            navigationRoot
+        }
+    }
+    
+    private var navigationRoot: some View {
+        ZStack {
+            List {
+                listContent
+            }
+            .listStyle(.plain)
+            .scrollDismissesKeyboard(.interactively)
+            #if !os(visionOS) && !targetEnvironment(macCatalyst)
+            .modifier(ToolbarSafeAreaInsetModifier())
+            #endif
+        }
+        .overlay(alignment: .top) {
+            if let poster {
+                PostProgressView(poster: poster)
+                    .frame(alignment: .top)
+            }
+        }
+        #if !os(visionOS)
+        .overlay(alignment: .bottom, content: {
+            // TODO: during ducking animation, toolbar should move off the botto edge
+            // This needs to be in an overlay, ignoring the keyboard safe area
+            // doesn't work with the safeAreaInset modifier.
+            toolbarView
+                .frame(maxHeight: .infinity, alignment: .bottom)
+                .ignoresSafeArea(.keyboard)
+        })
+        #endif
+        // Have these after the overlays so they barely work instead of not working at all. FB11790805
+        .modifier(DropAttachmentModifier(draft: draft))
+        .modifier(AddAttachmentConditionsModifier(draft: draft, instanceFeatures: mastodonController.instanceFeatures))
+        .modifier(NavigationTitleModifier(draft: draft, mastodonController: mastodonController))
+        .navigationBarTitleDisplayMode(.inline)
+        .toolbar {
+            ToolbarActions(draft: draft, controller: controller)
+            #if os(visionOS)
+            ToolbarItem(placement: .bottomOrnament) {
+                toolbarView
+            }
+            #endif
+        }
+    }
+    
+    private var toolbarView: some View {
+        ComposeToolbarView(draft: draft, mastodonController: mastodonController, focusedField: $focusedField)
+    }
+    
+    @ViewBuilder
+    private var listContent: some View {
+        NewReplyStatusView(draft: draft, mastodonController: mastodonController)
+            .listRowInsets(EdgeInsets(top: 8, leading: 8, bottom: 4, trailing: 8))
+            .listRowSeparator(.hidden)
+        
+        NewHeaderView(draft: draft, instanceFeatures: mastodonController.instanceFeatures)
+            .listRowInsets(EdgeInsets(top: 8, leading: 8, bottom: 4, trailing: 8))
+            .listRowSeparator(.hidden)
+        
+        ContentWarningTextField(draft: draft, focusedField: $focusedField)
+            .listRowInsets(EdgeInsets(top: 8, leading: 8, bottom: 4, trailing: 8))
+            .listRowSeparator(.hidden)
+        
+        NewMainTextView(value: $draft.text, focusedField: $focusedField, handleAttachmentDrop: self.addAttachments)
+            .listRowInsets(EdgeInsets(top: 8, leading: 8, bottom: 4, trailing: 8))
+            .listRowSeparator(.hidden)
+
+        AttachmentsListSection(draft: draft, instanceFeatures: mastodonController.instanceFeatures)
+    }
+    
+    private func addAttachments(_ itemProviders: [NSItemProvider]) {
+        AttachmentsListSection.insertAttachments(in: draft, at: draft.attachments.count, itemProviders: itemProviders)
+    }
+}
+
+private struct NavigationTitleModifier: ViewModifier {
+    let draft: Draft
+    let mastodonController: any ComposeMastodonContext
+    
+    private var navigationTitle: String {
+        if let id = draft.inReplyToID,
+           let status = mastodonController.fetchStatus(id: id) {
+            return "Reply to @\(status.account.acct)"
+        } else if draft.editedStatusID != nil {
+            return "Edit Post"
+        } else {
+            return "New Post"
+        }
+    }
+
+    func body(content: Content) -> some View {
+        content
+            .navigationTitle(navigationTitle)
+            .preference(key: NavigationTitlePreferenceKey.self, value: navigationTitle)
+    }
+}
+
+// Public preference so that the host can read the title.
+public struct NavigationTitlePreferenceKey: PreferenceKey {
+    public static var defaultValue: String? { nil }
+    public static func reduce(value: inout String?, nextValue: () -> String?) {
+        value = value ?? nextValue()
+    }
+}
+
+private struct ToolbarActions: ToolbarContent {
+    @ObservedObject var draft: Draft
+    // Prior to iOS 16, the toolbar content doesn't seem to have access
+    // to the environment form the containing view.
+    let controller: ComposeController
+    
+    var body: some ToolbarContent {
+        ToolbarItem(placement: .cancellationAction) { ToolbarCancelButton(draft: draft) }
+        
+        #if targetEnvironment(macCatalyst)
+        ToolbarItem(placement: .topBarTrailing) { draftsButton }
+        ToolbarItem(placement: .confirmationAction) { postButton }
+        #else
+        ToolbarItem(placement: .confirmationAction) { postOrDraftsButton }
+        #endif
+    }
+    
+    private var draftsButton: some View {
+        Button(action: controller.showDrafts) {
+            Text("Drafts")
+        }
+    }
+    
+    private var postButton: some View {
+        // TODO: don't use the controller for this
+        Button(action: controller.postStatus) {
+            Text(draft.editedStatusID == nil ? "Post" : "Edit")
+        }
+        .keyboardShortcut(.return, modifiers: .command)
+        .disabled(!controller.postButtonEnabled)
+    }
+    
+    #if !targetEnvironment(macCatalyst)
+    @ViewBuilder
+    private var postOrDraftsButton: some View {
+        if draft.hasContent || draft.editedStatusID != nil || !controller.config.allowSwitchingDrafts {
+            postButton
+        } else {
+            draftsButton
+        }
+    }
+    #endif
+}
+
+private struct ToolbarCancelButton: View {
+    let draft: Draft
+    @EnvironmentObject private var controller: ComposeController
+    
+    var body: some View {
+        Button(action: controller.cancel) {
+            Text("Cancel")
+                // otherwise all Buttons in the nav bar are made semibold
+                .font(.system(size: 17, weight: .regular))
+        }
+        .disabled(controller.isPosting)
+        .confirmationDialog("Are you sure?", isPresented: $controller.isShowingSaveDraftSheet) {
+            // edit drafts can't be saved
+            if draft.editedStatusID == nil {
+                Button(action: { controller.cancel(deleteDraft: false) }) {
+                    Text("Save Draft")
+                }
+                Button(role: .destructive, action: { controller.cancel(deleteDraft: true) }) {
+                    Text("Delete Draft")
+                }
+            } else {
+                Button(role: .destructive, action: { controller.cancel(deleteDraft: true) }) {
+                    Text("Cancel Edit")
+                }
+            }
+        }
+    }
+}
+
+enum FocusableField: Hashable {
+    case contentWarning
+    case body
+    case attachmentDescription(UUID)
+    
+    var nextField: FocusableField? {
+        switch self {
+        case .contentWarning:
+            return .body
+        default:
+            return nil
+        }
+    }
+}
+
+#if !os(visionOS) && !targetEnvironment(macCatalyst)
+private struct ToolbarSafeAreaInsetModifier: ViewModifier {
+    @StateObject private var keyboardReader = KeyboardReader()
+    
+    func body(content: Content) -> some View {
+        if #available(iOS 17.0, *) {
+            content
+                .safeAreaPadding(.bottom, keyboardReader.isVisible ? 0 : ComposeToolbarView.height)
+        } else {
+            content
+                .safeAreaInset(edge: .bottom) {
+                    if !keyboardReader.isVisible {
+                        Color.clear.frame(height: ComposeToolbarView.height)
+                    }
+                }
+        }
+    }
+}
+#endif
+
+//#Preview {
+//    ComposeView()
+//}

Packages/ComposeUI/Sources/ComposeUI/Views/ContentWarningTextField.swift

@@ -0,0 +1,38 @@
+//
+//  ContentWarningTextField.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+
+struct ContentWarningTextField: View {
+    @ObservedObject var draft: Draft
+    @FocusState.Binding var focusedField: FocusableField?
+    
+    var body: some View {
+        if draft.contentWarningEnabled {
+            EmojiTextField(
+                text: $draft.contentWarning,
+                placeholder: "Write your warning here",
+                maxLength: nil,
+                // TODO: completely replace this with FocusState
+                becomeFirstResponder: .constant(false),
+                focusNextView: Binding(get: {
+                    false
+                }, set: {
+                    if $0 {
+                        focusedField = .body
+                    }
+                })
+            )
+            .focused($focusedField, equals: .contentWarning)
+            .modifier(FocusedInputModifier())
+        }
+    }
+}
+
+//#Preview {
+//    ContentWarningTextField()
+//}

Packages/ComposeUI/Sources/ComposeUI/Views/EmojiTextField.swift

@@ -12,6 +12,7 @@ struct EmojiTextField: UIViewRepresentable {
     
     @EnvironmentObject private var controller: ComposeController
     @Environment(\.colorScheme) private var colorScheme
+    @Environment(\.composeInputBox) private var inputBox
     
     @Binding var text: String
     let placeholder: String
@@ -75,7 +76,11 @@ struct EmojiTextField: UIViewRepresentable {
     }
     
     func makeCoordinator() -> Coordinator {
-        Coordinator(controller: controller, text: $text, focusNextView: focusNextView)
+        let coordinator = Coordinator(controller: controller, text: $text, focusNextView: focusNextView)
+        DispatchQueue.main.async {
+            inputBox.wrappedValue = coordinator
+        }
+        return coordinator
     }
     
     class Coordinator: NSObject, UITextFieldDelegate, ComposeInput {
@@ -113,12 +118,16 @@ struct EmojiTextField: UIViewRepresentable {
         }
         
         func textFieldDidBeginEditing(_ textField: UITextField) {
-            controller.currentInput = self
+            DispatchQueue.main.async {
+                self.controller.currentInput = self
+            }
             autocompleteState = textField.updateAutocompleteState(permittedModes: .emojis)
         }
         
         func textFieldDidEndEditing(_ textField: UITextField) {
-            controller.currentInput = nil
+            DispatchQueue.main.async {
+                self.controller.currentInput = nil
+            }
             autocompleteState = textField.updateAutocompleteState(permittedModes: .emojis)
         }
         

Packages/ComposeUI/Sources/ComposeUI/Views/HeaderView.swift

@@ -29,3 +29,19 @@ struct HeaderView: View {
         }.frame(height: 50)
     }
 }
+
+struct NewHeaderView: View {
+    @ObservedObject var draft: Draft
+    @ObservedObject var instanceFeatures: InstanceFeatures
+    @Environment(\.currentAccount) private var currentAccount
+    
+    private var charactersRemaining: Int {
+        let limit = instanceFeatures.maxStatusChars
+        let cwCount = draft.contentWarningEnabled ? draft.contentWarning.count : 0
+        return limit - (cwCount + CharacterCounter.count(text: draft.text, for: instanceFeatures))
+    }
+    
+    var body: some View {
+        HeaderView(currentAccount: currentAccount, charsRemaining: charactersRemaining)
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/NewMainTextView.swift

@@ -0,0 +1,281 @@
+//
+//  NewMainTextView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/11/24.
+//
+
+import SwiftUI
+
+struct NewMainTextView: View {
+    static var minHeight: CGFloat { 150 }
+    
+    @Binding var value: String
+    @FocusState.Binding var focusedField: FocusableField?
+    var handleAttachmentDrop: ([NSItemProvider]) -> Void
+    @State private var becomeFirstResponder = true
+    
+    var body: some View {
+        NewMainTextViewRepresentable(value: $value, becomeFirstResponder: $becomeFirstResponder, handleAttachmentDrop: handleAttachmentDrop)
+            .focused($focusedField, equals: .body)
+            .modifier(FocusedInputModifier())
+            .overlay(alignment: .topLeading) {
+                if value.isEmpty {
+                    PlaceholderView()
+                }
+            }
+    }
+}
+
+private struct NewMainTextViewRepresentable: UIViewRepresentable {
+    @Binding var value: String
+    @Binding var becomeFirstResponder: Bool
+    var handleAttachmentDrop: ([NSItemProvider]) -> Void
+    @Environment(\.composeInputBox) private var inputBox
+    @Environment(\.isEnabled) private var isEnabled
+    @Environment(\.colorScheme) private var colorScheme
+    @Environment(\.composeUIConfig.fillColor) private var fillColor
+    @Environment(\.composeUIConfig.useTwitterKeyboard) private var useTwitterKeyboard
+    // TODO: test textSelectionStartsAtBeginning
+    @Environment(\.composeUIConfig.textSelectionStartsAtBeginning) private var textSelectionStartsAtBeginning
+    
+    func makeUIView(context: Context) -> UITextView {
+        // TODO: if we're not doing the pill background, reevaluate whether this version fork is necessary
+        let view = WrappedTextView(usingTextLayoutManager: true)
+        view.addInteraction(UIDropInteraction(delegate: context.coordinator))
+        view.delegate = context.coordinator
+        view.adjustsFontForContentSizeCategory = true
+        view.textContainer.lineBreakMode = .byWordWrapping
+        view.isScrollEnabled = false
+        view.typingAttributes = [
+            .foregroundColor: UIColor.label,
+            .font: UIFontMetrics.default.scaledFont(for: .systemFont(ofSize: 20)),
+        ]
+        
+        view.layer.cornerRadius = 5
+        view.layer.cornerCurve = .continuous
+//        view.layer.shadowColor = UIColor.black.cgColor
+//        view.layer.shadowOpacity = 0.15
+//        view.layer.shadowOffset = .zero
+//        view.layer.shadowRadius = 1
+        
+        if textSelectionStartsAtBeginning {
+            // Update the text immediately so that the selection isn't invalidated by the text changing.
+            context.coordinator.updateTextViewTextIfNecessary(value, textView: view)
+            view.selectedTextRange = view.textRange(from: view.beginningOfDocument, to: view.beginningOfDocument)
+        }
+        
+        return view
+    }
+    
+    func updateUIView(_ uiView: UIViewType, context: Context) {
+        context.coordinator.value = $value
+        context.coordinator.handleAttachmentDrop = handleAttachmentDrop
+        context.coordinator.updateTextViewTextIfNecessary(value, textView: uiView)
+        
+        uiView.isEditable = isEnabled
+        uiView.keyboardType = useTwitterKeyboard ? .twitter : .default
+        #if !os(visionOS)
+        uiView.backgroundColor = colorScheme == .dark ? UIColor(fillColor) : .secondarySystemBackground
+        #endif
+        
+        // Trying to set this with the @FocusState binding in onAppear results in the
+        // keyboard not appearing until after the sheet presentation animation completes :/
+        if becomeFirstResponder {
+            uiView.becomeFirstResponder()
+            DispatchQueue.main.async {
+                becomeFirstResponder = false
+            }
+        }
+    }
+    
+    func makeCoordinator() -> WrappedTextViewCoordinator {
+        let coordinator = WrappedTextViewCoordinator(value: $value, handleAttachmentDrop: handleAttachmentDrop)
+//        DispatchQueue.main.async {
+//            inputBox.wrappedValue = coordinator
+//        }
+        return coordinator
+    }
+    
+    @available(iOS 16.0, *)
+    func sizeThatFits(_ proposal: ProposedViewSize, uiView: UIViewType, context: Context) -> CGSize? {
+        let width = proposal.width ?? 10
+        let size = uiView.sizeThatFits(CGSize(width: width, height: 0))
+        return CGSize(width: width, height: max(NewMainTextView.minHeight, size.height))
+    }
+}
+
+// laxer than the CharacterCounter regex, because we want to find mentions that are being typed but aren't yet complete (e.g., "@a@b")
+private let mentionRegex = try! NSRegularExpression(pattern: "(@[a-z0-9_]+)(?:@[a-z0-9\\-\\.]+)?", options: .caseInsensitive)
+
+private final class WrappedTextViewCoordinator: NSObject {
+    private static let attachment: NSTextAttachment = {
+        let font = UIFont.systemFont(ofSize: 20)
+        let size = /*1.4 * */font.capHeight
+        let renderer = UIGraphicsImageRenderer(size: CGSize(width: size, height: size))
+        let image = renderer.image { ctx in
+            UIColor.systemRed.setFill()
+            ctx.fill(CGRect(x: 0, y: 0, width: size, height: size))
+        }
+        let attachment = NSTextAttachment(image: image)
+        attachment.bounds = CGRect(x: 0, y: -1, width: size + 2, height: size)
+        attachment.lineLayoutPadding = 1
+        return attachment
+    }()
+    
+    var value: Binding<String>
+    var handleAttachmentDrop: ([NSItemProvider]) -> Void
+    
+    init(value: Binding<String>, handleAttachmentDrop: @escaping ([NSItemProvider]) -> Void) {
+        self.value = value
+        self.handleAttachmentDrop = handleAttachmentDrop
+    }
+    
+    private func plainTextFromAttributed(_ attributedText: NSAttributedString) -> String {
+        attributedText.string.replacingOccurrences(of: "\u{FFFC}", with: "")
+    }
+    
+    private func attributedTextFromPlain(_ text: String) -> NSAttributedString {
+        let str = NSMutableAttributedString(string: text)
+        let mentionMatches = CharacterCounter.mention.matches(in: text, range: NSRange(location: 0, length: str.length))
+        for match in mentionMatches.reversed() {
+            str.insert(NSAttributedString(attachment: Self.attachment), at: match.range.location)
+            let range = NSRange(location: match.range.location, length: match.range.length + 1)
+            str.addAttributes([
+                .mention: true,
+                .foregroundColor: UIColor.tintColor,
+            ], range: range)
+        }
+        return str
+    }
+    
+    func updateTextViewTextIfNecessary(_ text: String, textView: UITextView) {
+        if text != plainTextFromAttributed(textView.attributedText) {
+            textView.attributedText = attributedTextFromPlain(text)
+        }
+    }
+    
+    private func updateAttributes(in textView: UITextView) {
+        let str = NSMutableAttributedString(attributedString: textView.attributedText!)
+        var changed = false
+        var cursorOffset = 0
+        
+        // remove existing mentions that aren't valid
+        str.enumerateAttribute(.mention, in: NSRange(location: 0, length: str.length), options: .reverse) { value, range, stop in
+            var substr = (str.string as NSString).substring(with: range)
+            let hasTextAttachment = substr.unicodeScalars.first == UnicodeScalar(NSTextAttachment.character)
+            if hasTextAttachment {
+                substr = String(substr.dropFirst())
+            }
+            if mentionRegex.numberOfMatches(in: substr, range: NSRange(location: 0, length: substr.utf16.count)) == 0 {
+                changed = true
+                str.removeAttribute(.mention, range: range)
+                str.removeAttribute(.foregroundColor, range: range)
+                if hasTextAttachment {
+                    str.deleteCharacters(in: NSRange(location: range.location, length: 1))
+                    cursorOffset -= 1
+                }
+            }
+        }
+        
+        // add mentions for those missing
+        let mentionMatches = mentionRegex.matches(in: str.string, range: NSRange(location: 0, length: str.length))
+        for match in mentionMatches.reversed() {
+            var attributeRange = NSRange()
+            let attribute = str.attribute(.mention, at: match.range.location, effectiveRange: &attributeRange)
+            // the attribute range should always be one greater than the match range, to account for the text attachment
+            if attribute == nil || attributeRange.length <= match.range.length {
+                changed = true
+                let newAttributeRange: NSRange
+                if attribute == nil {
+                    str.insert(NSAttributedString(attachment: Self.attachment), at: match.range.location)
+                    newAttributeRange = NSRange(location: match.range.location, length: match.range.length + 1)
+                    cursorOffset += 1
+                } else {
+                    newAttributeRange = match.range
+                }
+                str.addAttributes([
+                    .mention: true,
+                    .foregroundColor: UIColor.tintColor,
+                ], range: newAttributeRange)
+            }
+        }
+        
+        if changed {
+            let selection = textView.selectedRange
+            
+            textView.attributedText = str
+            
+            textView.selectedRange = NSRange(location: selection.location + cursorOffset, length: selection.length)
+        }
+    }
+}
+
+extension WrappedTextViewCoordinator: UITextViewDelegate {
+    func textViewDidChange(_ textView: UITextView) {
+        if textView.text.isEmpty {
+            textView.typingAttributes = [
+                .foregroundColor: UIColor.label,
+                .font: UIFontMetrics.default.scaledFont(for: .systemFont(ofSize: 20)),
+            ]
+        } else {
+            updateAttributes(in: textView)
+        }
+        
+        let plain = plainTextFromAttributed(textView.attributedText)
+        if plain != value.wrappedValue {
+            value.wrappedValue = plain
+        }
+    }
+    
+    func textViewDidChangeSelection(_ textView: UITextView) {
+    }
+}
+
+//extension WrappedTextViewCoordinator: ComposeInput {
+//    
+//}
+
+// Because of FB11790805, we can't handle drops for the entire screen.
+// The onDrop modifier also doesn't work when applied to the NewMainTextView.
+// So, manually add the UIInteraction to at least handle that.
+extension WrappedTextViewCoordinator: UIDropInteractionDelegate {
+    func dropInteraction(_ interaction: UIDropInteraction, canHandle session: any UIDropSession) -> Bool {
+        session.canLoadObjects(ofClass: DraftAttachment.self)
+    }
+    func dropInteraction(_ interaction: UIDropInteraction, sessionDidUpdate session: any UIDropSession) -> UIDropProposal {
+        UIDropProposal(operation: .copy)
+    }
+    func dropInteraction(_ interaction: UIDropInteraction, performDrop session: any UIDropSession) {
+        handleAttachmentDrop(session.items.map(\.itemProvider))
+    }
+}
+
+private final class WrappedTextView: UITextView {
+}
+
+private extension NSAttributedString.Key {
+    static let mention = NSAttributedString.Key("Tusker.ComposeUI.mention")
+}
+
+private struct PlaceholderView: View {
+    @State private var placeholder: PlaceholderController.PlaceholderView = PlaceholderController.makePlaceholderView()
+    @ScaledMetric private var fontSize = 20
+    
+    private var placeholderOffset: CGSize {
+        #if os(visionOS)
+        CGSize(width: 8, height: 8)
+        #else
+        CGSize(width: 4, height: 8)
+        #endif
+    }
+
+    var body: some View {
+        placeholder
+            .font(.system(size: fontSize))
+            .foregroundStyle(.secondary)
+            .offset(placeholderOffset)
+            .accessibilityHidden(true)
+            .allowsHitTesting(false)
+    }
+}

Packages/ComposeUI/Sources/ComposeUI/Views/PostProgressView.swift

@@ -0,0 +1,21 @@
+//
+//  PostProgressView.swift
+//  ComposeUI
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+
+struct PostProgressView: View {
+    @ObservedObject var poster: PostService
+    
+    var body: some View {
+        // can't use SwiftUI.ProgressView because there's no UIProgressView.Style.bar equivalent, see FB8587149
+        WrappedProgressView(value: poster.currentStep, total: poster.totalSteps)
+    }
+}
+
+//#Preview {
+//    PostProgressView()
+//}

Packages/ComposeUI/Sources/ComposeUI/Views/ReplyStatusView.swift

@@ -132,3 +132,21 @@ private struct AvatarContainerRepresentable<Content: View>: UIViewControllerRepr
         }
     }
 }
+
+struct NewReplyStatusView: View {
+    let draft: Draft
+    let mastodonController: any ComposeMastodonContext
+    
+    var body: some View {
+        if let id = draft.inReplyToID,
+           let status = mastodonController.fetchStatus(id: id) {
+            ReplyStatusView(
+                status: status,
+                rowTopInset: 8,
+                globalFrameOutsideList: .zero
+            )
+            // i don't know why swiftui can't infer this from the status that's passed into the ReplyStatusView changing
+            .id(id)
+        }
+    }
+}

Packages/GalleryVC/Package.swift

@@ -14,15 +14,11 @@ let package = Package(
             name: "GalleryVC",
             targets: ["GalleryVC"]),
     ],
-    dependencies: [
-        .package(path: "../TuskerComponents"),
-    ],
     targets: [
         // Targets are the basic building blocks of a package, defining a module or a test suite.
         // Targets can depend on other targets in this package and products from dependencies.
         .target(
             name: "GalleryVC",
-            dependencies: ["TuskerComponents"],
             swiftSettings: [
                 .swiftLanguageMode(.v5)
             ]),

Packages/GalleryVC/Sources/GalleryVC/GalleryContentViewController.swift

@@ -15,7 +15,7 @@ public protocol GalleryContentViewController: UIViewController {
     var caption: String? { get }
     var contentOverlayAccessoryViewController: UIViewController? { get }
     var bottomControlsAccessoryViewController: UIViewController? { get }
-    var presentationAnimation: GalleryContentPresentationAnimation { get }
+    var canAnimateFromSourceView: Bool { get }
     
     func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool)
     func galleryContentDidAppear()
@@ -31,8 +31,8 @@ public extension GalleryContentViewController {
         nil
     }
     
-    var presentationAnimation: GalleryContentPresentationAnimation {
-        .fromSourceView
+    var canAnimateFromSourceView: Bool {
+        true
     }
     
     func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
@@ -44,9 +44,3 @@ public extension GalleryContentViewController {
     func galleryContentWillDisappear() {
     }
 }
-
-public enum GalleryContentPresentationAnimation {
-    case fade
-    case fromSourceView
-    case fromSourceViewWithoutSnapshot
-}

Packages/GalleryVC/Sources/GalleryVC/GalleryDismissAnimationController.swift

@@ -30,37 +30,12 @@ class GalleryDismissAnimationController: NSObject, UIViewControllerAnimatedTrans
         
         let itemViewController = from.currentItemViewController
         
-        if itemViewController.content.presentationAnimation == .fade || (UIAccessibility.prefersCrossFadeTransitions && interactiveVelocity == nil) {
+        if !itemViewController.content.canAnimateFromSourceView || (UIAccessibility.prefersCrossFadeTransitions && interactiveVelocity == nil) {
             animateCrossFadeTransition(using: transitionContext)
             return
         }
         
         let container = transitionContext.containerView
-
-        // Moving `to.view` to the container is necessary when the presenting VC (i.e., `to`)
-        // is in the window's root presentation.
-        // But it breaks when the gallery is presented from a sheet-presented VC--in which case
-        // `to.view` is already in the view hierarchy at this point; and adding it to the
-        // container causees it to be removed when the transition completes.
-        if to.view.superview == nil {
-            to.view.frame = container.bounds
-            container.addSubview(to.view)
-        }
-        
-        let sourceSnapshot: UIView? = if itemViewController.content.presentationAnimation == .fromSourceViewWithoutSnapshot {
-            nil
-        } else {
-            sourceView.snapshotView(afterScreenUpdates: false)
-        }
-        if let sourceSnapshot {
-            let snapshotContainer = sourceView.ancestorForInsertingSnapshot
-            snapshotContainer.addSubview(sourceSnapshot)
-            let sourceFrameInShapshotContainer = snapshotContainer.convert(sourceView.bounds, from: sourceView)
-            sourceSnapshot.frame = sourceFrameInShapshotContainer
-            sourceSnapshot.layer.opacity = 1
-            self.sourceView.layer.opacity = 0
-        }
-
         let sourceFrameInContainer = container.convert(sourceView.bounds, from: sourceView)
         let destFrameInContainer = container.convert(itemViewController.content.view.bounds, from: itemViewController.content.view)
         
@@ -73,39 +48,38 @@ class GalleryDismissAnimationController: NSObject, UIViewControllerAnimatedTrans
                 .translatedBy(x: destFrameInContainer.midX - sourceFrameInContainer.midX, y: destFrameInContainer.midY - sourceFrameInContainer.midY)
                 .scaledBy(x: scale, y: scale)
             sourceView.transform = sourceToDestTransform
-            sourceSnapshot?.transform = sourceToDestTransform
         } else {
             appliedSourceToDestTransform = false
         }
         
+        // Moving `to.view` to the container is necessary when the presenting VC (i.e., `to`)
+        // is in the window's root presentation.
+        // But it breaks when the gallery is presented from a sheet-presented VC--in which case
+        // `to.view` is already in the view hierarchy at this point; and adding it to the
+        // container causees it to be removed when the transition completes.
+        if to.view.superview == nil {
+            to.view.frame = container.bounds
+            container.addSubview(to.view)
+        }
+        
         from.view.frame = container.bounds
         container.addSubview(from.view)
-        
-        let contentContainer = UIView()
-        contentContainer.layer.masksToBounds = true
-        contentContainer.frame = destFrameInContainer
-        container.addSubview(contentContainer)
-        
+
         let content = itemViewController.takeContent()
         content.view.translatesAutoresizingMaskIntoConstraints = true
-        content.view.transform = .identity
-        content.view.layer.opacity = 1
-        content.view.frame = contentContainer.bounds
-        contentContainer.addSubview(content.view)
-
-        container.layoutIfNeeded()
+        content.view.layer.masksToBounds = true
+        container.addSubview(content.view)
         
-        // Hide overlaid controls immediately, to prevent the Live Text button's position
-        // getting caught up in the rest of the animation.
-        UIView.animate(withDuration: 0.1) {
-            content.setControlsVisible(false, animated: false, dueToUserInteraction: false)
-        }
+        content.view.frame = destFrameInContainer
+        content.view.layer.opacity = 1
+        
+        container.layoutIfNeeded()
         
         let duration = self.transitionDuration(using: transitionContext)
         var initialVelocity: CGVector
         if let interactiveVelocity,
            let interactiveTranslation,
-           // very short/fast flicks don't transfer their velocity, since it makes size change animation look wacky due to the spring's initial undershoot
+           // very short/fast flicks don't transfer their velocity, since it makes size change animation look wacky due to the springs initial undershoot
            sqrt(pow(interactiveTranslation.x, 2) + pow(interactiveTranslation.y, 2)) > 100,
            sqrt(pow(interactiveVelocity.x, 2) + pow(interactiveVelocity.y, 2)) < 2000 {
             let xDistance = sourceFrameInContainer.midX - destFrameInContainer.midX
@@ -128,34 +102,14 @@ class GalleryDismissAnimationController: NSObject, UIViewControllerAnimatedTrans
             
             if appliedSourceToDestTransform {
                 self.sourceView.transform = origSourceTransform
-                sourceSnapshot?.transform = origSourceTransform
             }
-            
-            contentContainer.frame = sourceFrameInContainer
-            // Using sourceSizeWithDestAspectRatioCenteredInContentContainer does not seem to be necessary here.
-            // I guess autoresizing takes care of it?
+            content.view.frame = sourceFrameInContainer
+            content.view.layer.opacity = 0
             
             itemViewController.setControlsVisible(false, animated: false, dueToUserInteraction: false)
         }
         
-        // Delay fading out the content because if it's still big while it's semi-transparent,
-        // seeing the stuff behind it looks odd.
-        animator.addAnimations({
-            content.view.layer.opacity = 0
-        }, delayFactor: 0.35)
-        
-        if let sourceSnapshot {
-            animator.addAnimations({
-                self.sourceView.layer.opacity = 1
-                sourceSnapshot.layer.opacity = 0
-            }, delayFactor: 0.5)
-        }
-        
         animator.addCompletion { _ in
-            sourceSnapshot?.removeFromSuperview()
-            
-            // Having dismissed, we don't need to undo any of the changes to the content VC.
-            
             transitionContext.completeTransition(true)
         }
         

Packages/GalleryVC/Sources/GalleryVC/GalleryDismissInteraction.swift

@@ -20,8 +20,6 @@ class GalleryDismissInteraction: NSObject {
     private(set) var dismissVelocity: CGPoint?
     private(set) var dismissTranslation: CGPoint?
     
-    private var cancelAnimator: UIViewPropertyAnimator?
-    
     init(viewController: GalleryViewController) {
         self.viewController = viewController
         super.init()
@@ -40,8 +38,6 @@ class GalleryDismissInteraction: NSObject {
             content = viewController.currentItemViewController.takeContent()
             content!.view.translatesAutoresizingMaskIntoConstraints = true
             content!.view.frame = origContentFrameInGallery!
-            // Make sure the context remains behind the controls
-            content!.view.layer.zPosition = -1000
             viewController.view.addSubview(content!.view)
             
             origControlsVisible = viewController.currentItemViewController.controlsVisible
@@ -57,42 +53,12 @@ class GalleryDismissInteraction: NSObject {
             let translation = recognizer.translation(in: viewController.view)
             let velocity = recognizer.velocity(in: viewController.view)
             
-            let translationMagnitude = sqrt(translation.x.magnitudeSquared + translation.y.magnitudeSquared)
-            let velocityMagnitude = sqrt(velocity.x.magnitudeSquared + velocity.y.magnitudeSquared)
-            
-            if translationMagnitude < 150 && velocityMagnitude < 500 {
-                isActive = false
-                
-                cancelAnimator?.stopAnimation(true)
-                
-                let spring = UISpringTimingParameters(mass: 1, stiffness: 439, damping: 42, initialVelocity: .zero)
-                cancelAnimator = UIViewPropertyAnimator(duration: 0.2, timingParameters: spring)
-                cancelAnimator!.addAnimations {
-                    self.content!.view.frame = self.origContentFrameInGallery!
-                    self.viewController.currentItemViewController.setControlsVisible(self.origControlsVisible!, animated: false, dueToUserInteraction: false)
-                }
-                cancelAnimator!.addCompletion { _ in
-                    guard !self.isActive else {
-                        // bail in case the animation finishing raced with the user's interaction
-                        return
-                    }
-                    self.content!.view.layer.zPosition = 0
-                    self.content!.view.removeFromSuperview()
-                    self.viewController.currentItemViewController.addContent()
-                    self.content = nil
-                    self.origContentFrameInGallery = nil
-                    self.origControlsVisible = nil
-                }
-                cancelAnimator!.startAnimation()
+            dismissVelocity = velocity
+            dismissTranslation = translation
+            viewController.dismiss(animated: true)
 
-            } else {
-                dismissVelocity = velocity
-                dismissTranslation = translation
-                viewController.dismiss(animated: true)
-                
-                // don't unset this until after dismiss is called, so that the dismiss animation controller can read it
-                isActive = false
-            }
+            // don't unset this until after dismiss is called, so that the dismiss animation controller can read it
+            isActive = false
             
         default:
             break

Packages/GalleryVC/Sources/GalleryVC/GalleryItemViewController.swift

@@ -69,10 +69,6 @@ class GalleryItemViewController: UIViewController {
         scrollView = UIScrollView()
         scrollView.translatesAutoresizingMaskIntoConstraints = false
         scrollView.delegate = self
-        // We calculate zoom/position ignoring the safe area, so content insets need to not incorporate it either.
-        // Otherwise, content that fills the screen (extending into the safe area) may still end up scrollable
-        // (this is readily observable with tall images on a landscape iPad).
-        scrollView.contentInsetAdjustmentBehavior = .never
         
         view.addSubview(scrollView)
         

Packages/GalleryVC/Sources/GalleryVC/GalleryPresentationAnimationController.swift

@@ -25,31 +25,11 @@ class GalleryPresentationAnimationController: NSObject, UIViewControllerAnimated
         
         let itemViewController = to.currentItemViewController
 
-        if itemViewController.content.presentationAnimation == .fade || UIAccessibility.prefersCrossFadeTransitions {
+        if !itemViewController.content.canAnimateFromSourceView || UIAccessibility.prefersCrossFadeTransitions {
             animateCrossFadeTransition(using: transitionContext)
             return
         }
         
-        // Try to effectively "fade out" anything that's on top of the source view.
-        // The 0.1 duration makes this happen faster than the rest of the animation,
-        // and so less noticeable.
-        let sourceSnapshot: UIView? = if itemViewController.content.presentationAnimation == .fromSourceViewWithoutSnapshot {
-            nil
-        } else {
-            sourceView.snapshotView(afterScreenUpdates: false)
-        }
-        if let sourceSnapshot {
-            let snapshotContainer = sourceView.ancestorForInsertingSnapshot
-            snapshotContainer.addSubview(sourceSnapshot)
-            let sourceFrameInShapshotContainer = snapshotContainer.convert(sourceView.bounds, from: sourceView)
-            sourceSnapshot.frame = sourceFrameInShapshotContainer
-            sourceSnapshot.transform = sourceView.transform
-            sourceSnapshot.layer.opacity = 0
-            UIView.animate(withDuration: 0.1) {
-                sourceSnapshot.layer.opacity = 1
-            }
-        }
-        
         let container = transitionContext.containerView
         to.view.frame = container.bounds
         container.addSubview(to.view)
@@ -76,70 +56,21 @@ class GalleryPresentationAnimationController: NSObject, UIViewControllerAnimated
             sourceToDestTransform = nil
         }
         
-        // Grab these before taking the content out and changing the transform.
-        let origContentTransform = itemViewController.content.view.transform
-        let origContentFrame = itemViewController.content.view.frame
-        
-        // The content container provides the clipping for the content view,
-        // which, in case the source/dest aspect ratios don't match, makes
-        // it look like the content is expanding out from the source rect.
-        let contentContainer = UIView()
-        contentContainer.layer.masksToBounds = true
-        container.insertSubview(contentContainer, belowSubview: to.view)
         let content = itemViewController.takeContent()
         content.view.translatesAutoresizingMaskIntoConstraints = true
-        content.view.transform = .identity
-        // The fade-in makes the aspect ratio handling look a little bit worse,
-        // but papers over the z-index change and potential corner radius change.
-        content.view.layer.opacity = 0
-        contentContainer.addSubview(content.view)
+        container.insertSubview(content.view, belowSubview: to.view)
 
         // Use a separate dimming view from to.view, so that the gallery controls can be in front of the moving content.
         let dimmingView = UIView()
         dimmingView.backgroundColor = .black
         dimmingView.frame = container.bounds
         dimmingView.layer.opacity = 0
-        container.insertSubview(dimmingView, belowSubview: contentContainer)
+        container.insertSubview(dimmingView, belowSubview: content.view)
 
         to.view.backgroundColor = nil
         to.view.layer.opacity = 0
-        
-        contentContainer.frame = sourceFrameInContainer
-        
-        let sourceAspectRatio: CGFloat = if sourceFrameInContainer.height > 0 {
-            sourceFrameInContainer.width / sourceFrameInContainer.height
-        } else {
-            0
-        }
-        let destAspectRatio: CGFloat = if destFrameInContainer.height > 0 {
-            destFrameInContainer.width / destFrameInContainer.height
-        } else {
-            0
-        }
-        let sourceSizeWithDestAspectRatioCenteredInContentContainer: CGRect
-        if 0.001 < abs(sourceAspectRatio - destAspectRatio) {
-            // asepct ratios are effectively equal
-            sourceSizeWithDestAspectRatioCenteredInContentContainer = CGRect(origin: .zero, size: sourceFrameInContainer.size)
-        } else if sourceAspectRatio < destAspectRatio {
-            // source aspect ratio is narrow/taller than dest
-            let width = sourceFrameInContainer.height * destAspectRatio
-            sourceSizeWithDestAspectRatioCenteredInContentContainer = CGRect(
-                x: -(width - sourceFrameInContainer.width) / 2,
-                y: 0,
-                width: width,
-                height: sourceFrameInContainer.height
-            )
-        } else {
-            // source aspect ratio is wider/shorter than dest
-            let height = sourceFrameInContainer.width / destAspectRatio
-            sourceSizeWithDestAspectRatioCenteredInContentContainer = CGRect(
-                x: 0,
-                y: -(height - sourceFrameInContainer.height) / 2,
-                width: sourceFrameInContainer.width,
-                height: height
-            )
-        }
-        content.view.frame = sourceSizeWithDestAspectRatioCenteredInContentContainer
+        content.view.frame = sourceFrameInContainer
+        content.view.layer.opacity = 0
         
         container.layoutIfNeeded()
         
@@ -147,14 +78,8 @@ class GalleryPresentationAnimationController: NSObject, UIViewControllerAnimated
         itemViewController.setControlsVisible(false, animated: false, dueToUserInteraction: false)
 
         let duration = self.transitionDuration(using: transitionContext)
-        // less bounce on bigger screens
-        let spring = if UIDevice.current.userInterfaceIdiom == .pad {
-            // roughly equivalent to duration: 0.35, bounce: 0.2
-            UISpringTimingParameters(mass: 1, stiffness: 322, damping: 28, initialVelocity: .zero)
-        } else {
-            // roughly equivalent to duration: 0.35, bounce: 0.3
-            UISpringTimingParameters(mass: 1, stiffness: 322, damping: 25, initialVelocity: .zero)
-        }
+        // rougly equivalent to duration: 0.35, bounce: 0.3
+        let spring = UISpringTimingParameters(mass: 1, stiffness: 322, damping: 25, initialVelocity: .zero)
         let animator = UIViewPropertyAnimator(duration: duration, timingParameters: spring)
         
         animator.addAnimations {
@@ -162,35 +87,25 @@ class GalleryPresentationAnimationController: NSObject, UIViewControllerAnimated
             
             to.view.layer.opacity = 1
             
-            contentContainer.frame = destFrameInContainer
-            content.view.frame = contentContainer.bounds
+            content.view.frame = destFrameInContainer
             content.view.layer.opacity = 1
-
+            
             itemViewController.setControlsVisible(true, animated: false, dueToUserInteraction: false)
 
             if let sourceToDestTransform {
-                sourceSnapshot?.transform = sourceToDestTransform
                 self.sourceView.transform = sourceToDestTransform
             }
         }
         
         animator.addCompletion { _ in
-            sourceSnapshot?.removeFromSuperview()
-            self.sourceView.layer.opacity = 1
-            if sourceToDestTransform != nil {
-                self.sourceView.transform = origSourceTransform
-            }
-
-            contentContainer.removeFromSuperview()
             dimmingView.removeFromSuperview()
             
             to.view.backgroundColor = .black
             
-            // Reset the properties we changed before re-adding the content to the scroll view.
-            // (I would expect UIScrollView to effectively do this itself, but w/e.)
-            content.view.transform = origContentTransform
-            content.view.frame = origContentFrame
-
+            if sourceToDestTransform != nil {
+                self.sourceView.transform = origSourceTransform
+            }
+            
             itemViewController.addContent()
             
             transitionContext.completeTransition(true)

Packages/GalleryVC/Sources/GalleryVC/UIView+Utilities.swift

@@ -1,26 +0,0 @@
-//
-//  UIView+Utilities.swift
-//  GalleryVC
-//
-//  Created by Shadowfacts on 11/24/24.
-//
-
-import UIKit
-
-extension UIView {
-    
-    var ancestorForInsertingSnapshot: UIView {
-        var view = self
-        while let superview = view.superview {
-            if superview.layer.masksToBounds {
-                return superview
-            } else if superview is UIScrollView {
-                return self
-            } else {
-                view = superview
-            }
-        }
-        return view
-    }
-    
-}

Packages/Pachyderm/Package.swift

@@ -7,7 +7,6 @@ let package = Package(
     name: "Pachyderm",
     platforms: [
         .iOS(.v16),
-        .macOS(.v13),
     ],
     products: [
         // Products define the executables and libraries a package produces, and make them visible to other packages.
@@ -17,6 +16,7 @@ let package = Package(
     ],
     dependencies: [
         // Dependencies declare other packages that this package depends on.
+        .package(url: "https://github.com/karwa/swift-url.git", exact: "0.4.2"),
     ],
     targets: [
         // Targets are the basic building blocks of a package. A target can define a module or a test suite.
@@ -24,6 +24,8 @@ let package = Package(
         .target(
             name: "Pachyderm",
             dependencies: [
+                .product(name: "WebURL", package: "swift-url"),
+                .product(name: "WebURLFoundationExtras", package: "swift-url"),
             ],
             swiftSettings: [
                 .swiftLanguageMode(.v5)

Packages/Pachyderm/Sources/Pachyderm/Client.swift

@@ -7,6 +7,7 @@
 //
 
 import Foundation
+import WebURL
 
 /**
  The base Mastodon API client.
@@ -24,30 +25,27 @@ public struct Client: Sendable {
     
     public var timeoutInterval: TimeInterval = 60
     
-    private static let dateFormatter: DateFormatter = {
+    static let decoder: JSONDecoder = {
+        let decoder = JSONDecoder()
+        
         let formatter = DateFormatter()
         formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss.SZ"
         formatter.timeZone = TimeZone(abbreviation: "UTC")
         formatter.locale = Locale(identifier: "en_US_POSIX")
-        return formatter
-    }()
-    private static let iso8601Formatter = ISO8601DateFormatter()
-    private static func decodeDate(string: String) -> Date? {
-        // for the next time mastodon accidentally changes date formats >.>
-        return dateFormatter.date(from: string) ?? iso8601Formatter.date(from: string)
-    }
-    
-    static let decoder: JSONDecoder = {
-        let decoder = JSONDecoder()
+        let iso8601 = ISO8601DateFormatter()
         decoder.dateDecodingStrategy = .custom({ (decoder) in
             let container = try decoder.singleValueContainer()
             let str = try container.decode(String.self)
-            if let date = Self.decodeDate(string: str) {
+            // for the next time mastodon accidentally changes date formats >.>
+            if let date = formatter.date(from: str) {
+                return date
+            } else if let date = iso8601.date(from: str) {
                 return date
             } else {
                 throw DecodingError.typeMismatch(Date.self, .init(codingPath: container.codingPath, debugDescription: "unexpected date format: \(str)"))
             }
         })
+        
         return decoder
     }()
     
@@ -107,15 +105,6 @@ public struct Client: Sendable {
         return task
     }
     
-    private func error(from response: HTTPURLResponse) -> ErrorType {
-        if response.statusCode == 429,
-           let date = response.value(forHTTPHeaderField: "X-RateLimit-Reset").flatMap(Self.decodeDate) {
-            return .rateLimited(date)
-        } else {
-            return .unexpectedStatus(response.statusCode)
-        }
-    }
-    
     @discardableResult
     public func run<Result: Sendable>(_ request: Request<Result>) async throws -> (Result, Pagination?) {
         return try await withCheckedThrowingContinuation { continuation in
@@ -201,8 +190,8 @@ public struct Client: Sendable {
         let wellKnown = Request<WellKnown>(method: .get, path: "/.well-known/nodeinfo")
         let wellKnownResults = try await run(wellKnown).0
         if let url = wellKnownResults.links.first(where: { $0.rel == "http://nodeinfo.diaspora.software/ns/schema/2.0" }),
-           let href = try? URL.ParseStrategy().parse(url.href),
-           href.host == self.baseURL.host() {
+           let href = WebURL(url.href),
+           href.host == WebURL(self.baseURL)?.host {
             let nodeInfo = Request<NodeInfo>(method: .get, path: Endpoint(stringLiteral: href.path))
             return try await run(nodeInfo).0
         } else {
@@ -586,8 +575,6 @@ extension Client {
                 return "Invalid Model"
             case .mastodonError(let code, let error):
                 return "Server Error (\(code)): \(error)"
-            case .rateLimited(let reset):
-                return "Rate Limited Until \(reset.formatted(date: .omitted, time: .standard))"
             }
         }
     }
@@ -598,7 +585,6 @@ extension Client {
         case invalidResponse
         case invalidModel(Swift.Error)
         case mastodonError(Int, String)
-        case rateLimited(Date)
     }
     
     enum NodeInfoError: LocalizedError {

Packages/Pachyderm/Sources/Pachyderm/Model/Announcement.swift

@@ -6,6 +6,7 @@
 //
 
 import Foundation
+import WebURL
 
 public struct Announcement: Decodable, Sendable, Hashable, Identifiable {
     public let id: String
@@ -59,7 +60,7 @@ extension Announcement {
     public struct Account: Decodable, Sendable, Hashable {
         public let id: String
         public let username: String
-        @URLDecoder public var url: URL
+        public let url: WebURL
         public let acct: String
     }
 }
@@ -67,7 +68,7 @@ extension Announcement {
 extension Announcement {
     public struct Status: Decodable, Sendable, Hashable {
         public let id: String
-        @URLDecoder public var url: URL
+        public let url: WebURL
     }
 }
 

Packages/Pachyderm/Sources/Pachyderm/Model/Card.swift

@@ -7,17 +7,18 @@
 //
 
 import Foundation
+import WebURL
 
 public struct Card: Codable, Sendable {
-    @URLDecoder public var url: URL
+    public let url: WebURL
     public let title: String
     public let description: String
-    @OptionalURLDecoder public var image: URL?
+    public let image: WebURL?
     public let kind: Kind
     public let authorName: String?
-    @OptionalURLDecoder public var authorURL: URL?
+    public let authorURL: WebURL?
     public let providerName: String?
-    @OptionalURLDecoder public var providerURL: URL?
+    public let providerURL: WebURL?
     public let html: String?
     public let width: Int?
     public let height: Int?
@@ -26,15 +27,15 @@ public struct Card: Codable, Sendable {
     public let history: [History]?
     
     public init(
-        url: URL,
+        url: WebURL,
         title: String,
         description: String,
-        image: URL? = nil,
+        image: WebURL? = nil,
         kind: Card.Kind,
         authorName: String? = nil,
-        authorURL: URL? = nil,
+        authorURL: WebURL? = nil,
         providerName: String? = nil,
-        providerURL: URL? = nil,
+        providerURL: WebURL? = nil,
         html: String? = nil,
         width: Int? = nil,
         height: Int? = nil,
@@ -60,15 +61,15 @@ public struct Card: Codable, Sendable {
     public init(from decoder: Decoder) throws {
         let container = try decoder.container(keyedBy: CodingKeys.self)
         
-        self._url = try container.decode(URLDecoder.self, forKey: .url)
+        self.url = try container.decode(WebURL.self, forKey: .url)
         self.title = try container.decode(String.self, forKey: .title)
         self.description = try container.decode(String.self, forKey: .description)
         self.kind = try container.decode(Kind.self, forKey: .kind)
-        self._image = try container.decodeIfPresent(OptionalURLDecoder.self, forKey: .image) ?? nil
+        self.image = try? container.decodeIfPresent(WebURL.self, forKey: .image)
         self.authorName = try? container.decodeIfPresent(String.self, forKey: .authorName)
-        self._authorURL = try container.decodeIfPresent(OptionalURLDecoder.self, forKey: .authorURL) ?? nil
+        self.authorURL = try? container.decodeIfPresent(WebURL.self, forKey: .authorURL)
         self.providerName = try? container.decodeIfPresent(String.self, forKey: .providerName)
-        self._providerURL = try container.decodeIfPresent(OptionalURLDecoder.self, forKey: .providerURL) ?? nil
+        self.providerURL = try? container.decodeIfPresent(WebURL.self, forKey: .providerURL)
         self.html = try? container.decodeIfPresent(String.self, forKey: .html)
         self.width = try? container.decodeIfPresent(Int.self, forKey: .width)
         self.height = try? container.decodeIfPresent(Int.self, forKey: .height)

Packages/Pachyderm/Sources/Pachyderm/Model/Emoji.swift

@@ -7,11 +7,14 @@
 //
 
 import Foundation
+import WebURL
 
 public struct Emoji: Codable, Sendable {
     public let shortcode: String
-    @URLDecoder public var url: URL
-    @URLDecoder public var staticURL: URL
+    // these shouldn't need to be WebURLs as they're not external resources,
+    // but some instances (pleroma?) has emoji urls that Foundation considers malformed so we use WebURL to be more lenient
+    public let url: WebURL
+    public let staticURL: WebURL
     public let visibleInPicker: Bool
     public let category: String?
     
@@ -19,8 +22,8 @@ public struct Emoji: Codable, Sendable {
         let container = try decoder.container(keyedBy: CodingKeys.self)
         
         self.shortcode = try container.decode(String.self, forKey: .shortcode)
-        self._url = try container.decode(URLDecoder.self, forKey: .url)
-        self._staticURL = try container.decode(URLDecoder.self, forKey: .staticURL)
+        self.url = try container.decode(WebURL.self, forKey: .url)
+        self.staticURL = try container.decode(WebURL.self, forKey: .staticURL)
         self.visibleInPicker = try container.decode(Bool.self, forKey: .visibleInPicker)
         self.category = try container.decodeIfPresent(String.self, forKey: .category)
     }

Packages/Pachyderm/Sources/Pachyderm/Model/Hashtag.swift

@@ -7,10 +7,12 @@
 //
 
 import Foundation
+import WebURL
+import WebURLFoundationExtras
 
 public struct Hashtag: Codable, Sendable {
     public let name: String
-    @URLDecoder public var url: URL
+    public let url: WebURL
     /// Only present when returned from the trending hashtags endpoint
     public let history: [History]?
     /// Only present on Mastodon >= 4 and when logged in
@@ -18,7 +20,7 @@ public struct Hashtag: Codable, Sendable {
     
     public init(name: String, url: URL) {
         self.name = name
-        self.url = url
+        self.url = WebURL(url)!
         self.history = nil
         self.following = nil
     }
@@ -27,7 +29,7 @@ public struct Hashtag: Codable, Sendable {
         let container = try decoder.container(keyedBy: CodingKeys.self)
         self.name = try container.decode(String.self, forKey: .name)
         // pixelfed (possibly others) don't fully escape special characters in the hashtag url
-        self._url = try container.decode(URLDecoder.self, forKey: .url)
+        self.url = try container.decode(WebURL.self, forKey: .url)
         self.history = try container.decodeIfPresent([History].self, forKey: .history)
         self.following = try container.decodeIfPresent(Bool.self, forKey: .following)
     }

Packages/Pachyderm/Sources/Pachyderm/Model/Mention.swift

@@ -7,9 +7,10 @@
 //
 
 import Foundation
+import WebURL
 
 public struct Mention: Codable, Sendable {
-    @URLDecoder public var url: URL
+    public let url: WebURL
     public let username: String
     public let acct: String
     /// The instance-local ID of the user being mentioned.
@@ -20,10 +21,15 @@ public struct Mention: Codable, Sendable {
         self.username = try container.decode(String.self, forKey: .username)
         self.acct = try container.decode(String.self, forKey: .acct)
         self.id = try container.decode(String.self, forKey: .id)
-        self._url = try container.decode(URLDecoder.self, forKey: .url)
+        do {
+            self.url = try container.decode(WebURL.self, forKey: .url)
+        } catch {
+            let s = try? container.decode(String.self, forKey: .url)
+            throw DecodingError.dataCorruptedError(forKey: .url, in: container, debugDescription: "Could not decode URL '\(s ?? "<failed to decode string>")'")
+        }
     }
     
-    public init(url: URL, username: String, acct: String, id: String) {
+    public init(url: WebURL, username: String, acct: String, id: String) {
         self.url = url
         self.username = username
         self.acct = acct

Packages/Pachyderm/Sources/Pachyderm/Model/Notification.swift

@@ -7,6 +7,7 @@
 //
 
 import Foundation
+import WebURL
 
 public struct Notification: Decodable, Sendable {
     public let id: String
@@ -17,7 +18,7 @@ public struct Notification: Decodable, Sendable {
     // Only present for pleroma emoji reactions
     // Either an emoji or :shortcode: (for akkoma custom emoji reactions)
     public let emoji: String?
-    @OptionalURLDecoder public var emojiURL: URL?
+    public let emojiURL: WebURL?
     
     public init(from decoder: Decoder) throws {
         let container = try decoder.container(keyedBy: CodingKeys.self)
@@ -32,7 +33,7 @@ public struct Notification: Decodable, Sendable {
         self.account = try container.decode(Account.self, forKey: .account)
         self.status = try container.decodeIfPresent(Status.self, forKey: .status)
         self.emoji = try container.decodeIfPresent(String.self, forKey: .emoji)
-        self._emojiURL = try container.decodeIfPresent(OptionalURLDecoder.self, forKey: .emojiURL) ?? nil
+        self.emojiURL = try container.decodeIfPresent(WebURL.self, forKey: .emojiURL)
     }
 
     public static func dismiss(id notificationID: String) -> Request<Empty> {

Packages/Pachyderm/Sources/Pachyderm/Model/PushNotification.swift

@@ -6,13 +6,14 @@
 //
 
 import Foundation
+import WebURL
 
 public struct PushNotification: Decodable {
     public let accessToken: String
     public let preferredLocale: String
     public let notificationID: String
     public let notificationType: Notification.Kind
-    @URLDecoder public var icon: URL
+    public let icon: WebURL
     public let title: String
     public let body: String
     
@@ -28,7 +29,7 @@ public struct PushNotification: Decodable {
             self.notificationID = i.description
         }
         self.notificationType = try container.decode(Notification.Kind.self, forKey: .notificationType)
-        self._icon = try container.decode(URLDecoder.self, forKey: .icon)
+        self.icon = try container.decode(WebURL.self, forKey: .icon)
         self.title = try container.decode(String.self, forKey: .title)
         self.body = try container.decode(String.self, forKey: .body)
     }

Packages/Pachyderm/Sources/Pachyderm/Model/Status.swift

@@ -7,6 +7,7 @@
 //
 
 import Foundation
+import WebURL
 
 public final class Status: StatusProtocol, Decodable, Sendable {
     /// The pseudo-visibility used by instance types (Akkoma) that overload the visibility for local-only posts.
@@ -14,8 +15,7 @@ public final class Status: StatusProtocol, Decodable, Sendable {
     
     public let id: String
     public let uri: String
-    private let _url: OptionalURLDecoder
-    public var url: URL? { _url.wrappedValue }
+    public let url: WebURL?
     public let account: Account
     public let inReplyToID: String?
     public let inReplyToAccountID: String?
@@ -55,13 +55,13 @@ public final class Status: StatusProtocol, Decodable, Sendable {
         self.id = try container.decode(String.self, forKey: .id)
         self.uri = try container.decode(String.self, forKey: .uri)
         do {
-            self._url = try container.decodeIfPresent(OptionalURLDecoder.self, forKey: .url) ?? nil
+            self.url = try container.decodeIfPresent(WebURL.self, forKey: .url)
         } catch {
             let s = try? container.decode(String.self, forKey: .url)
             if s == "" {
-                self._url = OptionalURLDecoder(wrappedValue: nil)
+                self.url = nil
             } else {
-                throw error
+                throw DecodingError.dataCorrupted(.init(codingPath: container.codingPath + [CodingKeys.url], debugDescription: "Could not decode URL '\(s ?? "<failed to decode string>")'", underlyingError: error))
             }
         }
         self.account = try container.decode(Account.self, forKey: .account)

Packages/Pachyderm/Sources/Pachyderm/Utilities/NotificationGroup.swift

@@ -7,6 +7,7 @@
 //
 
 import Foundation
+import WebURL
 
 public struct NotificationGroup: Identifiable, Hashable, Sendable {
     public private(set) var notifications: [Notification]
@@ -149,7 +150,7 @@ public struct NotificationGroup: Identifiable, Hashable, Sendable {
         case poll
         case update
         case status
-        case emojiReaction(String, URL?)
+        case emojiReaction(String, WebURL?)
         case unknown
         
         var notificationKind: Notification.Kind {

Packages/Pachyderm/Sources/Pachyderm/Utilities/URLDecoder.swift

@@ -1,86 +0,0 @@
-//
-//  URLDecoder.swift
-//  Pachyderm
-//
-//  Created by Shadowfacts on 12/15/24.
-//
-import Foundation
-
-private let parseStrategy = URL.ParseStrategy()
-    .scheme(.required)
-    .user(.optional)
-    .password(.optional)
-    .host(.required)
-    .port(.optional)
-    .path(.optional)
-    .query(.optional)
-    .fragment(.optional)
-
-private let formatStyle = URL.FormatStyle()
-    .scheme(.always)
-    .user(.omitWhen(.user, matches: [""]))
-    .password(.omitWhen(.password, matches: [""]))
-    .host(.always)
-    .port(.omitIfHTTPFamily)
-    .path(.always)
-    .query(.omitWhen(.query, matches: [""]))
-    .fragment(.omitWhen(.fragment, matches: [""]))
-
-@propertyWrapper
-public struct URLDecoder: Codable, Sendable, Hashable {
-    public var wrappedValue: URL
-    
-    public init(wrappedValue: URL) {
-        self.wrappedValue = wrappedValue
-    }
-    
-    public init(from decoder: any Decoder) throws {
-        let s = try decoder.singleValueContainer().decode(String.self)
-        self.wrappedValue = try parseStrategy.parse(s)
-    }
-    
-    public func encode(to encoder: any Encoder) throws {
-        var container = encoder.singleValueContainer()
-        try container.encode(wrappedValue.formatted(formatStyle))
-    }
-}
-
-@propertyWrapper
-public struct OptionalURLDecoder: Codable, Sendable, Hashable, ExpressibleByNilLiteral {
-    public var wrappedValue: URL?
-    
-    public init(wrappedValue: URL?) {
-        self.wrappedValue = wrappedValue
-    }
-    
-    public init(nilLiteral: ()) {
-        self.wrappedValue = nil
-    }
-    
-    public init(from decoder: any Decoder) throws {
-        let container = try decoder.singleValueContainer()
-        if container.decodeNil() {
-            self.wrappedValue = nil
-        } else {
-            let s = try container.decode(String.self)
-            if s.isEmpty {
-                self.wrappedValue = nil
-            } else {
-                do {
-                    self.wrappedValue = try parseStrategy.parse(s)
-                } catch {
-                    throw DecodingError.dataCorrupted(.init(codingPath: container.codingPath, debugDescription: "Could not decode URL '\(s)'", underlyingError: error))
-                }
-            }
-        }
-    }
-    
-    public func encode(to encoder: any Encoder) throws {
-        var container = encoder.singleValueContainer()
-        if let wrappedValue {
-            try container.encode(wrappedValue.formatted(formatStyle))
-        } else {
-            try container.encodeNil()
-        }
-    }
-}

Packages/Pachyderm/Tests/PachydermTests/NotificationGroupTests.swift

@@ -197,72 +197,72 @@ class NotificationGroupTests: XCTestCase {
 
     func testGroupSimple() {
         let groups = NotificationGroup.createGroups(notifications: [likeA1, likeA2], only: [.favourite])
-        XCTAssertEqual(groups, [NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!])
+        XCTAssertEqual(groups, [NotificationGroup(notifications: [likeA1, likeA2])!])
     }
     
     func testGroupWithOtherGroupableInBetween() {
         let groups = NotificationGroup.createGroups(notifications: [likeA1, likeB, likeA2], only: [.favourite])
         XCTAssertEqual(groups, [
-            NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!,
-            NotificationGroup(notifications: [likeB], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1, likeA2])!,
+            NotificationGroup(notifications: [likeB])!,
         ])
     }
     
     func testDontGroupWithUngroupableInBetween() {
         let groups = NotificationGroup.createGroups(notifications: [likeA1, mentionB, likeA2], only: [.favourite])
         XCTAssertEqual(groups, [
-            NotificationGroup(notifications: [likeA1], kind: .favourite)!,
-            NotificationGroup(notifications: [mentionB], kind: .mention)!,
-            NotificationGroup(notifications: [likeA2], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1])!,
+            NotificationGroup(notifications: [mentionB])!,
+            NotificationGroup(notifications: [likeA2])!,
         ])
     }
 
     func testMergeSimpleGroups() {
-        let group1 = NotificationGroup(notifications: [likeA1], kind: .favourite)!
-        let group2 = NotificationGroup(notifications: [likeA2], kind: .favourite)!
+        let group1 = NotificationGroup(notifications: [likeA1])!
+        let group2 = NotificationGroup(notifications: [likeA2])!
         let merged = NotificationGroup.mergeGroups(first: [group1], second: [group2], only: [.favourite])
         XCTAssertEqual(merged, [
-            NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!
+            NotificationGroup(notifications: [likeA1, likeA2])!
         ])
     }
     
     func testMergeGroupsWithOtherGroupableInBetween() {
-        let group1 = NotificationGroup(notifications: [likeA1], kind: .favourite)!
-        let group2 = NotificationGroup(notifications: [likeB], kind: .favourite)!
-        let group3 = NotificationGroup(notifications: [likeA2], kind: .favourite)!
+        let group1 = NotificationGroup(notifications: [likeA1])!
+        let group2 = NotificationGroup(notifications: [likeB])!
+        let group3 = NotificationGroup(notifications: [likeA2])!
         let merged = NotificationGroup.mergeGroups(first: [group1, group2], second: [group3], only: [.favourite])
         XCTAssertEqual(merged, [
-            NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!,
-            NotificationGroup(notifications: [likeB], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1, likeA2])!,
+            NotificationGroup(notifications: [likeB])!,
         ])
         
         let merged2 = NotificationGroup.mergeGroups(first: [group1], second: [group2, group3], only: [.favourite])
         XCTAssertEqual(merged2, [
-            NotificationGroup(notifications: [likeA1, likeA2], kind: .favourite)!,
-            NotificationGroup(notifications: [likeB], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1, likeA2])!,
+            NotificationGroup(notifications: [likeB])!,
         ])
         
-        let group4 = NotificationGroup(notifications: [likeB2], kind: .favourite)!
-        let group5 = NotificationGroup(notifications: [mentionB], kind: .mention)!
+        let group4 = NotificationGroup(notifications: [likeB2])!
+        let group5 = NotificationGroup(notifications: [mentionB])!
         let merged3 = NotificationGroup.mergeGroups(first: [group1, group5, group2], second: [group4, group3], only: [.favourite])
         print(merged3.count)
         XCTAssertEqual(merged3, [
             group1,
             group5,
-            NotificationGroup(notifications: [likeB, likeB2], kind: .favourite),
+            NotificationGroup(notifications: [likeB, likeB2]),
             group3
         ])
     }
     
     func testDontMergeWithUngroupableInBetween() {
-        let group1 = NotificationGroup(notifications: [likeA1], kind: .favourite)!
-        let group2 = NotificationGroup(notifications: [mentionB], kind: .mention)!
-        let group3 = NotificationGroup(notifications: [likeA2], kind: .favourite)!
+        let group1 = NotificationGroup(notifications: [likeA1])!
+        let group2 = NotificationGroup(notifications: [mentionB])!
+        let group3 = NotificationGroup(notifications: [likeA2])!
         let merged = NotificationGroup.mergeGroups(first: [group1, group2], second: [group3], only: [.favourite])
         XCTAssertEqual(merged, [
-            NotificationGroup(notifications: [likeA1], kind: .favourite)!,
-            NotificationGroup(notifications: [mentionB], kind: .mention)!,
-            NotificationGroup(notifications: [likeA2], kind: .favourite)!,
+            NotificationGroup(notifications: [likeA1])!,
+            NotificationGroup(notifications: [mentionB])!,
+            NotificationGroup(notifications: [likeA2])!,
         ])
     }
 

Packages/Pachyderm/Tests/PachydermTests/URLTests.swift

@@ -6,21 +6,20 @@
 //
 
 import XCTest
-@testable import Pachyderm
+import WebURL
+import WebURLFoundationExtras
 
 class URLTests: XCTestCase {
 
     func testDecodeURL() {
-        XCTAssertNotNil(try? URL.ParseStrategy().parse("https://xn--baw-joa.social/test/é"))
-        XCTAssertNotNil(try? URL.ParseStrategy().parse("http://見.香港/热狗/🌭"))
-    }
-    
-    func testRoundtripURL() throws {
-        let orig = URLDecoder(wrappedValue: URL(string: "https://example.com")!)
-        let encoded = try JSONEncoder().encode(orig)
-        print(String(data: encoded, encoding: .utf8)!)
-        let decoded = try JSONDecoder().decode(URLDecoder.self, from: encoded)
-        XCTAssertEqual(orig.wrappedValue, decoded.wrappedValue)
+        XCTAssertNotNil(WebURL(URL(string: "https://xn--baw-joa.social/@unituebingen")!))
+        XCTAssertNotNil(WebURL("https://xn--baw-joa.social/@unituebingen"))
+        XCTAssertNotNil(URLComponents(string: "https://xn--baw-joa.social/test/é"))
+        XCTAssertNotNil(WebURL("https://xn--baw-joa.social/test/é"))
+        if #available(iOS 16.0, *) {
+            XCTAssertNotNil(try? URL.ParseStrategy().parse("https://xn--baw-joa.social/test/é"))
+            XCTAssertNotNil(try? URL.ParseStrategy().parse("http://見.香港/热狗/🌭"))
+        }
     }
 
 }

Packages/TuskerPreferences/Sources/TuskerPreferences/Supporting Types/FeatureFlag.swift

@@ -9,5 +9,6 @@ import Foundation
 
 public enum FeatureFlag: String, Codable {
     case iPadBrowserNavigation = "ipad-browser-navigation"
+    case composeRewrite = "compose-rewrite"
     case pushNotifCustomEmoji = "push-notif-custom-emoji"
 }

Packages/TuskerPreferences/Sources/TuskerPreferences/SwiftUI/PreferenceObserving.swift

@@ -0,0 +1,37 @@
+//
+//  PreferenceObserving.swift
+//  TuskerPreferences
+//
+//  Created by Shadowfacts on 8/10/24.
+//
+
+import SwiftUI
+import Combine
+
+@propertyWrapper
+public struct PreferenceObserving<Key: PreferenceKey>: DynamicProperty {
+    public typealias PrefKeyPath = KeyPath<PreferenceStore, PreferencePublisher<Key>>
+    
+    private let keyPath: PrefKeyPath
+    @StateObject private var observer: Observer
+    
+    public init(_ keyPath: PrefKeyPath) {
+        self.keyPath = keyPath
+        self._observer = StateObject(wrappedValue: Observer(keyPath: keyPath))
+    }
+    
+    public var wrappedValue: Key.Value {
+        Preferences.shared.getValue(preferenceKeyPath: keyPath)
+    }
+    
+    @MainActor
+    private class Observer: ObservableObject {
+        private var cancellable: AnyCancellable?
+        
+        init(keyPath: PrefKeyPath) {
+            cancellable = Preferences.shared[keyPath: keyPath].sink { [unowned self] _ in
+                self.objectWillChange.send()
+            }
+        }
+    }
+}

ShareExtension/ShareHostingController.swift

@@ -9,6 +9,7 @@
 import SwiftUI
 import ComposeUI
 import TuskerComponents
+import WebURLFoundationExtras
 import Combine
 import TuskerPreferences
 
@@ -45,7 +46,7 @@ class ShareHostingController: UIHostingController<ShareHostingController.View> {
             currentAccountContainerView: { AnyView(SwitchAccountContainerView(content: $0, mastodonContextPublisher: mastodonContextPublisher)) },
             replyContentView: { _, _  in fatalError("replies aren't allowed in share sheet") },
             emojiImageView: {
-                AnyView(AsyncImage(url: $0.url) {
+                AnyView(AsyncImage(url: URL($0.url)!) {
                     $0
                         .resizable()
                         .aspectRatio(contentMode: .fit)

ShareExtension/ShareMastodonContext.swift

@@ -83,4 +83,8 @@ final class ShareMastodonContext: ComposeMastodonContext, ObservableObject, Send
     
     func storeCreatedStatus(_ status: Status) {
     }
+    
+    func fetchStatus(id: String) -> (any StatusProtocol)? {
+        return nil
+    }
 }

Tusker.xcodeproj/project.pbxproj

@@ -103,6 +103,7 @@
 		D630C3E12BC61C6700208903 /* UserAccounts in Frameworks */ = {isa = PBXBuildFile; productRef = D630C3E02BC61C6700208903 /* UserAccounts */; };
 		D630C3E52BC6313400208903 /* Pachyderm in Frameworks */ = {isa = PBXBuildFile; productRef = D630C3E42BC6313400208903 /* Pachyderm */; };
 		D630C4232BC7842C00208903 /* HTMLStreamer in Frameworks */ = {isa = PBXBuildFile; productRef = D630C4222BC7842C00208903 /* HTMLStreamer */; };
+		D630C4252BC7845800208903 /* WebURL in Frameworks */ = {isa = PBXBuildFile; productRef = D630C4242BC7845800208903 /* WebURL */; };
 		D6311C5025B3765B00B27539 /* ImageDataCache.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6311C4F25B3765B00B27539 /* ImageDataCache.swift */; };
 		D6333B372137838300CE884A /* AttributedString+Helpers.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6333B362137838300CE884A /* AttributedString+Helpers.swift */; };
 		D6333B792139AEFD00CE884A /* Date+TimeAgo.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6333B782139AEFD00CE884A /* Date+TimeAgo.swift */; };
@@ -163,6 +164,7 @@
 		D6620ACE2511A0ED00312CA0 /* StatusStateResolver.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6620ACD2511A0ED00312CA0 /* StatusStateResolver.swift */; };
 		D663626C21361C6700C9CBA2 /* Account+Preferences.swift in Sources */ = {isa = PBXBuildFile; fileRef = D663626B21361C6700C9CBA2 /* Account+Preferences.swift */; };
 		D6674AEA23341F7600E8DF94 /* AppShortcutItems.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6674AE923341F7600E8DF94 /* AppShortcutItems.swift */; };
+		D6676CA527A8D0020052936B /* WebURLFoundationExtras in Frameworks */ = {isa = PBXBuildFile; productRef = D6676CA427A8D0020052936B /* WebURLFoundationExtras */; };
 		D66A77BB233838DC0058F1EC /* UIFont+Traits.swift in Sources */ = {isa = PBXBuildFile; fileRef = D66A77BA233838DC0058F1EC /* UIFont+Traits.swift */; };
 		D66C900B28DAB7FD00217BF2 /* TimelineViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D66C900A28DAB7FD00217BF2 /* TimelineViewController.swift */; };
 		D674A50927F9128D00BA03AC /* Pachyderm in Frameworks */ = {isa = PBXBuildFile; productRef = D674A50827F9128D00BA03AC /* Pachyderm */; };
@@ -201,16 +203,20 @@
 		D691771729A710520054D7EF /* ProfileNoContentCollectionViewCell.swift in Sources */ = {isa = PBXBuildFile; fileRef = D691771629A710520054D7EF /* ProfileNoContentCollectionViewCell.swift */; };
 		D691771929A7B8820054D7EF /* ProfileHeaderMovedOverlayView.swift in Sources */ = {isa = PBXBuildFile; fileRef = D691771829A7B8820054D7EF /* ProfileHeaderMovedOverlayView.swift */; };
 		D691772E29AA5D420054D7EF /* UserActivityHandlingContext.swift in Sources */ = {isa = PBXBuildFile; fileRef = D691772D29AA5D420054D7EF /* UserActivityHandlingContext.swift */; };
+		D69261232BB3AEFB0023152C /* VideoOverlayViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D69261222BB3AEFB0023152C /* VideoOverlayViewController.swift */; };
 		D69261272BB3BA610023152C /* Box.swift in Sources */ = {isa = PBXBuildFile; fileRef = D69261262BB3BA610023152C /* Box.swift */; };
 		D6934F2C2BA7AD32002B1C8D /* GalleryVC in Frameworks */ = {isa = PBXBuildFile; productRef = D6934F2B2BA7AD32002B1C8D /* GalleryVC */; };
 		D6934F2E2BA7AEF9002B1C8D /* StatusAttachmentsGalleryDataSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F2D2BA7AEF9002B1C8D /* StatusAttachmentsGalleryDataSource.swift */; };
-		D6934F302BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F2F2BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift */; };
+		D6934F302BA7AF91002B1C8D /* ImageGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F2F2BA7AF91002B1C8D /* ImageGalleryContentViewController.swift */; };
+		D6934F322BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F312BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift */; };
 		D6934F342BA8D65A002B1C8D /* ImageGalleryDataSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F332BA8D65A002B1C8D /* ImageGalleryDataSource.swift */; };
 		D6934F362BA8E020002B1C8D /* GifvGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F352BA8E020002B1C8D /* GifvGalleryContentViewController.swift */; };
 		D6934F382BA8E2B7002B1C8D /* GifvController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F372BA8E2B7002B1C8D /* GifvController.swift */; };
-		D6934F3C2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F3B2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift */; };
+		D6934F3A2BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F392BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift */; };
+		D6934F3C2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F3B2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift */; };
 		D6934F3E2BAA19D5002B1C8D /* ImageActivityItemSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F3D2BAA19D5002B1C8D /* ImageActivityItemSource.swift */; };
 		D6934F402BAA19EC002B1C8D /* VideoActivityItemSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F3F2BAA19EC002B1C8D /* VideoActivityItemSource.swift */; };
+		D6934F422BAC7D6E002B1C8D /* VideoControlsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D6934F412BAC7D6E002B1C8D /* VideoControlsViewController.swift */; };
 		D693A72825CF282E003A14E2 /* TrendingHashtagsViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D693A72725CF282E003A14E2 /* TrendingHashtagsViewController.swift */; };
 		D693DE5723FE1A6A0061E07D /* EnhancedNavigationViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D693DE5623FE1A6A0061E07D /* EnhancedNavigationViewController.swift */; };
 		D693DE5923FE24310061E07D /* InteractivePushTransition.swift in Sources */ = {isa = PBXBuildFile; fileRef = D693DE5823FE24300061E07D /* InteractivePushTransition.swift */; };
@@ -631,15 +637,19 @@
 		D691771629A710520054D7EF /* ProfileNoContentCollectionViewCell.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ProfileNoContentCollectionViewCell.swift; sourceTree = "<group>"; };
 		D691771829A7B8820054D7EF /* ProfileHeaderMovedOverlayView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ProfileHeaderMovedOverlayView.swift; sourceTree = "<group>"; };
 		D691772D29AA5D420054D7EF /* UserActivityHandlingContext.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UserActivityHandlingContext.swift; sourceTree = "<group>"; };
+		D69261222BB3AEFB0023152C /* VideoOverlayViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VideoOverlayViewController.swift; sourceTree = "<group>"; };
 		D69261262BB3BA610023152C /* Box.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Box.swift; sourceTree = "<group>"; };
 		D6934F2D2BA7AEF9002B1C8D /* StatusAttachmentsGalleryDataSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StatusAttachmentsGalleryDataSource.swift; sourceTree = "<group>"; };
-		D6934F2F2BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GrayscalableImageGalleryContentViewController.swift; sourceTree = "<group>"; };
+		D6934F2F2BA7AF91002B1C8D /* ImageGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageGalleryContentViewController.swift; sourceTree = "<group>"; };
+		D6934F312BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = LoadingGalleryContentViewController.swift; sourceTree = "<group>"; };
 		D6934F332BA8D65A002B1C8D /* ImageGalleryDataSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageGalleryDataSource.swift; sourceTree = "<group>"; };
 		D6934F352BA8E020002B1C8D /* GifvGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GifvGalleryContentViewController.swift; sourceTree = "<group>"; };
 		D6934F372BA8E2B7002B1C8D /* GifvController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GifvController.swift; sourceTree = "<group>"; };
-		D6934F3B2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = GrayscalableVideoGalleryContentViewController.swift; sourceTree = "<group>"; };
+		D6934F392BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FallbackGalleryContentViewController.swift; sourceTree = "<group>"; };
+		D6934F3B2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VideoGalleryContentViewController.swift; sourceTree = "<group>"; };
 		D6934F3D2BAA19D5002B1C8D /* ImageActivityItemSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ImageActivityItemSource.swift; sourceTree = "<group>"; };
 		D6934F3F2BAA19EC002B1C8D /* VideoActivityItemSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VideoActivityItemSource.swift; sourceTree = "<group>"; };
+		D6934F412BAC7D6E002B1C8D /* VideoControlsViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VideoControlsViewController.swift; sourceTree = "<group>"; };
 		D693A72725CF282E003A14E2 /* TrendingHashtagsViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TrendingHashtagsViewController.swift; sourceTree = "<group>"; };
 		D693DE5623FE1A6A0061E07D /* EnhancedNavigationViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EnhancedNavigationViewController.swift; sourceTree = "<group>"; };
 		D693DE5823FE24300061E07D /* InteractivePushTransition.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = InteractivePushTransition.swift; sourceTree = "<group>"; };
@@ -816,6 +826,7 @@
 			isa = PBXFrameworksBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				D630C4252BC7845800208903 /* WebURL in Frameworks */,
 				D62220472C7EA8DF003E43B7 /* TuskerPreferences in Frameworks */,
 				D630C4232BC7842C00208903 /* HTMLStreamer in Frameworks */,
 				D630C3E52BC6313400208903 /* Pachyderm in Frameworks */,
@@ -852,6 +863,7 @@
 				D6934F2C2BA7AD32002B1C8D /* GalleryVC in Frameworks */,
 				D6552367289870790048A653 /* ScreenCorners in Frameworks */,
 				D60BB3942B30076F00DAEA65 /* HTMLStreamer in Frameworks */,
+				D6676CA527A8D0020052936B /* WebURLFoundationExtras in Frameworks */,
 				D63CC702290EC0B8000E19DE /* Sentry in Frameworks */,
 				D6BEA245291A0EDE002F4D01 /* Duckable in Frameworks */,
 			);
@@ -887,9 +899,13 @@
 			children = (
 				D6934F2D2BA7AEF9002B1C8D /* StatusAttachmentsGalleryDataSource.swift */,
 				D6934F332BA8D65A002B1C8D /* ImageGalleryDataSource.swift */,
-				D6934F2F2BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift */,
+				D6934F312BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift */,
+				D6934F2F2BA7AF91002B1C8D /* ImageGalleryContentViewController.swift */,
 				D6934F352BA8E020002B1C8D /* GifvGalleryContentViewController.swift */,
-				D6934F3B2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift */,
+				D6934F3B2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift */,
+				D69261222BB3AEFB0023152C /* VideoOverlayViewController.swift */,
+				D6934F412BAC7D6E002B1C8D /* VideoControlsViewController.swift */,
+				D6934F392BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift */,
 			);
 			path = Gallery;
 			sourceTree = "<group>";
@@ -1777,6 +1793,7 @@
 				D630C3E02BC61C6700208903 /* UserAccounts */,
 				D630C3E42BC6313400208903 /* Pachyderm */,
 				D630C4222BC7842C00208903 /* HTMLStreamer */,
+				D630C4242BC7845800208903 /* WebURL */,
 				D62220462C7EA8DF003E43B7 /* TuskerPreferences */,
 			);
 			productName = NotificationExtension;
@@ -1828,6 +1845,7 @@
 			);
 			name = Tusker;
 			packageProductDependencies = (
+				D6676CA427A8D0020052936B /* WebURLFoundationExtras */,
 				D674A50827F9128D00BA03AC /* Pachyderm */,
 				D6552366289870790048A653 /* ScreenCorners */,
 				D63CC701290EC0B8000E19DE /* Sentry */,
@@ -1954,6 +1972,7 @@
 			);
 			mainGroup = D6D4DDC3212518A000E1C4BB;
 			packageReferences = (
+				D6676CA127A8D0020052936B /* XCRemoteSwiftPackageReference "swift-url" */,
 				D6552365289870790048A653 /* XCRemoteSwiftPackageReference "ScreenCorners" */,
 				D63CC700290EC0B8000E19DE /* XCRemoteSwiftPackageReference "sentry-cocoa" */,
 				D60BB3922B30076F00DAEA65 /* XCRemoteSwiftPackageReference "HTMLStreamer" */,
@@ -2103,6 +2122,7 @@
 			isa = PBXSourcesBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				D6934F422BAC7D6E002B1C8D /* VideoControlsViewController.swift in Sources */,
 				0427033A22B31269000D31B6 /* AdvancedPrefsView.swift in Sources */,
 				D6C3F4F5298ED0890009FCFF /* LocalPredicateStatusesViewController.swift in Sources */,
 				D691771729A710520054D7EF /* ProfileNoContentCollectionViewCell.swift in Sources */,
@@ -2149,7 +2169,8 @@
 				D6A4DCCC2553667800D9DE31 /* FastAccountSwitcherViewController.swift in Sources */,
 				D627944F23A9C99800D38C68 /* EditListAccountsViewController.swift in Sources */,
 				D6945C3423AC6431005C403C /* AddSavedHashtagViewController.swift in Sources */,
-				D6934F3C2BAA0F80002B1C8D /* GrayscalableVideoGalleryContentViewController.swift in Sources */,
+				D69261232BB3AEFB0023152C /* VideoOverlayViewController.swift in Sources */,
+				D6934F3C2BAA0F80002B1C8D /* VideoGalleryContentViewController.swift in Sources */,
 				D6F6A552291F098700F496A8 /* RenameListService.swift in Sources */,
 				D62D2426217ABF63005076CC /* UserActivityType.swift in Sources */,
 				D698F46B2BD079F00054DB14 /* AnnouncementListRow.swift in Sources */,
@@ -2169,6 +2190,7 @@
 				D6D94955298963A900C59229 /* Colors.swift in Sources */,
 				D6945C3823AC739F005C403C /* InstanceTimelineViewController.swift in Sources */,
 				D625E4822588262A0074BB2B /* DraggableTableViewCell.swift in Sources */,
+				D6934F322BA7E43E002B1C8D /* LoadingGalleryContentViewController.swift in Sources */,
 				D68E525B24A3D77E0054355A /* TuskerRootViewController.swift in Sources */,
 				D62D2422217AA7E1005076CC /* UserActivityManager.swift in Sources */,
 				D64A50482C739DEA009D7193 /* BaseMainTabBarViewController.swift in Sources */,
@@ -2196,6 +2218,7 @@
 				D630C3CC2BC5FD4600208903 /* GetAuthorizationTokenService.swift in Sources */,
 				D61DC84B28F4FD2000B82C6E /* ProfileHeaderCollectionViewCell.swift in Sources */,
 				D61A45E828DF477D002BE511 /* LoadingCollectionViewCell.swift in Sources */,
+				D6934F3A2BA8F3D7002B1C8D /* FallbackGalleryContentViewController.swift in Sources */,
 				D67B506D250B291200FAECFB /* BlurHashDecode.swift in Sources */,
 				D68A76EC295369A8001DA1B3 /* AboutView.swift in Sources */,
 				04DACE8E212CC7CC009840C4 /* ImageCache.swift in Sources */,
@@ -2318,7 +2341,7 @@
 				D61A45EA28DF51EE002BE511 /* TimelineLikeCollectionViewController.swift in Sources */,
 				D64D0AB12128D9AE005A6F37 /* OnboardingViewController.swift in Sources */,
 				D64A50BE2C752247009D7193 /* AdaptableNavigationController.swift in Sources */,
-				D6934F302BA7AF91002B1C8D /* GrayscalableImageGalleryContentViewController.swift in Sources */,
+				D6934F302BA7AF91002B1C8D /* ImageGalleryContentViewController.swift in Sources */,
 				D6934F3E2BAA19D5002B1C8D /* ImageActivityItemSource.swift in Sources */,
 				D67C1795266D57D10070F250 /* FastAccountSwitcherIndicatorView.swift in Sources */,
 				D61F75962937037800C0B37F /* ToggleFollowHashtagService.swift in Sources */,
@@ -3267,6 +3290,14 @@
 				minimumVersion = 1.0.1;
 			};
 		};
+		D6676CA127A8D0020052936B /* XCRemoteSwiftPackageReference "swift-url" */ = {
+			isa = XCRemoteSwiftPackageReference;
+			repositoryURL = "https://github.com/karwa/swift-url";
+			requirement = {
+				kind = exactVersion;
+				version = 0.4.2;
+			};
+		};
 /* End XCRemoteSwiftPackageReference section */
 
 /* Begin XCSwiftPackageProductDependency section */
@@ -3304,6 +3335,11 @@
 			package = D60BB3922B30076F00DAEA65 /* XCRemoteSwiftPackageReference "HTMLStreamer" */;
 			productName = HTMLStreamer;
 		};
+		D630C4242BC7845800208903 /* WebURL */ = {
+			isa = XCSwiftPackageProductDependency;
+			package = D6676CA127A8D0020052936B /* XCRemoteSwiftPackageReference "swift-url" */;
+			productName = WebURL;
+		};
 		D635237029B78A7D009ED5E7 /* TuskerComponents */ = {
 			isa = XCSwiftPackageProductDependency;
 			productName = TuskerComponents;
@@ -3322,6 +3358,11 @@
 			isa = XCSwiftPackageProductDependency;
 			productName = TTTKit;
 		};
+		D6676CA427A8D0020052936B /* WebURLFoundationExtras */ = {
+			isa = XCSwiftPackageProductDependency;
+			package = D6676CA127A8D0020052936B /* XCRemoteSwiftPackageReference "swift-url" */;
+			productName = WebURLFoundationExtras;
+		};
 		D674A50827F9128D00BA03AC /* Pachyderm */ = {
 			isa = XCSwiftPackageProductDependency;
 			productName = Pachyderm;

Tusker/CoreData/FollowedHashtag.swift

@@ -9,6 +9,7 @@
 import Foundation
 import CoreData
 import Pachyderm
+import WebURLFoundationExtras
 
 @objc(FollowedHashtag)
 public final class FollowedHashtag: NSManagedObject {
@@ -32,6 +33,6 @@ extension FollowedHashtag {
     convenience init(hashtag: Hashtag, context: NSManagedObjectContext) {
         self.init(context: context)
         self.name = hashtag.name
-        self.url = hashtag.url
+        self.url = URL(hashtag.url)!
     }
 }

Tusker/CoreData/MastodonCachePersistentStore.swift

@@ -375,14 +375,13 @@ class MastodonCachePersistentStore: NSPersistentCloudKitContainer, @unchecked Se
         }
     }
 
-    func addAll(notifications: [Pachyderm.Notification], in context: NSManagedObjectContext? = nil, completion: (() -> Void)? = nil) {
-        let context = context ?? backgroundContext
-        context.perform {
+    func addAll(notifications: [Pachyderm.Notification], completion: (() -> Void)? = nil) {
+        backgroundContext.perform {
             let statuses = notifications.compactMap { $0.status }
             let accounts = notifications.map { $0.account }
-            statuses.forEach { self.upsert(status: $0, context: context) }
-            accounts.forEach { self.upsert(account: $0, in: context) }
-            self.save(context: context)
+            statuses.forEach { self.upsert(status: $0, context: self.backgroundContext) }
+            accounts.forEach { self.upsert(account: $0, in: self.backgroundContext) }
+            self.save(context: self.backgroundContext)
             completion?()
             statuses.forEach { self.statusSubject.send($0.id) }
             accounts.forEach { self.accountSubject.send($0.id) }

Tusker/CoreData/SavedHashtag.swift

@@ -9,6 +9,7 @@
 import Foundation
 import CoreData
 import Pachyderm
+import WebURLFoundationExtras
 import UserAccounts
 
 @objc(SavedHashtag)
@@ -41,6 +42,6 @@ extension SavedHashtag {
         self.init(context: context)
         self.accountID = account.id
         self.name = hashtag.name
-        self.url = hashtag.url
+        self.url = URL(hashtag.url)!
     }
 }

Tusker/CoreData/StatusMO.swift

@@ -10,6 +10,7 @@
 import Foundation
 import CoreData
 import Pachyderm
+import WebURLFoundationExtras
 
 @objc(StatusMO)
 public final class StatusMO: NSManagedObject, StatusProtocol {
@@ -135,7 +136,7 @@ extension StatusMO {
         self.sensitive = status.sensitive
         self.spoilerText = status.spoilerText
         self.uri = status.uri
-        self.url = status.url
+        self.url = status.url != nil ? URL(status.url!) : nil
         self.visibility = status.visibility
         self.poll = status.poll
         self.localOnly = status.localOnly ?? false

Tusker/Extensions/View+AppListStyle.swift

@@ -59,31 +59,3 @@ private struct AppGroupedListRowBackground: ViewModifier {
         }
     }
 }
-
-@propertyWrapper
-private struct PreferenceObserving<Key: TuskerPreferences.PreferenceKey>: DynamicProperty {
-    typealias PrefKeyPath = KeyPath<PreferenceStore, PreferencePublisher<Key>>
-    
-    let keyPath: PrefKeyPath
-    @StateObject private var observer: Observer
-    
-    init(_ keyPath: PrefKeyPath) {
-        self.keyPath = keyPath
-        self._observer = StateObject(wrappedValue: Observer(keyPath: keyPath))
-    }
-    
-    var wrappedValue: Key.Value {
-        Preferences.shared.getValue(preferenceKeyPath: keyPath)
-    }
-    
-    @MainActor
-    private class Observer: ObservableObject {
-        private var cancellable: AnyCancellable?
-        
-        init(keyPath: PrefKeyPath) {
-            cancellable = Preferences.shared[keyPath: keyPath].sink { [unowned self] _ in
-                self.objectWillChange.send()
-            }
-        }
-    }
-}

Tusker/HTMLConverter.swift

@@ -8,7 +8,8 @@
 
 import UIKit
 import HTMLStreamer
-import Pachyderm
+import WebURL
+import WebURLFoundationExtras
 
 class HTMLConverter {
     
@@ -44,7 +45,17 @@ extension HTMLConverter {
     // note: this is duplicated in NotificationExtension
     struct Callbacks: HTMLConversionCallbacks {
         static func makeURL(string: String) -> URL? {
-            try? URL.ParseStrategy().parse(string)
+            // Converting WebURL to URL is a small but non-trivial expense (since it works by
+            // serializing the WebURL as a string and then having Foundation parse it again),
+            // so, if available, use the system parser which doesn't require another round trip.
+            if let url = try? URL.ParseStrategy().parse(string) {
+                url
+            } else if let web = WebURL(string),
+                      let url = URL(web) {
+                url
+            } else {
+                nil
+            }
         }
         
         static func elementAction(name: String, attributes: [Attribute]) -> ElementAction {

Tusker/Screens/Announcements/AnnouncementContentTextView.swift

@@ -8,6 +8,7 @@
 
 import UIKit
 import Pachyderm
+import WebURL
 
 class AnnouncementContentTextView: ContentTextView {
     
@@ -29,7 +30,7 @@ class AnnouncementContentTextView: ContentTextView {
     
     override func getMention(for url: URL, text: String) -> Mention? {
         announcement?.mentions.first {
-            $0.url == url
+            URL($0.url) == url
         }.map {
             Mention(url: $0.url, username: $0.username, acct: $0.acct, id: $0.id)
         }
@@ -37,7 +38,7 @@ class AnnouncementContentTextView: ContentTextView {
     
     override func getHashtag(for url: URL, text: String) -> Hashtag? {
         announcement?.tags.first {
-            $0.url == url
+            URL($0.url) == url
         }
     }
 

Tusker/Screens/Announcements/AnnouncementListRow.swift

@@ -9,6 +9,7 @@
 import SwiftUI
 import Pachyderm
 import TuskerComponents
+import WebURLFoundationExtras
 
 struct AnnouncementListRow: View {
     @Binding var announcement: Announcement
@@ -115,8 +116,8 @@ struct AnnouncementListRow: View {
         let url: URL?
         let staticURL: URL?
         if case .custom(let emoji) = reaction {
-            url = emoji.url
-            staticURL = emoji.staticURL
+            url = URL(emoji.url)
+            staticURL = URL(emoji.staticURL)
         } else {
             url = nil
             staticURL = nil

Tusker/Screens/Compose/ComposeHostingController.swift

@@ -50,6 +50,10 @@ class ComposeHostingController: UIHostingController<ComposeHostingController.Vie
             emojiImageView: { AnyView(CustomEmojiImageView(emoji: $0)) }
         )
         
+        if let account = mastodonController.account {
+            controller.currentAccount = account
+        }
+        
         self.mastodonController = mastodonController
         
         super.init(rootView: View(mastodonController: mastodonController, controller: controller))
@@ -129,7 +133,6 @@ class ComposeHostingController: UIHostingController<ComposeHostingController.Vie
         let picker = PHPickerViewController(configuration: config)
         picker.delegate = self
         picker.modalPresentationStyle = .pageSheet
-        picker.overrideUserInterfaceStyle = .dark
         // sheet detents don't play nice with PHPickerViewController, see
 //        let sheet = picker.sheetPresentationController!
 //        sheet.detents = [.medium(), .large()]
@@ -151,7 +154,8 @@ class ComposeHostingController: UIHostingController<ComposeHostingController.Vie
         var body: some SwiftUI.View {
             ControllerView(controller: { controller })
                 .task {
-                    if let account = try? await mastodonController.getOwnAccount() {
+                    if controller.currentAccount == nil,
+                       let account = try? await mastodonController.getOwnAccount() {
                         controller.currentAccount = account
                     }
                 }
@@ -185,6 +189,7 @@ extension ComposeHostingController: DuckableViewController {
 }
 #endif
 
+// TODO: don't conform MastodonController to this protocol, use a separate type
 extension MastodonController: ComposeMastodonContext {
     @MainActor
     func searchCachedAccounts(query: String) -> [AccountProtocol] {
@@ -227,6 +232,10 @@ extension MastodonController: ComposeMastodonContext {
     func storeCreatedStatus(_ status: Status) {
         persistentContainer.addOrUpdate(status: status)
     }
+    
+    func fetchStatus(id: String) -> (any StatusProtocol)? {
+        return persistentContainer.status(for: id)
+    }
 }
 
 extension ComposeHostingController: PHPickerViewControllerDelegate {

Tusker/Screens/Conversation/ConversationViewController.swift

@@ -8,6 +8,8 @@
 
 import UIKit
 import Pachyderm
+import WebURL
+import WebURLFoundationExtras
 
 private let mastodonRemoteStatusRegex = try! NSRegularExpression(pattern: "^/@.+@.+/\\d{18}")
 private func isLikelyMastodonRemoteStatus(url: URL) -> Bool {
@@ -227,10 +229,10 @@ class ConversationViewController: UIViewController {
               let location = (response as? HTTPURLResponse)?.value(forHTTPHeaderField: "location") {
                effectiveURL = location
            } else {
-               effectiveURL = url.formatted(.url.fragment(.never))
+               effectiveURL = WebURL(url)!.serialized(excludingFragment: true)
            }
         } else {
-            effectiveURL = url.formatted(.url.fragment(.never))
+            effectiveURL = WebURL(url)!.serialized(excludingFragment: true)
         }
         
         let request = Client.search(query: effectiveURL, types: [.statuses], resolve: true)
@@ -482,11 +484,3 @@ extension ConversationViewController: StatusBarTappableViewController {
         }
     }
 }
-
-extension ConversationViewController: RefreshableViewController {
-    func refresh() {
-        Task {
-            await refreshContext()
-        }
-    }
-}

Tusker/Screens/Explore/ExploreViewController.swift

@@ -10,6 +10,7 @@ import UIKit
 import Combine
 import Pachyderm
 import CoreData
+import WebURLFoundationExtras
 
 class ExploreViewController: UIViewController, UICollectionViewDelegate, CollectionViewController {
 
@@ -559,7 +560,10 @@ extension ExploreViewController: UICollectionViewDragDelegate {
             activity.displaysAuxiliaryScene = true
             provider = NSItemProvider(object: activity)
         case let .savedHashtag(hashtag):
-            provider = NSItemProvider(object: hashtag.url as NSURL)
+            guard let url = URL(hashtag.url) else {
+                return []
+            }
+            provider = NSItemProvider(object: url as NSURL)
             if let activity = UserActivityManager.showTimelineActivity(timeline: .tag(hashtag: hashtag.name), accountID: accountID) {
                 activity.displaysAuxiliaryScene = true
                 provider.registerObject(activity, visibility: .all)

Tusker/Screens/Explore/TrendingHashtagsViewController.swift

@@ -8,6 +8,7 @@
 
 import UIKit
 import Pachyderm
+import WebURLFoundationExtras
 import Combine
 
 class TrendingHashtagsViewController: UIViewController, CollectionViewController {
@@ -276,10 +277,11 @@ extension TrendingHashtagsViewController: UICollectionViewDelegate {
 extension TrendingHashtagsViewController: UICollectionViewDragDelegate {
     func collectionView(_ collectionView: UICollectionView, itemsForBeginning session: UIDragSession, at indexPath: IndexPath) -> [UIDragItem] {
         guard let item = dataSource.itemIdentifier(for: indexPath),
-              case let .tag(hashtag) = item else {
+              case let .tag(hashtag) = item,
+              let url = URL(hashtag.url) else {
                   return []
               }
-        let provider = NSItemProvider(object: hashtag.url as NSURL)
+        let provider = NSItemProvider(object: url as NSURL)
         if let activity = UserActivityManager.showTimelineActivity(timeline: .tag(hashtag: hashtag.name), accountID: mastodonController.accountInfo!.id) {
             activity.displaysAuxiliaryScene = true
             provider.registerObject(activity, visibility: .all)

Tusker/Screens/Explore/TrendingLinkCardCollectionViewCell.swift

@@ -9,6 +9,7 @@
 #if !os(visionOS)
 import UIKit
 import Pachyderm
+import WebURLFoundationExtras
 import HTMLStreamer
 
 class TrendingLinkCardCollectionViewCell: UICollectionViewCell {
@@ -70,7 +71,7 @@ class TrendingLinkCardCollectionViewCell: UICollectionViewCell {
         self.card = card
         self.thumbnailView.image = nil
         
-        thumbnailView.update(for: card.image, blurhash: card.blurhash)
+        thumbnailView.update(for: card.image.flatMap { URL($0) }, blurhash: card.blurhash)
         
         let title = card.title.trimmingCharacters(in: .whitespacesAndNewlines)
         titleLabel.text = title

Tusker/Screens/Explore/TrendingLinkCardView.swift

@@ -9,17 +9,22 @@
 #if os(visionOS)
 import SwiftUI
 import Pachyderm
+import WebURLFoundationExtras
 import HTMLStreamer
 
 struct TrendingLinkCardView: View {
     let card: Card
     
     private var imageURL: URL? {
-        card.image
+        if let image = card.image {
+            URL(image)
+        } else {
+            nil
+        }
     }
     
     private var descriptionText: String {
-        let converter = TextConverter(configuration: .init(insertNewlines: false))
+        var converter = TextConverter(configuration: .init(insertNewlines: false))
         return converter.convert(html: card.description)
     }
     

Tusker/Screens/Explore/TrendingLinksViewController.swift

@@ -8,6 +8,7 @@
 
 import UIKit
 import Pachyderm
+import WebURLFoundationExtras
 import SafariServices
 import Combine
 #if os(visionOS)
@@ -292,19 +293,21 @@ extension TrendingLinksViewController: UICollectionViewDelegate {
     }
     
     func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
-        guard case .link(let card) = dataSource.itemIdentifier(for: indexPath) else {
+        guard case .link(let card) = dataSource.itemIdentifier(for: indexPath),
+              let url = URL(card.url) else {
             return
         }
-        selected(url: card.url)
+        selected(url: url)
     }
     
     func collectionView(_ collectionView: UICollectionView, contextMenuConfigurationForItemAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration? {
         guard case .link(let card) = dataSource.itemIdentifier(for: indexPath),
+              let url = URL(card.url),
               let cell = collectionView.cellForItem(at: indexPath) else {
             return nil
         }
         return UIContextMenuConfiguration {
-            let vc = SFSafariViewController(url: card.url)
+            let vc = SFSafariViewController(url: url)
             #if !os(visionOS)
             vc.preferredControlTintColor = Preferences.shared.accentColor.color
             #endif
@@ -321,10 +324,11 @@ extension TrendingLinksViewController: UICollectionViewDelegate {
 
 extension TrendingLinksViewController: UICollectionViewDragDelegate {
     func collectionView(_ collectionView: UICollectionView, itemsForBeginning session: UIDragSession, at indexPath: IndexPath) -> [UIDragItem] {
-        guard case .link(let card) = dataSource.itemIdentifier(for: indexPath) else {
+        guard case .link(let card) = dataSource.itemIdentifier(for: indexPath),
+              let url = URL(card.url) else {
             return []
         }
-        return [UIDragItem(itemProvider: NSItemProvider(object: card.url as NSURL))]
+        return [UIDragItem(itemProvider: NSItemProvider(object: url as NSURL))]
     }
 }
 

Tusker/Screens/Explore/TrendsViewController.swift

@@ -513,7 +513,9 @@ extension TrendsViewController: UICollectionViewDelegate {
             show(HashtagTimelineViewController(for: hashtag, mastodonController: mastodonController), sender: nil)
             
         case let .link(card):
-            selected(url: card.url)
+            if let url = URL(card.url) {
+                selected(url: url)
+            }
             
         case let .status(id, state):
             selected(status: id, state: state.copy())
@@ -542,9 +544,12 @@ extension TrendsViewController: UICollectionViewDelegate {
             }
             
         case let .link(card):
+            guard let url = URL(card.url) else {
+                return nil
+            }
             let cell = collectionView.cellForItem(at: indexPath)!
             return UIContextMenuConfiguration {
-                let vc = SFSafariViewController(url: card.url)
+                let vc = SFSafariViewController(url: url)
                 #if !os(visionOS)
                 vc.preferredControlTintColor = Preferences.shared.accentColor.color
                 #endif
@@ -619,7 +624,10 @@ extension TrendsViewController: UICollectionViewDragDelegate {
             return []
             
         case let .tag(hashtag):
-            let provider = NSItemProvider(object: hashtag.url as NSURL)
+            guard let url = URL(hashtag.url) else {
+                return []
+            }
+            let provider = NSItemProvider(object: url as NSURL)
             if let activity = UserActivityManager.showTimelineActivity(timeline: .tag(hashtag: hashtag.name), accountID: mastodonController.accountInfo!.id) {
                 activity.displaysAuxiliaryScene = true
                 provider.registerObject(activity, visibility: .all)
@@ -627,7 +635,10 @@ extension TrendsViewController: UICollectionViewDragDelegate {
             return [UIDragItem(itemProvider: provider)]
             
         case let .link(card):
-            return [UIDragItem(itemProvider: NSItemProvider(object: card.url as NSURL))]
+            guard let url = URL(card.url) else {
+                return []
+            }
+            return [UIDragItem(itemProvider: NSItemProvider(object: url as NSURL))]
             
         case let .status(id, _):
             guard let status = mastodonController.persistentContainer.status(for: id),

Tusker/Screens/Fast Account Switcher/FastSwitchingAccountView.swift

@@ -8,6 +8,7 @@
 
 import UIKit
 import UserAccounts
+import WebURL
 
 class FastSwitchingAccountView: UIView {
     
@@ -130,7 +131,11 @@ class FastSwitchingAccountView: UIView {
     
     private func setupAccount(account: UserAccountInfo) {
         usernameLabel.text = account.username
-        instanceLabel.text = account.instanceURL.host(percentEncoded: false)
+        if let domain = WebURL.Domain(account.instanceURL.host!) {
+            instanceLabel.text = domain.render(.uncheckedUnicodeString)
+        } else {
+            instanceLabel.text = account.instanceURL.host!
+        }
         let controller = MastodonController.getForAccount(account)
         avatarTask = Task {
             guard let account = try? await controller.getOwnAccount(),

Tusker/Screens/Gallery/FallbackGalleryContentViewController.swift

@@ -1,13 +1,15 @@
 //
 //  FallbackGalleryContentViewController.swift
-//  GalleryVC
+//  Tusker
 //
 //  Created by Shadowfacts on 3/18/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
 //
 
 import UIKit
+import GalleryVC
 import QuickLook
+import Pachyderm
 
 private class FallbackGalleryContentViewController: QLPreviewController {
     private let previewItem = GalleryPreviewItem()
@@ -50,40 +52,40 @@ extension FallbackGalleryContentViewController: QLPreviewControllerDataSource {
     }
 }
 
-public class FallbackGalleryNavigationController: UINavigationController, GalleryContentViewController {
-    public init(url: URL) {
+class FallbackGalleryNavigationController: UINavigationController, GalleryContentViewController {
+    init(url: URL) {
         super.init(nibName: nil, bundle: nil)
         self.viewControllers = [FallbackGalleryContentViewController(url: url)]
     }
     
-    public override func viewDidLoad() {
+    override func viewDidLoad() {
         super.viewDidLoad()
         
         container?.disableGalleryScrollAndZoom()
     }
     
-    public required init?(coder aDecoder: NSCoder) {
+    required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
     
     // MARK: GalleryContentViewController
     
-    public weak var container: (any GalleryContentViewControllerContainer)?
+    weak var container: (any GalleryVC.GalleryContentViewControllerContainer)?
     
-    public var contentSize: CGSize {
+    var contentSize: CGSize {
         .zero
     }
     
-    public var activityItemsForSharing: [Any] {
+    var activityItemsForSharing: [Any] {
         []
     }
     
-    public var caption: String? {
+    var caption: String? {
         nil
     }
     
-    public var presentationAnimation: GalleryContentPresentationAnimation {
-        .fade
+    var canAnimateFromSourceView: Bool {
+        false
     }
 }
 

Tusker/Screens/Gallery/GifvGalleryContentViewController.swift

@@ -69,8 +69,4 @@ class GifvGalleryContentViewController: UIViewController, GalleryContentViewCont
         [VideoActivityItemSource(asset: controller.item.asset, url: url)]
     }
     
-    var presentationAnimation: GalleryContentPresentationAnimation {
-        .fromSourceViewWithoutSnapshot
-    }
-    
 }

Tusker/Screens/Gallery/GrayscalableImageGalleryContentViewController.swift

@@ -1,60 +0,0 @@
-//
-//  GrayscalableImageGalleryContentViewController.swift
-//  Tusker
-//
-//  Created by Shadowfacts on 11/21/24.
-//  Copyright © 2024 Shadowfacts. All rights reserved.
-//
-
-import UIKit
-import TuskerComponents
-import GalleryVC
-
-class GrayscalableImageGalleryContentViewController: GalleryVC.ImageGalleryContentViewController {
-    private let url: URL
-    private let originalImage: UIImage
-    private let originalData: Data?
-    private var isGrayscale = false
-    
-    init(url: URL, caption: String?, originalData: Data?, image: UIImage, gifController: GIFController?) {
-        self.url = url
-        self.originalImage = image
-        self.originalData = originalData
-        
-        super.init(image: image, caption: caption, gifController: gifController)
-        
-        isGrayscale = Preferences.shared.grayscaleImages
-        if isGrayscale {
-            self.image = ImageGrayscalifier.convert(url: url, image: image) ?? image
-        }
-        
-        NotificationCenter.default.addObserver(self, selector: #selector(preferencesChanged), name: .preferencesChanged, object: nil)
-    }
-    
-    @MainActor required init?(coder: NSCoder) {
-        fatalError("init(coder:) has not been implemented")
-    }
-    
-    @objc private func preferencesChanged() {
-        if isGrayscale != Preferences.shared.grayscaleImages {
-            isGrayscale = Preferences.shared.grayscaleImages
-            let image = if isGrayscale {
-                ImageGrayscalifier.convert(url: url, image: originalImage)
-            } else {
-                originalImage
-            }
-            if let image {
-                self.image = image
-            }
-        }
-    }
-    
-    override var activityItemsForSharing: [Any] {
-        if let data = originalData ?? image.pngData() {
-            return [ImageActivityItemSource(data: data, url: url, image: image)]
-        } else {
-            return []
-        }
-    }
-    
-}

Tusker/Screens/Gallery/GrayscalableVideoGalleryContentViewController.swift

@@ -1,83 +0,0 @@
-//
-//  GrayscalableVideoGalleryContentViewController.swift
-//  Tusker
-//
-//  Created by Shadowfacts on 11/21/24.
-//  Copyright © 2024 Shadowfacts. All rights reserved.
-//
-
-import UIKit
-import GalleryVC
-import AVFoundation
-
-class GrayscalableVideoGalleryContentViewController: GalleryVC.VideoGalleryContentViewController {
-    private var audioSessionToken: AudioSessionCoordinator.Token?
-    private var isGrayscale: Bool
-    private var isFirstAppearance = true
-
-    override init(url: URL, caption: String?) {
-        self.isGrayscale = Preferences.shared.grayscaleImages
-        
-        super.init(url: url, caption: caption)
-        
-        NotificationCenter.default.addObserver(self, selector: #selector(preferencesChanged), name: .preferencesChanged, object: nil)
-    }
-    
-    @MainActor required init?(coder: NSCoder) {
-        fatalError("init(coder:) has not been implemented")
-    }
-    
-    override class func createItem(asset: AVAsset) -> AVPlayerItem {
-        let item = AVPlayerItem(asset: asset)
-        if Preferences.shared.grayscaleImages {
-            #if os(visionOS)
-            #warning("Use async AVVideoComposition CIFilter initializer")
-            #else
-            let filter = CIFilter(name: "CIColorMonochrome")!
-            filter.setValue(CIColor(red: 0.85, green: 0.85, blue: 0.85), forKey: "inputColor")
-            filter.setValue(1.0, forKey: "inputIntensity")
-            
-            item.videoComposition = AVVideoComposition(asset: asset, applyingCIFiltersWithHandler: { request in
-                filter.setValue(request.sourceImage, forKey: "inputImage")
-                request.finish(with: filter.outputImage!, context: nil)
-            })
-            #endif
-        }
-        return item
-    }
-    
-    @objc private func preferencesChanged() {
-        if isGrayscale != Preferences.shared.grayscaleImages {
-            let isPlaying = player.rate > 0
-            isGrayscale = Preferences.shared.grayscaleImages
-            replaceCurrentItem(with: Self.createItem(asset: item.asset))
-            if isPlaying {
-                player.play()
-            }
-        }
-    }
-    
-    override func galleryContentDidAppear() {
-        super.galleryContentDidAppear()
-        
-        let wasFirstAppearance = isFirstAppearance
-        isFirstAppearance = false
-        
-        audioSessionToken = AudioSessionCoordinator.shared.beginPlayback(mode: .video) {
-            if wasFirstAppearance {
-                DispatchQueue.main.async {
-                    self.player.play()
-                }
-            }
-        }
-    }
-    
-    override func galleryContentWillDisappear() {
-        super.galleryContentWillDisappear()
-        
-        if let audioSessionToken {
-            AudioSessionCoordinator.shared.endPlayback(token: audioSessionToken)
-        }
-    }
-    
-}

Tusker/Screens/Gallery/ImageGalleryContentViewController.swift

@@ -1,22 +1,22 @@
 //
 //  ImageGalleryContentViewController.swift
-//  GalleryVC
+//  Tusker
 //
 //  Created by Shadowfacts on 3/17/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
 //
 
 import UIKit
+import GalleryVC
+import Pachyderm
 import TuskerComponents
 @preconcurrency import VisionKit
 
-open class ImageGalleryContentViewController: UIViewController, GalleryContentViewController {
-    public let caption: String?
-    public var image: UIImage {
-        didSet {
-            imageView?.image = image
-        }
-    }
+class ImageGalleryContentViewController: UIViewController, GalleryContentViewController {
+    let url: URL
+    let caption: String?
+    let originalData: Data?
+    let image: UIImage
     let gifController: GIFController?
     
     private var imageView: GIFImageView!
@@ -27,8 +27,12 @@ open class ImageGalleryContentViewController: UIViewController, GalleryContentVi
     @available(iOS 16.0, macCatalyst 17.0, *)
     private var analysisInteraction: ImageAnalysisInteraction? { _analysisInteraction as? ImageAnalysisInteraction }
     
-    public init(image: UIImage, caption: String?, gifController: GIFController?) {
+    private var isGrayscale = false
+    
+    init(url: URL, caption: String?, originalData: Data?, image: UIImage, gifController: GIFController?) {
+        self.url = url
         self.caption = caption
+        self.originalData = originalData
         self.image = image
         self.gifController = gifController
         
@@ -37,14 +41,21 @@ open class ImageGalleryContentViewController: UIViewController, GalleryContentVi
         preferredContentSize = image.size
     }
     
-    public required init?(coder: NSCoder) {
+    required init?(coder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
     
-    public override func viewDidLoad() {
+    override func viewDidLoad() {
         super.viewDidLoad()
         
-        imageView = GIFImageView(image: image)
+        isGrayscale = Preferences.shared.grayscaleImages
+        let maybeGrayscaleImage = if isGrayscale {
+            ImageGrayscalifier.convert(url: url, image: image) ?? image
+        } else {
+            image
+        }
+        
+        imageView = GIFImageView(image: maybeGrayscaleImage)
         imageView.translatesAutoresizingMaskIntoConstraints = false
         imageView.contentMode = .scaleAspectFill
         imageView.isUserInteractionEnabled = true
@@ -75,9 +86,11 @@ open class ImageGalleryContentViewController: UIViewController, GalleryContentVi
                 }
             }
         }
+        
+        NotificationCenter.default.addObserver(self, selector: #selector(preferencesChanged), name: .preferencesChanged, object: nil)
     }
     
-    public override func viewWillAppear(_ animated: Bool) {
+    override func viewWillAppear(_ animated: Bool) {
         super.viewWillAppear(animated)
         
         if let gifController {
@@ -85,23 +98,37 @@ open class ImageGalleryContentViewController: UIViewController, GalleryContentVi
         }
     }
     
+    @objc private func preferencesChanged() {
+        if isGrayscale != Preferences.shared.grayscaleImages {
+            isGrayscale = Preferences.shared.grayscaleImages
+            let image = if isGrayscale {
+                ImageGrayscalifier.convert(url: url, image: image)
+            } else {
+                image
+            }
+            if let image {
+                imageView.image = image
+            }
+        }
+    }
+    
     // MARK: GalleryContentViewController
     
-    public weak var container: (any GalleryContentViewControllerContainer)?
+    weak var container: (any GalleryVC.GalleryContentViewControllerContainer)?
     
-    public var contentSize: CGSize {
+    var contentSize: CGSize {
         image.size
     }
     
-    open var activityItemsForSharing: [Any] {
-        return [image]
+    var activityItemsForSharing: [Any] {
+        if let data = originalData ?? image.pngData() {
+            return [ImageActivityItemSource(data: data, url: url, image: image)]
+        } else {
+            return []
+        }
     }
     
-    public var presentationAnimation: GalleryContentPresentationAnimation {
-        gifController != nil ? .fromSourceViewWithoutSnapshot : .fromSourceView
-    }
-    
-    public func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
+    func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
         if #available(iOS 16.0, macCatalyst 17.0, *),
            let analysisInteraction {
             analysisInteraction.setSupplementaryInterfaceHidden(!visible, animated: animated)
@@ -111,7 +138,7 @@ open class ImageGalleryContentViewController: UIViewController, GalleryContentVi
 
 @available(iOS 16.0, macCatalyst 17.0, *)
 extension ImageGalleryContentViewController: ImageAnalysisInteractionDelegate {
-    public func interaction(_ interaction: ImageAnalysisInteraction, shouldBeginAt point: CGPoint, for interactionType: ImageAnalysisInteraction.InteractionTypes) -> Bool {
+    func interaction(_ interaction: ImageAnalysisInteraction, shouldBeginAt point: CGPoint, for interactionType: ImageAnalysisInteraction.InteractionTypes) -> Bool {
         return container?.galleryControlsVisible ?? true
     }
 }

Tusker/Screens/Gallery/ImageGalleryDataSource.swift

@@ -34,7 +34,7 @@ class ImageGalleryDataSource: GalleryDataSource {
                 } else {
                     nil
                 }
-            return GrayscalableImageGalleryContentViewController(
+            return ImageGalleryContentViewController(
                 url: url,
                 caption: nil,
                 originalData: entry.data,
@@ -52,7 +52,7 @@ class ImageGalleryDataSource: GalleryDataSource {
                         } else {
                             nil
                         }
-                    return GrayscalableImageGalleryContentViewController(
+                    return ImageGalleryContentViewController(
                         url: self.url,
                         caption: nil,
                         originalData: data,

Tusker/Screens/Gallery/LoadingGalleryContentViewController.swift

@@ -7,42 +7,43 @@
 //
 
 import UIKit
+import GalleryVC
 
-public class LoadingGalleryContentViewController: UIViewController, GalleryContentViewController {
+class LoadingGalleryContentViewController: UIViewController, GalleryContentViewController {
     private let fallbackCaption: String?
     private let provider: () async -> (any GalleryContentViewController)?
     private var wrapped: (any GalleryContentViewController)!
     
-    public weak var container: GalleryContentViewControllerContainer?
+    weak var container: GalleryContentViewControllerContainer?
     
-    public var contentSize: CGSize {
+    var contentSize: CGSize {
         wrapped?.contentSize ?? .zero
     }
     
-    public var activityItemsForSharing: [Any] {
+    var activityItemsForSharing: [Any] {
         wrapped?.activityItemsForSharing ?? []
     }
     
-    public var caption: String? {
+    var caption: String? {
         wrapped?.caption ?? fallbackCaption
     }
     
-    public var presentationAnimation: GalleryContentPresentationAnimation {
-        wrapped?.presentationAnimation ?? .fade
+    var canAnimateFromSourceView: Bool {
+        wrapped?.canAnimateFromSourceView ?? true
     }
     
-    public init(caption: String?, provider: @escaping () async -> (any GalleryContentViewController)?) {
+    init(caption: String?, provider: @escaping () async -> (any GalleryContentViewController)?) {
         self.fallbackCaption = caption
         self.provider = provider
         
         super.init(nibName: nil, bundle: nil)
     }
     
-    public required init?(coder: NSCoder) {
+    required init?(coder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
     
-    public override func viewDidLoad() {
+    override func viewDidLoad() {
         super.viewDidLoad()
         
         container?.setGalleryContentLoading(true)
@@ -80,7 +81,7 @@ public class LoadingGalleryContentViewController: UIViewController, GalleryConte
         
         let label = UILabel()
         label.text = "Error Loading"
-        label.font = UIFont(descriptor: .preferredFontDescriptor(withTextStyle: .title1).withSymbolicTraits(.traitBold)!, size: 0)
+        label.font = .preferredFont(forTextStyle: .title1).withTraits(.traitBold)!
         label.textColor = .secondaryLabel
         label.adjustsFontForContentSizeCategory = true
         
@@ -101,15 +102,15 @@ public class LoadingGalleryContentViewController: UIViewController, GalleryConte
         ])
     }
     
-    public func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
+    func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
         wrapped?.setControlsVisible(visible, animated: animated, dueToUserInteraction: dueToUserInteraction)
     }
     
-    public func galleryContentDidAppear() {
+    func galleryContentDidAppear() {
         wrapped?.galleryContentDidAppear()
     }
     
-    public func galleryContentWillDisappear() {
+    func galleryContentWillDisappear() {
         wrapped?.galleryContentWillDisappear()
     }
     

Tusker/Screens/Gallery/StatusAttachmentsGalleryDataSource.swift

@@ -33,7 +33,7 @@ class StatusAttachmentsGalleryDataSource: GalleryDataSource {
         case .image:
             if let view = attachmentView(for: attachment),
                let image = view.attachmentImage {
-                return GrayscalableImageGalleryContentViewController(
+                return ImageGalleryContentViewController(
                     url: attachment.url,
                     caption: attachment.description,
                     originalData: view.originalData,
@@ -49,7 +49,7 @@ class StatusAttachmentsGalleryDataSource: GalleryDataSource {
                     } else {
                         nil
                     }
-                return GrayscalableImageGalleryContentViewController(
+                return ImageGalleryContentViewController(
                     url: attachment.url,
                     caption: attachment.description,
                     originalData: entry.data,
@@ -68,7 +68,7 @@ class StatusAttachmentsGalleryDataSource: GalleryDataSource {
                             } else {
                                 nil
                             }
-                        return GrayscalableImageGalleryContentViewController(
+                        return ImageGalleryContentViewController(
                             url: attachment.url,
                             caption: attachment.description,
                             originalData: data,
@@ -91,10 +91,10 @@ class StatusAttachmentsGalleryDataSource: GalleryDataSource {
                 }
             return GifvGalleryContentViewController(controller: controller, url: attachment.url, caption: attachment.description)
         case .video:
-            return GrayscalableVideoGalleryContentViewController(url: attachment.url, caption: attachment.description)
+            return VideoGalleryContentViewController(url: attachment.url, caption: attachment.description)
         case .audio:
             // TODO: use separate content VC with audio visualization?
-            return GrayscalableVideoGalleryContentViewController(url: attachment.url, caption: attachment.description)
+            return VideoGalleryContentViewController(url: attachment.url, caption: attachment.description)
         case .unknown:
             return LoadingGalleryContentViewController(caption: nil) {
                 do {

Tusker/Screens/Gallery/VideoControlsViewController.swift

@@ -1,6 +1,6 @@
 //
 //  VideoControlsViewController.swift
-//  GalleryVC
+//  Tusker
 //
 //  Created by Shadowfacts on 3/21/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
@@ -19,35 +19,27 @@ class VideoControlsViewController: UIViewController {
 
     private let player: AVPlayer
     
-    private lazy var muteButton: MuteButton = {
-        let button = MuteButton()
-        button.addTarget(self, action: #selector(muteButtonPressed), for: .touchUpInside)
-        button.setMuted(false, animated: false)
-        return button
-    }()
+    private lazy var muteButton = MuteButton().configure {
+        $0.addTarget(self, action: #selector(muteButtonPressed), for: .touchUpInside)
+        $0.setMuted(false, animated: false)
+    }
     
-    private let timestampLabel: UILabel = {
-        let label = UILabel()
-        label.text = "0:00"
-        label.font = UIFontMetrics(forTextStyle: .caption1).scaledFont(for: .monospacedDigitSystemFont(ofSize: 13, weight: .regular))
-        return label
-    }()
+    private let timestampLabel = UILabel().configure {
+        $0.text = "0:00"
+        $0.font = UIFontMetrics(forTextStyle: .caption1).scaledFont(for: .monospacedDigitSystemFont(ofSize: 13, weight: .regular))
+    }
     
-    private lazy var scrubbingControl: VideoScrubbingControl = {
-        let control = VideoScrubbingControl()
-        control.heightAnchor.constraint(equalToConstant: 44).isActive = true
-        control.addTarget(self, action: #selector(scrubbingStarted), for: .editingDidBegin)
-        control.addTarget(self, action: #selector(scrubbingChanged), for: .editingChanged)
-        control.addTarget(self, action: #selector(scrubbingEnded), for: .editingDidEnd)
-        return control
-    }()
+    private lazy var scrubbingControl = VideoScrubbingControl().configure {
+        $0.heightAnchor.constraint(equalToConstant: 44).isActive = true
+        $0.addTarget(self, action: #selector(scrubbingStarted), for: .editingDidBegin)
+        $0.addTarget(self, action: #selector(scrubbingChanged), for: .editingChanged)
+        $0.addTarget(self, action: #selector(scrubbingEnded), for: .editingDidEnd)
+    }
     
-    private let timeRemainingLabel: UILabel = {
-        let label = UILabel()
-        label.text = "-0:00"
-        label.font = UIFontMetrics(forTextStyle: .caption1).scaledFont(for: .monospacedDigitSystemFont(ofSize: 13, weight: .regular))
-        return label
-    }()
+    private let timeRemainingLabel = UILabel().configure {
+        $0.text = "-0:00"
+        $0.font = UIFontMetrics(forTextStyle: .caption1).scaledFont(for: .monospacedDigitSystemFont(ofSize: 13, weight: .regular))
+    }
     
     private lazy var optionsButton = MenuButton { [unowned self] in
         let imageName: String
@@ -78,19 +70,17 @@ class VideoControlsViewController: UIViewController {
         return UIMenu(children: [speedMenu])
     }
     
-    private lazy var hStack: UIStackView = {
-        let stack = UIStackView(arrangedSubviews: [
-            muteButton,
-            timestampLabel,
-            scrubbingControl,
-            timeRemainingLabel,
-            optionsButton,
-        ])
-        stack.axis = .horizontal
-        stack.spacing = 8
-        stack.alignment = .center
-        return stack
-    }()
+    private lazy var hStack = UIStackView(arrangedSubviews: [
+        muteButton,
+        timestampLabel,
+        scrubbingControl,
+        timeRemainingLabel,
+        optionsButton,
+    ]).configure {
+        $0.axis = .horizontal
+        $0.spacing = 8
+        $0.alignment = .center
+    }
 
     private var timestampObserverToken: Any?
     private var scrubberObserverToken: Any?

Tusker/Screens/Gallery/VideoGalleryContentViewController.swift

@@ -1,53 +1,68 @@
 //
 //  VideoGalleryContentViewController.swift
-//  GalleryVC
+//  Tusker
 //
 //  Created by Shadowfacts on 3/19/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
 //
 
 import UIKit
+import GalleryVC
 import AVFoundation
 import CoreImage
 
-open class VideoGalleryContentViewController: UIViewController, GalleryContentViewController {
-    public let url: URL
-    public let caption: String?
-    public private(set) var item: AVPlayerItem
-    public let player: AVPlayer
+class VideoGalleryContentViewController: UIViewController, GalleryContentViewController {
+    private let url: URL
+    let caption: String?
+    private var item: AVPlayerItem
+    let player: AVPlayer
+    
+    private var isGrayscale: Bool
     
     private var presentationSizeObservation: NSKeyValueObservation?
     private var statusObservation: NSKeyValueObservation?
     private var rateObservation: NSKeyValueObservation?
+    private var isFirstAppearance = true
     private var hideControlsWorkItem: DispatchWorkItem?
-    private var isShowingError = false
+    private var audioSessionToken: AudioSessionCoordinator.Token?
     
-    public init(url: URL, caption: String?) {
+    init(url: URL, caption: String?) {
         self.url = url
         self.caption = caption
         
+        self.isGrayscale = Preferences.shared.grayscaleImages
+        
         let asset = AVAsset(url: url)
-        self.item = Self.createItem(asset: asset)
+        self.item = VideoGalleryContentViewController.createItem(asset: asset)
         self.player = AVPlayer(playerItem: item)
         
         super.init(nibName: nil, bundle: nil)
     }
     
-    public required init?(coder: NSCoder) {
+    required init?(coder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
     
-    open class func createItem(asset: AVAsset) -> AVPlayerItem {
-        return AVPlayerItem(asset: asset)
+    private static func createItem(asset: AVAsset) -> AVPlayerItem {
+        let item = AVPlayerItem(asset: asset)
+        if Preferences.shared.grayscaleImages {
+            #if os(visionOS)
+            #warning("Use async AVVideoComposition CIFilter initializer")
+            #else
+            let filter = CIFilter(name: "CIColorMonochrome")!
+            filter.setValue(CIColor(red: 0.85, green: 0.85, blue: 0.85), forKey: "inputColor")
+            filter.setValue(1.0, forKey: "inputIntensity")
+
+            item.videoComposition = AVVideoComposition(asset: asset, applyingCIFiltersWithHandler: { request in
+                filter.setValue(request.sourceImage, forKey: "inputImage")
+                request.finish(with: filter.outputImage!, context: nil)
+            })
+            #endif
+        }
+        return item
     }
     
-    public func replaceCurrentItem(with item: AVPlayerItem) {
-        self.item = item
-        player.replaceCurrentItem(with: item)
-        updateItemObservations()
-    }
-    
-    public override func viewDidLoad() {
+    override func viewDidLoad() {
         super.viewDidLoad()
         
         container?.setGalleryContentLoading(true)
@@ -72,17 +87,19 @@ open class VideoGalleryContentViewController: UIViewController, GalleryContentVi
                 scheduleControlsHide()
             }
         })
+        
+        NotificationCenter.default.addObserver(self, selector: #selector(preferencesChanged), name: .preferencesChanged, object: nil)
     }
     
     private func updateItemObservations() {
         presentationSizeObservation = item.observe(\.presentationSize, changeHandler: { [unowned self] item, _ in
-            MainActor.assumeIsolated {
+            MainActor.runUnsafely {
                 self.preferredContentSize = item.presentationSize
                 self.container?.galleryContentChanged()
             }
         })
         statusObservation = item.observe(\.status, changeHandler: { [unowned self] item, _ in
-            MainActor.assumeIsolated {
+            MainActor.runUnsafely {
                 if item.status == .readyToPlay {
                     self.container?.setGalleryContentLoading(false)
                     self.statusObservation = nil
@@ -91,22 +108,19 @@ open class VideoGalleryContentViewController: UIViewController, GalleryContentVi
                     self.container?.setGalleryContentLoading(false)
                     self.showErrorView(error)
                     self.statusObservation = nil
-                    self.overlayVC.setVisible(false)
                 }
             }
         })
     }
     
     private func showErrorView(_ error: any Error) {
-        isShowingError = true
-        
         let image = UIImageView(image: UIImage(systemName: "exclamationmark.triangle.fill")!)
         image.tintColor = .secondaryLabel
         image.contentMode = .scaleAspectFit
         
         let label = UILabel()
         label.text = "Error Loading"
-        label.font = UIFont(descriptor: .preferredFontDescriptor(withTextStyle: .title1).withSymbolicTraits(.traitBold)!, size: 0)
+        label.font = .preferredFont(forTextStyle: .title1).withTraits(.traitBold)!
         label.textColor = .secondaryLabel
         label.adjustsFontForContentSizeCategory = true
         
@@ -134,9 +148,22 @@ open class VideoGalleryContentViewController: UIViewController, GalleryContentVi
         ])
     }
     
+    @objc private func preferencesChanged() {
+        if isGrayscale != Preferences.shared.grayscaleImages {
+            let isPlaying = player.rate > 0
+            isGrayscale = Preferences.shared.grayscaleImages
+            item = VideoGalleryContentViewController.createItem(asset: item.asset)
+            player.replaceCurrentItem(with: item)
+            updateItemObservations()
+            if isPlaying {
+                player.play()
+            }
+        }
+    }
+    
     private func scheduleControlsHide() {
         hideControlsWorkItem = DispatchWorkItem { [weak self] in
-            MainActor.assumeIsolated {
+            MainActor.runUnsafely {
                 guard let self,
                       let container = self.container,
                       container.galleryControlsVisible else {
@@ -150,32 +177,25 @@ open class VideoGalleryContentViewController: UIViewController, GalleryContentVi
     
     // MARK: GalleryContentViewController
     
-    public weak var container: (any GalleryVC.GalleryContentViewControllerContainer)?
+    weak var container: (any GalleryVC.GalleryContentViewControllerContainer)?
     
-    public var contentSize: CGSize {
+    var contentSize: CGSize {
         item.presentationSize
     }
     
-    open var activityItemsForSharing: [Any] {
-//        [VideoActivityItemSource(asset: item.asset, url: url)]
-        []
-    }
-    
-    public var presentationAnimation: GalleryContentPresentationAnimation {
-        isShowingError ? .fade : .fromSourceViewWithoutSnapshot
+    var activityItemsForSharing: [Any] {
+        [VideoActivityItemSource(asset: item.asset, url: url)]
     }
     
     private lazy var overlayVC = VideoOverlayViewController(player: player)
-    public var contentOverlayAccessoryViewController: UIViewController? {
+    var contentOverlayAccessoryViewController: UIViewController? {
         overlayVC
     }
     
-    public private(set) lazy var bottomControlsAccessoryViewController: UIViewController? = VideoControlsViewController(player: player)
+    private(set) lazy var bottomControlsAccessoryViewController: UIViewController? = VideoControlsViewController(player: player)
     
-    public func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
-        if !isShowingError {
-            overlayVC.setVisible(visible)
-        }
+    func setControlsVisible(_ visible: Bool, animated: Bool, dueToUserInteraction: Bool) {
+        overlayVC.setVisible(visible)
         
         if !visible {
             hideControlsWorkItem?.cancel()
@@ -185,11 +205,25 @@ open class VideoGalleryContentViewController: UIViewController, GalleryContentVi
         }
     }
     
-    open func galleryContentDidAppear() {
+    func galleryContentDidAppear() {
+        let wasFirstAppearance = isFirstAppearance
+        isFirstAppearance = false
+        
+        audioSessionToken = AudioSessionCoordinator.shared.beginPlayback(mode: .video) {
+            if wasFirstAppearance {
+                DispatchQueue.main.async {
+                    self.player.play()
+                }
+            }
+        }
     }
     
-    open func galleryContentWillDisappear() {
+    func galleryContentWillDisappear() {
         player.pause()
+        
+        if let audioSessionToken {
+            AudioSessionCoordinator.shared.endPlayback(token: audioSessionToken)
+        }
     }
     
 }
@@ -218,9 +252,9 @@ private class PlayerView: UIView {
         playerLayer.player = player
         playerLayer.videoGravity = .resizeAspect
         
-        presentationSizeObservation = item.observe(\.presentationSize, changeHandler: { [weak self] _, _ in
-            MainActor.assumeIsolated {
-                self?.invalidateIntrinsicContentSize()
+        presentationSizeObservation = item.observe(\.presentationSize, changeHandler: { [unowned self] _, _ in
+            MainActor.runUnsafely {
+                self.invalidateIntrinsicContentSize()
             }
         })
     }

Tusker/Screens/Gallery/VideoOverlayViewController.swift

@@ -1,6 +1,6 @@
 //
 //  VideoOverlayViewController.swift
-//  GalleryVC
+//  Tusker
 //
 //  Created by Shadowfacts on 3/26/24.
 //  Copyright © 2024 Shadowfacts. All rights reserved.
@@ -79,7 +79,7 @@ class VideoOverlayViewController: UIViewController {
         ])
         
         rateObservation = player.observe(\.rate, changeHandler: { player, _ in
-            MainActor.assumeIsolated {
+            MainActor.runUnsafely {
                 playPauseButton.image = player.rate > 0 ? VideoOverlayViewController.pauseImage : VideoOverlayViewController.playImage
             }
         })

Tusker/Screens/Main/BaseMainTabBarViewController.swift

@@ -151,22 +151,6 @@ class BaseMainTabBarViewController: UITabBarController, FastAccountSwitcherViewC
         return false
         #endif // !os(visionOS)
     }
-    
-    // MARK: Keyboard shortcuts
-    
-    override func target(forAction action: Selector, withSender sender: Any?) -> Any? {
-        // This is a silly workaround for when the sidebar is focused (and therefore first responder), which,
-        // unfortunately, is almost always. Because the content view controller then isn't in the responder chain,
-        // we manually delegate to the top view controller if possible.
-        if action == #selector(RefreshableViewController.refresh),
-           let selected = selectedViewController as? NavigationControllerProtocol,
-           let top = selected.topViewController as? RefreshableViewController {
-            return top
-        } else {
-            return super.target(forAction: action, withSender: sender)
-        }
-    }
-
 }
 
 extension BaseMainTabBarViewController: TuskerNavigationDelegate {

Tusker/Screens/Main/MainSplitViewController.swift

@@ -219,19 +219,6 @@ class MainSplitViewController: UISplitViewController {
     @objc func handleComposeKeyCommand() {
         compose(editing: nil)
     }
-    
-    override func target(forAction action: Selector, withSender sender: Any?) -> Any? {
-        // This is a silly workaround for when the sidebar is focused (and therefore first responder), which,
-        // unfortunately, is almost always. Because the content view controller then isn't in the responder chain,
-        // we manually delegate to the top view controller if possible.
-        if action == #selector(RefreshableViewController.refresh),
-           traitCollection.horizontalSizeClass == .regular,
-           let top = secondaryNavController.topViewController as? RefreshableViewController {
-            return top
-        } else {
-            return super.target(forAction: action, withSender: sender)
-        }
-    }
 
 }
 

Tusker/Screens/Main/NewMainTabBarViewController.swift

@@ -33,13 +33,6 @@ final class NewMainTabBarViewController: BaseMainTabBarViewController {
     private var isCompact: Bool?
     @Box fileprivate var myProfileCell: UIView?
     private var sidebarTapRecognizer: UITapGestureRecognizer?
-    
-    private lazy var fastAccountSwitcherIndicator: UIView = {
-        let indicator = FastAccountSwitcherIndicatorView()
-        // need to explicitly set the frame to get it vertically centered
-        indicator.frame = CGRect(origin: .zero, size: indicator.intrinsicContentSize)
-        return indicator
-    }()
 
     override func viewDidLoad() {
         super.viewDidLoad()
@@ -520,6 +513,13 @@ extension NewMainTabBarViewController: UITabBarControllerDelegate {
     }
 }
 
+private var fastAccountSwitcherIndicator: UIView = {
+    let indicator = FastAccountSwitcherIndicatorView()
+    // need to explicitly set the frame to get it vertically centered
+    indicator.frame = CGRect(origin: .zero, size: indicator.intrinsicContentSize)
+    return indicator
+}()
+
 @available(iOS 18.0, *)
 extension NewMainTabBarViewController: UITabBarController.Sidebar.Delegate {
     func tabBarController(_ tabBarController: UITabBarController, sidebarVisibilityWillChange sidebar: UITabBarController.Sidebar, animator: any UITabBarController.Sidebar.Animating) {

Tusker/Screens/Notifications/ActionNotificationGroupCollectionViewCell.swift

@@ -155,7 +155,7 @@ class ActionNotificationGroupCollectionViewCell: UICollectionViewListCell {
             fetchCustomEmojiImage?.1.cancel()
         case .emojiReaction(let emojiOrShortcode, let url):
             iconImageView.image = nil
-            if let url,
+            if let url = url.flatMap({ URL($0) }),
                fetchCustomEmojiImage?.0 != url {
                 fetchCustomEmojiImage?.1.cancel()
                 let task = Task {

Tusker/Screens/Notifications/NotificationLoadingViewController.swift

@@ -48,9 +48,7 @@ class NotificationLoadingViewController: UIViewController {
             do {
                 let (notification, _) = try await mastodonController.run(request)
                 await withCheckedContinuation { continuation in
-                    let container = mastodonController.persistentContainer
-                    let context = container.viewContext
-                    container.addAll(notifications: [notification], in: context) {
+                    mastodonController.persistentContainer.addAll(notifications: [notification]) {
                         continuation.resume()
                     }
                 }

Tusker/Screens/Notifications/NotificationsCollectionViewController.swift

@@ -740,7 +740,7 @@ extension NotificationsCollectionViewController: UICollectionViewDragDelegate {
             return cell.dragItemsForBeginning(session: session)
         case .poll, .update:
             let status = group.notifications.first!.status!
-            let provider = NSItemProvider(object: status.url! as NSURL)
+            let provider = NSItemProvider(object: URL(status.url!)! as NSURL)
             let activity = UserActivityManager.showConversationActivity(mainStatusID: status.id, accountID: mastodonController.accountInfo!.id)
             activity.displaysAuxiliaryScene = true
             provider.registerObject(activity, visibility: .all)

Tusker/Screens/Notifications/NotificationsPageViewController.swift

@@ -180,9 +180,3 @@ extension NotificationsPageViewController: StateRestorableViewController {
         return currentPage.userActivity(accountID: mastodonController.accountInfo!.id)
     }
 }
-
-extension NotificationsPageViewController: RefreshableViewController {
-    func refresh() {
-        (currentViewController as? RefreshableViewController)?.refresh()
-    }
-}

Tusker/Screens/Preferences/AdvancedPrefsView.swift

@@ -18,7 +18,6 @@ struct AdvancedPrefsView : View {
     @State private var mastodonCacheSize: Int64 = 0
     @State private var cloudKitStatus: CKAccountStatus?
     @State private var isShowingFeatureFlagAlert = false
-    @State private var featureFlagName = ""
     
     var body: some View {
         List {
@@ -32,23 +31,9 @@ struct AdvancedPrefsView : View {
         .listStyle(.insetGrouped)
         .appGroupedListBackground(container: PreferencesNavigationController.self)
         .onTapGesture(count: 3) {
-            featureFlagName = ""
             isShowingFeatureFlagAlert = true
         }
-        .alert("Enable Feature Flag", isPresented: $isShowingFeatureFlagAlert) {
-            TextField("Flag Name", text: $featureFlagName)
-                .textInputAutocapitalization(.never)
-                .autocorrectionDisabled()
-            
-            Button("Cancel", role: .cancel) {}
-            Button("Enable") {
-                if let flag = FeatureFlag(rawValue: featureFlagName) {
-                    preferences.enabledFeatureFlags.insert(flag)
-                }
-            }
-        } message: {
-            Text("Warning: Feature flags are intended for development and debugging use only. They are experimental and subject to change at any time.")
-        }
+        .modifier(FeatureFlagAlertModifier(showing: $isShowingFeatureFlagAlert))
         .navigationBarTitle(Text("Advanced"))
     }
     
@@ -252,6 +237,74 @@ extension StatusContentType {
     }
 }
 
+private struct FeatureFlagAlertModifier: ViewModifier {
+    @Binding var showing: Bool
+    @ObservedObject private var preferences = Preferences.shared
+    @State private var featureFlagName = ""
+    
+    func body(content: Content) -> some View {
+        if #available(iOS 16.0, *) {
+            content
+                .onChange(of: showing) {
+                    if $0 {
+                        featureFlagName = ""
+                    }
+                }
+                .alert("Enable Feature Flag", isPresented: $showing) {
+                    textField
+                    Button("Cancel", role: .cancel) {}
+                    Button("Enable", action: enableFlag)
+                } message: {
+                    warning
+                }
+        } else {
+            content
+                .sheet(isPresented: $showing) {
+                    NavigationView {
+                        List {
+                            Section {
+                                textField
+                            } footer: {
+                                warning
+                            }
+                        }
+                        .navigationTitle("Enable Feature Flag")
+                        .navigationBarTitleDisplayMode(.inline)
+                        .listStyle(.insetGrouped)
+                        .toolbar {
+                            ToolbarItem(placement: .cancellationAction) {
+                                Button("Cancel") {
+                                    showing = false
+                                }
+                            }
+                            ToolbarItem(placement: .confirmationAction) {
+                                Button("Enable", action: self.enableFlag)
+                            }
+                        }
+                    }
+                    .navigationViewStyle(.stack)
+                }
+        }
+    }
+    
+    private var textField: some View {
+        TextField("Flag Name", text: $featureFlagName)
+            .textInputAutocapitalization(.never)
+            .autocorrectionDisabled()
+    }
+    
+    private var warning: Text {
+        Text("Warning: Feature flags are intended for development and debugging use only. They are experimental and subject to change at any time.")
+    }
+    
+    private func enableFlag() {
+        if let flag = FeatureFlag(rawValue: featureFlagName) {
+            preferences.enabledFeatureFlags.insert(flag)
+            showing = false
+        }
+    }
+}
+
 #if DEBUG
 struct AdvancedPrefsView_Previews : PreviewProvider {
     static var previews: some View {

Tusker/Screens/Preferences/Appearance/MockStatusView.swift

@@ -8,6 +8,7 @@
 
 import SwiftUI
 import Pachyderm
+import WebURL
 
 struct MockStatusView: View {
     @ObservedObject private var preferences = Preferences.shared
@@ -135,8 +136,8 @@ private struct MockStatusCardView: UIViewRepresentable {
         let view = StatusCardView()
         view.isUserInteractionEnabled = false
         let card = StatusCardView.CardData(
-            url: URL(string: "https://vaccor.space/tusker")!,
-            image: URL(string: "https://vaccor.space/tusker/img/icon.png")!,
+            url: WebURL("https://vaccor.space/tusker")!,
+            image: WebURL("https://vaccor.space/tusker/img/icon.png")!,
             title: "Tusker",
             description: "Tusker is an iOS app for Mastodon"
         )

Tusker/Screens/Preferences/PrefsAccountView.swift

@@ -8,6 +8,7 @@
 
 import SwiftUI
 import UserAccounts
+import WebURL
 
 struct PrefsAccountView: View {
     let account: UserAccountInfo
@@ -18,7 +19,12 @@ struct PrefsAccountView: View {
             VStack(alignment: .prefsAvatar) {
                 Text(verbatim: account.username)
                     .foregroundColor(.primary)
-                Text(verbatim: account.instanceURL.host(percentEncoded: false)!)
+                let instance = if let domain = WebURL.Domain(account.instanceURL.host!) {
+                    domain.render(.uncheckedUnicodeString)
+                } else {
+                    account.instanceURL.host!
+                }
+                Text(verbatim: instance)
                     .font(.caption)
                     .foregroundColor(.primary)
             }

Tusker/Screens/Profile/ProfileViewController.swift

@@ -393,9 +393,3 @@ extension ProfileViewController: StatusBarTappableViewController {
         return currentViewController.handleStatusBarTapped(xPosition: xPosition)
     }
 }
-
-extension ProfileViewController: RefreshableViewController {
-    func refresh() {
-        currentViewController.refresh()
-    }
-}

Tusker/Screens/Search/SearchResultsViewController.swift

@@ -9,6 +9,7 @@
 import UIKit
 import Combine
 import Pachyderm
+import WebURLFoundationExtras
 
 fileprivate let accountCell = "accountCell"
 fileprivate let statusCell = "statusCell"
@@ -537,7 +538,7 @@ extension SearchResultsViewController: UICollectionViewDragDelegate {
             url = account.url
             activity = UserActivityManager.showProfileActivity(id: id, accountID: accountInfo.id)
         case .hashtag(let tag):
-            url = tag.url
+            url = URL(tag.url)!
             activity = UserActivityManager.showTimelineActivity(timeline: .tag(hashtag: tag.name), accountID: accountInfo.id)!
         case .status(let id, _):
             guard let status = mastodonController.persistentContainer.status(for: id),

Tusker/Screens/Status Action Account List/StatusActionAccountListViewController.swift

@@ -8,6 +8,7 @@
 
 import UIKit
 import Pachyderm
+import WebURL
 
 class StatusActionAccountListViewController: UIViewController {
     
@@ -182,7 +183,7 @@ extension StatusActionAccountListViewController {
     enum ActionType {
         case favorite
         case reblog
-        case emojiReaction(String, URL?)
+        case emojiReaction(String, WebURL?)
         
         init?(_ groupKind: NotificationGroup.Kind) {
             switch groupKind {

Tusker/Screens/Timeline/InstanceTimelineViewController.swift

@@ -77,25 +77,11 @@ class InstanceTimelineViewController: TimelineViewController {
         cell.updateUI(statusID: id, state: state, filterResult: filterResult, precomputedContent: precomputedContent)
     }
     
-    override func collectionView(_ collectionView: UICollectionView, shouldSelectItemAt indexPath: IndexPath) -> Bool {
-        guard browsingEnabled else {
-            return false
-        }
-        return super.collectionView(collectionView, shouldSelectItemAt: indexPath)
-    }
-    
     override func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
         guard browsingEnabled else { return }
         super.collectionView(collectionView, didSelectItemAt: indexPath)
     }
     
-    override func collectionView(_ collectionView: UICollectionView, contextMenuConfigurationForItemAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration? {
-        guard browsingEnabled else {
-            return nil
-        }
-        return super.collectionView(collectionView, contextMenuConfigurationForItemAt: indexPath, point: point)
-    }
-    
     // MARK: Timeline
     
     override func handleLoadAllError(_ error: Swift.Error) async {

Tusker/Screens/Timeline/TimelinesPageViewController.swift

@@ -212,9 +212,3 @@ extension TimelinesPageViewController: StateRestorableViewController {
         return (currentViewController as? TimelineViewController)?.stateRestorationActivity()
     }
 }
-
-extension TimelinesPageViewController: RefreshableViewController {
-    func refresh() {
-        (currentViewController as? RefreshableViewController)?.refresh()
-    }
-}

Tusker/Screens/Utilities/Previewing.swift

@@ -9,6 +9,7 @@
 import UIKit
 import SafariServices
 import Pachyderm
+import WebURLFoundationExtras
 import SwiftUI
 
 @MainActor
@@ -153,7 +154,12 @@ extension MenuActionProvider {
             }
         }
         
-        let shareSection = actionsForURL(hashtag.url, source: source)
+        let shareSection: [UIMenuElement]
+        if let url = URL(hashtag.url) {
+            shareSection = actionsForURL(url, source: source)
+        } else {
+            shareSection = []
+        }
         
         return [
             UIMenu(title: "", image: nil, identifier: nil, options: [.displayInline], children: shareSection),
@@ -369,11 +375,14 @@ extension MenuActionProvider {
     }
     
     func actionsForTrendingLink(card: Card, source: PopoverSource) -> [UIMenuElement] {
+        guard let url = URL(card.url) else {
+            return []
+        }
         return [
-            openInSafariAction(url: card.url),
+            openInSafariAction(url: url),
             createAction(identifier: "share", title: "Share…", systemImageName: "square.and.arrow.up", handler: { [weak self] (_) in
                 guard let self else { return }
-                self.navigationDelegate?.showMoreOptions(forURL: card.url, source: source)
+                self.navigationDelegate?.showMoreOptions(forURL: url, source: source)
             }),
             createAction(identifier: "postlink", title: "Post this Link", systemImageName: "square.and.pencil", handler: { [weak self] _ in
                 guard let self = self else { return }
@@ -384,7 +393,7 @@ extension MenuActionProvider {
                     text += title
                     text += ":\n"
                 }
-                text += card.url.absoluteString
+                text += url.absoluteString
                 
                 let draft = self.mastodonController!.createDraft(text: text)
                 self.navigationDelegate?.compose(editing: draft)

Tusker/Views/AccountDisplayAndUserNameLabel.swift

@@ -30,9 +30,7 @@ class AccountDisplayAndUserNameLabel: EmojiLabel {
     
     private func makeAttributedText(state: State) -> NSAttributedString {
         let s = NSMutableAttributedString()
-        // U+2068 FIRST-STRONG ISOLATE and U+2069 POP DIRECTIONAL ISOLATE
-        // to prevent bidi text in the display name influencing the username
-        s.append(NSAttributedString(string: "\u{2068}\(state.displayName)\u{2069}", attributes: [
+        s.append(NSAttributedString(string: state.displayName, attributes: [
             .font: UIFont(descriptor: baseFont.addingAttributes([
                 .traits: [
                     UIFontDescriptor.TraitKey.weight: UIFont.Weight.semibold.rawValue,

Tusker/Views/AccountDisplayNameView.swift

@@ -8,6 +8,7 @@
 
 import SwiftUI
 import Pachyderm
+import WebURLFoundationExtras
 import os
 
 private let emojiRegex = try! NSRegularExpression(pattern: ":(\\w+):", options: [])
@@ -53,7 +54,7 @@ struct AccountDisplayNameView: View {
             }
             
             group.enter()
-            let request = ImageCache.emojis.get(emoji.url) { (_, image) in
+            let request = ImageCache.emojis.get(URL(emoji.url)!) { (_, image) in
                 defer { group.leave() }
                 guard let image = image else { return }
                 

Tusker/Views/Attachments/AttachmentView.swift

@@ -402,7 +402,7 @@ class AttachmentView: GIFImageView {
             makeBadgeView(text: "ALT")
         }
         if badges.contains(.noAlt) {
-            makeBadgeView(text: "NO ALT")
+            makeBadgeView(text: "No ALT")
         }
         
         let first = stack.arrangedSubviews.first!
@@ -467,12 +467,12 @@ extension AttachmentView: UIContextMenuInteractionDelegate {
         return UIContextMenuConfiguration { [unowned self] () -> UIViewController? in
             if self.attachment.kind == .image,
                let image {
-                return GrayscalableImageGalleryContentViewController(url: self.attachment.url, caption: nil, originalData: nil, image: image, gifController: self.gifController)
+                return ImageGalleryContentViewController(url: self.attachment.url, caption: nil, originalData: nil, image: image, gifController: self.gifController)
             } else if self.attachment.kind == .gifv,
                       let gifvView {
                 return GifvGalleryContentViewController(controller: gifvView.controller, url: self.attachment.url, caption: nil)
             } else if self.attachment.kind == .video || self.attachment.kind == .audio {
-                let vc = GrayscalableVideoGalleryContentViewController(url: self.attachment.url, caption: nil)
+                let vc = VideoGalleryContentViewController(url: self.attachment.url, caption: nil)
                 vc.player.isMuted = true
                 return vc
             } else {