Pachyderm/Model/Status.swift

@@ -80,28 +80,28 @@ public final class Status: /*StatusProtocol,*/ Decodable {
         return Request<Status>(method: .post, path: "/api/v1/statuses/\(statusID)/unfavourite")
     }
     
-    public static func pin(_ statusID: String) -> Request<Status> {
+    public static func pin(_ status: Status) -> Request<Status> {
-        return Request<Status>(method: .post, path: "/api/v1/statuses/\(statusID)/pin")
+        return Request<Status>(method: .post, path: "/api/v1/statuses/\(status.id)/pin")
     }
     
-    public static func unpin(_ statusID: String) -> Request<Status> {
+    public static func unpin(_ status: Status) -> Request<Status> {
-        return Request<Status>(method: .post, path: "/api/v1/statuses/\(statusID)/unpin")
+        return Request<Status>(method: .post, path: "/api/v1/statuses/\(status.id)/unpin")
     }
     
-    public static func bookmark(_ statusID: String) -> Request<Status> {
+    public static func bookmark(_ status: Status) -> Request<Status> {
-        return Request<Status>(method: .post, path: "/api/v1/statuses/\(statusID)/bookmark")
+        return Request<Status>(method: .post, path: "/api/v1/statuses/\(status.id)/bookmark")
     }
     
     public static func unbookmark(_ statusID: String) -> Request<Status> {
         return Request<Status>(method: .post, path: "/api/v1/statuses/\(statusID)/unbookmark")
     }
     
-    public static func muteConversation(_ statusID: String) -> Request<Status> {
+    public static func muteConversation(_ status: Status) -> Request<Status> {
-        return Request<Status>(method: .post, path: "/api/v1/statuses/\(statusID)/mute")
+        return Request<Status>(method: .post, path: "/api/v1/statuses/\(status.id)/mute")
     }
     
-    public static func unmuteConversation(_ statusID: String) -> Request<Status> {
+    public static func unmuteConversation(_ status: Status) -> Request<Status> {
-        return Request<Status>(method: .post, path: "/api/v1/statuses/\(statusID)/unmute")
+        return Request<Status>(method: .post, path: "/api/v1/statuses/\(status.id)/unmute")
     }
     
     private enum CodingKeys: String, CodingKey {

Tusker.xcodeproj/project.pbxproj

@@ -168,10 +168,6 @@
 		D67C57B421E2910700C3118B /* ComposeStatusReplyView.swift in Sources */ = {isa = PBXBuildFile; fileRef = D67C57B321E2910700C3118B /* ComposeStatusReplyView.swift */; };
 		D68015402401A6BA00D6103B /* ComposingPrefsView.swift in Sources */ = {isa = PBXBuildFile; fileRef = D680153F2401A6BA00D6103B /* ComposingPrefsView.swift */; };
 		D68015422401A74600D6103B /* MediaPrefsView.swift in Sources */ = {isa = PBXBuildFile; fileRef = D68015412401A74600D6103B /* MediaPrefsView.swift */; };
-		D681E4D3246E2AFF0053414F /* MuteConversationActivity.swift in Sources */ = {isa = PBXBuildFile; fileRef = D681E4D2246E2AFF0053414F /* MuteConversationActivity.swift */; };
-		D681E4D5246E2BC30053414F /* UnmuteConversationActivity.swift in Sources */ = {isa = PBXBuildFile; fileRef = D681E4D4246E2BC30053414F /* UnmuteConversationActivity.swift */; };
-		D681E4D7246E32290053414F /* StatusActivityItemSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D681E4D6246E32290053414F /* StatusActivityItemSource.swift */; };
-		D681E4D9246E346E0053414F /* AccountActivityItemSource.swift in Sources */ = {isa = PBXBuildFile; fileRef = D681E4D8246E346E0053414F /* AccountActivityItemSource.swift */; };
 		D68232F72464F4FD00325FB8 /* ComposeDrawingViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D68232F62464F4FD00325FB8 /* ComposeDrawingViewController.swift */; };
 		D68FEC4F232C5BC300C84F23 /* SegmentedPageViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D68FEC4E232C5BC300C84F23 /* SegmentedPageViewController.swift */; };
 		D693DE5723FE1A6A0061E07D /* EnhancedNavigationViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = D693DE5623FE1A6A0061E07D /* EnhancedNavigationViewController.swift */; };
@@ -471,10 +467,6 @@
 		D67C57B321E2910700C3118B /* ComposeStatusReplyView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ComposeStatusReplyView.swift; sourceTree = "<group>"; };
 		D680153F2401A6BA00D6103B /* ComposingPrefsView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ComposingPrefsView.swift; sourceTree = "<group>"; };
 		D68015412401A74600D6103B /* MediaPrefsView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MediaPrefsView.swift; sourceTree = "<group>"; };
-		D681E4D2246E2AFF0053414F /* MuteConversationActivity.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MuteConversationActivity.swift; sourceTree = "<group>"; };
-		D681E4D4246E2BC30053414F /* UnmuteConversationActivity.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = UnmuteConversationActivity.swift; sourceTree = "<group>"; };
-		D681E4D6246E32290053414F /* StatusActivityItemSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = StatusActivityItemSource.swift; sourceTree = "<group>"; };
-		D681E4D8246E346E0053414F /* AccountActivityItemSource.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = AccountActivityItemSource.swift; sourceTree = "<group>"; };
 		D68232F62464F4FD00325FB8 /* ComposeDrawingViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ComposeDrawingViewController.swift; sourceTree = "<group>"; };
 		D68FEC4E232C5BC300C84F23 /* SegmentedPageViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SegmentedPageViewController.swift; sourceTree = "<group>"; };
 		D693DE5623FE1A6A0061E07D /* EnhancedNavigationViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = EnhancedNavigationViewController.swift; sourceTree = "<group>"; };
@@ -781,8 +773,6 @@
 				D627943823A553B600D38C68 /* UnbookmarkStatusActivity.swift */,
 				D64BC18723C1640A000D0238 /* PinStatusActivity.swift */,
 				D64BC18923C16487000D0238 /* UnpinStatusActivity.swift */,
-				D681E4D2246E2AFF0053414F /* MuteConversationActivity.swift */,
-				D681E4D4246E2BC30053414F /* UnmuteConversationActivity.swift */,
 			);
 			path = "Status Activities";
 			sourceTree = "<group>";
@@ -1141,8 +1131,6 @@
 		D6AEBB3F2321640F00E5038B /* Activities */ = {
 			isa = PBXGroup;
 			children = (
-				D681E4D6246E32290053414F /* StatusActivityItemSource.swift */,
-				D681E4D8246E346E0053414F /* AccountActivityItemSource.swift */,
 				D6AEBB3D2321638100E5038B /* UIActivity+Types.swift */,
 				D6AEBB422321685E00E5038B /* OpenInSafariActivity.swift */,
 				D64BC19123C271D9000D0238 /* MastodonActivity.swift */,
@@ -1717,7 +1705,6 @@
 				D6674AEA23341F7600E8DF94 /* AppShortcutItems.swift in Sources */,
 				D646C956213B365700269FB5 /* LargeImageExpandAnimationController.swift in Sources */,
 				D667E5F82135C3040057A976 /* Mastodon+Equatable.swift in Sources */,
-				D681E4D5246E2BC30053414F /* UnmuteConversationActivity.swift in Sources */,
 				D67C57B421E2910700C3118B /* ComposeStatusReplyView.swift in Sources */,
 				D6B053A623BD2D0C00A066FA /* AssetCollectionViewController.swift in Sources */,
 				04DACE8E212CC7CC009840C4 /* ImageCache.swift in Sources */,
@@ -1757,7 +1744,6 @@
 				D627943E23A564D400D38C68 /* ExploreViewController.swift in Sources */,
 				D6B053AB23BD2F1400A066FA /* AssetCollectionViewCell.swift in Sources */,
 				D6434EB3215B1856001A919A /* XCBRequest.swift in Sources */,
-				D681E4D3246E2AFF0053414F /* MuteConversationActivity.swift in Sources */,
 				D6969EA0240C8384002843CE /* EmojiLabel.swift in Sources */,
 				D64BC18623C1253A000D0238 /* AssetPreviewViewController.swift in Sources */,
 				D663626221360B1900C9CBA2 /* Preferences.swift in Sources */,
@@ -1787,7 +1773,6 @@
 				D66362752137068A00C9CBA2 /* Visibility+Helpers.swift in Sources */,
 				D6DFC6A0242C4CCC00ACC392 /* WeakArray.swift in Sources */,
 				D6C693FC2162FE6F007D6A6D /* LoadingViewController.swift in Sources */,
-				D681E4D7246E32290053414F /* StatusActivityItemSource.swift in Sources */,
 				D646C95A213B5D0500269FB5 /* LargeImageInteractionController.swift in Sources */,
 				D6A3BC7C232195C600FD64D5 /* ActionNotificationGroupTableViewCell.swift in Sources */,
 				D6F953EC212519E700CF0F2B /* TimelineTableViewController.swift in Sources */,
@@ -1807,7 +1792,6 @@
 				0427037C22B316B9000D31B6 /* SilentActionPrefs.swift in Sources */,
 				D6AEBB3E2321638100E5038B /* UIActivity+Types.swift in Sources */,
 				D61AC1D5232E9FA600C54D2D /* InstanceSelectorTableViewController.swift in Sources */,
-				D681E4D9246E346E0053414F /* AccountActivityItemSource.swift in Sources */,
 				D626493F23C101C500612E6E /* AlbumAssetCollectionViewController.swift in Sources */,
 				D68015422401A74600D6103B /* MediaPrefsView.swift in Sources */,
 				D6757A7E2157E02600721E32 /* XCBRequestSpec.swift in Sources */,

Tusker/Activities/Account Activities/AccountActivity.swift

@@ -7,6 +7,7 @@
 //
 
 import UIKit
+import Pachyderm
 
 class AccountActivity: MastodonActivity {
 
@@ -14,17 +15,17 @@ class AccountActivity: MastodonActivity {
         return .action
     }
     
-    var account: AccountMO?
+    var account: Account?
     
     override func canPerform(withActivityItems activityItems: [Any]) -> Bool {
-        for case is AccountMO in activityItems {
+        for case is Account in activityItems {
             return true
         }
         return false
     }
     
     override func prepare(withActivityItems activityItems: [Any]) {
-        for case let account as AccountMO in activityItems {
+        for case let account as Account in activityItems {
             self.account = account
             return
         }

Tusker/Activities/AccountActivityItemSource.swift

@@ -1,39 +0,0 @@
-//
-//  AccountActivityItemSource.swift
-//  Tusker
-//
-//  Created by Shadowfacts on 5/14/20.
-//  Copyright © 2020 Shadowfacts. All rights reserved.
-//
-
-import UIKit
-import LinkPresentation
-
-class AccountActivityItemSource: NSObject, UIActivityItemSource {
-    let account: AccountMO
-    
-    init(_ account: AccountMO) {
-        self.account = account
-    }
-    
-    func activityViewControllerPlaceholderItem(_ activityViewController: UIActivityViewController) -> Any {
-        return account
-    }
-    
-    func activityViewController(_ activityViewController: UIActivityViewController, itemForActivityType activityType: UIActivity.ActivityType?) -> Any? {
-        return account
-    }
-    
-    func activityViewControllerLinkMetadata(_ activityViewController: UIActivityViewController) -> LPLinkMetadata? {
-        let metadata = LPLinkMetadata()
-        metadata.originalURL = account.url
-        metadata.url = account.url
-        metadata.title = "\(account.displayName) (@\(account.username)@\(account.url.host!)"
-        if let data = ImageCache.avatars.get(account.avatar),
-            let image = UIImage(data: data) {
-            metadata.iconProvider = NSItemProvider(object: image)
-        }
-        return metadata
-    }
-    
-}

Tusker/Activities/Status Activities/BookmarkStatusActivity.swift

@@ -26,7 +26,7 @@ class BookmarkStatusActivity: StatusActivity {
     override func perform() {
         guard let status = status else { return }
         
-        let request = Status.bookmark(status.id)
+        let request = Status.bookmark(status)
         mastodonController.run(request) { (response) in
             if case let .success(status, _) = response {
                 self.mastodonController.persistentContainer.addOrUpdate(status: status, incrementReferenceCount: false)

Tusker/Activities/Status Activities/MuteConversationActivity.swift

@@ -1,40 +0,0 @@
-//
-//  MuteConversationActivity.swift
-//  Tusker
-//
-//  Created by Shadowfacts on 5/14/20.
-//  Copyright © 2020 Shadowfacts. All rights reserved.
-//
-
-import UIKit
-import Pachyderm
-
-class MuteConversationActivity: StatusActivity {
-    override var activityType: UIActivity.ActivityType? {
-        return .muteConversation
-    }
-    
-    override var activityTitle: String? {
-        return NSLocalizedString("Mute Conversation", comment: "mute conversation activity title")
-    }
-    
-    override var activityImage: UIImage? {
-        return UIImage(systemName: "speaker.slash")
-    }
-    
-    override func perform() {
-        guard let status = status else { return }
-        
-        let request = Status.muteConversation(status.id)
-        mastodonController.run(request) { (response) in
-            if case let .success(status, _) = response {
-                self.mastodonController.persistentContainer.addOrUpdate(status: status, incrementReferenceCount: false)
-            } else {
-                // todo: display error message
-                UINotificationFeedbackGenerator().notificationOccurred(.error)
-                fatalError()
-            }
-        }
-    }
-
-}

Tusker/Activities/Status Activities/PinStatusActivity.swift

@@ -25,7 +25,7 @@ class PinStatusActivity: StatusActivity {
     override func perform() {
         guard let status = status else { return }
         
-        let request = Status.pin(status.id)
+        let request = Status.pin(status)
         mastodonController.run(request) { (response) in
             if case let .success(status, _) = response {
                 self.mastodonController.persistentContainer.addOrUpdate(status: status, incrementReferenceCount: false)

Tusker/Activities/Status Activities/StatusActivity.swift

@@ -7,6 +7,7 @@
 //
 
 import UIKit
+import Pachyderm
 
 class StatusActivity: MastodonActivity {
 
@@ -14,17 +15,17 @@ class StatusActivity: MastodonActivity {
         return .action
     }
     
-    var status: StatusMO?
+    var status: Status?
     
     override func canPerform(withActivityItems activityItems: [Any]) -> Bool {
-        for case is StatusMO in activityItems {
+        for case is Status in activityItems {
             return true
         }
         return false
     }
     
     override func prepare(withActivityItems activityItems: [Any]) {
-        for case let status as StatusMO in activityItems {
+        for case let status as Status in activityItems {
             self.status = status
             return
         }

Tusker/Activities/Status Activities/UnmuteConversationActivity.swift

@@ -1,40 +0,0 @@
-//
-//  UnmuteConversationActivity.swift
-//  Tusker
-//
-//  Created by Shadowfacts on 5/14/20.
-//  Copyright © 2020 Shadowfacts. All rights reserved.
-//
-
-import UIKit
-import Pachyderm
-
-class UnmuteConversationActivity: StatusActivity {
-    override var activityType: UIActivity.ActivityType? {
-        return .unmuteConversation
-    }
-    
-    override var activityTitle: String? {
-        return NSLocalizedString("Unmute Conversation", comment: "unmute conversation activity title")
-    }
-    
-    override var activityImage: UIImage? {
-        return UIImage(systemName: "speaker")
-    }
-    
-    override func perform() {
-        guard let status = status else { return }
-        
-        let request = Status.unmuteConversation(status.id)
-        mastodonController.run(request) { (response) in
-            if case let .success(status, _) = response {
-                self.mastodonController.persistentContainer.addOrUpdate(status: status, incrementReferenceCount: false)
-            } else {
-                // todo: display error message
-                UINotificationFeedbackGenerator().notificationOccurred(.error)
-                fatalError()
-            }
-        }
-    }
-
-}

Tusker/Activities/Status Activities/UnpinStatusActivity.swift

@@ -25,7 +25,7 @@ class UnpinStatusActivity: StatusActivity {
     override func perform() {
         guard let status = status else { return }
         
-        let request = Status.unpin(status.id)
+        let request = Status.unpin(status)
         mastodonController.run(request) { (response) in
             if case let .success(status, _) = response {
                 self.mastodonController.persistentContainer.addOrUpdate(status: status, incrementReferenceCount: false)

Tusker/Activities/StatusActivityItemSource.swift

@@ -1,42 +0,0 @@
-//
-//  StatusActivityItemSource.swift
-//  Tusker
-//
-//  Created by Shadowfacts on 5/14/20.
-//  Copyright © 2020 Shadowfacts. All rights reserved.
-//
-
-import UIKit
-import LinkPresentation
-import SwiftSoup
-
-class StatusActivityItemSource: NSObject, UIActivityItemSource {
-    let status: StatusMO
-    
-    init(_ status: StatusMO) {
-        self.status = status
-    }
-    
-    func activityViewControllerPlaceholderItem(_ activityViewController: UIActivityViewController) -> Any {
-        return status
-    }
-    
-    func activityViewController(_ activityViewController: UIActivityViewController, itemForActivityType activityType: UIActivity.ActivityType?) -> Any? {
-        return status
-    }
-    
-    func activityViewControllerLinkMetadata(_ activityViewController: UIActivityViewController) -> LPLinkMetadata? {
-        let metadata = LPLinkMetadata()
-        metadata.originalURL = status.url!
-        metadata.url = status.url!
-        let doc = try! SwiftSoup.parse(status.content)
-        let content = try! doc.text()
-        metadata.title = "\(status.account.displayName): \"\(content)\""
-        if let data = ImageCache.avatars.get(status.account.avatar),
-            let image = UIImage(data: data) {
-            metadata.iconProvider = NSItemProvider(object: image)
-        }
-        return metadata
-    }
-
-}

Tusker/Activities/UIActivity+Types.swift

@@ -22,7 +22,5 @@ extension UIActivity.ActivityType {
     static let unbookmarkStatus = UIActivity.ActivityType("\(Bundle.main.bundleIdentifier!).unbookmark_status")
     static let pinStatus = UIActivity.ActivityType("\(Bundle.main.bundleIdentifier!).pin_status")
     static let unpinStatus = UIActivity.ActivityType("\(Bundle.main.bundleIdentifier!).unpin_status")
-    static let muteConversation = UIActivity.ActivityType("\(Bundle.main.bundleIdentifier!).mute_conversation")
-    static let unmuteConversation = UIActivity.ActivityType("\(Bundle.main.bundleIdentifier!).unmute_conversation")
 
 }

Tusker/Screens/Profile/ProfileTableViewController.swift

@@ -297,7 +297,7 @@ extension ProfileTableViewController: ProfileHeaderTableViewCellDelegate {
             }
             
             DispatchQueue.main.async {
-                let activityController = UIActivityViewController(activityItems: [account.url, AccountActivityItemSource(account)], applicationActivities: customActivities)
+                let activityController = UIActivityViewController(activityItems: [account.url, account], applicationActivities: customActivities)
                 activityController.completionWithItemsHandler = OpenInSafariActivity.completionHandler(viewController: self, url: account.url)
                 activityController.popoverPresentationController?.sourceView = cell.moreButtonVisualEffectView
                 self.present(activityController, animated: true)

Tusker/TuskerNavigationDelegate.swift

@@ -205,33 +205,24 @@ extension TuskerNavigationDelegate where Self: UIViewController {
     private func moreOptions(forStatus statusID: String) -> UIActivityViewController {
         guard let status = apiController.persistentContainer.status(for: statusID) else { fatalError("Missing cached status \(statusID)") }
         guard let url = status.url else { fatalError("Missing url for status \(statusID)") }
-        
+        var customActivites: [UIActivity] = [OpenInSafariActivity()]
-        var customActivites: [UIActivity] = [
+
-            OpenInSafariActivity(),
+        let bookmarked = status.bookmarked ?? false
-            (status.bookmarked ?? false) ? UnbookmarkStatusActivity() : BookmarkStatusActivity(),
+        customActivites.insert(bookmarked ? UnbookmarkStatusActivity() : BookmarkStatusActivity(), at: 0)
-            status.muted ? UnmuteConversationActivity() : MuteConversationActivity(),
-        ]
 
         if apiController.account != nil, status.account.id == apiController.account.id {
             let pinned = status.pinned ?? false
             customActivites.insert(pinned ? UnpinStatusActivity() : PinStatusActivity(), at: 1)
         }
         
-        let activityController = UIActivityViewController(activityItems: [url, StatusActivityItemSource(status)], applicationActivities: customActivites)
+        let activityController = UIActivityViewController(activityItems: [url, status], applicationActivities: customActivites)
         activityController.completionWithItemsHandler = OpenInSafariActivity.completionHandler(viewController: self, url: url)
         return activityController
     }
     
     private func moreOptions(forAccount accountID: String) -> UIActivityViewController {
         guard let account = apiController.persistentContainer.account(for: accountID) else { fatalError("Missing cached account \(accountID)") }
-        
+        return moreOptions(forURL: account.url)
-        let customActivities: [UIActivity] = [
-            OpenInSafariActivity(),
-        ]
-        
-        let activityController = UIActivityViewController(activityItems: [account.url, AccountActivityItemSource(account)], applicationActivities: customActivities)
-        activityController.completionWithItemsHandler = OpenInSafariActivity.completionHandler(viewController: self, url: account.url)
-        return activityController
     }
     
     func showMoreOptions(forStatus statusID: String, sourceView: UIView?) {