Support filtering on Notifications screen

Packages/InstanceFeatures/Sources/InstanceFeatures/InstanceFeatures.swift

@@ -121,7 +121,7 @@ public class InstanceFeatures: ObservableObject {
             return true
         case .pleroma(.vanilla(let v)) where v >= Version(2, 5, 0):
             return true
-        case .pleroma(.akkoma(nil)):
+        case .pleroma(.akkoma(_)):
             return true
         default:
             return false

Packages/Pachyderm/Sources/Pachyderm/Model/EditStatusParameters.swift

@@ -22,7 +22,7 @@ struct EditStatusParameters: Encodable, Sendable {
         var container = encoder.container(keyedBy: CodingKeys.self)
         try container.encode(self.id, forKey: .id)
         try container.encode(self.text, forKey: .text)
-        try container.encode(self.contentType, forKey: .contentType)
+        try container.encode(self.contentType.mimeType, forKey: .contentType)
         try container.encodeIfPresent(self.spoilerText, forKey: .spoilerText)
         try container.encode(self.sensitive, forKey: .sensitive)
         try container.encodeIfPresent(self.language, forKey: .language)

Packages/Pachyderm/Sources/Pachyderm/Utilities/NotificationGroup.swift

@@ -12,20 +12,12 @@ public struct NotificationGroup: Identifiable, Hashable, Sendable {
     public private(set) var notifications: [Notification]
     public let id: String
     public let kind: Notification.Kind
-    public let statusState: CollapseState?
 
-    @MainActor
     public init?(notifications: [Notification]) {
         guard !notifications.isEmpty else { return nil }
         self.notifications = notifications
         self.id = notifications.first!.id
         self.kind = notifications.first!.kind
-        switch kind {
-        case .mention, .status:
-            self.statusState = .unknown
-        default:
-            self.statusState = nil
-        }
     }
     
     public static func ==(lhs: NotificationGroup, rhs: NotificationGroup) -> Bool {

Tusker/Screens/Conversation/ExpandThreadCollectionViewCell.swift

@@ -54,9 +54,12 @@ class ExpandThreadCollectionViewCell: UICollectionViewListCell {
         threadLinkViewFullHeightConstraint = threadLinkView.bottomAnchor.constraint(equalTo: contentView.bottomAnchor)
         threadLinkViewShortHeightConstraint = threadLinkView.bottomAnchor.constraint(equalTo: avatarContainerView.topAnchor, constant: -2)
         
+        let avatarContainerHeightConstraint = avatarContainerView.heightAnchor.constraint(equalToConstant: 32)
+        // let this be broken during intermediate layouts when the collection view imposes a height constraint
+        avatarContainerHeightConstraint.priority = .init(999)
         NSLayoutConstraint.activate([
             avatarContainerWidthConstraint,
-            avatarContainerView.heightAnchor.constraint(equalToConstant: 32),
+            avatarContainerHeightConstraint,
             
             stackViewLeadingConstraint,
             hStack.trailingAnchor.constraint(equalTo: contentView.trailingAnchor, constant: -16),

Tusker/Screens/Notifications/ActionNotificationGroupCollectionViewCell.swift

@@ -60,7 +60,7 @@ class ActionNotificationGroupCollectionViewCell: UICollectionViewListCell {
         $0.adjustsFontForContentSizeCategory = true
         $0.numberOfLines = 2
         $0.lineBreakMode = .byTruncatingTail
-        $0.combiner = { [unowned self] in self.updateActionLabel(names: $0) }
+        $0.combiner = { [weak self] in self?.updateActionLabel(names: $0) ?? NSAttributedString() }
     }
     
     private let statusContentLabel = UILabel().configure {

Tusker/Screens/Notifications/NotificationsCollectionViewController.swift

@@ -14,6 +14,7 @@ import Sentry
 class NotificationsCollectionViewController: UIViewController, TimelineLikeCollectionViewController, CollectionViewController {
     
     weak var mastodonController: MastodonController!
+    private let filterer: Filterer
     
     private let allowedTypes: [Pachyderm.Notification.Kind]
     private let groupTypes = [Pachyderm.Notification.Kind.favourite, .reblog, .follow]
@@ -31,6 +32,11 @@ class NotificationsCollectionViewController: UIViewController, TimelineLikeColle
         self.allowedTypes = allowedTypes
         self.mastodonController = mastodonController
         
+        self.filterer = Filterer(mastodonController: mastodonController, context: .notifications)
+        self.filterer.htmlConverter.font = TimelineStatusCollectionViewCell.contentFont
+        self.filterer.htmlConverter.monospaceFont = TimelineStatusCollectionViewCell.monospaceFont
+        self.filterer.htmlConverter.paragraphStyle = TimelineStatusCollectionViewCell.contentParagraphStyle
+        
         super.init(nibName: nil, bundle: nil)
         
         self.controller = TimelineLikeController(delegate: self, ownerType: String(describing: self))
@@ -73,6 +79,10 @@ class NotificationsCollectionViewController: UIViewController, TimelineLikeColle
             if item.hidesSeparators {
                 config.topSeparatorVisibility = .hidden
                 config.bottomSeparatorVisibility = .hidden
+            } else if case .group(_, _, .some(let filterState)) = item,
+                      self.filterer.isKnownHide(state: filterState) {
+                config.topSeparatorVisibility = .hidden
+                config.bottomSeparatorVisibility = .hidden
             } else {
                 config.topSeparatorInsets = TimelineStatusCollectionViewCell.separatorInsets
                 config.bottomSeparatorInsets = TimelineStatusCollectionViewCell.separatorInsets
@@ -106,14 +116,18 @@ class NotificationsCollectionViewController: UIViewController, TimelineLikeColle
         collectionView.refreshControl = UIRefreshControl()
         collectionView.refreshControl!.addTarget(self, action: #selector(refresh), for: .valueChanged)
         #endif
+        
+        filterer.filtersChanged = { [unowned self] actionsChanged in
+            self.reapplyFilters(actionsChanged: actionsChanged)
+        }
     }
     
     private func createDataSource() -> UICollectionViewDiffableDataSource<Section, Item> {
-        let statusCell = UICollectionView.CellRegistration<TimelineStatusCollectionViewCell, NotificationGroup> { [unowned self] cell, indexPath, itemIdentifier in
+        let statusCell = UICollectionView.CellRegistration<TimelineStatusCollectionViewCell, (NotificationGroup, CollapseState, Filterer.Result, NSAttributedString?)> { [unowned self] cell, indexPath, itemIdentifier in
             cell.delegate = self
-            let statusID = itemIdentifier.notifications.first!.status!.id
-            let statusState = itemIdentifier.statusState!
-            cell.updateUI(statusID: statusID, state: statusState, filterResult: .allow, precomputedContent: nil)
+            let statusID = itemIdentifier.0.notifications.first!.status!.id
+            let statusState = itemIdentifier.1
+            cell.updateUI(statusID: statusID, state: statusState, filterResult: itemIdentifier.2, precomputedContent: itemIdentifier.3)
         }
         let actionGroupCell = UICollectionView.CellRegistration<ActionNotificationGroupCollectionViewCell, NotificationGroup> { [unowned self] cell, indexPath, itemIdentifier in
             cell.delegate = self
@@ -140,12 +154,23 @@ class NotificationsCollectionViewController: UIViewController, TimelineLikeColle
             config.text = "Unknown Notification"
             cell.contentConfiguration = config
         }
+        let zeroHeightCell = UICollectionView.CellRegistration<ZeroHeightCollectionViewCell, Void> { _, _, _ in
+        }
         return UICollectionViewDiffableDataSource(collectionView: collectionView) { [unowned self] collectionView, indexPath, itemIdentifier in
             switch itemIdentifier {
-            case .group(let group):
+            case .group(let group, let collapseState, let filterState):
                 switch group.kind {
                 case .status, .mention:
-                    return collectionView.dequeueConfiguredReusableCell(using: statusCell, for: indexPath, item: group)
+                    let (result, precomputedContent) = self.filterer.resolve(state: filterState!) {
+                        let id = group.notifications.first!.status!.id
+                        return (self.mastodonController.persistentContainer.status(for: id)!, false)
+                    }
+                    switch result {
+                    case .allow, .warn(_):
+                        return collectionView.dequeueConfiguredReusableCell(using: statusCell, for: indexPath, item: (group, collapseState!, result, precomputedContent))
+                    case .hide:
+                        return collectionView.dequeueConfiguredReusableCell(using: zeroHeightCell, for: indexPath, item: ())
+                    }
                 case .favourite, .reblog:
                     return collectionView.dequeueConfiguredReusableCell(using: actionGroupCell, for: indexPath, item: group)
                 case .follow:
@@ -192,8 +217,44 @@ class NotificationsCollectionViewController: UIViewController, TimelineLikeColle
         }
     }
     
+    private func filterResult(state: FilterState, statusID: String) -> (Filterer.Result, NSAttributedString?) {
+        let status = {
+            let status = self.mastodonController.persistentContainer.status(for: statusID)!
+            // if the status is a reblog of another one, filter based on that one
+            if let reblogged = status.reblog {
+                return (reblogged, true)
+            } else {
+                return (status, false)
+            }
+        }
+        return filterer.resolve(state: state, status: status)
+    }
+    
+    private func reapplyFilters(actionsChanged: Bool) {
+        let visible = collectionView.indexPathsForVisibleItems
+        let items = visible
+            .compactMap { dataSource.itemIdentifier(for: $0) }
+            .filter {
+                if case .group(_, _, .some(_)) = $0 {
+                    return true
+                } else {
+                    return false
+                }
+            }
+        guard !items.isEmpty else {
+            return
+        }
+        var snapshot = dataSource.snapshot()
+        if actionsChanged {
+            snapshot.reloadItems(items)
+        } else {
+            snapshot.reconfigureItems(items)
+        }
+        dataSource.apply(snapshot)
+    }
+    
     private func dismissNotificationsInGroup(at indexPath: IndexPath) async {
-        guard case .group(let group) = dataSource.itemIdentifier(for: indexPath) else {
+        guard case .group(let group, let collapseState, let filterState) = dataSource.itemIdentifier(for: indexPath) else {
             return
         }
         let notifications = group.notifications
@@ -216,11 +277,11 @@ class NotificationsCollectionViewController: UIViewController, TimelineLikeColle
         }
         var snapshot = dataSource.snapshot()
         if dismissFailedIndices.isEmpty {
-            snapshot.deleteItems([.group(group)])
+            snapshot.deleteItems([.group(group, collapseState, filterState)])
         } else if !dismissFailedIndices.isEmpty && dismissFailedIndices.count == notifications.count {
             let dismissFailed = dismissFailedIndices.sorted().map { notifications[$0] }
-            snapshot.insertItems([.group(NotificationGroup(notifications: dismissFailed)!)], afterItem: .group(group))
-            snapshot.deleteItems([.group(group)])
+            snapshot.insertItems([.group(NotificationGroup(notifications: dismissFailed)!, collapseState, filterState)], afterItem: .group(group, collapseState, filterState))
+            snapshot.deleteItems([.group(group, collapseState, filterState)])
         }
         await apply(snapshot, animatingDifferences: true)
     }
@@ -235,16 +296,46 @@ extension NotificationsCollectionViewController {
         static var entries: Self { .notifications }
     }
     enum Item: TimelineLikeCollectionViewItem {
-        case group(NotificationGroup)
+        case group(NotificationGroup, CollapseState?, FilterState?)
         case loadingIndicator
         case confirmLoadMore
         
         static func fromTimelineItem(_ item: NotificationGroup) -> Self {
-            return .group(item)
+            switch item.kind {
+            case .mention, .status:
+                return .group(item, .unknown, .unknown)
+            default:
+                return .group(item, nil, nil)
+            }
+        }
+        
+        static func ==(lhs: Item, rhs: Item) -> Bool {
+            switch (lhs, rhs) {
+            case (.group(let a, _, _), .group(let b, _, _)):
+                return a == b
+            case (.loadingIndicator, .loadingIndicator):
+                return true
+            case (.confirmLoadMore, .confirmLoadMore):
+                return true
+            default:
+                return false
+            }
+        }
+        
+        func hash(into hasher: inout Hasher) {
+            switch self {
+            case .group(let group, _, _):
+                hasher.combine(0)
+                hasher.combine(group)
+            case .loadingIndicator:
+                hasher.combine(1)
+            case .confirmLoadMore:
+                hasher.combine(1)
+            }
         }
         
         var group: NotificationGroup? {
-            if case .group(let group) = self {
+            if case .group(let group, _, _) = self {
                 return group
             } else {
                 return nil
@@ -253,7 +344,7 @@ extension NotificationsCollectionViewController {
         
         var isSelectable: Bool {
             switch self {
-            case .group(_):
+            case .group(_, _, _):
                 return true
             default:
                 return false
@@ -369,7 +460,7 @@ extension NotificationsCollectionViewController {
                     $0.id == topID
                 }
             }!
-            if let newTopIndexPath = dataSource.indexPath(for: .group(newTopGroup)) {
+            if let newTopIndexPath = dataSource.indexPath(for: .group(newTopGroup, nil, nil)) {
                 collectionView.scrollToItem(at: newTopIndexPath, at: .top, animated: false)
             }
         }
@@ -429,14 +520,24 @@ extension NotificationsCollectionViewController: UICollectionViewDelegate {
     }
     
     func collectionView(_ collectionView: UICollectionView, didSelectItemAt indexPath: IndexPath) {
-        guard case .group(let group) = dataSource.itemIdentifier(for: indexPath) else {
+        guard let item = dataSource.itemIdentifier(for: indexPath),
+              case .group(let group, let collapseState, let filterState) = item else {
             return
         }
         switch group.kind {
         case .mention, .status, .poll, .update:
+            if let filterState,
+               filterState.isWarning == true {
+                filterer.setResult(.allow, for: filterState)
+                collectionView.deselectItem(at: indexPath, animated: true)
+                var snapshot = dataSource.snapshot()
+                snapshot.reconfigureItems([item])
+                dataSource.apply(snapshot, animatingDifferences: true)
+            } else {
                 let statusID = group.notifications.first!.status!.id
-            let state = group.statusState?.copy() ?? .unknown
+                let state = collapseState?.copy() ?? .unknown
                 selected(status: statusID, state: state)
+            }
         case .favourite, .reblog:
             let type = group.kind == .favourite ? StatusActionAccountListViewController.ActionType.favorite : .reblog
             let statusID = group.notifications.first!.status!.id
@@ -463,7 +564,7 @@ extension NotificationsCollectionViewController: UICollectionViewDelegate {
     }
     
     func collectionView(_ collectionView: UICollectionView, contextMenuConfigurationForItemAt indexPath: IndexPath, point: CGPoint) -> UIContextMenuConfiguration? {
-        guard case .group(let group) = dataSource.itemIdentifier(for: indexPath),
+        guard case .group(let group, let collapseState, _) = dataSource.itemIdentifier(for: indexPath),
               let cell = collectionView.cellForItem(at: indexPath) else {
             return nil
         }
@@ -473,7 +574,7 @@ extension NotificationsCollectionViewController: UICollectionViewDelegate {
                   let status = mastodonController.persistentContainer.status(for: statusID) else {
                 return nil
             }
-            let state = group.statusState?.copy() ?? .unknown
+            let state = collapseState?.copy() ?? .unknown
             return UIContextMenuConfiguration {
                 ConversationViewController(for: statusID, state: state, mastodonController: self.mastodonController)
             } actionProvider: { _ in
@@ -536,7 +637,7 @@ extension NotificationsCollectionViewController: UICollectionViewDelegate {
 
 extension NotificationsCollectionViewController: UICollectionViewDragDelegate {
     func collectionView(_ collectionView: UICollectionView, itemsForBeginning session: UIDragSession, at indexPath: IndexPath) -> [UIDragItem] {
-        guard case .group(let group) = dataSource.itemIdentifier(for: indexPath) else {
+        guard case .group(let group, _, _) = dataSource.itemIdentifier(for: indexPath) else {
             return []
         }
         switch group.kind {
@@ -586,5 +687,13 @@ extension NotificationsCollectionViewController: StatusCollectionViewCellDelegat
     }
     
     func statusCellShowFiltered(_ cell: StatusCollectionViewCell) {
+        if let indexPath = collectionView.indexPath(for: cell),
+           let item = dataSource.itemIdentifier(for: indexPath),
+           case .group(_, _, .some(let filterState)) = item {
+            filterer.setResult(.allow, for: filterState)
+            var snapshot = dataSource.snapshot()
+            snapshot.reconfigureItems([item])
+            dataSource.apply(snapshot, animatingDifferences: true)
+        }
     }
 }

Tusker/Screens/Profile/ProfileStatusesViewController.swift

@@ -41,6 +41,7 @@ class ProfileStatusesViewController: UIViewController, TimelineLikeCollectionVie
         self.mastodonController = owner.mastodonController
         self.filterer = Filterer(mastodonController: mastodonController, context: .account)
         self.filterer.htmlConverter.font = TimelineStatusCollectionViewCell.contentFont
+        self.filterer.htmlConverter.monospaceFont = TimelineStatusCollectionViewCell.monospaceFont
         self.filterer.htmlConverter.paragraphStyle = TimelineStatusCollectionViewCell.contentParagraphStyle
         
         super.init(nibName: nil, bundle: nil)

Tusker/Views/MultiSourceEmojiLabel.swift

@@ -24,21 +24,18 @@ class MultiSourceEmojiLabel: UILabel, BaseEmojiLabel {
         
         var attributedStrings = pairs.map { NSAttributedString(string: $0.0) }
         
-        func recombine() {
-            if let combiner = self.combiner {
+        let recombine = { [weak self] in
+            if let self,
+               let combiner = self.combiner {
                 self.attributedText = combiner(attributedStrings)
             }
         }
-        
         recombine()
         
         for (index, (string, emojis)) in pairs.enumerated() {
             self.replaceEmojis(in: string, emojis: emojis, identifier: identifier) { (attributedString, _) in
                 attributedStrings[index] = attributedString
-                DispatchQueue.main.async { [weak self] in
-                    guard let self else { return }
-                    recombine()
-                }
+                DispatchQueue.main.async(execute: recombine)
             }
         }
     }

Tusker/Views/Status/StatusCollectionViewCell.swift

@@ -119,12 +119,6 @@ extension StatusCollectionViewCell {
         favoriteButton.isEnabled = mastodonController.loggedIn
         
         let didResolve = statusState.resolveFor(status: status, height: self.estimateContentHeight)
-//        let didResolve = statusState.resolveFor(status: status) {
-////            // layout so that we can take the content height into consideration when deciding whether to collapse
-////            layoutIfNeeded()
-////            return contentContainer.visibleSubviewHeight
-//            return contentContainer.estimateVisibleSubviewHeight(effectiveWidth: )
-//        }
         if didResolve {
             if statusState.collapsible! && showStatusAutomatically {
                 statusState.collapsed = false