Tapping links is broken in statuses containing lists #20

New Issue

shadowfacts · 2019-04-05T02:08:26Z

shadowfacts commented

2019-04-05 02:08:26 +00:00

Something about the way lists are converted from HTML -> attributed strings breaks everything and makes NSLayoutManager.glyphIndex(for:in:) returns the wrong character index.

odds are slim i'll figure this out myself

Something about the way lists are converted from HTML -> attributed strings breaks everything and makes `NSLayoutManager.glyphIndex(for:in:)` returns the wrong character index. odds are slim i'll figure this out myself

shadowfacts added this to the 1.0.0 milestone 2019-04-05 02:08:26 +00:00

shadowfacts self-assigned this 2019-04-05 02:08:26 +00:00

shadowfacts added the

bug

label 2019-04-05 02:08:26 +00:00

shadowfacts commented

2019-09-06 22:10:07 +00:00

notes for myself:

possible solutions: https://mastodon.technology/users/brunoph/statuses/101875790249779349

possibly switch to NSAttributeString's HTML rendering?

https://github.com/ShihabM/Mast/pull/68
https://developer.apple.com/documentation/foundation/nsattributedstring/1524613-init#discussion
https://www.robpeck.com/2015/04/nshtmltextdocumenttype-is-slow
^ apparently it's slow, and sanitizing would add a second html parse pass

notes for myself: possible solutions: https://mastodon.technology/users/brunoph/statuses/101875790249779349 possibly switch to NSAttributeString's HTML rendering? - https://github.com/ShihabM/Mast/pull/68 - https://developer.apple.com/documentation/foundation/nsattributedstring/1524613-init#discussion - https://www.robpeck.com/2015/04/nshtmltextdocumenttype-is-slow - ^ apparently it's slow, and sanitizing would add a second html parse pass

shadowfacts modified the milestone from 1.0.0 to Public Beta

2020-01-04 21:33:41 +00:00

shadowfacts referenced this issue from a commit

2020-01-18 21:27:20 +00:00

Replace content labels with text views UITextView uses TextKit internally, unlike UILabel, so no additional code is needed to keep the TextKit and view representations of the text in sync since they are one and the same. This means that detecting which character was tapped in a content text view is much more accurate, which means link handling is substantially imrpoved. Fixes #20

shadowfacts closed this issue

2020-01-18 21:27:20 +00:00

Sign in to join this conversation.