Tapping links is broken in statuses containing lists #20

建立問題

shadowfacts · 2019-04-05T02:08:26Z

shadowfacts " 評論

2019-04-05 02:08:26 +00:00

"

管理員

Something about the way lists are converted from HTML -> attributed strings breaks everything and makes NSLayoutManager.glyphIndex(for:in:) returns the wrong character index.

odds are slim i'll figure this out myself

Something about the way lists are converted from HTML -> attributed strings breaks everything and makes `NSLayoutManager.glyphIndex(for:in:)` returns the wrong character index. odds are slim i'll figure this out myself

shadowfacts 新增至1.0.0 里程碑 2019-04-05 02:08:26 +00:00

shadowfacts 將 2019-04-05 02:08:26 +00:00 指派給自己

shadowfacts added the

bug

label 2019-04-05 02:08:26 +00:00

shadowfacts " 評論

2019-09-06 22:10:07 +00:00

"

管理員

notes for myself:

possible solutions: https://mastodon.technology/users/brunoph/statuses/101875790249779349

possibly switch to NSAttributeString's HTML rendering?

https://github.com/ShihabM/Mast/pull/68
https://developer.apple.com/documentation/foundation/nsattributedstring/1524613-init#discussion
https://www.robpeck.com/2015/04/nshtmltextdocumenttype-is-slow
^ apparently it's slow, and sanitizing would add a second html parse pass

notes for myself: possible solutions: https://mastodon.technology/users/brunoph/statuses/101875790249779349 possibly switch to NSAttributeString's HTML rendering? - https://github.com/ShihabM/Mast/pull/68 - https://developer.apple.com/documentation/foundation/nsattributedstring/1524613-init#discussion - https://www.robpeck.com/2015/04/nshtmltextdocumenttype-is-slow - ^ apparently it's slow, and sanitizing would add a second html parse pass

shadowfacts 2020-01-04 21:33:41 +00:00 修改了里程碑 1.0.0 到 Public Beta

shadowfacts 在代碼提交

2020-01-18 21:27:20 +00:00

中引用了該問題

Replace content labels with text views UITextView uses TextKit internally, unlike UILabel, so no additional code is needed to keep the TextKit and view representations of the text in sync since they are one and the same. This means that detecting which character was tapped in a content text view is much more accurate, which means link handling is substantially imrpoved. Fixes #20

shadowfacts closed this issue

2020-01-18 21:27:20 +00:00

登入才能加入這對話。