Backgrounding the app dismisses any presented SFSafariViewControllers #399

New Issue

saagarjha · 2023-05-25T06:14:01Z

saagarjha commented

2023-05-25 06:14:01 +00:00

Title. Also it seems to reset the app layout, perhaps related?

shadowfacts commented

2023-05-25 06:24:21 +00:00

What kind of device are you using? An iPad, perchance?

shadowfacts added the

bug

label 2023-05-25 06:38:45 +00:00

shadowfacts added this to the 2023.6 milestone 2023-05-25 06:38:47 +00:00

shadowfacts commented

2023-05-25 06:47:32 +00:00

Notes for self: This is caused by the splitViewControllerDidCollapse (or the expand?) logic to transfer state to the tab bar. The system changes the window to a horizontally-compact size to take snapshots, which triggers the collapse. The VC dismissing should be fixable (possible dupe of #316).

The layout may be more involved since it involves the collection view size changing -> cell heights change, so the same absolute content offset has a different visual position. The switch back may result in a third visual position for the same absolute content offset (I think) if the collapse/expanded caused additional cells to be laid out.

Notes for self: This is caused by the splitViewControllerDidCollapse (or the expand?) logic to transfer state to the tab bar. The system changes the window to a horizontally-compact size to take snapshots, which triggers the collapse. The VC dismissing should be fixable (possible dupe of #316). The layout may be more involved since it involves the collection view size changing -> cell heights change, so the same absolute content offset has a different visual position. The switch back may result in a third visual position for the same absolute content offset (I think) if the collapse/expanded caused additional cells to be laid out.

saagarjha commented

2023-05-25 07:13:09 +00:00

Yep, it’s iPad.

shadowfacts referenced this issue from a commit

2023-05-28 22:20:46 +00:00

Fix backgrounding app on iPad dismissing modally-presented VC

shadowfacts closed this issue

2023-05-28 22:20:46 +00:00

Sign in to join this conversation.