shadowfacts/Tusker
2
10
Fork 2
Code Issues 70 Pull Requests Releases Wiki Activity

Backgrounding the app dismisses any presented SFSafariViewControllers #399

New Issue
Closed
opened 2023-05-25 06:14:01 +00:00 by saagarjha · 3 comments
saagarjha commented 2023-05-25 06:14:01 +00:00
Copy Link

Title. Also it seems to reset the app layout, perhaps related?

Title. Also it seems to reset the app layout, perhaps related?
shadowfacts commented 2023-05-25 06:24:21 +00:00
Owner
Copy Link

What kind of device are you using? An iPad, perchance?

What kind of device are you using? An iPad, perchance?
shadowfacts added the
bug
 label 2023-05-25 06:38:45 +00:00
shadowfacts added this to the 2023.6 milestone 2023-05-25 06:38:47 +00:00
shadowfacts commented 2023-05-25 06:47:32 +00:00
Owner
Copy Link

Notes for self: This is caused by the splitViewControllerDidCollapse (or the expand?) logic to transfer state to the tab bar. The system changes the window to a horizontally-compact size to take snapshots, which triggers the collapse. The VC dismissing should be fixable (possible dupe of #316).

The layout may be more involved since it involves the collection view size changing -> cell heights change, so the same absolute content offset has a different visual position. The switch back may result in a third visual position for the same absolute content offset (I think) if the collapse/expanded caused additional cells to be laid out.

Notes for self: This is caused by the splitViewControllerDidCollapse (or the expand?) logic to transfer state to the tab bar. The system changes the window to a horizontally-compact size to take snapshots, which triggers the collapse. The VC dismissing should be fixable (possible dupe of #316). The layout may be more involved since it involves the collection view size changing -> cell heights change, so the same absolute content offset has a different visual position. The switch back may result in a third visual position for the same absolute content offset (I think) if the collapse/expanded caused additional cells to be laid out.
saagarjha commented 2023-05-25 07:13:09 +00:00
Author
Copy Link

Yep, it’s iPad.

Yep, it’s iPad.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
external
Issue depends on changes to external projects.
help wanted
Need some help
invalid
Something is wrong
investigate
An unconfirmed issue
question
More information is needed
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone 2023.6
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shadowfacts/Tusker#399
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?