shadowfacts/Tusker
2
10
Fork 2
Code Issues 72 Pull Requests Releases Wiki Activity

AccountPreferences is not accessible from app extensions #438

New Issue
Closed
opened 2023-10-27 20:05:52 +00:00 by shadowfacts · 0 comments
shadowfacts commented 2023-10-27 20:05:52 +00:00
Owner
Copy Link

This means we have to do a network request in the share sheet launch codepath:

ShareExtension/ShareViewController.swift Line 56 in 6e5e0c3bb5
// TODO: I really don't like that there's a network request in the hot path here, but we don't have easy access to AccountPreferences :/

Possibilities:

  • the cloud.sqlite store could be moved to the app group container
    • but the data model description is still part of the app, so how to initilaize it?
  • AccountPreferences could be a separate package and a separate CoreData model
This means we have to do a network request in the share sheet launch codepath: https://git.shadowfacts.net/shadowfacts/Tusker/src/commit/6e5e0c3bb55c320ac0ba5e310b0365be2bfba91d/ShareExtension/ShareViewController.swift#L56 Possibilities: - the cloud.sqlite store could be moved to the app group container - but the data model description is still part of the app, so how to initilaize it? - AccountPreferences could be a separate package and a separate CoreData model
shadowfacts added this to the 2023.8 milestone 2023-10-27 20:05:52 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
external
Issue depends on changes to external projects.
help wanted
Need some help
invalid
Something is wrong
investigate
An unconfirmed issue
question
More information is needed
wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone 2023.8
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shadowfacts/Tusker#438
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?