shadowfacts
/
Tusker
2
10
Fork 2
Code Issues 73 Pull Requests Releases Wiki Activity

Persistent history tracking returns all transactions on app launch #480

New Issue
Closed
opened 2024-05-23 18:42:39 +00:00 by shadowfacts · 0 comments
shadowfacts commented 2024-05-23 18:42:39 +00:00
Owner
Copy Link

844d4056e3/Tusker/CoreData/MastodonCachePersistentStore.swift (L531)

Because we call fetchHistory(after:) with nil, we waste a lot of time/energy going through every history instruction. We need to save the NSPersistentHistoryToken to disk after each remote change notification is handled.

Should also purge old history entries per https://developer.apple.com/documentation/coredata/consuming_relevant_store_changes

https://git.shadowfacts.net/shadowfacts/Tusker/src/commit/844d4056e3bf584d9bf6e7d86bb8ef74fd9e0b7a/Tusker/CoreData/MastodonCachePersistentStore.swift#L531 Because we call `fetchHistory(after:)` with nil, we waste a lot of time/energy going through every history instruction. We need to save the `NSPersistentHistoryToken` to disk after each remote change notification is handled. Should also purge old history entries per https://developer.apple.com/documentation/coredata/consuming_relevant_store_changes
shadowfacts added this to the 2024.3 milestone 2024-05-23 18:42:39 +00:00
shadowfacts added the
bug
 label 2024-05-23 18:42:39 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
develop
public-beta
release
calckey
async
simple-swift-promises
pixelfed
2024.4-136
2024.4-135
2024.4-134
2024.3-133
2024.3-132
2024.3-131
2024.3-130
2024.3-129
2024.3-128
2024.3-127
2024.3-126
2024.3-125
2024.2-124
2024.2-122
2024.2-121
2024.2-120
2024.1-119
2024.1-118
2024.1-117
2024.1-116
2024.1-115
2024.1-113
2024.1-112
2024.1-111
2023.8-110
2023.8-109
2023.8-107
2023.8-106
2023.8-105
2023.8-104
2023.7-103
2023.6-100
2023.5-98
2023.5-97
2023.5-96
2023.5-94
2023.5-91
2023.5-89
2023.5-84
2023.5-83
2023.5-81
2023.5-80
2023.5-77
2023.4-76
2023.4-75
2023.4-74
2023.4-73
2023.4-72
2023.4-71
2023.4-70
2023.3-69
2023.2-68
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
external

Issue depends on changes to external projects.

  
help wanted

Need some help

  
invalid

Something is wrong

  
investigate

An unconfirmed issue

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
external
help wanted
invalid
investigate
question
wontfix
Milestone
Clear milestone
No items
No Milestone
2024.3
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: shadowfacts/Tusker#480
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?