NotificationLoadingVC used outside of navigation controller #484

New Issue

shadowfacts · 2024-05-23T18:59:55Z

shadowfacts commented

2024-05-23 18:59:55 +00:00

We're sometimes hitting this check: 844d4056e3/Tusker/Screens/Notifications/NotificationLoadingViewController.swift (L98)

I don't know how that's possible. ActiveAccountUserActivityHandlingContext uses show(_:sender:) to push a VC, which is what the show notification user activity handler uses. Might be hitting that after requesting a scene session activation with the NSUA when handling a push notification tap.

We're sometimes hitting this check: https://git.shadowfacts.net/shadowfacts/Tusker/src/commit/844d4056e3bf584d9bf6e7d86bb8ef74fd9e0b7a/Tusker/Screens/Notifications/NotificationLoadingViewController.swift#L98 I don't know how that's possible. `ActiveAccountUserActivityHandlingContext` uses `show(_:sender:)` to push a VC, which is what the show notification user activity handler uses. Might be hitting that after requesting a scene session activation with the NSUA when handling a push notification tap.

shadowfacts added this to the 2024.3 milestone 2024-05-23 18:59:55 +00:00

shadowfacts added the

bug

label 2024-05-23 18:59:55 +00:00

shadowfacts commented

2024-06-02 17:11:08 +00:00

This reproduces when a notification is tapped while the window has a VC presented modally (e.g., preferences)

shadowfacts referenced this issue from a commit

2024-06-02 17:44:49 +00:00

Fix crash when opening push notification while VC modally presented

shadowfacts closed this issue

2024-06-02 17:44:49 +00:00