shadowfacts/Tusker
2
10
Fork 2
Code Issues 72 Pull Requests Releases Wiki Activity

NotificationLoadingVC used outside of navigation controller #484

New Issue
Closed
opened 2024-05-23 18:59:55 +00:00 by shadowfacts · 1 comment
shadowfacts commented 2024-05-23 18:59:55 +00:00
Owner
Copy Link

We're sometimes hitting this check:

Tusker/Screens/Notifications/NotificationLoadingViewController.swift Line 98 in 844d4056e3
fatalError("Don't know how to show notification VC outside of navigation controller")

I don't know how that's possible. ActiveAccountUserActivityHandlingContext uses show(_:sender:) to push a VC, which is what the show notification user activity handler uses. Might be hitting that after requesting a scene session activation with the NSUA when handling a push notification tap.

We're sometimes hitting this check: https://git.shadowfacts.net/shadowfacts/Tusker/src/commit/844d4056e3bf584d9bf6e7d86bb8ef74fd9e0b7a/Tusker/Screens/Notifications/NotificationLoadingViewController.swift#L98 I don't know how that's possible. `ActiveAccountUserActivityHandlingContext` uses `show(_:sender:)` to push a VC, which is what the show notification user activity handler uses. Might be hitting that after requesting a scene session activation with the NSUA when handling a push notification tap.
shadowfacts added this to the 2024.3 milestone 2024-05-23 18:59:55 +00:00
shadowfacts added the
bug
 label 2024-05-23 18:59:55 +00:00
shadowfacts commented 2024-06-02 17:11:08 +00:00
Author
Owner
Copy Link

This reproduces when a notification is tapped while the window has a VC presented modally (e.g., preferences)

This reproduces when a notification is tapped while the window has a VC presented modally (e.g., preferences)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
external
Issue depends on changes to external projects.
help wanted
Need some help
invalid
Something is wrong
investigate
An unconfirmed issue
question
More information is needed
wontfix
This won't be fixed
No Label
bug
Milestone
No items
No Milestone 2024.3
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shadowfacts/Tusker#484
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?