shadowfacts/Tusker
2
10
Fork 2
Code Issues 72 Pull Requests Releases Wiki Activity

Allow sharing gifv attachments from gallery #98

New Issue
Closed
opened 2020-05-11 02:34:49 +00:00 by shadowfacts · 2 comments
shadowfacts commented 2020-05-11 02:34:49 +00:00
Owner
Copy Link
No description provided.
shadowfacts added the
enhancement
 label 2020-05-11 02:34:49 +00:00
shadowfacts commented 2020-05-13 01:48:12 +00:00
Author
Owner
Copy Link

This is kind of implemented, but it still needs work. The issue is that the top controls/image description stuff is tangled up with the plain image stuff in the LargeImageViewController. Really, the actual content for LIVC should be a separate child view controller which would allow having an AttachmentViewController that's applicable to images and gifvs which contains the controls and image description. But that's a larger refactor than I feel like dealing with right now...

This is kind of implemented, but it still needs work. The issue is that the top controls/image description stuff is tangled up with the plain image stuff in the LargeImageViewController. Really, the actual content for LIVC should be a separate child view controller which would allow having an AttachmentViewController that's applicable to images and gifvs which contains the controls and image description. But that's a larger refactor than I feel like dealing with right now...
shadowfacts changed title from Display gifv attachments to Allow sharing gifv attachments from gallery 2020-06-18 03:34:25 +00:00
shadowfacts commented 2020-06-18 03:35:45 +00:00
Author
Owner
Copy Link

This is even more mostly implemented, but sharing gifvs is disabled because there's nothing to share (remote URL and AVAsset don't work).

This is even more mostly implemented, but sharing gifvs is disabled because there's nothing to share (remote URL and AVAsset don't work).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
external
Issue depends on changes to external projects.
help wanted
Need some help
invalid
Something is wrong
investigate
An unconfirmed issue
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: shadowfacts/Tusker#98
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?