From 04b43ed8335ceb71c13b7de81012a2d9cb69c6af Mon Sep 17 00:00:00 2001 From: Cosimo Lupo Date: Wed, 9 Nov 2022 11:05:57 +0000 Subject: [PATCH] woff2_test: fix test_hmtx_compressed test it had been failing after we renamed a name string containing 'master' => 'main; in https://github.com/fonttools/fonttools/pull/2883 --- Tests/ttLib/woff2_test.py | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/Tests/ttLib/woff2_test.py b/Tests/ttLib/woff2_test.py index 7fe40dd10..8d59caee7 100644 --- a/Tests/ttLib/woff2_test.py +++ b/Tests/ttLib/woff2_test.py @@ -623,17 +623,22 @@ class WOFF2WriterTTFTest(WOFF2WriterTest): def test_hmtx_trasform(self): tableTransforms = {"glyf", "loca", "hmtx"} - writer = WOFF2Writer(BytesIO(), self.numTables, self.font.sfntVersion) - writer.flavorData = WOFF2FlavorData(transformedTables=tableTransforms) + def compile_hmtx(compressed): + tableTransforms = woff2TransformedTableTags + if compressed: + tableTransforms += ("hmtx",) + writer = WOFF2Writer(BytesIO(), self.numTables, self.font.sfntVersion) + writer.flavorData = WOFF2FlavorData(transformedTables=tableTransforms) + for tag in self.tags: + writer[tag] = self.font.getTableData(tag) + writer.close() + return writer.tables["hmtx"].length - for tag in self.tags: - writer[tag] = self.font.getTableData(tag) - writer.close() - - length = len(writer.file.getvalue()) + uncompressed_length = compile_hmtx(compressed=False) + compressed_length = compile_hmtx(compressed=True) # enabling optional hmtx transform shaves off a few bytes - self.assertLess(length, len(TT_WOFF2.getvalue())) + self.assertLess(compressed_length, uncompressed_length) def test_no_transforms(self): writer = WOFF2Writer(BytesIO(), self.numTables, self.font.sfntVersion)