From 0bfee639c65fcc719bcac08864e9426a48b4617b Mon Sep 17 00:00:00 2001
From: justvanrossum <justvanrossum@gmail.com>
Date: Fri, 2 Nov 2018 08:02:34 +0100
Subject: [PATCH] test named instances

---
 Tests/fontBuilder/data/test_var.ttf.ttx | 28 +++++++++++++++++++++++++
 Tests/fontBuilder/fontBuilder_test.py   |  5 ++++-
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/Tests/fontBuilder/data/test_var.ttf.ttx b/Tests/fontBuilder/data/test_var.ttf.ttx
index 6ebf24d53..a7bdcaf07 100644
--- a/Tests/fontBuilder/data/test_var.ttf.ttx
+++ b/Tests/fontBuilder/data/test_var.ttf.ttx
@@ -189,6 +189,12 @@
     <namerecord nameID="259" platformID="1" platEncID="0" langID="0x0" unicode="True">
       Down
     </namerecord>
+    <namerecord nameID="260" platformID="1" platEncID="0" langID="0x0" unicode="True">
+      TotallyNormal
+    </namerecord>
+    <namerecord nameID="261" platformID="1" platEncID="0" langID="0x0" unicode="True">
+      Right Up
+    </namerecord>
     <namerecord nameID="1" platformID="3" platEncID="1" langID="0x409">
       HelloTestFont
     </namerecord>
@@ -210,6 +216,12 @@
     <namerecord nameID="259" platformID="3" platEncID="1" langID="0x409">
       Down
     </namerecord>
+    <namerecord nameID="260" platformID="3" platEncID="1" langID="0x409">
+      TotallyNormal
+    </namerecord>
+    <namerecord nameID="261" platformID="3" platEncID="1" langID="0x409">
+      Right Up
+    </namerecord>
     <namerecord nameID="1" platformID="3" platEncID="1" langID="0x413">
       HalloTestFont
     </namerecord>
@@ -283,6 +295,22 @@
       <MaxValue>100.0</MaxValue>
       <AxisNameID>259</AxisNameID>
     </Axis>
+
+    <!-- TotallyNormal -->
+    <NamedInstance flags="0x0" subfamilyNameID="260">
+      <coord axis="LEFT" value="0.0"/>
+      <coord axis="RGHT" value="0.0"/>
+      <coord axis="UPPP" value="0.0"/>
+      <coord axis="DOWN" value="0.0"/>
+    </NamedInstance>
+
+    <!-- Right Up -->
+    <NamedInstance flags="0x0" subfamilyNameID="261">
+      <coord axis="LEFT" value="0.0"/>
+      <coord axis="RGHT" value="100.0"/>
+      <coord axis="UPPP" value="100.0"/>
+      <coord axis="DOWN" value="0.0"/>
+    </NamedInstance>
   </fvar>
 
   <gvar>
diff --git a/Tests/fontBuilder/fontBuilder_test.py b/Tests/fontBuilder/fontBuilder_test.py
index edf28d063..161fdfe35 100644
--- a/Tests/fontBuilder/fontBuilder_test.py
+++ b/Tests/fontBuilder/fontBuilder_test.py
@@ -159,7 +159,10 @@ def test_build_var(tmpdir):
         ('UPPP', 0, 0, 100, "Up"),
         ('DOWN', 0, 0, 100, "Down"),
     ]
-    instances = []
+    instances = [
+        dict(location=dict(LEFT=0, RGHT=0, UPPP=0, DOWN=0), stylename="TotallyNormal"),
+        dict(location=dict(LEFT=0, RGHT=100, UPPP=100, DOWN=0), stylename="Right Up"),
+    ]
     fb.setupFvar(axes, instances)
     variations = {}
     # Four (x, y) pairs and four phantom points: