shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Provide additional information for a common failure

Browse Source
This commit is contained in:
Simon Cozens 2021-03-15 12:51:02 +00:00
parent 46bd7a7e97
commit 1bf3cccead
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
Lib/fontTools/varLib/errors.py
View File

@ -51,6 +51,23 @@ class VarLibMergeError(VarLibError):
return index, self._master_name(index) return index, self._master_name(index)
return None, None return None, None
def _incompatible_features(self, offender_index):
cause, stack = self.args[0], self.args[1:]
bad_ttf = self.merger.ttfs[offender_index]
good_ttf = self.merger.ttfs[offender_index - 1]
good_features = [
x.FeatureTag for x in good_ttf[stack[-1]].table.FeatureList.FeatureRecord
]
bad_features = [
x.FeatureTag for x in bad_ttf[stack[-1]].table.FeatureList.FeatureRecord
]
return (
"\nIncompatible features between masters.\n"
f"Expected: {', '.join(good_features)}.\n"
f"Got: {', '.join(bad_features)}.\n"
)
def __str__(self): def __str__(self):
cause, stack = self.args[0], self.args[1:] cause, stack = self.args[0], self.args[1:]
context = "".join(reversed(stack)) context = "".join(reversed(stack))
@ -61,6 +78,9 @@ class VarLibMergeError(VarLibError):
details = f"\n\nThe problem is likely to be in {offender}:\n" details = f"\n\nThe problem is likely to be in {offender}:\n"
if cause["reason"] == VarLibMergeFailure.FoundANone: if cause["reason"] == VarLibMergeFailure.FoundANone:
details = details + f"{stack[0]}=={cause['got']}\n" details = details + f"{stack[0]}=={cause['got']}\n"
elif cause["reason"] == VarLibMergeFailure.ShouldBeConstant:
# Common case
details = details + self._incompatible_features(offender_index)
elif "expected" in cause and "got" in cause: elif "expected" in cause and "got" in cause:
offender = [x == cause["expected"] for x in cause["got"]].index(False) offender = [x == cause["expected"] for x in cause["got"]].index(False)
got = cause["got"][offender] got = cause["got"][offender]