shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

subset: drop empty features unless 'size' with FeatureParams table

Browse Source 
Fixes #2324
This commit is contained in:
Cosimo Lupo 2021-05-27 13:08:59 +01:00 committed by Behdad Esfahbod
parent 6a97d4cfdd
commit 1df4f1eac1
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Lib/fontTools/subset/__init__.py
View File

@ -1308,7 +1308,13 @@ def subset_lookups(self, lookup_indices):
self.LookupListIndex = [lookup_indices.index(l) self.LookupListIndex = [lookup_indices.index(l)
for l in self.LookupListIndex] for l in self.LookupListIndex]
self.LookupCount = len(self.LookupListIndex) self.LookupCount = len(self.LookupListIndex)
return self.LookupCount or self.FeatureParams # keep 'size' feature even if it contains no lookups; but drop any other
# empty feature (e.g. FeatureParams for stylistic set names)
# https://github.com/fonttools/fonttools/issues/2324
return (
self.LookupCount or
isinstance(self.FeatureParams, otTables.FeatureParamsSize)
)
@_add_method(otTables.FeatureList) @_add_method(otTables.FeatureList)
def subset_lookups(self, lookup_indices): def subset_lookups(self, lookup_indices):