From 25f29841b70aa1155a918be421c733de7654b477 Mon Sep 17 00:00:00 2001 From: justvanrossum Date: Thu, 1 Nov 2018 13:19:27 +0100 Subject: [PATCH] rename setupDSIG to setupDummyDSIG and added a doc string to clarify the legacy status of this --- Lib/fontTools/fontBuilder.py | 5 ++++- Tests/fontBuilder/fontBuilder_test.py | 4 ++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Lib/fontTools/fontBuilder.py b/Lib/fontTools/fontBuilder.py index 7e578ffe7..ba3c4eb9f 100644 --- a/Lib/fontTools/fontBuilder.py +++ b/Lib/fontTools/fontBuilder.py @@ -498,7 +498,10 @@ class FontBuilder(object): defaults = _maxpDefaultsOTF self._initTableWithValues("maxp", defaults, {}) - def setupDSIG(self): + def setupDummyDSIG(self): + """This adds a dummy DSIG table to the font to make some MS applications + happy. This does not properly sign the font. + """ from .ttLib.tables.D_S_I_G_ import SignatureRecord sig = SignatureRecord() diff --git a/Tests/fontBuilder/fontBuilder_test.py b/Tests/fontBuilder/fontBuilder_test.py index 88bea7053..e4fafef98 100644 --- a/Tests/fontBuilder/fontBuilder_test.py +++ b/Tests/fontBuilder/fontBuilder_test.py @@ -70,7 +70,7 @@ def test_build_ttf(tmpdir): fb.setupNameTable(nameStrings) fb.setupOS2() fb.setupPost() - fb.setupDSIG() + fb.setupDummyDSIG() fb.save(outPath) @@ -101,7 +101,7 @@ def test_build_otf(tmpdir): fb.setupNameTable(nameStrings) fb.setupOS2() fb.setupPost() - fb.setupDSIG() + fb.setupDummyDSIG() fb.save(outPath)