From c2cbcc7a06eeaa66931cc6e6334158ba394ca06c Mon Sep 17 00:00:00 2001 From: Antonio Cavedoni Date: Fri, 20 Nov 2020 12:58:00 +0100 Subject: [PATCH 1/2] Optionally install PyObjC if on macOS test env (#2108) --- .github/workflows/test.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 7c3025871..274a4181a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -43,6 +43,9 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install packages run: pip install tox coverage + - name: (Optionally install PyObjC package if on macOS platform) + if: ${{ runner.os == "macOS" }} + run: pip install pyobjc - name: Run Tox run: tox -e py-cov - name: Run Tox without lxml From 56a168aa814d25a9b3a52538dfb71734ca4f3263 Mon Sep 17 00:00:00 2001 From: Antonio Cavedoni Date: Fri, 20 Nov 2020 14:05:46 +0100 Subject: [PATCH 2/2] Update requirements.txt rather than conditionally install pyobjc in the GHA workflow --- .github/workflows/test.yml | 3 --- requirements.txt | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 274a4181a..7c3025871 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -43,9 +43,6 @@ jobs: python-version: ${{ matrix.python-version }} - name: Install packages run: pip install tox coverage - - name: (Optionally install PyObjC package if on macOS platform) - if: ${{ runner.os == "macOS" }} - run: pip install pyobjc - name: Run Tox run: tox -e py-cov - name: Run Tox without lxml diff --git a/requirements.txt b/requirements.txt index 940e2d4a3..680ffbb57 100644 --- a/requirements.txt +++ b/requirements.txt @@ -10,3 +10,4 @@ fs==2.4.11 skia-pathops==0.5.1.post1; platform_python_implementation != "PyPy" # this is only required to run Tests/cu2qu/{ufo,cli}_test.py ufoLib2==0.6.2 +pyobjc==6.2.2; sys_platform == "darwin"