From 2da26538375339c39135296a02688f8d56ffe7a7 Mon Sep 17 00:00:00 2001 From: Harry Dalton Date: Thu, 1 Sep 2022 17:21:04 +0100 Subject: [PATCH] Allow "minimum"/"maximum" keys to be missing, as well as None Some areas of the library check for both representations, and so doing this here too means we are less likely to break existing code. Despite this, flexibility introduces ambiguity, and so if typing gives us confidence that such an input is unlikely, we could re-review this; conditions with missing keys are not safe to use across the entire code- base. --- Lib/fontTools/designspaceLib/split.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/fontTools/designspaceLib/split.py b/Lib/fontTools/designspaceLib/split.py index 3558775ce..0c99473d9 100644 --- a/Lib/fontTools/designspaceLib/split.py +++ b/Lib/fontTools/designspaceLib/split.py @@ -352,7 +352,7 @@ def _extractSubSpace( def _conditionSetFrom(conditionSet: List[Dict[str, Any]]) -> ConditionSet: c: Dict[str, Range] = {} for condition in conditionSet: - minimum, maximum = condition["minimum"], condition["maximum"] + minimum, maximum = condition.get("minimum"), condition.get("maximum") c[condition["name"]] = Range( minimum if minimum is not None else -math.inf, maximum if maximum is not None else math.inf,