shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[agl] Add link to GitHub issue for details about TODO comment

Browse Source 
https://github.com/fonttools/fonttools/issues/775
This commit is contained in:
Sascha Brawer 2016-12-19 15:42:39 +01:00
parent 428636cfaf
commit 3b6648e725
2 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Lib/fontTools/agl.py
View File

@ -780,6 +780,7 @@ def _glyphComponentToUnicode(component, isZapfDingbats):
# TODO: We currently use the AGLFN (Adobe glyph list for new fonts), # TODO: We currently use the AGLFN (Adobe glyph list for new fonts),
# although the spec actually mandates the legacy AGL which is # although the spec actually mandates the legacy AGL which is
# a superset of the AGLFN. # a superset of the AGLFN.
# https://github.com/fonttools/fonttools/issues/775
uchar = AGL2UV.get(component) uchar = AGL2UV.get(component)
if uchar: if uchar:
return unichr(uchar) return unichr(uchar)

2
Lib/fontTools/agl_test.py
View File

@ -9,10 +9,12 @@ import unittest
class AglToUnicodeTest(unittest.TestCase): class AglToUnicodeTest(unittest.TestCase):
def test_spec_examples(self): def test_spec_examples(self):
# https://github.com/adobe-type-tools/agl-specification#3-examples # https://github.com/adobe-type-tools/agl-specification#3-examples
#
# TODO: Currently, we only handle AGLFN instead of legacy AGL names. # TODO: Currently, we only handle AGLFN instead of legacy AGL names.
# Therefore, the test cases below use Iogonek instead of Lcommaaccent. # Therefore, the test cases below use Iogonek instead of Lcommaaccent.
# Change Iogonek to Lcommaaccent as soon as the implementation has # Change Iogonek to Lcommaaccent as soon as the implementation has
# been fixed to also support legacy AGL names. # been fixed to also support legacy AGL names.
# https://github.com/fonttools/fonttools/issues/775
self.assertEqual(agl.toUnicode("Iogonek"), "Į") self.assertEqual(agl.toUnicode("Iogonek"), "Į")
self.assertEqual(agl.toUnicode("uni20AC0308"), "\u20AC\u0308") self.assertEqual(agl.toUnicode("uni20AC0308"), "\u20AC\u0308")
self.assertEqual(agl.toUnicode("u1040C"), "\U0001040C") self.assertEqual(agl.toUnicode("u1040C"), "\U0001040C")