shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add 2nd test contour to expose bug in dropImpliedOnCurvePoints

Browse Source 
there's a bug whereby we don't correctly drop impliable oncurve if it occurs on the first point of the second contour.. because we forgot to update the contour start = last + 1...
This commit is contained in:
Cosimo Lupo 2023-06-06 17:00:16 +01:00
parent d673fad56b
commit 4298c28e3c
No known key found for this signature in database
GPG Key ID: DF65A8A5A119C9A8
1 changed files with 29 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
Tests/ttLib/tables/_g_l_y_f_test.py
View File

@ -856,7 +856,17 @@ def test_dropImpliedOnCurvePoints_all_quad_off_curves():
((-1, -1), 0), ((-1, -1), 0),
((-1, 0), flagOnCurve), ((-1, 0), flagOnCurve),
((-1, 1), 0), ((-1, 1), 0),
] ],
[
((0, 2), flagOnCurve),
((2, 2), 0),
((2, 0), flagOnCurve),
((2, -2), 0),
((0, -2), flagOnCurve),
((-2, -2), 0),
((-2, 0), flagOnCurve),
((-2, 2), 0),
],
], ],
Transform().scale(2.0), Transform().scale(2.0),
) )
@ -864,12 +874,25 @@ def test_dropImpliedOnCurvePoints_all_quad_off_curves():
glyph3 = Glyph() glyph3 = Glyph()
glyph3.numberOfContours = 0 glyph3.numberOfContours = 0
assert dropImpliedOnCurvePoints(glyph1, glyph2, glyph3) == {0, 2, 4, 6} assert dropImpliedOnCurvePoints(glyph1, glyph2, glyph3) == {
0,
2,
4,
6,
8,
10,
12,
14,
}
assert glyph1.flags == glyph2.flags == array.array("B", [0, 0, 0, 0]) assert glyph1.flags == glyph2.flags == array.array("B", [0, 0, 0, 0, 0, 0, 0, 0])
assert glyph1.coordinates == GlyphCoordinates([(1, 1), (1, -1), (-1, -1), (-1, 1)]) assert glyph1.coordinates == GlyphCoordinates(
assert glyph2.coordinates == GlyphCoordinates([(2, 2), (2, -2), (-2, -2), (-2, 2)]) [(1, 1), (1, -1), (-1, -1), (-1, 1), (2, 2), (2, -2), (-2, -2), (-2, 2)]
assert glyph1.endPtsOfContours == glyph2.endPtsOfContours == [3] )
assert glyph2.coordinates == GlyphCoordinates(
[(2, 2), (2, -2), (-2, -2), (-2, 2), (4, 4), (4, -4), (-4, -4), (-4, 4)]
)
assert glyph1.endPtsOfContours == glyph2.endPtsOfContours == [3, 7]
assert glyph3.numberOfContours == 0 assert glyph3.numberOfContours == 0