shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Drop nameID 25 if instantiating a static font

Browse Source
This commit is contained in:
Marc Foley 2021-02-26 09:52:30 +00:00 committed by Cosimo Lupo
parent a7913ef50e
commit 52fec53d20
No known key found for this signature in database
GPG Key ID: 179A8F0895A02F4F
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
Lib/fontTools/varLib/instancer/names.py
View File

@ -314,6 +314,9 @@ def _updateNameTableStyleRecords(
assert string, nameID assert string, nameID
nametable.setName(string, nameID, *platform) nametable.setName(string, nameID, *platform)
if "fvar" not in varfont:
nametable.removeNames(NameID.VARIATIONS_POSTSCRIPT_NAME_PREFIX)
def _updatePSNameRecord(varfont, familyName, styleName, platform): def _updatePSNameRecord(varfont, familyName, styleName, platform):
# Implementation based on Adobe Technical Note #5902 : # Implementation based on Adobe Technical Note #5902 :

6
Tests/varLib/instancer/names_test.py
View File

@ -39,11 +39,15 @@ def _test_name_records(varfont, expected, isNonRIBBI, platforms=[0x409]):
if k[-1] not in platforms: if k[-1] not in platforms:
continue continue
assert font_names[k] == expected[k] assert font_names[k] == expected[k]
font_nameids = set(i[0] for i in font_names)
if isNonRIBBI: if isNonRIBBI:
font_nameids = set(i[0] for i in font_names)
assert 16 in font_nameids assert 16 in font_nameids
assert 17 in font_nameids assert 17 in font_nameids
if "fvar" not in varfont:
assert 25 not in font_nameids
@pytest.mark.parametrize( @pytest.mark.parametrize(
"limits, expected, isNonRIBBI", "limits, expected, isNonRIBBI",