shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[name] Speed up NameRecordVisitor

Browse Source 
Don't visit large tables without any name records.
This commit is contained in:
Behdad Esfahbod 2023-07-20 09:47:38 -06:00
parent d27cc3abf8
commit 530e409416
1 changed files with 16 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
Lib/fontTools/ttLib/tables/_n_a_m_e.py
View File

@ -242,9 +242,6 @@ class table__n_a_m_e(DefaultTable.DefaultTable):
if record.nameID not in visitor.seen: if record.nameID not in visitor.seen:
toDelete.add(record.nameID) toDelete.add(record.nameID)
if not toDelete:
return
log.info(f"Deleting name records with NameIDs {toDelete}")
for nameID in toDelete: for nameID in toDelete:
ttFont["name"].removeNames(nameID) ttFont["name"].removeNames(nameID)
return toDelete return toDelete
@ -1167,6 +1164,9 @@ _MAC_LANGUAGE_TO_SCRIPT = {
class NameRecordVisitor(TTVisitor): class NameRecordVisitor(TTVisitor):
# Font tables that have NameIDs we need to collect.
TABLES = ("GSUB", "GPOS", "fvar", "CPAL", "STAT")
def __init__(self): def __init__(self):
self.seen = set() self.seen = set()
@ -1211,3 +1211,16 @@ def visit(visitor, obj):
if obj.version == 1: if obj.version == 1:
visitor.seen.update(obj.paletteLabels) visitor.seen.update(obj.paletteLabels)
visitor.seen.update(obj.paletteEntryLabels) visitor.seen.update(obj.paletteEntryLabels)
@NameRecordVisitor.register(ttLib.TTFont)
def visit(visitor, font, *args, **kwargs):
if hasattr(visitor, "font"):
return False
visitor.font = font
for tag in visitor.TABLES:
if tag in font:
visitor.visit(font[tag], *args, **kwargs)
del visitor.font
return False