From 5dca3c5a50ff822c89eab68a6573fa0df96aec66 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Fri, 17 May 2024 12:44:29 -0700 Subject: [PATCH] [instancer] Warn about missing VORG support --- Lib/fontTools/varLib/instancer/__init__.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/Lib/fontTools/varLib/instancer/__init__.py b/Lib/fontTools/varLib/instancer/__init__.py index cf44b0859..7120b0831 100644 --- a/Lib/fontTools/varLib/instancer/__init__.py +++ b/Lib/fontTools/varLib/instancer/__init__.py @@ -1063,8 +1063,13 @@ def _instantiateVHVAR(varfont, axisLimits, tableFields, *, round=round): varIdx = varfont.getGlyphID(glyphName) metrics[glyphName] = (advanceWidth + round(defaultDeltas[varIdx]), sb) - # TODO if tableTag == "VVAR" and getattr(vhvar, tableFields.vOrigMapping), - # update VORG table as well + if ( + tableTag == "VVAR" + and getattr(vhvar, tableFields.vOrigMapping) is not None + ): + log.warning( + "VORG table not yet updated to reflect changes in VVAR table" + ) # For full instances (i.e. all axes pinned), we can simply drop HVAR/VVAR and return if set(location).issuperset(axis.axisTag for axis in fvarAxes):