From 7fadfa4e8198ed438d4982af2e79c0705b63b2b0 Mon Sep 17 00:00:00 2001 From: Behdad Esfahbod Date: Tue, 22 Oct 2024 01:34:48 -0600 Subject: [PATCH] Revert "refactor: pass isfinal argument spelled-out not a number" This reverts commit 6d65a87301b6c746ae0ec1dc1cf0df75c0c21d63. https://github.com/fonttools/fonttools/pull/3669#issuecomment-2428475144 --- Lib/fontTools/misc/testTools.py | 2 +- Lib/fontTools/misc/xmlReader.py | 4 ++-- Lib/fontTools/ufoLib/glifLib.py | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Lib/fontTools/misc/testTools.py b/Lib/fontTools/misc/testTools.py index 8e18374ef..7d7872148 100644 --- a/Lib/fontTools/misc/testTools.py +++ b/Lib/fontTools/misc/testTools.py @@ -38,7 +38,7 @@ def parseXML(xmlSnippet): % type(xmlSnippet).__name__ ) xml += b"" - reader.parser.Parse(xml, isfinal=True) + reader.parser.Parse(xml, 1) return reader.root[2] diff --git a/Lib/fontTools/misc/xmlReader.py b/Lib/fontTools/misc/xmlReader.py index 205704686..d8e502f14 100644 --- a/Lib/fontTools/misc/xmlReader.py +++ b/Lib/fontTools/misc/xmlReader.py @@ -70,12 +70,12 @@ class XMLReader(object): while True: chunk = file.read(BUFSIZE) if not chunk: - parser.Parse(chunk, isfinal=True) + parser.Parse(chunk, 1) break pos = pos + len(chunk) if self.progress: self.progress.set(pos // 100) - parser.Parse(chunk, isfinal=False) + parser.Parse(chunk, 0) def _startElementHandler(self, name, attrs): if self.stackSize == 1 and self.contentOnly: diff --git a/Lib/fontTools/ufoLib/glifLib.py b/Lib/fontTools/ufoLib/glifLib.py index 1d2ce3cf7..abbda4914 100755 --- a/Lib/fontTools/ufoLib/glifLib.py +++ b/Lib/fontTools/ufoLib/glifLib.py @@ -1765,7 +1765,7 @@ class _BaseParser: parser = ParserCreate() parser.StartElementHandler = self.startElementHandler parser.EndElementHandler = self.endElementHandler - parser.Parse(text, isfinal=True) + parser.Parse(text, 1) def startElementHandler(self, name, attrs): self._elementStack.append(name)