shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

reverseContourPen_test: check outputImpliedClosingLine works as expected

Browse Source 
I looked at this again and got suspicious becuase I noticed that the number of pen commands increased from 4 to 6, whereas I only expected it to be 5 (4+1) in the outputImpliedClosingLine=True case.

Turns out we are adding an extra duplicate lineTo right after moveTo, which I think is not correct.
This commit is contained in:
Cosimo Lupo 2023-02-17 15:02:59 +00:00
parent bf265ce49e
commit 81279d2ed6
No known key found for this signature in database
GPG Key ID: DF65A8A5A119C9A8
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Tests/pens/reverseContourPen_test.py
View File

@ -288,7 +288,13 @@ def test_reverse_pen_outputImpliedClosingLine():
revpen.lineTo((0, 10)) revpen.lineTo((0, 10))
revpen.lineTo((0, 0)) revpen.lineTo((0, 0))
revpen.closePath() revpen.closePath()
assert len(recpen.value) == 4 assert recpen.value == [
("moveTo", ((0, 0),)),
("lineTo", ((0, 10),)),
("lineTo", ((10, 0),)),
# ("lineTo", ((0, 0),)), # implied
("closePath", ()),
]
recpen = RecordingPen() recpen = RecordingPen()
revpen = ReverseContourPen(recpen, outputImpliedClosingLine=True) revpen = ReverseContourPen(recpen, outputImpliedClosingLine=True)
@ -297,7 +303,13 @@ def test_reverse_pen_outputImpliedClosingLine():
revpen.lineTo((0, 10)) revpen.lineTo((0, 10))
revpen.lineTo((0, 0)) revpen.lineTo((0, 0))
revpen.closePath() revpen.closePath()
assert len(recpen.value) == 6 assert recpen.value == [
("moveTo", ((0, 0),)),
("lineTo", ((0, 10),)),
("lineTo", ((10, 0),)),
("lineTo", ((0, 0),)), # not implied
("closePath", ()),
]
@pytest.mark.parametrize("contour, expected", TEST_DATA) @pytest.mark.parametrize("contour, expected", TEST_DATA)