shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[subset_test] add failing test to repro SinglePosFormat2 with ValueFormat=0

Browse Source 
reproduces #2602
This commit is contained in:
Cosimo Lupo 2022-04-27 15:58:29 +01:00
parent ba8880e9f1
commit 8309aaf8d8
1 changed files with 46 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

48
Tests/subset/subset_test.py
View File

@ -953,7 +953,8 @@ def test_subset_feature_variations_drop_all(featureVarsTestFont):
# https://github.com/fonttools/fonttools/issues/1881#issuecomment-619415044 # https://github.com/fonttools/fonttools/issues/1881#issuecomment-619415044
def test_subset_single_pos_format(): @pytest.fixture
def singlepos2_font():
fb = FontBuilder(unitsPerEm=1000) fb = FontBuilder(unitsPerEm=1000)
fb.setupGlyphOrder([".notdef", "a", "b", "c"]) fb.setupGlyphOrder([".notdef", "a", "b", "c"])
fb.setupCharacterMap({ord("a"): "a", ord("b"): "b", ord("c"): "c"}) fb.setupCharacterMap({ord("a"): "a", ord("b"): "b", ord("c"): "c"})
@ -971,8 +972,11 @@ def test_subset_single_pos_format():
fb.save(buf) fb.save(buf)
buf.seek(0) buf.seek(0)
font = TTFont(buf) return TTFont(buf)
def test_subset_single_pos_format(singlepos2_font):
font = singlepos2_font
# The input font has a SinglePos Format 2 subtable where each glyph has # The input font has a SinglePos Format 2 subtable where each glyph has
# different ValueRecords # different ValueRecords
assert getXML(font["GPOS"].table.LookupList.Lookup[0].toXML, font) == [ assert getXML(font["GPOS"].table.LookupList.Lookup[0].toXML, font) == [
@ -1018,6 +1022,46 @@ def test_subset_single_pos_format():
'</Lookup>', '</Lookup>',
] ]
def test_subset_single_pos_format2_all_None(singlepos2_font):
# https://github.com/fonttools/fonttools/issues/2602
font = singlepos2_font
gpos = font["GPOS"].table
subtable = gpos.LookupList.Lookup[0].SubTable[0]
assert subtable.Format == 2
# Hack a SinglePosFormat2 with ValueFormat = 0; our own buildSinglePos
# never makes these as a SinglePosFormat1 is more compact, but they can
# be found in the wild.
subtable.Value = [None] * subtable.ValueCount
subtable.ValueFormat = 0
assert getXML(subtable.toXML, font) == [
'<SinglePos Format="2">',
' <Coverage>',
' <Glyph value="a"/>',
' <Glyph value="b"/>',
' <Glyph value="c"/>',
' </Coverage>',
' <ValueFormat value="0"/>',
' <!-- ValueCount=3 -->',
'</SinglePos>',
]
options = subset.Options()
subsetter = subset.Subsetter(options)
subsetter.populate(unicodes=[ord("a"), ord("c")])
subsetter.subset(font)
# Check it was downgraded to Format1 after subsetting
assert getXML(font["GPOS"].table.LookupList.Lookup[0].SubTable[0].toXML, font) == [
'<SinglePos Format="1">',
' <Coverage>',
' <Glyph value="a"/>',
' <Glyph value="c"/>',
' </Coverage>',
' <ValueFormat value="0"/>',
'</SinglePos>',
]
@pytest.fixture @pytest.fixture
def ttf_path(tmp_path): def ttf_path(tmp_path):