shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[feaLib] Let the parser set nameIDs 1 through 6

Browse Source
This commit is contained in:
David Corbett 2022-07-02 15:23:03 -04:00
parent 97958a95e1
commit 8ec37c4bb3
3 changed files with 24 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Lib/fontTools/feaLib/parser.py
View File

@ -1253,14 +1253,6 @@ class Parser(object):
raise FeatureLibError( raise FeatureLibError(
"Name id value cannot be greater than 32767", self.cur_token_location_ "Name id value cannot be greater than 32767", self.cur_token_location_
) )
if 1 <= nameID <= 6:
log.warning(
"Name id %d cannot be set from the feature file. "
"Ignoring record" % nameID
)
self.parse_name_() # skip to the next record
return None
platformID, platEncID, langID, string = self.parse_name_() platformID, platEncID, langID, string = self.parse_name_()
return self.ast.NameRecord( return self.ast.NameRecord(
nameID, platformID, platEncID, langID, string, location=location nameID, platformID, platEncID, langID, string, location=location

12
Tests/feaLib/data/name.fea
View File

@ -1,16 +1,16 @@
table name { table name {
#test-fea2fea: #test-fea2fea:
nameid 1 "Ignored-1"; nameid 1 "Test1";
#test-fea2fea: #test-fea2fea:
nameid 2 "Ignored-2"; nameid 2 "Test2";
#test-fea2fea: #test-fea2fea:
nameid 3 "Ignored-3"; nameid 3 "Test3";
#test-fea2fea: #test-fea2fea:
nameid 4 "Ignored-4"; nameid 4 "Test4";
#test-fea2fea: #test-fea2fea:
nameid 5 "Ignored-5"; nameid 5 "Test5";
#test-fea2fea: #test-fea2fea:
nameid 6 "Ignored-6"; nameid 6 "Test6";
#test-fea2fea: nameid 7 "Test7"; #test-fea2fea: nameid 7 "Test7";
nameid 7 3 "Test7"; nameid 7 3 "Test7";
nameid 8 1 "Test8"; nameid 8 1 "Test8";

18
Tests/feaLib/data/name.ttx
View File

@ -2,6 +2,24 @@
<ttFont> <ttFont>
<name> <name>
<namerecord nameID="1" platformID="3" platEncID="1" langID="0x409">
Test1
</namerecord>
<namerecord nameID="2" platformID="3" platEncID="1" langID="0x409">
Test2
</namerecord>
<namerecord nameID="3" platformID="3" platEncID="1" langID="0x409">
Test3
</namerecord>
<namerecord nameID="4" platformID="3" platEncID="1" langID="0x409">
Test4
</namerecord>
<namerecord nameID="5" platformID="3" platEncID="1" langID="0x409">
Test5
</namerecord>
<namerecord nameID="6" platformID="3" platEncID="1" langID="0x409">
Test6
</namerecord>
<namerecord nameID="7" platformID="3" platEncID="1" langID="0x409"> <namerecord nameID="7" platformID="3" platEncID="1" langID="0x409">
Test7 Test7
</namerecord> </namerecord>