shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

rename parmeter ids => retained_ids for clarity as per review

Browse Source
This commit is contained in:
Cosimo Lupo 2021-11-15 17:41:42 +00:00
parent 863c9de57c
commit 92470ea361
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
Lib/fontTools/subset/svg.py
View File

@ -107,17 +107,17 @@ def closure_element_ids(
unvisited = referenced unvisited = referenced
def subset_elements(el: etree.Element, ids: Set[str]) -> bool: def subset_elements(el: etree.Element, retained_ids: Set[str]) -> bool:
# Keep elements if their id is in the subset, or any of their children's id is. # Keep elements if their id is in the subset, or any of their children's id is.
# Drop elements whose id is not in the subset, and either have no children, # Drop elements whose id is not in the subset, and either have no children,
# or all their children are being dropped. # or all their children are being dropped.
el_id = el.attrib.get("id") el_id = el.attrib.get("id")
if el_id is not None and el_id in ids: if el_id is not None and el_id in retained_ids:
# if id is in the set, don't recurse; keep whole subtree # if id is in the set, don't recurse; keep whole subtree
return True return True
keep = False keep = False
for e in el: for e in el:
keep |= subset_elements(e, ids) keep |= subset_elements(e, retained_ids)
if keep: if keep:
return True return True
assert len(el) == 0 assert len(el) == 0