From 9af92fdb41779d9d0d8330831364546f8c87f210 Mon Sep 17 00:00:00 2001 From: Cosimo Lupo Date: Tue, 11 Jun 2019 12:44:46 +0100 Subject: [PATCH] woff2_test: fix up flaky tests some tests were failing when shuffling the order of the tests with pytest-randomly. That's because calling TTFont.getTableData method on 'loca' table before having compiled 'glyf' returns an empty b"" string. --- Tests/ttLib/woff2_test.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Tests/ttLib/woff2_test.py b/Tests/ttLib/woff2_test.py index 55c4b778e..c2702954d 100644 --- a/Tests/ttLib/woff2_test.py +++ b/Tests/ttLib/woff2_test.py @@ -145,6 +145,7 @@ class WOFF2ReaderTTFTest(WOFF2ReaderTest): def test_reconstruct_loca(self): woff2Reader = WOFF2Reader(self.file) reconstructedData = woff2Reader['loca'] + self.font.getTableData("glyf") # 'glyf' needs to be compiled before 'loca' self.assertEqual(self.font.getTableData('loca'), reconstructedData) self.assertTrue(hasattr(woff2Reader.tables['glyf'], 'data')) @@ -360,7 +361,7 @@ class WOFF2WriterTest(unittest.TestCase): def setUpClass(cls): cls.font = ttLib.TTFont(recalcBBoxes=False, recalcTimestamp=False, flavor="woff2") cls.font.importXML(OTX) - cls.tags = [t for t in cls.font.keys() if t != 'GlyphOrder'] + cls.tags = sorted(t for t in cls.font.keys() if t != 'GlyphOrder') cls.numTables = len(cls.tags) cls.file = BytesIO(CFF_WOFF2.getvalue()) cls.file.seek(0, 2) @@ -518,7 +519,7 @@ class WOFF2WriterTTFTest(WOFF2WriterTest): def setUpClass(cls): cls.font = ttLib.TTFont(recalcBBoxes=False, recalcTimestamp=False, flavor="woff2") cls.font.importXML(TTX) - cls.tags = [t for t in cls.font.keys() if t != 'GlyphOrder'] + cls.tags = sorted(t for t in cls.font.keys() if t != 'GlyphOrder') cls.numTables = len(cls.tags) cls.file = BytesIO(TT_WOFF2.getvalue()) cls.file.seek(0, 2)