shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace PrivateDict.__getattr__ with property

Browse Source 
The dunder method doesn't seem to be doing anything other than providing
an `in_cff2` attribute. Do that with a property instead of bending
__getattr__.

This one confused me when I was working on
https://github.com/fonttools/fonttools/pull/1488.
This commit is contained in:
Nikolaus Waxweiler 2019-02-06 10:15:38 +00:00
parent 649dc49dba
commit a8d4bfc42d
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
Lib/fontTools/cffLib/__init__.py
View File

@ -2432,11 +2432,9 @@ class PrivateDict(BaseDict):
self.defaults = buildDefaults(privateDictOperators) self.defaults = buildDefaults(privateDictOperators)
self.order = buildOrder(privateDictOperators) self.order = buildOrder(privateDictOperators)
def __getattr__(self, name): @property
if name == "in_cff2": def in_cff2(self):
return self._isCFF2 return self._isCFF2
value = BaseDict.__getattr__(self, name)
return value
def getNumRegions(self, vi=None): # called from misc/psCharStrings.py def getNumRegions(self, vi=None): # called from misc/psCharStrings.py
# if getNumRegions is being called, we can assume that VarStore exists. # if getNumRegions is being called, we can assume that VarStore exists.