From aa2d9196c0fa9dd42c4b430d244cad6e1e4b8a32 Mon Sep 17 00:00:00 2001 From: David Jones Date: Thu, 18 Jul 2024 19:29:41 +0100 Subject: [PATCH] Lift .get("hex") out of try:; and avoid re-evaluating it --- Lib/fontTools/ufoLib/glifLib.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Lib/fontTools/ufoLib/glifLib.py b/Lib/fontTools/ufoLib/glifLib.py index 24ab284e4..8f5cba064 100755 --- a/Lib/fontTools/ufoLib/glifLib.py +++ b/Lib/fontTools/ufoLib/glifLib.py @@ -1191,12 +1191,12 @@ def _readGlyphFromTreeFormat1( haveSeenAdvance = True _readAdvance(glyphObject, element) elif element.tag == "unicode": - if element.get("hex") is None: + v = element.get("hex") + if v is None: raise GlifLibError( "A unicode element is missing its required hex attribute." ) try: - v = element.get("hex") v = int(v, 16) if v not in unicodes: unicodes.append(v) @@ -1258,12 +1258,12 @@ def _readGlyphFromTreeFormat2( haveSeenAdvance = True _readAdvance(glyphObject, element) elif element.tag == "unicode": - if element.get("hex") is None: + v = element.get("hex") + if v is None: raise GlifLibError( "A unicode element is missing its required hex attribute." ) try: - v = element.get("hex") v = int(v, 16) if v not in unicodes: unicodes.append(v)