From b07940421d1946deafcb5d2d65bfb3d085a9fcf7 Mon Sep 17 00:00:00 2001 From: Nikolaus Waxweiler Date: Wed, 13 May 2020 15:45:27 +0100 Subject: [PATCH] Fix test_addRuleDescriptor Use API correctly. --- Tests/designspaceLib/designspace_test.py | 25 +++++++++++++++--------- 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/Tests/designspaceLib/designspace_test.py b/Tests/designspaceLib/designspace_test.py index 378effe6e..f883730fe 100644 --- a/Tests/designspaceLib/designspace_test.py +++ b/Tests/designspaceLib/designspace_test.py @@ -996,23 +996,30 @@ def test_addInstanceDescriptor(): assert instance.styleMapStyleName == "regular" -def test_addRuleDescriptor(): +def test_addRuleDescriptor(tmp_path): ds = DesignSpaceDocument() rule = ds.addRuleDescriptor( - name="TestRule", - conditionSets=[ - dict(name='Weight', minimum=100, maximum=200), - dict(name='Weight', minimum=700, maximum=900), - ], - subs=[("a", "a.alt")], + name="TestRule", + conditionSets=[ + [ + dict(name="Weight", minimum=100, maximum=200), + dict(name="Weight", minimum=700, maximum=900), + ] + ], + subs=[("a", "a.alt")], ) assert ds.rules[0] is rule assert isinstance(rule, RuleDescriptor) assert rule.name == "TestRule" assert rule.conditionSets == [ - dict(name='Weight', minimum=100, maximum=200), - dict(name='Weight', minimum=700, maximum=900), + [ + dict(name="Weight", minimum=100, maximum=200), + dict(name="Weight", minimum=700, maximum=900), + ] ] assert rule.subs == [("a", "a.alt")] + + # Test it doesn't crash. + ds.write(tmp_path / "test.designspace")