shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[subset] FeatureVariations subsetting is wrong

Browse Source 
Fixes https://github.com/fonttools/fonttools/issues/1881
This commit is contained in:
Behdad Esfahbod 2020-04-20 12:10:05 -07:00
parent dfd2ffe751
commit cab7d13dc0
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
Lib/fontTools/subset/__init__.py
View File

@ -1321,8 +1321,14 @@ def subset_features(self, feature_indices):
@_add_method(otTables.FeatureVariations) @_add_method(otTables.FeatureVariations)
def subset_features(self, feature_indices): def subset_features(self, feature_indices):
self.ensureDecompiled() self.ensureDecompiled()
self.FeaturVariationRecord = [r for r in self.FeatureVariationRecord for r in self.FeatureVariationRecord:
if r.FeatureTableSubstitution.subset_features(feature_indices)] r.FeatureTableSubstitution.subset_features(feature_indices)
# Prune empty records at the end only
# https://github.com/fonttools/fonttools/issues/1881
while (self.FeatureVariationRecord and
not self.FeatureVariationRecord[-1]
.FeatureTableSubstitution.SubstitutionCount):
self.FeatureVariationRecord.pop()
self.FeatureVariationCount = len(self.FeatureVariationRecord) self.FeatureVariationCount = len(self.FeatureVariationRecord)
return bool(self.FeatureVariationCount) return bool(self.FeatureVariationCount)