[subset] FeatureVariations subsetting is wrong

Fixes https://github.com/fonttools/fonttools/issues/1881
This commit is contained in:
Behdad Esfahbod 2020-04-20 12:10:05 -07:00
parent dfd2ffe751
commit cab7d13dc0

View File

@ -1321,8 +1321,14 @@ def subset_features(self, feature_indices):
@_add_method(otTables.FeatureVariations)
def subset_features(self, feature_indices):
self.ensureDecompiled()
self.FeaturVariationRecord = [r for r in self.FeatureVariationRecord
if r.FeatureTableSubstitution.subset_features(feature_indices)]
for r in self.FeatureVariationRecord:
r.FeatureTableSubstitution.subset_features(feature_indices)
# Prune empty records at the end only
# https://github.com/fonttools/fonttools/issues/1881
while (self.FeatureVariationRecord and
not self.FeatureVariationRecord[-1]
.FeatureTableSubstitution.SubstitutionCount):
self.FeatureVariationRecord.pop()
self.FeatureVariationCount = len(self.FeatureVariationRecord)
return bool(self.FeatureVariationCount)