shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add check for missing glyphs to featureVars (#2654)

Browse Source 
* Add check for missing glyphs to featureVars
This commit is contained in:
Jens Kutilek 2022-06-17 15:24:54 +02:00 committed by GitHub
parent 2aafbb5073
commit d0020b2536
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
Lib/fontTools/varLib/featureVars.py
View File

@ -44,6 +44,10 @@ def addFeatureVariations(font, conditionalSubstitutions, featureTag='rvrn'):
# >>> f.save(dstPath) # >>> f.save(dstPath)
""" """
_checkSubstitutionGlyphsExist(
glyphNames=set(font.getGlyphOrder()),
substitutions=conditionalSubstitutions,
)
substitutions = overlayFeatureVariations(conditionalSubstitutions) substitutions = overlayFeatureVariations(conditionalSubstitutions)
@ -66,6 +70,18 @@ def addFeatureVariations(font, conditionalSubstitutions, featureTag='rvrn'):
conditionsAndLookups, conditionsAndLookups,
featureTag) featureTag)
def _checkSubstitutionGlyphsExist(glyphNames, substitutions):
referencedGlyphNames = set()
for _, substitution in substitutions:
referencedGlyphNames |= substitution.keys()
referencedGlyphNames |= set(substitution.values())
missing = referencedGlyphNames - glyphNames
if missing:
raise VarLibValidationError(
"Missing glyphs are referenced in conditional substitution rules:"
f" {', '.join(missing)}"
)
def overlayFeatureVariations(conditionalSubstitutions): def overlayFeatureVariations(conditionalSubstitutions):
"""Compute overlaps between all conditional substitutions. """Compute overlaps between all conditional substitutions.