shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fall back to 'Regular' when no subFamilyName

Browse Source 
assert we have some 'string' instead of silently continuing
This commit is contained in:
Cosimo Lupo 2021-02-19 11:03:41 +00:00
parent 0c92d33bc0
commit d1a8e1ee76
No known key found for this signature in database
GPG Key ID: 179A8F0895A02F4F
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Lib/fontTools/varLib/instancer/names.py
View File

@ -279,7 +279,7 @@ def _updateNameTableStyleRecords(
nameIDs = {
NameID.FAMILY_NAME: currentFamilyName,
NameID.SUBFAMILY_NAME: subFamilyName,
NameID.SUBFAMILY_NAME: subFamilyName or "Regular",
}
if typoSubFamilyName:
nameIDs[NameID.FAMILY_NAME] = f"{currentFamilyName} {familyNameSuffix}".strip()
@ -305,13 +305,13 @@ def _updateNameTableStyleRecords(
nameIDs[NameID.POSTSCRIPT_NAME] = _updatePSNameRecord(
varfont, newFamilyName, newStyleName, platform
)
nameIDs[NameID.UNIQUE_FONT_IDENTIFIER] = _updateUniqueIdNameRecord(
varfont, nameIDs, platform
)
uniqueID = _updateUniqueIdNameRecord(varfont, nameIDs, platform)
if uniqueID:
nameIDs[NameID.UNIQUE_FONT_IDENTIFIER] = uniqueID
for nameID, string in nameIDs.items():
if not string:
continue
assert string, nameID
nametable.setName(string, nameID, *platform)