shadowfacts/fonttools
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clarify comment with the plan vs the actual implementation

Browse Source
This commit is contained in:
Jany Belluz 2021-07-05 15:03:10 +01:00
parent 7860dd5fe8
commit d1c46f9d10
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
Lib/fontTools/otlLib/optimize/gpos.py
View File

@ -16,12 +16,19 @@ log = logging.getLogger("fontTools.otlLib.optimize.gpos")
def compact(font: TTFont, mode: str) -> TTFont: def compact(font: TTFont, mode: str) -> TTFont:
# Plan: # Ideal plan:
# 1. Find lookups of Lookup Type 2: Pair Adjustment Positioning Subtable # 1. Find lookups of Lookup Type 2: Pair Adjustment Positioning Subtable
# https://docs.microsoft.com/en-us/typography/opentype/spec/gpos#lookup-type-2-pair-adjustment-positioning-subtable # https://docs.microsoft.com/en-us/typography/opentype/spec/gpos#lookup-type-2-pair-adjustment-positioning-subtable
# 2. Extract glyph-glyph kerning and class-kerning from all present subtables # 2. Extract glyph-glyph kerning and class-kerning from all present subtables
# 3. Regroup into different subtable arrangements # 3. Regroup into different subtable arrangements
# 4. Put back into the lookup # 4. Put back into the lookup
#
# Actual implementation:
# 2. Only class kerning is optimized currently
# 3. If the input kerning is already in several subtables, the subtables
# are not grouped together first; instead each subtable is treated
# independently, so currently this step is:
# Split existing subtables into more smaller subtables
gpos = font["GPOS"] gpos = font["GPOS"]
for lookup in gpos.table.LookupList.Lookup: for lookup in gpos.table.LookupList.Lookup:
if lookup.LookupType == 2: if lookup.LookupType == 2: