From d1fa34e72c6dabbedaf3bb9af24bf467ffc42f01 Mon Sep 17 00:00:00 2001 From: Cosimo Lupo Date: Sat, 14 Jul 2018 12:22:42 +0100 Subject: [PATCH] test_plistlib.py: mute harmless ResourceWarning on py27 --- Lib/ufoLib/test/test_plistlib.py | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/Lib/ufoLib/test/test_plistlib.py b/Lib/ufoLib/test/test_plistlib.py index 9ba16d0dd..cf85a3de6 100644 --- a/Lib/ufoLib/test/test_plistlib.py +++ b/Lib/ufoLib/test/test_plistlib.py @@ -1,5 +1,5 @@ from __future__ import absolute_import, unicode_literals -from ufoLib import plistlib +import sys import os import datetime import codecs @@ -8,9 +8,20 @@ from io import BytesIO from numbers import Integral from fontTools.misc.py23 import tounicode from ufoLib import etree +from ufoLib import plistlib import pytest +PY2 = sys.version_info < (3,) +if PY2: + # This is a ResourceWarning that only happens on py27 at interpreter + # finalization, and only when coverage is enabled. We can ignore it. + # https://github.com/numpy/numpy/issues/3778#issuecomment-24885336 + pytestmark = pytest.mark.filterwarnings( + "ignore:tp_compare didn't return -1 or -2 for exception" + ) + + # The testdata is generated using https://github.com/python/cpython/... # Mac/Tools/plistlib_generate_testdata.py # which uses PyObjC to control the Cocoa classes for generating plists @@ -382,9 +393,9 @@ def test_totree(pl): def test_no_pretty_print(): data = plistlib.dumps({"data": b"hello"}, pretty_print=False) assert data == ( - plistlib.XML_DECLARATION + - plistlib.PLIST_DOCTYPE + - b'' + plistlib.XML_DECLARATION + + plistlib.PLIST_DOCTYPE + + b'' b"" b"data" b"aGVsbG8="