Test OTTableReader.getSubReader()

Also removing unused stats collection. The need for setting up
an object to collect these (unused) stats made it hard to write
tests on code that called OTTableReader.getSubReader().
This commit is contained in:
Sascha Brawer 2015-10-18 00:09:32 +02:00
parent 582852119c
commit d8d5ab2c29
2 changed files with 6 additions and 3 deletions

View File

@ -142,9 +142,6 @@ class OTTableReader(object):
def getSubReader(self, offset):
offset = self.offset + offset
cachingStats = self.globalState.cachingStats
if cachingStats is not None:
cachingStats[offset] = cachingStats.get(offset, 0) + 1
return self.__class__(self.data, self.globalState, self.localState, offset)
def readUShort(self):

View File

@ -52,6 +52,12 @@ class OTTableReaderTest(unittest.TestCase):
self.assertEqual(reader.readData(5), b"Hello")
self.assertEqual(reader.pos, 5)
def test_getSubReader(self):
reader = OTTableReader(deHexStr("CAFE F00D"))
sub = reader.getSubReader(2)
self.assertEqual(sub.readUShort(), 0xF00D)
self.assertEqual(reader.readUShort(), 0xCAFE)
class OTTableWriterTest(unittest.TestCase):
def test_writeShort(self):